@decentnetwork/peer 0.1.156 → 0.1.158

package/dist/peer.d.ts

@@ -97,7 +97,28 @@ export declare class Peer {
         routes: number;
         targets: number;
     } | undefined;
-    acceptFriendRequest(pubkey: string): Promise<void>;
+    /**
+     * Accept a friend request.
+     *
+     * `#pendingFriendRequests` is an in-memory cache, not the authority on what
+     * was asked. A host that remembers requests across a restart — beagle-web
+     * keeps them in IndexedDB, because a request usually arrives while the tab is
+     * closed — is doing the right thing, and refusing it here made every restored
+     * card permanently un-acceptable: click Accept, the SDK throws "no pending
+     * friend request", the card comes back, and the button reads as dead. That is
+     * the whole of the reported "Accept does not respond" on app.beagle.chat.
+     *
+     * Accepting is the host's decision. Take it, and let the host pass back what
+     * it remembered so the friend does not arrive nameless — anything missing is
+     * filled in by the userinfo exchange once the session comes up.
+     */
+    acceptFriendRequest(pubkey: string, opts?: {
+        name?: string;
+        description?: string;
+        hello?: string;
+        address?: string;
+        nospam?: number;
+    }): Promise<void>;
     /** Decline an inbound request.
      *
      *  Also drops any friend record and session the request already created.

package/dist/peer.js

@@ -527,6 +527,10 @@ export class Peer {
     // #initiateSession every few seconds for every friend; without this
     // dedupe, lower-pubkey side floods the log with "deferring to peer".
     #initiateSkipLogged = new Set();
+    /** Recently COMPLETED bulkmsg assemblies, same key, kept for the same 60s
+     *  the assembly itself lives. Without it a retransmitted message reassembles
+     *  a second time and is delivered twice. */
+    #bulkCompleted = new Map();
     // In-flight Carrier BULKMSG reassemblies, keyed `${friendId}:${tid}`.
     // Fragments are appended in arrival order (the lossless stream keeps
     // them ordered) and the message completes when totalsz bytes arrived.
@@ -1241,20 +1245,49 @@ export class Peer {
     lastFriendRequestDispatch() {
         return this.#lastFriendRequestDispatch;
     }
-    async acceptFriendRequest(pubkey) {
+    /**
+     * Accept a friend request.
+     *
+     * `#pendingFriendRequests` is an in-memory cache, not the authority on what
+     * was asked. A host that remembers requests across a restart — beagle-web
+     * keeps them in IndexedDB, because a request usually arrives while the tab is
+     * closed — is doing the right thing, and refusing it here made every restored
+     * card permanently un-acceptable: click Accept, the SDK throws "no pending
+     * friend request", the card comes back, and the button reads as dead. That is
+     * the whole of the reported "Accept does not respond" on app.beagle.chat.
+     *
+     * Accepting is the host's decision. Take it, and let the host pass back what
+     * it remembered so the friend does not arrive nameless — anything missing is
+     * filled in by the userinfo exchange once the session comes up.
+     */
+    async acceptFriendRequest(pubkey, opts) {
         const request = this.#pendingFriendRequests.get(pubkey);
-        if (!request) {
-            throw new Error("No pending friend request from this peer");
+        if (!request && !opts) {
+            // No cached request AND the caller told us nothing: it can still be
+            // accepted, but say so, because it means the host is not passing on what
+            // it knows and the friend will start out anonymous.
+            this.#debugLog(`accepting ${pubkey} with no cached request and no details from the host`);
+        }
+        let key;
+        try {
+            key = base58ToBytes(pubkey);
         }
+        catch {
+            throw new Error(`Not a valid peer key: ${pubkey}`);
+        }
+        if (key.length !== 32) {
+            throw new Error(`Not a valid peer key: ${pubkey}`);
+        }
+        const nospam = request?.nospam ?? opts?.nospam ?? 0;
         this.#pendingFriendRequests.delete(pubkey);
         this.#friends.set(pubkey, {
             pubkey,
-            userid: request.userid,
-            address: request.address,
-            nospam: request.nospam,
-            name: request.name,
-            description: request.description,
-            hello: request.hello,
+            userid: request?.userid ?? pubkey,
+            address: request?.address ?? opts?.address ?? carrierAddressFromPublicKey(key, nospam),
+            nospam,
+            name: request?.name ?? opts?.name ?? "",
+            description: request?.description ?? opts?.description ?? "",
+            hello: request?.hello ?? opts?.hello ?? "",
             status: "offline",
             acceptedAt: Date.now()
         });
@@ -1613,6 +1646,29 @@ export class Peer {
                 return;
             }
         }
+        // Inline files ride the TEXT channel, and the delivery envelope wraps them.
+        //
+        // The call sites check for an inline file BEFORE this function, i.e. before
+        // the envelope comes off — so they were looking at "\x1eDNPACK1:<base64>",
+        // which does not start with "{", and every inline file sent with delivery
+        // tracking was reported as a text message instead. Measured 2026-08-31,
+        // peer to peer: a 95-byte PNG arrived as 200 characters of JSON, and a
+        // 300 KB one as 409,672 characters. Both transferred perfectly; both were
+        // handed to the application as a wall of base64.
+        //
+        // The check belongs here, on the unwrapped text, where it sees what the
+        // sender actually wrote. The call-site checks stay for envelope-less
+        // senders (iOS and Android do not speak this envelope).
+        //
+        // ACK first: an inline file is delivered, and skipping the ACK because we
+        // did not run the text handlers would make the sender retransmit forever.
+        if (this.#tryEmitInlineFile(msg.pubkey, text, msg.via === "offline" ? "offline" : "online")) {
+            if (deliveryId) {
+                this.#rememberDeliveredTextId(deliveryId);
+                void this.#sendTextAck(msg.pubkey, deliveryId).catch(() => undefined);
+            }
+            return;
+        }
         if (this.#textHandlers.size === 0) {
             if (deliveryId)
                 this.#debugLog(`text delivery ${deliveryId} from ${msg.pubkey} has no onText handlers; not ACKing`);
@@ -3179,13 +3235,22 @@ export class Peer {
         try {
             const decoded = decodeCarrierPacket(carrierPacket);
             if (decoded.type !== PACKET_TYPE_FRIEND_REQUEST) {
+                // Was a bare `return`. An onion friend-request that arrived and did not
+                // parse left NOTHING anywhere — the sender saw success, the recipient
+                // saw no request, and there was no way to tell "never arrived" from
+                // "arrived and was dropped". That is the single most-reported symptom
+                // on this project and it was undiagnosable by construction.
+                this.#debugLog(`friend-request from ${carrierIdFromPublicKey(senderPublicKey)} DROPPED: ` +
+                    `decoded as packet type ${decoded.type}, expected ${PACKET_TYPE_FRIEND_REQUEST}`);
                 return;
             }
             hello = decoded.hello;
             name = decoded.name;
             description = decoded.descr;
         }
-        catch {
+        catch (error) {
+            this.#debugLog(`friend-request from ${carrierIdFromPublicKey(senderPublicKey)} DROPPED: ` +
+                `undecodable (${carrierPacket.length} bytes): ${error.message}`);
             return;
         }
         const userid = carrierIdFromPublicKey(senderPublicKey);
@@ -3227,13 +3292,17 @@ export class Peer {
         try {
             const decoded = decodeCarrierPacket(packet);
             if (decoded.type !== PACKET_TYPE_FRIEND_REQUEST) {
+                this.#debugLog(`offline friend-request from ${fromUserId} DROPPED: decoded as packet ` +
+                    `type ${decoded.type}, expected ${PACKET_TYPE_FRIEND_REQUEST}`);
                 return;
             }
             helloText = decoded.hello;
             name = decoded.name;
             description = decoded.descr;
         }
-        catch {
+        catch (error) {
+            this.#debugLog(`offline friend-request from ${fromUserId} DROPPED: undecodable ` +
+                `(${packet.length} bytes): ${error.message}`);
             return;
         }
         // Already an established friend? Ignore this (re-)request. Auto-friend
@@ -4763,6 +4832,24 @@ export class Peer {
                 this.#bulkAssembly.delete(key);
         }
         const key = `${friendId}:${frag.tid.toString()}`;
+        // A completed assembly is deleted, so a second copy of the same fragments
+        // starts a fresh entry and completes AGAIN — the application gets the same
+        // message twice. Duplicate FRAGMENTS were already ignored; a duplicate
+        // whole MESSAGE was not.
+        //
+        // It shows up on the plain send path (a native peer, or a JS peer before
+        // userinfo has settled), because that path carries no delivery id and the
+        // text-level dedupe has nothing to key on. Measured 2026-08-31: one
+        // sendInlineFile call, two `bulkmsg complete (409672 bytes)` and two
+        // identical 300 KB images delivered.
+        for (const [k, at] of this.#bulkCompleted) {
+            if (at < now - 60_000)
+                this.#bulkCompleted.delete(k);
+        }
+        if (this.#bulkCompleted.has(key)) {
+            this.#debugLog(`bulkmsg ${key} already completed — dropping duplicate`);
+            return undefined;
+        }
         let entry = this.#bulkAssembly.get(key);
         if (!entry) {
             entry = { total: 0, frags: new Map(), got: 0, expireAtMs: now + 60_000 };
@@ -4787,6 +4874,7 @@ export class Peer {
         if (entry.total === 0 || entry.got < entry.total)
             return undefined;
         this.#bulkAssembly.delete(key);
+        this.#bulkCompleted.set(key, now);
         if (entry.got > entry.total) {
             this.#debugLog(`bulkmsg from ${friendId} got ${entry.got} > total ${entry.total} — dropped`);
             return undefined;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@decentnetwork/peer",
-  "version": "0.1.156",
+  "version": "0.1.158",
   "description": "Pure TypeScript port of Elastos Carrier (toxcore-derived) P2P messaging. DHT, onion routing, TCP relay, FlatBuffers app payloads, Express offline relay. Wire-compatible with iOS Beagle and the Carrier C SDK.",
   "type": "module",
   "main": "./dist/index.js",