@de-otio/trellis 0.6.1 → 0.7.1

package/src/lambda/pre-token-generation.ts

@@ -1,93 +1,334 @@
-import type { PreTokenGenerationV2TriggerEvent, PreTokenGenerationV2TriggerHandler } from "aws-lambda";
-import { DynamoDBClient, GetItemCommand, PutItemCommand } from "@aws-sdk/client-dynamodb";
-import { SecretsManagerClient, GetSecretValueCommand } from "@aws-sdk/client-secrets-manager";
-import { marshall, unmarshall } from "@aws-sdk/util-dynamodb";
-import { PrismaClient } from "@prisma/client";
+/**
+ * Cognito PreTokenGeneration trigger (V2 access-token override).
+ *
+ * Runs on every token issuance and refresh. Responsibilities:
+ *  1. Read the cached claims from DynamoDB.
+ *  2. On miss: load from RDS (User + active TenantMember + Tenant slug).
+ *  3. For federated users: re-resolve the tenant role from the current
+ *     `custom:idpGroups` against `TenantRoleMapping`. This catches admin-side
+ *     group changes within the access-token TTL.
+ *  4. Write the (possibly refreshed) claims back to DDB.
+ *  5. Override the access-token claims via the V2 response shape.
+ *
+ * Failure modes:
+ *  - User row missing (drift after RDS restore): return minimal claims —
+ *    the API responds 403 to tenant-scoped endpoints, never a 500 at sign-in.
+ *  - DDB or RDS error: bubble up; Cognito treats the issuance as failed.
+ *
+ * No PII is logged. We log counts and decisions ("cache_hit", "drift",
+ * "role_refreshed") and the opaque cognitoSub.
+ */
 
-const dynamo = new DynamoDBClient({ region: process.env.AWS_REGION });
-const TABLE = process.env.DYNAMODB_TABLE!;
-const CACHE_TTL_SECONDS = 300; // 5 minutes (S1.8 — reduced from 1 hour)
+import type {
+  PreTokenGenerationV2TriggerEvent,
+  PreTokenGenerationV2TriggerHandler,
+} from "aws-lambda";
+import { SecretsManagerClient, GetSecretValueCommand } from "@aws-sdk/client-secrets-manager";
+import { PrismaClient, type TenantRole } from "@prisma/client";
+import {
+  ClaimsCache,
+  createClaimsCacheFromEnv,
+  DEFAULT_CACHE_TTL_SECONDS,
+  type CachedClaims,
+} from "../lib/auth/claims-cache";
+import { resolveTenantRole, type RoleMappingInput } from "../lib/tenant/resolve-role";
 
 const secretsClient = new SecretsManagerClient({ region: process.env.AWS_REGION });
 let prisma: PrismaClient | null = null;
+let cache: ClaimsCache | null = null;
 
 async function getPrisma(): Promise<PrismaClient> {
   if (prisma) return prisma;
-  const secret = await secretsClient.send(new GetSecretValueCommand({ SecretId: process.env.DB_SECRET_ARN! }));
+  const secret = await secretsClient.send(
+    new GetSecretValueCommand({ SecretId: process.env.DB_SECRET_ARN! }),
+  );
   const { username, password, host, port, dbname } = JSON.parse(secret.SecretString!);
   prisma = new PrismaClient({
-    datasources: { db: { url: `postgresql://${username}:${encodeURIComponent(password)}@${host}:${port}/${dbname}?connection_limit=1` } },
+    datasources: {
+      db: {
+        url: `postgresql://${username}:${encodeURIComponent(password)}@${host}:${port}/${dbname}?connection_limit=1`,
+      },
+    },
   });
   return prisma;
 }
 
-interface CachedClaims {
-  userId: string;
-  role: string;
-  handle: string;
+function getCache(): ClaimsCache {
+  if (!cache) cache = createClaimsCacheFromEnv();
+  return cache;
 }
 
-async function getClaims(cognitoSub: string): Promise<CachedClaims | null> {
-  // Check DynamoDB cache first
-  const cacheResult = await dynamo.send(new GetItemCommand({
-    TableName: TABLE,
-    Key: marshall({ pk: `claims:${cognitoSub}`, sk: "meta" }),
-  }));
-
-  if (cacheResult.Item) {
-    const cached = unmarshall(cacheResult.Item);
-    if (!cached.ttl || cached.ttl > Math.floor(Date.now() / 1000)) {
-      return { userId: cached.userId, role: cached.role, handle: cached.handle };
-    }
+const DRIFT_CLAIMS: CachedClaims = {
+  userId: "",
+  globalRole: "",
+  activeTenantId: "",
+  tenantSlug: "",
+  tenantRole: "",
+  handle: "",
+};
+
+function parseIdpGroups(raw: string | undefined | null): string[] {
+  if (!raw) return [];
+  return raw
+    .split(/[,;]+/)
+    .map((s) => s.trim())
+    .filter(Boolean);
+}
+
+function isFederatedEvent(event: PreTokenGenerationV2TriggerEvent): boolean {
+  const identitiesRaw = event.request.userAttributes["identities"];
+  if (!identitiesRaw) return false;
+  try {
+    const parsed = JSON.parse(identitiesRaw);
+    return Array.isArray(parsed) && parsed.length > 0;
+  } catch {
+    return false;
   }
+}
 
-  // Cache miss — query RDS
-  const db = await getPrisma();
+interface RdsClaimsLoad {
+  user: {
+    id: string;
+    role: string;
+    handle: string | null;
+    suspended: boolean;
+    suspendedAt: Date | null;
+  } | null;
+  activeMembership: {
+    tenantId: string;
+    role: TenantRole;
+    tenant: { slug: string; status: string };
+  } | null;
+}
+
+async function loadFromRds(
+  db: PrismaClient,
+  cognitoSub: string,
+  preferOrgTenant: boolean,
+  preferredTenantId: string | null,
+): Promise<RdsClaimsLoad> {
   const user = await db.user.findUnique({
     where: { cognitoSub },
-    select: { id: true, role: true, handle: true, suspendedAt: true },
+    select: {
+      id: true,
+      role: true,
+      handle: true,
+      suspended: true,
+      suspendedAt: true,
+      personalTenantId: true,
+    },
   });
+  if (!user) return { user: null, activeMembership: null };
 
-  if (!user) return null;
+  const memberships = await db.tenantMember.findMany({
+    where: { userId: user.id, status: "ACTIVE" },
+    include: { tenant: { select: { id: true, slug: true, status: true, type: true } } },
+  });
 
-  // S1.8 — Check if user is suspended
-  if (user.suspendedAt && new Date(user.suspendedAt) > new Date()) {
-    console.warn(`User ${cognitoSub} is suspended until ${user.suspendedAt}`);
-    return null;
+  // Honor an explicit user choice (from a prior switch-tenant call) above
+  // any heuristic, provided the membership is still active.
+  let active = preferredTenantId
+    ? memberships.find(
+        (m) => m.tenant.id === preferredTenantId && m.tenant.status === "ACTIVE",
+      )
+    : undefined;
+  if (!active) {
+    active = memberships.find(
+      (m) =>
+        preferOrgTenant && m.tenant.type === "ORGANIZATION" && m.tenant.status === "ACTIVE",
+    );
+  }
+  if (!active) {
+    active = memberships.find(
+      (m) => m.tenant.id === user.personalTenantId && m.tenant.status === "ACTIVE",
+    );
+  }
+  if (!active) {
+    active = memberships.find((m) => m.tenant.status === "ACTIVE");
   }
 
-  const claims: CachedClaims = { userId: user.id, role: user.role, handle: user.handle ?? "" };
+  return {
+    user: {
+      id: user.id,
+      role: user.role,
+      handle: user.handle,
+      suspended: user.suspended,
+      suspendedAt: user.suspendedAt,
+    },
+    activeMembership: active
+      ? {
+          tenantId: active.tenantId,
+          role: active.role,
+          tenant: { slug: active.tenant.slug, status: active.tenant.status },
+        }
+      : null,
+  };
+}
 
-  // Write to cache
-  await dynamo.send(new PutItemCommand({
-    TableName: TABLE,
-    Item: marshall({
-      pk: `claims:${cognitoSub}`,
-      sk: "meta",
-      ...claims,
-      ttl: Math.floor(Date.now() / 1000) + CACHE_TTL_SECONDS,
-    }),
-  }));
+async function maybeRefreshFederatedRole(
+  db: PrismaClient,
+  tenantId: string,
+  idpGroups: string[],
+  currentRole: string,
+): Promise<TenantRole | null> {
+  const mappings = await db.tenantRoleMapping.findMany({
+    where: { tenantId },
+    select: { idpGroupName: true, tenantRole: true, priority: true },
+  });
+  const idp = await db.tenantIdentityProvider.findUnique({
+    where: { tenantId },
+    select: { defaultRole: true, status: true },
+  });
+  if (!idp || idp.status !== "ACTIVE") return null;
 
-  return claims;
+  const resolved = resolveTenantRole(
+    idpGroups,
+    mappings as RoleMappingInput[],
+    idp.defaultRole,
+  );
+  if (!resolved || resolved === currentRole) return null;
+  return resolved;
 }
 
 export const handler: PreTokenGenerationV2TriggerHandler = async (event) => {
-  const claims = await getClaims(event.userName);
-
-  if (claims) {
-    event.response = {
-      claimsAndScopeOverrideDetails: {
-        accessTokenGeneration: {
-          claimsToAddOrOverride: {
-            "custom:userId": claims.userId,
-            "custom:role": claims.role,
-            "custom:handle": claims.handle,
-          },
-        },
-      },
+  const cognitoSub = event.userName;
+  const claimsCache = getCache();
+  const federated = isFederatedEvent(event);
+  const idpGroups = parseIdpGroups(event.request.userAttributes["custom:idpGroups"]);
+
+  // Cache hits skip the user-suspension and tenant-status checks below
+  // (RDS is only consulted on miss). The mitigation is *active invalidation*:
+  //   - User suspension paths MUST call `claimsCache.invalidate(cognitoSub)`.
+  //   - TODO(T3): tenant-suspension API must invalidate caches for all members.
+  // Without invalidation, suspended users keep valid claims for up to one
+  // cache TTL (DEFAULT_CACHE_TTL_SECONDS = 3600s). Tracked as G2 finding H3.
+  let claims = await claimsCache.get(cognitoSub);
+  let cacheHit = !!claims;
+
+  if (!claims) {
+    const db = await getPrisma();
+    // Read the user's last explicit tenant preference, even from an expired
+    // cache row, so an admin-side switch-tenant call survives cache TTL.
+    let preferredTenantId: string | null = null;
+    try {
+      preferredTenantId = await claimsCache.getActiveTenantPreference(cognitoSub);
+    } catch (err) {
+      console.warn(
+        JSON.stringify({
+          event: "pretoken.preference_lookup_failed",
+          cognitoSub,
+          error: (err as { code?: string })?.code ?? "unknown",
+        }),
+      );
+    }
+    const loaded = await loadFromRds(db, cognitoSub, federated, preferredTenantId);
+
+    if (!loaded.user) {
+      console.warn(JSON.stringify({ event: "pretoken.drift", cognitoSub }));
+      claims = { ...DRIFT_CLAIMS };
+      writeAccessTokenClaims(event, claims);
+      return event;
+    }
+
+    // `suspended` is the authoritative flag set by user-deprovisioning + admin
+    // dashboard; `suspendedAt` is the timestamp of the action (always a past
+    // value when present). Treat either signal as suspension. Defense-in-depth:
+    // even if a writer forgets one column, the other still blocks issuance.
+    if (loaded.user.suspended || loaded.user.suspendedAt !== null) {
+      console.warn(JSON.stringify({ event: "pretoken.suspended", cognitoSub }));
+      claims = { ...DRIFT_CLAIMS };
+      writeAccessTokenClaims(event, claims);
+      return event;
+    }
+
+    claims = {
+      userId: loaded.user.id,
+      globalRole: loaded.user.role,
+      activeTenantId: loaded.activeMembership?.tenantId ?? "",
+      tenantSlug: loaded.activeMembership?.tenant.slug ?? "",
+      tenantRole: loaded.activeMembership?.role ?? "",
+      handle: loaded.user.handle ?? "",
     };
   }
 
+  if (federated && claims.activeTenantId && idpGroups.length > 0) {
+    try {
+      const db = await getPrisma();
+      const refreshed = await maybeRefreshFederatedRole(
+        db,
+        claims.activeTenantId,
+        idpGroups,
+        claims.tenantRole,
+      );
+      if (refreshed) {
+        // Only emit the new role into the JWT after the DB persist succeeds.
+        // Otherwise a transient DB error would oscillate the user's effective
+        // role between cached-old and JWT-new on alternating refreshes (G2 H2).
+        let persisted = false;
+        try {
+          await db.tenantMember.update({
+            where: {
+              tenantId_userId: { tenantId: claims.activeTenantId, userId: claims.userId },
+            },
+            data: { role: refreshed },
+          });
+          persisted = true;
+        } catch (err) {
+          console.warn(
+            JSON.stringify({
+              event: "pretoken.role_refresh_persist_failed",
+              cognitoSub,
+              error: (err as { code?: string })?.code ?? "unknown",
+            }),
+          );
+        }
+        if (persisted) {
+          claims = { ...claims, tenantRole: refreshed };
+          cacheHit = false;
+          console.log(
+            JSON.stringify({
+              event: "pretoken.role_refreshed",
+              cognitoSub,
+              tenantId: claims.activeTenantId,
+            }),
+          );
+        }
+      }
+    } catch (err) {
+      console.warn(
+        JSON.stringify({
+          event: "pretoken.role_refresh_failed",
+          cognitoSub,
+          error: (err as { code?: string }).code ?? "unknown",
+        }),
+      );
+    }
+  }
+
+  if (!cacheHit && claims.userId) {
+    await claimsCache.put(cognitoSub, claims, DEFAULT_CACHE_TTL_SECONDS);
+  }
+
+  writeAccessTokenClaims(event, claims);
   return event;
 };
+
+function writeAccessTokenClaims(
+  event: PreTokenGenerationV2TriggerEvent,
+  claims: CachedClaims,
+): void {
+  event.response = {
+    claimsAndScopeOverrideDetails: {
+      accessTokenGeneration: {
+        claimsToAddOrOverride: {
+          "custom:userId": claims.userId,
+          "custom:globalRole": claims.globalRole,
+          "custom:activeTenantId": claims.activeTenantId,
+          "custom:tenantSlug": claims.tenantSlug,
+          "custom:tenantRole": claims.tenantRole,
+          "custom:handle": claims.handle,
+        },
+      },
+    },
+  };
+}