@ddtcorex/dsh-maestro-review 0.4.0 → 0.5.0

package/lib/orchestrator.js

@@ -31,6 +31,9 @@ import { reviewDigestText } from './notify.js';
 import { loadedReviewProfile } from './skills-tool.js';
 import { gitlabProvider } from './providers/gitlab.js';
 import './events.js';
+import { gitlabAuthHeaders } from './gitlab-auth.js';
+import { reviewMarker, resolveFlow } from './review-marker.js';
+import { cloneSourceRepo, defaultRun } from './ci-clone.js';
 // Provider-aware wrapper — orchestrator can run reviews via any ReviewProvider.
 // This keeps the GitLab-specific flow intact while allowing Phase C to add GitHub/Jira without modifying core logic.
 export async function runReviewWithProvider(provider, request) {
@@ -132,7 +135,8 @@ export function buildReviewComment(opts) {
         ? `\n\n<details>\n<summary>⚠️ Failed to post (${opts.failures.length})</summary>\n\n${opts.failures.map((f) => `- \`${f}\``).join('\n')}\n\n</details>`
         : '';
     const footer = `\n\n---\n\n<sub>Generated by Maestro · [View MR →](${mrUrl})</sub>`;
-    return `${title}\n\n${metaLine}\n\n${scopeNote}${opts.summary}${findingsLine}${failuresBlock}${footer}`;
+    const markerLine = opts.marker === undefined ? '' : `\n\n${reviewMarker(opts.marker.sha, opts.marker.flow)}`;
+    return `${title}\n\n${metaLine}\n\n${scopeNote}${opts.summary}${findingsLine}${failuresBlock}${footer}${markerLine}`;
 }
 export function buildNotStartedComment(opts) {
     const mrUrl = `${opts.gitlabBaseUrl.replace(/\/$/, '')}/${opts.projectPath}/-/merge_requests/${opts.mrIid}`;
@@ -147,6 +151,7 @@ export function buildNotStartedComment(opts) {
         `---`,
         '',
         `<sub>Generated by Maestro · [View MR →](${mrUrl})</sub>`,
+        ...(opts.marker === undefined ? [] : [``, `${reviewMarker(opts.marker.sha, opts.marker.flow)}`]),
     ].join('\n');
 }
 export const name = 'maestro-orchestrator';
@@ -199,10 +204,12 @@ export function getTurnErrorMessage(handle) {
 }
 /**
  * Resolve the model to use for an automated review. Priority: per-project
- * override > global reviewModel > DSH default (`fallback`).
+ * override > global reviewModel (Maestro Settings) > row-config reviewModel
+ * (lets a headless profile such as reviewer-ci pin a model from env vars,
+ * where there is no Settings UI) > DSH default (`fallback`).
  */
-export function resolveReviewModel(userConfig, mapping, fallback) {
-    const raw = mapping?.reviewModel ?? userConfig.reviewModel;
+export function resolveReviewModel(userConfig, mapping, fallback, rowSelection) {
+    const raw = mapping?.reviewModel ?? userConfig.reviewModel ?? rowSelection;
     if (raw === undefined || raw === null)
         return fallback;
     return {
@@ -211,6 +218,13 @@ export function resolveReviewModel(userConfig, mapping, fallback) {
         ...(raw.reasoningEffort === undefined ? {} : { reasoningEffort: ReasoningEffortId(raw.reasoningEffort) }),
     };
 }
+/** Effective auto-trigger flags: per-project row overrides global, unset inherits (design §4). */
+export function resolveReviewTriggers(userConfig, mapping) {
+    return {
+        onPush: mapping?.rereviewOnPush ?? userConfig.autoRereviewOnPush ?? false,
+        onAssign: mapping?.reviewOnAssign ?? userConfig.autoReviewOnAssign ?? true,
+    };
+}
 /** Compose a newly-created agent from the preset service owned by the root context. */
 export async function mountAgentPreset(agentPresets, agentCtx, id) {
     await agentPresets.mount(agentCtx, id);
@@ -321,7 +335,7 @@ function normalizedDiffPath(path) {
 export async function postReviewFindings(findings, config) {
     const fetcher = config.fetcher ?? fetch;
     const apiBase = `${config.baseUrl}/api/v4/projects/${config.projectId}/merge_requests/${config.mrIid}`;
-    const headers = { 'PRIVATE-TOKEN': config.token, 'Content-Type': 'application/json' };
+    const headers = { ...gitlabAuthHeaders(config.token), 'Content-Type': 'application/json' };
     for (const finding of findings) {
         let response;
         const label = severityPrefix(finding.severity);
@@ -432,6 +446,58 @@ export function auditorOutputFromSession(session) {
     return finalAssistantOutput(events) ?? [];
 }
 /** Full review + performance audit; resolves to the comment body that was posted. */
+/** Marker for CI-posted comments; webhook payloads carry no headSha and stay marker-free. */
+function commentMarker(payload) {
+    if (payload.headSha === undefined)
+        return undefined;
+    return { sha: payload.headSha, flow: resolveFlow(payload.mode) };
+}
+/** CI-deep decision: deep mode + CI env + head SHA (spec §3). Mapping is checked by the caller. */
+export function shouldCiDeepReview(payload) {
+    return payload.mode === 'deep'
+        && payload.headSha !== undefined
+        && process.env.SOURCE_PROJECT_ID !== undefined
+        && process.env.MR_IID !== undefined;
+}
+/** CI quick-with-profile decision: quick mode + non-generic profile + CI env
+ *  + head SHA. Quick + generic/unset stays diff-only (no clone cost); a real
+ *  profile opts into the clone branch reviewer-only (no auditor — quick never
+ *  audits, see shouldAudit in runReviewAndAudit). Mapping is checked by the caller. */
+export function shouldCiQuickProfileReview(payload) {
+    return payload.mode === 'quick'
+        && payload.reviewProfile !== undefined
+        && payload.reviewProfile !== 'generic'
+        && payload.headSha !== undefined
+        && process.env.SOURCE_PROJECT_ID !== undefined
+        && process.env.MR_IID !== undefined;
+}
+/** Auditor degrade for CI (no runtime env): a govard throw becomes reviewer-only, never a failed review. */
+export function withAuditorDegrade(runAuditor) {
+    return async (worktreePath, payload) => {
+        try {
+            return await runAuditor(worktreePath, payload);
+        }
+        catch {
+            return 'Auditor skipped — no runtime environment in CI (reviewer-only review).';
+        }
+    };
+}
+/**
+ * Auditor instruction. The mapped flow keeps the full environment + test-suite
+ * workflow; the CI flow has no runtime, so the prompt countermands the
+ * auditor preset's environment steps and drops the Environment & Test Suite
+ * section entirely instead of reporting it "blocked".
+ */
+export function buildAuditorPrompt(opts) {
+    if (!opts.staticOnly) {
+        return 'Audit this merge request\'s performance: bring up the environment, run the test suite, look for regressions, then write a Markdown report and tear the environment down.';
+    }
+    return 'Audit this merge request\'s performance from the static diff and checked-out code only. '
+        + 'No runtime environment exists in this container: ignore the auditor preset\'s environment steps '
+        + '(do not bring anything up, do not run the test suite, do not tear anything down). '
+        + 'Look for regressions by static analysis (diff, dependencies, query/shape risks), then write a Markdown report '
+        + 'and OMIT the Environment & Test Suite section entirely — never report it as blocked.';
+}
 export async function runReviewAndAudit(payload, deps) {
     assertSafeId(payload.projectId, 'projectId');
     assertSafeId(payload.mrIid, 'mrIid');
@@ -468,6 +534,7 @@ export async function runReviewAndAudit(payload, deps) {
                         summary: summaryText,
                         failures,
                         findings: { newCount, replyCount, severityCounts },
+                        marker: commentMarker(payload),
                     })
                     : `## 🤖 Maestro Review\n\n**\`${payload.projectPath}\` !${payload.mrIid}** · ✅ Completed · \`${payload.mode}\`${deps.reviewProfile !== undefined ? ` · \`${deps.reviewProfile}\`` : ''}\n\n${summaryText}${failures.length > 0 ? `\n\n<details>\n<summary>⚠️ Failed to post (${failures.length})</summary>\n\n${failures.map((f) => `- \`${f}\``).join('\n')}\n\n</details>` : ''}`;
                 sections.push(richOpts);
@@ -489,7 +556,8 @@ export async function runReviewAndAudit(payload, deps) {
                 else
                     await deps.postComment(body);
             }
-            catch {
+            catch (err) {
+                console.error(`maestro-orchestrator: posting review comment failed: ${err instanceof Error ? err.message : String(err)}`);
                 await deps.writeFailedReport(payload.mrIid, body);
             }
             return body;
@@ -526,6 +594,7 @@ export async function runDiffOnlyReview(payload, deps) {
                 summary: summary ?? '',
                 failures,
                 isDiffOnly: true,
+                marker: commentMarker(payload),
             })
             : `## 🤖 Maestro Review — Diff-only\n\n> **Scope:** Diff-only — reviewed the GitLab diff without a local checkout, Magento environment, static analysis, or tests. For a full review, add this project in Settings → Maestro and mention again.\n\n${summary}${failures.length > 0 ? `\n\n<details>\n<summary>⚠️ Failed to post (${failures.length})</summary>\n\n${failures.map((f) => `- \`${f}\``).join('\n')}\n\n</details>` : ''}`;
         const body = diffBody;
@@ -535,7 +604,8 @@ export async function runDiffOnlyReview(payload, deps) {
             else
                 await deps.postComment(body);
         }
-        catch {
+        catch (err) {
+            console.error(`maestro-orchestrator: posting review comment failed: ${err instanceof Error ? err.message : String(err)}`);
             await deps.writeFailedReport(payload.mrIid, body);
         }
         return body;
@@ -555,7 +625,7 @@ export async function declineUnmappedDeepReview(payload, deps) {
     const depsWithUrl = deps;
     const baseUrl = depsWithUrl.gitlabBaseUrl;
     const body = baseUrl !== undefined
-        ? buildNotStartedComment({ gitlabBaseUrl: baseUrl, projectPath: payload.projectPath, mrIid: payload.mrIid })
+        ? buildNotStartedComment({ gitlabBaseUrl: baseUrl, projectPath: payload.projectPath, mrIid: payload.mrIid, marker: commentMarker(payload) })
         : '## 🤖 Maestro Review — Not started\n\n**`' + payload.projectPath + '` !' + payload.mrIid + '** · ⏸️ Not started\n\n> Deep review requires a project mapping with a local checkout and Magento environment.\n> Add this project in **Settings → Maestro**, then mention the reviewer again.';
     try {
         try {
@@ -564,7 +634,8 @@ export async function declineUnmappedDeepReview(payload, deps) {
             else
                 await deps.postComment(body);
         }
-        catch {
+        catch (err) {
+            console.error(`maestro-orchestrator: posting review comment failed: ${err instanceof Error ? err.message : String(err)}`);
             await deps.writeFailedReport(payload.mrIid, body);
         }
     }
@@ -626,7 +697,7 @@ export function govardWorktreeOverride(projectId, mrIid, keySuffix) {
  */
 export async function fetchMrBaseSha(baseUrl, token, projectId, mrIid, fetcher = fetch) {
     try {
-        const response = await fetcher(`${baseUrl}/api/v4/projects/${projectId}/merge_requests/${mrIid}`, { headers: { 'PRIVATE-TOKEN': token } });
+        const response = await fetcher(`${baseUrl}/api/v4/projects/${projectId}/merge_requests/${mrIid}`, { headers: gitlabAuthHeaders(token) });
         if (!response.ok)
             return undefined;
         const mr = await response.json();
@@ -942,7 +1013,7 @@ export function apply(ctx, config) {
             throw err;
         }
     }
-    async function runAuditor(worktreePath, payload, effective, modelSelection) {
+    async function runAuditor(worktreePath, payload, effective, modelSelection, opts) {
         let handle;
         const agentOptions = agentOptionsForModel(modelSelection ?? ctx.agentDefaultModel.currentSelection());
         try {
@@ -970,7 +1041,7 @@ export function apply(ctx, config) {
         }
         ctx.sessionTitle.rename(handle.agent.session, `Maestro Auditor — MR !${payload.mrIid} (${payload.projectPath})`);
         try {
-            const prompt = 'Audit this merge request\'s performance: bring up the environment, run the test suite, look for regressions, then write a Markdown report and tear the environment down.';
+            const prompt = buildAuditorPrompt({ staticOnly: opts?.staticOnly === true });
             handle.agent.followup(createUserMessage({ content: [{ type: 'text', text: prompt }], source: { kind: 'user' } }));
             await whenIdleWithTimeout(handle, effectiveAgentTimeoutMs);
             const output = auditorOutputFromSession(handle.agent.session);
@@ -981,8 +1052,9 @@ export function apply(ctx, config) {
             await handle.dispose();
         }
     }
-    ctx.on('maestro/review-request', (payload) => {
-        void (async () => {
+    async function runReview(payload) {
+        const t0 = Date.now();
+        try {
             const userConfig = await loadUserConfig();
             const effective = {
                 gitlabBaseUrl: userConfig.gitlabBaseUrl ?? config.gitlabBaseUrl,
@@ -1000,18 +1072,37 @@ export function apply(ctx, config) {
                 });
             }
             const mapping = effective.projectMappings.find(m => m.projectPath === payload.projectPath);
+            // CI-deep (spec §3): unmapped deep review with CI env + head SHA skips
+            // both the decline and the diff-only fallback and runs the clone branch
+            // below, which shares the mapped path's completion tail.
+            const ciDeep = mapping === undefined && payload.mode === 'deep' && shouldCiDeepReview(payload);
+            // CI quick-with-profile: unmapped quick + non-generic profile + CI env
+            // skips the diff-only fallback and joins the clone branch below, which
+            // runs reviewer-only (quick never audits).
+            const ciQuickProfile = mapping === undefined && shouldCiQuickProfileReview(payload);
             // Unmapped reviewer assignments remain no-ops. Only an explicit mention
             // may opt into the intentionally limited, diff-only fallback below.
-            if (mapping === undefined && payload.trigger !== 'mention')
-                return;
+            if (mapping === undefined && payload.trigger !== 'mention') {
+                return { ok: true, failures: [], durationMs: Date.now() - t0 };
+            }
+            const triggers = resolveReviewTriggers(userConfig, mapping);
+            // Gated-off auto-triggers stay fully silent: no history, no signals, no comment.
+            if (payload.trigger === 'reviewer-assignment' && !triggers.onAssign) {
+                return { ok: true, failures: [], durationMs: Date.now() - t0 };
+            }
+            if (payload.trigger === 'push' && !triggers.onPush) {
+                return { ok: true, failures: [], durationMs: Date.now() - t0 };
+            }
             // A push only re-reviews an MR that already has a completed review;
             // otherwise every newly opened MR would be reviewed twice.
-            if (payload.trigger === 'push' && !(await hasCompletedReview(payload.projectId, payload.mrIid)))
-                return;
+            if (payload.trigger === 'push' && !(await hasCompletedReview(payload.projectId, payload.mrIid))) {
+                return { ok: true, failures: [], durationMs: Date.now() - t0 };
+            }
             const { gitlabToken } = effective;
             if (gitlabToken === undefined) {
-                console.error(`maestro-orchestrator: MR !${String(payload.mrIid)} for project ${payload.projectPath} has no GitLab token — set one in Maestro Settings or MAESTRO_GITLAB_TOKEN`);
-                return;
+                const message = `MR !${String(payload.mrIid)} for project ${payload.projectPath} has no GitLab token — set one in Maestro Settings or MAESTRO_GITLAB_TOKEN`;
+                console.error(`maestro-orchestrator: ${message}`);
+                return { ok: false, failures: [message], durationMs: Date.now() - t0 };
             }
             const resolved = { ...effective, gitlabToken };
             const historyId = `${payload.projectId}-${payload.mrIid}-${Date.now()}`;
@@ -1043,7 +1134,7 @@ export function apply(ctx, config) {
             const fallbackSelection = ctx.get?.('agentDefaultModel')?.currentSelection()
                 ?? ctx.agentDefaultModel?.currentSelection()
                 ?? { provider: 'fallback', model: 'fallback' };
-            const reviewModelSelection = resolveReviewModel(userConfig, mapping, fallbackSelection);
+            const reviewModelSelection = resolveReviewModel(userConfig, mapping, fallbackSelection, config.reviewModel);
             // Opt-in Telegram digest; a delivery failure is logged and dropped.
             const reviewStartMsOuter = Date.now();
             const notifyTelegram = (status, summary, extra) => {
@@ -1095,7 +1186,7 @@ export function apply(ctx, config) {
             const postComment = async (body) => {
                 const response = await fetch(`${resolved.gitlabBaseUrl}/api/v4/projects/${payload.projectId}/merge_requests/${payload.mrIid}/notes`, {
                     method: 'POST',
-                    headers: { 'PRIVATE-TOKEN': resolved.gitlabToken, 'Content-Type': 'application/json' },
+                    headers: { ...gitlabAuthHeaders(resolved.gitlabToken), 'Content-Type': 'application/json' },
                     body: JSON.stringify({ body }),
                 });
                 if (!response.ok)
@@ -1104,23 +1195,25 @@ export function apply(ctx, config) {
             const replyToDiscussion = async (discussionId, body) => {
                 const response = await fetch(`${resolved.gitlabBaseUrl}/api/v4/projects/${payload.projectId}/merge_requests/${payload.mrIid}/discussions/${encodeURIComponent(discussionId)}/notes`, {
                     method: 'POST',
-                    headers: { 'PRIVATE-TOKEN': resolved.gitlabToken, 'Content-Type': 'application/json' },
+                    headers: { ...gitlabAuthHeaders(resolved.gitlabToken), 'Content-Type': 'application/json' },
                     body: JSON.stringify({ body }),
                 });
                 if (!response.ok)
                     throw new Error(`GitLab API error ${response.status}: ${await response.text()}`);
             };
             try {
-                if (mapping === undefined) {
-                    if (payload.mode === 'deep') {
+                if (mapping === undefined && !ciDeep && !ciQuickProfile) {
+                    // CI-deep (spec §3) skips the decline and falls through to the clone
+                    // branch below; every other unmapped deep review still declines here.
+                    if (payload.mode === 'deep' && !shouldCiDeepReview(payload)) {
                         await declineUnmappedDeepReview(payload, { postComment, replyToDiscussion, writeFailedReport, gitlabBaseUrl: resolved.gitlabBaseUrl });
                         await recordReviewFinish(historyId, { status: 'completed', summary: 'Deep review declined (unmapped project)' });
                         notifyTelegram('completed', 'Deep review declined (unmapped project)');
                         await signals?.finish('completed');
-                        return;
+                        return { ok: true, summary: 'Deep review declined (unmapped project)', failures: [], durationMs: Date.now() - t0 };
                     }
                     const diffBody = await runDiffOnlyReview(payload, {
-                        runReviewer: (p) => runReviewer(undefined, p, resolved, undefined, reviewModelSelection, incrementalBlock),
+                        runReviewer: (p) => runReviewer(undefined, p, resolved, payload.reviewProfile, reviewModelSelection, incrementalBlock),
                         postComment,
                         replyToDiscussion,
                         writeFailedReport,
@@ -1129,59 +1222,108 @@ export function apply(ctx, config) {
                     await recordReviewFinish(historyId, { status: 'completed', summary: summarize(diffBody) });
                     notifyTelegram('completed', summarize(diffBody));
                     await signals?.finish('completed');
-                    return;
+                    return { ok: true, summary: summarize(diffBody), failures: [], durationMs: Date.now() - t0 };
                 }
                 let fullBody;
-                try {
-                    fullBody = await runReviewAndAudit(payload, {
-                        localRepoPath: mapping.localRepoPath,
-                        ensureWorktree,
-                        removeWorktree,
-                        runReviewer: (worktreePath, p) => runReviewer(worktreePath, p, resolved, mapping.reviewProfile ?? 'magento2', reviewModelSelection, incrementalBlock),
-                        runAuditor: (worktreePath, p) => runAuditor(worktreePath, p, resolved, reviewModelSelection),
-                        postComment,
-                        replyToDiscussion,
-                        writeFailedReport,
-                        gitlabBaseUrl: resolved.gitlabBaseUrl,
-                        reviewProfile: mapping.reviewProfile ?? 'magento2',
-                    });
+                if (ciDeep || ciQuickProfile) {
+                    // CI-deep (mapping is always undefined here — the unmapped block above
+                    // returned for every other case): clone the source at the head SHA,
+                    // map it in memory, and reuse the mapped machinery reviewer-only.
+                    // CI quick-with-profile joins the same branch; runReviewAndAudit skips
+                    // the auditor for quick (shouldAudit), so it stays reviewer-only.
+                    // No govard/vendor linking (ciEnsureWorktree is plain fetch + worktree).
+                    const ciHost = process.env.GITLAB_HOST?.trim() || new URL(resolved.gitlabBaseUrl).hostname;
+                    const cloneDir = join('/tmp', `maestro-ci-src-${payload.projectId}-${payload.mrIid}`);
+                    await cloneSourceRepo({ fetcher: fetch, run: defaultRun, host: ciHost, projectId: payload.projectId, sourceBranch: payload.sourceBranch, headSha: payload.headSha, token: resolved.gitlabToken, dir: cloneDir });
+                    try {
+                        const ciEnsureWorktree = async (repoPath, branch, pid, iid, suffix) => {
+                            assertSafeBranchName(branch);
+                            const wt = join('/tmp', `maestro-mr-${pid}-${iid}${suffix === undefined ? '' : `-${suffix}`}`);
+                            await defaultRun('git', ['fetch', '--depth', '50', 'origin', branch], repoPath);
+                            await defaultRun('git', ['worktree', 'remove', '--force', wt], repoPath).catch(() => { });
+                            await defaultRun('git', ['worktree', 'add', '--detach', '--', wt, payload.headSha], repoPath);
+                            return wt;
+                        };
+                        fullBody = await runReviewAndAudit(payload, {
+                            localRepoPath: cloneDir,
+                            ensureWorktree: ciEnsureWorktree,
+                            removeWorktree,
+                            runReviewer: (worktreePath, p) => runReviewer(worktreePath, p, resolved, payload.reviewProfile ?? 'generic', reviewModelSelection, incrementalBlock),
+                            runAuditor: withAuditorDegrade((worktreePath, p) => runAuditor(worktreePath, p, resolved, reviewModelSelection, { staticOnly: true })),
+                            postComment,
+                            replyToDiscussion,
+                            writeFailedReport,
+                            gitlabBaseUrl: resolved.gitlabBaseUrl,
+                            reviewProfile: payload.reviewProfile ?? 'generic',
+                        });
+                    }
+                    finally {
+                        await defaultRun('rm', ['-rf', cloneDir]).catch(() => { });
+                    }
                 }
-                catch (err) {
-                    const isBranchNotFound = err?.code === 'BRANCH_NOT_FOUND' || isBranchNotFoundError(err);
-                    if (isBranchNotFound) {
-                        const diffBody = await runDiffOnlyReview(payload, {
-                            runReviewer: (p) => runReviewer(undefined, p, resolved, undefined, reviewModelSelection, incrementalBlock),
+                else {
+                    // Unreachable when mapping is undefined: the unmapped block returned
+                    // for every non-CI-deep case, and ciDeep took the branch above.
+                    if (mapping === undefined)
+                        throw new Error('unreachable: unmapped review without CI-deep decision');
+                    try {
+                        fullBody = await runReviewAndAudit(payload, {
+                            localRepoPath: mapping.localRepoPath,
+                            ensureWorktree,
+                            removeWorktree,
+                            runReviewer: (worktreePath, p) => runReviewer(worktreePath, p, resolved, mapping.reviewProfile ?? 'magento2', reviewModelSelection, incrementalBlock),
+                            runAuditor: (worktreePath, p) => runAuditor(worktreePath, p, resolved, reviewModelSelection),
                             postComment,
                             replyToDiscussion,
                             writeFailedReport,
                             gitlabBaseUrl: resolved.gitlabBaseUrl,
+                            reviewProfile: mapping.reviewProfile ?? 'magento2',
                         });
-                        const summary = summarize(diffBody);
-                        const branchNote = `fallback diff-only: branch ${payload.sourceBranch} not found on origin — ${summary ?? ''}`.trim();
-                        await recordReviewFinish(historyId, { status: 'completed', summary: branchNote });
-                        notifyTelegram('completed', branchNote);
-                        await signals?.finish('completed');
-                        return;
                     }
-                    throw err;
+                    catch (err) {
+                        const isBranchNotFound = err?.code === 'BRANCH_NOT_FOUND' || isBranchNotFoundError(err);
+                        if (isBranchNotFound) {
+                            const diffBody = await runDiffOnlyReview(payload, {
+                                runReviewer: (p) => runReviewer(undefined, p, resolved, payload.reviewProfile, reviewModelSelection, incrementalBlock),
+                                postComment,
+                                replyToDiscussion,
+                                writeFailedReport,
+                                gitlabBaseUrl: resolved.gitlabBaseUrl,
+                            });
+                            const summary = summarize(diffBody);
+                            const branchNote = `fallback diff-only: branch ${payload.sourceBranch} not found on origin — ${summary ?? ''}`.trim();
+                            await recordReviewFinish(historyId, { status: 'completed', summary: branchNote });
+                            notifyTelegram('completed', branchNote);
+                            await signals?.finish('completed');
+                            return { ok: true, summary: branchNote, failures: [], durationMs: Date.now() - t0 };
+                        }
+                        throw err;
+                    }
                 }
                 await recordReviewFinish(historyId, { status: 'completed', summary: summarize(fullBody) });
                 notifyTelegram('completed', summarize(fullBody));
                 await signals?.finish('completed');
+                return { ok: true, summary: summarize(fullBody), failures: [], durationMs: Date.now() - t0 };
             }
             catch (err) {
                 const message = err instanceof Error ? err.message : String(err);
                 await recordReviewFinish(historyId, { status: 'failed', error: message }).catch(() => { });
                 notifyTelegram('failed', message);
                 await signals?.finish('failed');
-                throw err;
+                return { ok: false, summary: undefined, failures: [message], durationMs: Date.now() - t0 };
             }
-        })().catch((err) => {
+        }
+        catch (err) {
             // Worktree creation, agent creation, and fallback delivery all run from
-            // an event callback, so surface failures rather than leaking a rejected
-            // fire-and-forget Promise.
+            // this function — surface failures as a result instead of an unhandled
+            // rejection, so both the fire-and-forget webhook path and an awaiting
+            // CI caller observe the same outcome.
+            const message = err instanceof Error ? err.message : String(err);
             console.error(`maestro-orchestrator: review run failed for MR !${String(payload.mrIid)}:`, err);
-        });
-    });
+            return { ok: false, summary: undefined, failures: [message], durationMs: Date.now() - t0 };
+        }
+    }
+    ctx.on('maestro/review-request', (payload) => { void runReview(payload); });
+    ctx.provide('reviewRunner', runReview);
 }
 //# sourceMappingURL=orchestrator.js.map