@ddtcorex/dsh-maestro-review 0.3.1 → 0.4.0

package/src/host/review-findings-tool.ts

@@ -4,12 +4,18 @@ import { defineTool } from '@deepseek-ai/dsh-tools'
 export const name = 'maestro-review-findings-tool'
 export const inject = ['tools']
 
+export type FindingSeverity = 'blocking' | 'major' | 'minor' | 'nit'
+
 export interface ReviewFinding {
   status: 'new' | 'reply'
   body: string
   path?: string
   line?: number
   discussionId?: string
+  /** Assigned by the reviewer; missing values are treated as `minor`. */
+  severity?: FindingSeverity
+  /** Optional area tag, e.g. security, correctness, perf, style. */
+  category?: string
 }
 
 export interface Config {
@@ -19,7 +25,7 @@ export interface Config {
 export function apply(ctx: Context, config: Config): void {
   ctx.tools.register(defineTool({
     name: 'report_review_findings',
-    description: 'Submit your complete list of review findings exactly once, when done analyzing. Each finding is {status: "new", path, line, body} for a location with no existing thread, or {status: "reply", discussionId, body} to update an existing thread returned by gitlab_list_own_review_threads.',
+    description: 'Submit your complete list of review findings exactly once, when done analyzing. Each finding is {status: "new", path, line, body, severity, category?} for a location with no existing thread, or {status: "reply", discussionId, body, severity, category?} to update an existing thread returned by gitlab_list_own_review_threads (reply to a resolved thread reopens it — prefer reply over new when the substance matches). Severity (required in spirit, defaults to minor): blocking = must fix before merge (regression, data loss, real XSS/RCE); major = should fix (correctness bug, security hardening with a realistic path); minor = nice to fix (perf nit with impact, stale docs, fragile coupling); nit = style/micro with no behavior impact.',
     parameters: {
       findings: {
         type: 'array',
@@ -34,6 +40,8 @@ export function apply(ctx: Context, config: Config): void {
             path: { type: 'string' },
             line: { type: 'number' },
             discussionId: { type: 'string' },
+            severity: { type: 'string', enum: ['blocking', 'major', 'minor', 'nit'] },
+            category: { type: 'string' },
           },
         },
       },

package/src/host/review-intake.ts

@@ -81,6 +81,10 @@ export function routeGitlabReviewRequest(body: unknown, botUsername: string, opt
   if (value.object_kind !== 'note' || typeof attributes.note !== 'string' || !isMentioned(attributes.note, botUsername)) return undefined
   const scope = noteScope(attributes)
   if (scope === undefined) return undefined
-  const mode: ReviewMode = /(?:^|\s)\/maestro\s+deep(?:\s|$)/i.test(attributes.note) ? 'deep' : 'quick'
+  // Deep runs the auditor (env + perf) and costs far more than quick, so the
+  // trigger stays explicit: the `/maestro deep` slash command or the natural
+  // phrase "deep review". A bare "deep" alone never triggers (too loose).
+  const note = attributes.note
+  const mode: ReviewMode = /(?:^|\s)\/maestro\s+deep(?:\s|$)/i.test(note) || /\bdeep\s+review\b/i.test(note) ? 'deep' : 'quick'
   return { ...payload, trigger: 'mention', mode, scope }
 }

package/src/host/settings-rpc.ts

@@ -12,7 +12,7 @@ export const inject = ['connection', 'maestroTunnel']
 /** Keys the Settings card may persist; anything else is a rejected save. */
 const SAVABLE_KEYS = new Set<keyof MaestroUserConfig>([
   'gitlabBaseUrl', 'gitlabToken', 'botUsername', 'webhookSecret', 'webhookPort',
-  'projectMappings', 'reviewModel', 'supervisorModel', 'autoRereviewOnPush', 'agentTimeoutMs', 'reviewSessionRetentionDays',
+  'projectMappings', 'reviewModel', 'autoRereviewOnPush', 'agentTimeoutMs', 'reviewSessionRetentionDays',
   'tunnelMode', 'quickTarget', 'tunnelId', 'tunnelCredentialsFile', 'tunnelHostname',
   'proxyPort', 'proxyHost', 'lanPinEnabled', 'telegramBotToken', 'telegramChatId',
   'telegramReviewNotifications',
@@ -86,14 +86,6 @@ function validateSavePayload(payload: unknown): { ok: true; patch: Partial<Maest
       const err = validateReviewModel(value)
       if (err !== null) return { ok: false, message: err }
     }
-    if (key === 'supervisorModel') {
-      if (value === null) {
-        patch[key as keyof MaestroUserConfig] = undefined as never
-        continue
-      }
-      const err = validateReviewModel(value)
-      if (err !== null) return { ok: false, message: err.replace('reviewModel', 'supervisorModel') }
-    }
     if (key === 'webhookPort' && value !== undefined && (typeof value !== 'number' || !Number.isInteger(value) || value < 1 || value > 65535)) {
       return { ok: false, message: 'webhookPort must be an integer between 1 and 65535.' }
     }