@ddtcorex/dsh-maestro-review 0.10.0 → 0.11.0

package/skills/dsh-native-tools/SKILL.md

@@ -1,6 +1,6 @@
 ---
 name: dsh-native-tools
-description: Use when running a Maestro skill inside DeepSeek Harness and its text says "native ... when provided" — this maps each such capability (query-log stats, lint, deploy preflight, layout extraction, theme inspection, review scope split, escape scan, module check, MR diff) to the tool DSH actually exposes
+description: Use when running a Maestro skill inside DeepSeek Harness and its text says "native ... when provided" — this maps each such capability (query-log stats, lint, deploy preflight, layout extraction, theme inspection, review scope split, escape scan, module check, MR diff) to the DSH tool or the govard CLI command, run with bash, that provides it
 ---
 
 # DSH Native Tools
@@ -47,15 +47,15 @@ Left column is the phrase the public skill uses; right column is what to call.
 | Public skill says | Tool and signature |
 |---|---|
 | native query-log stats tool | `maestro_perf_log_stats {topN?, repeatThreshold?, timeThresholdMs?}` → streaming and bounded; never hand-grep a 16–50k line log or open it as a spreadsheet |
-| native lint tool | `govard_audit_lint`; in the review plugin `{worktreePath?, scope?: "diff"\|"project", base?}` — the workflow quick/deep split; in the govard plugin `{worktreePath?, mode?, phpVersions?}` or `{checks:["integrity"]}` for container-free analysis. Do not hand-parse text or exit codes |
-| native deploy preflight | `govard_deploy_plan {remote, build?, artifactDir?}` prints the pipeline without connecting; `govard_deploy_check {remote, build?, artifactDir?}` runs it. Both read-only, `remote` required. Running a deploy stays in the terminal |
+| native lint tool | `govard audit run --checks lint --format json --mode auto --timeout auto --lint-provider govard --scope diff --base <sha>` run with `bash` in the review worktree (`--scope project` drops `--base`); `govard audit run --checks integrity --format json` is the container-free analysis. Read the JSON; exit `0` is clean, `1` findings, `3` a missing capability. A missing `govard` binary or Docker is not a finding: report lint as unavailable |
+| native deploy preflight | `govard deploy plan <remote>` (add `--json` for machine-readable) prints the pipeline without connecting; `govard deploy check <remote>` preflights connectivity and the release layout. Both run with `bash`, `remote` is a remote from `.govard.yml`, and running the deploy itself stays in the terminal |
 | native layout extraction | `layout_xml_extract {changedFiles:<MR layout files>}` → handles/blocks/moves + templateExists/parseError |
 | native theme inspection | `hyva_theme_inspect {classes:["<class-from-diff>"]}` → `{themes[],tailwind:{major,...},hyvaPackages[]}`; a null field means downgrade to a question |
 | native review scope split | `maestro_review_scope_split {diffStats:{files,addedLinesPerFile}, mode}` → `{split:{quick,deep},reason,estimatedSavingsTokens}`; run quick checks only on quick files |
 | native escape scan | `phtml_escape_scan {scope:"diff", paths:<changed phtml>}` → `{findings[],scannedFiles,truncated}` with confidence + M2-SEC-xxx; `hyva_csp_scan {maxFiles?}` covers CSP work and truncates at `maxFiles` with no `truncated` flag — size the input yourself |
 | native module check | `magento_module_check {modulePath:"app/code/Vendor/Module"}` → `{modules[],scannedModules,truncated}`; always check `scannedModules` against what you expected |
 | native MR diff | `gitlab_get_mr_diff`, `gitlab_list_own_review_threads`, `gitlab_post_inline_comment` — diff plus own threads plus inline comments in one call |
-| local lint inside a review worktree | `govard_audit_lint` (see the lint row above); `govard_shell` runs one command in the container |
+| local environment inside a review worktree | `govard env up` brings it up, `govard shell -c "<command>"` runs one command in the container, `govard env down -v` tears it down (always, even after a failure). All three run with `bash`; the worktree carries its own project name so it never collides with the primary checkout |
 
 The `maestro_get_skills` tool searches this same skill catalogue by keyword and
 returns full content — useful when a review profile has not preloaded a skill.
@@ -75,7 +75,7 @@ returns full content — useful when a review profile has not preloaded a skill.
 ## Maintenance
 
 - Public skills stay tool-neutral. Never copy a tool name back into
-  `maestro-skills`: its catalog test rejects `maestro_*`, `govard_audit_lint`, `DSH`
+  `maestro-skills`: its catalog test rejects `maestro_*`, `DSH`
   and `DeepSeek Harness` anywhere in skill content, `compatibility: dsh` frontmatter
   excepted.
 - Renaming a tool in `src/host` must fail `tests/dsh-native-tools-skill.test.ts`, so

package/src/client/BrandMark.tsx

@@ -0,0 +1,42 @@
+/**
+ * The Maestro M badge this package's settings header draws.
+ *
+ * A copy of `dsh-maestro-core/src/client/config/components/BrandMark.tsx`, for
+ * the structural reason its own header explains: one plugin's client bundle
+ * cannot import another's. The glyph and tile come from `./maestro-mark.ts`.
+ */
+
+import { createElement as h } from 'react'
+import {
+  MAESTRO_BRAND_TILE,
+  MAESTRO_MARK_PATH,
+  MAESTRO_MARK_STROKE_WIDTH,
+  MAESTRO_MARK_VIEWBOX,
+} from './maestro-mark.js'
+
+export function MaestroMark(props: { size?: number }) {
+  const s = props.size ?? 16
+  return h('svg', { width: s, height: s, viewBox: MAESTRO_MARK_VIEWBOX, fill: 'none', 'aria-hidden': 'true' } as any,
+    h('path', { d: MAESTRO_MARK_PATH, stroke: 'currentColor', strokeWidth: MAESTRO_MARK_STROKE_WIDTH, strokeLinecap: 'round', strokeLinejoin: 'round' } as any),
+  )
+}
+
+/**
+ * The 28px brand tile. Its colour, border, shadow and radius are the brand and
+ * are not negotiable — a token-only background resolves to near-white on some
+ * dark themes, which is why the fixed tile exists.
+ */
+export function BrandBadge(props: { size?: number; outer?: number; radius?: number; style?: Record<string, unknown> }) {
+  const outer = props.outer ?? 28
+  const size = props.size ?? 16
+  const radius = props.radius ?? 8
+  return h('span', {
+    'data-maestro-logo': '',
+    style: {
+      width: outer, height: outer, borderRadius: radius, display: 'inline-flex', alignItems: 'center', justifyContent: 'center',
+      background: `var(--dsw-alias-brand-primary, ${MAESTRO_BRAND_TILE})`, backgroundColor: MAESTRO_BRAND_TILE, color: '#fff', flex: 'none',
+      border: '1px solid rgba(0,0,0,0.08)', boxShadow: '0 0 0 1px var(--dsw-alias-border-l1)', boxSizing: 'border-box' as any,
+      ...props.style,
+    },
+  } as any, h(MaestroMark as any, { size }))
+}

package/src/client/index.tsx

@@ -0,0 +1,109 @@
+/**
+ * dsh-maestro-review — client bundle entry.
+ *
+ * Registers `settings.section` id `maestro-review` (order 32): the GitLab and
+ * Review keys this package owns.
+ *
+ * Every field here is a key review still saves. The tunnel, proxy, PIN and
+ * telegram fields left with their owners in wave 2, and the Secrets tab that
+ * used to render the Telegram token went with them: a plugin that cannot save
+ * a value has no business rendering its field.
+ */
+import * as React from 'react'
+import { ReviewSettings } from './review/ReviewSettings.js'
+import { REVIEW_CSS } from './review/styles.js'
+import { registerSettingsNavIcon, SETTINGS_NAV_MARKER } from './settings-nav-icon.js'
+
+/** This package's own channel; the endpoints it serves. */
+export const REVIEW_CHANNEL = '/dsh-maestro-review'
+
+export type RpcCall = (endpoint: string, payload?: unknown) => Promise<any>
+
+/**
+ * Unwrap the `RpcResult` envelope. A bare `{ ok: true }` is not a usable
+ * answer: the value is what the form renders, so an endpoint that forgets it
+ * produces an empty card that saves nothing and reports no error.
+ */
+function unwrap(res: any): any {
+  return res && typeof res === 'object' && 'ok' in res ? (res.ok ? res.value : null) : res
+}
+
+export function makeRpcCall(ctx: any): RpcCall {
+  return async (endpoint, payload) => {
+    const conn = ctx.get?.('connection')
+    if (conn?.rpc?.call === undefined) throw new Error('RPC not available')
+    const res = await conn.rpc.call(REVIEW_CHANNEL, endpoint, payload ?? {})
+    const value = unwrap(res)
+    if (value === null) {
+      throw new Error(String(res?.error?.message ?? res?.error ?? endpoint))
+    }
+    return value
+  }
+}
+
+const REVIEW_NAV_CSS = `
+[${SETTINGS_NAV_MARKER}] > svg:first-child,
+[${SETTINGS_NAV_MARKER}] > svg.zWKi1a_navIcon {
+  display: none !important;
+}
+
+[${SETTINGS_NAV_MARKER}]::before {
+  content: '';
+  flex: none;
+  width: 16px;
+  height: 16px;
+  display: inline-block;
+  background: currentColor;
+  -webkit-mask: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16' fill='none' stroke='black' stroke-width='1.6' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M2 11 L5 4 L8 9 L11 4 L14 11'/%3E%3C/svg%3E") center / contain no-repeat;
+  mask: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' width='16' height='16' viewBox='0 0 16 16' fill='none' stroke='black' stroke-width='1.6' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M2 11 L5 4 L8 9 L11 4 L14 11'/%3E%3C/svg%3E") center / contain no-repeat;
+}
+`
+
+function installStyleTag(css: string, pluginCss: string): () => void {
+  if (typeof document === 'undefined') return () => {}
+  const tag = document.createElement('style')
+  tag.dataset.plugin = '@ddtcorex/dsh-maestro-review'
+  tag.dataset.pluginCss = pluginCss
+  tag.textContent = css
+  document.head.appendChild(tag)
+  return () => {
+    document.querySelector(`style[data-plugin-css="${pluginCss}"]`)?.remove()
+  }
+}
+
+export const inject = ['slots', 'connection'] as const
+
+export function apply(ctx: any): void {
+  const slots = ctx.get?.('slots')
+  if (!slots?.inject || !slots?.register) return
+
+  const rpcCall = makeRpcCall(ctx)
+
+  ctx.effect(() => registerSettingsNavIcon(() => 'Maestro Review'), 'maestro-review: settings nav icon')
+  ctx.effect(() => installStyleTag(REVIEW_NAV_CSS, 'maestro-review/settings-nav.css'), 'maestro-review: settings nav css')
+  ctx.effect(() => installStyleTag(REVIEW_CSS, 'maestro-review/settings.css'), 'maestro-review: settings css')
+
+  ctx.effect(() => {
+    const dispose = slots.inject('settings.section', () =>
+      slots.register(
+        {
+          name: 'settings.section',
+          id: 'maestro-review',
+          order: 32,
+          label: () => 'Maestro Review',
+          inject: () => ({ rpcCall }),
+        },
+        (props: { rpcCall: RpcCall }) => React.createElement(ReviewSettings, props),
+      ),
+    )
+    return () => {
+      try {
+        ;(dispose as any)?.()
+      } catch {
+        // Teardown must never throw.
+      }
+    }
+  }, 'maestro-review: settings')
+}
+
+export default { inject, apply }

package/src/client/maestro-mark.ts

@@ -0,0 +1,21 @@
+/**
+ * Maestro M logo — the react-free half of this package's copy.
+ *
+ * This is a verbatim copy of
+ * `dsh-maestro-core/src/client/config/maestro-mark.ts`, which is the source of
+ * record for the house pattern. The duplication is structural, not accidental:
+ * every Maestro package declares its own `dsh.client` entry and builds its own
+ * `lib/client.js`, so one plugin's client module cannot import another's.
+ *
+ * The react half lives in `BrandMark.tsx` and cannot be imported from vitest at
+ * all — `react` is a client-bundler EXTERNAL with no entry in this package's
+ * `package.json`. Splitting the glyph declaration out is what lets a test assert
+ * these exact bytes instead of grepping source text.
+ */
+
+export const MAESTRO_MARK_PATH = 'M2 11 L5 4 L8 9 L11 4 L14 11'
+export const MAESTRO_MARK_VIEWBOX = '0 0 16 16'
+export const MAESTRO_MARK_STROKE_WIDTH = 1.6
+
+/** Badge tile colour — part of the house pattern documented in AGENTS.md. */
+export const MAESTRO_BRAND_TILE = '#0A84FF'

package/src/client/review/ReviewSettings.tsx

@@ -0,0 +1,236 @@
+/**
+ * The GitLab and Review keys `dsh-maestro-review` owns, and nothing else.
+ *
+ * Secrets follow a three-state rule and are never rendered back: the server
+ * answers `hasGitlabToken` / `hasWebhookSecret` instead of the value, a blank
+ * field keeps what is stored, and a filled field replaces it.
+ */
+import * as React from 'react'
+import type { RpcCall } from '../index.js'
+import { BrandBadge } from '../BrandMark.js'
+
+interface Cfg {
+  gitlabBaseUrl?: string
+  botUsername?: string
+  webhookPort?: string | number
+  autoRereviewOnPush?: boolean
+  autoReviewOnAssign?: boolean
+  agentTimeoutMs?: number
+  reviewSessionRetentionDays?: number
+  hasGitlabToken?: boolean
+  hasWebhookSecret?: boolean
+}
+
+/**
+ * What each setting is called on screen.
+ *
+ * The page used to label every field with `String(key)`, so it read
+ * "gitlabBaseUrl" and "reviewSessionRetentionDays" to anyone who had not
+ * opened the store. The key stays as the `data-review-input` value and the
+ * wire name; only the visible label changes.
+ */
+const FIELD_LABELS: Partial<Record<keyof Cfg, string>> = {
+  gitlabBaseUrl: 'GitLab base URL',
+  botUsername: 'Bot username',
+  webhookPort: 'Webhook port',
+  autoRereviewOnPush: 'Re-review on push',
+  autoReviewOnAssign: 'Review on assign',
+  agentTimeoutMs: 'Agent timeout (ms)',
+  reviewSessionRetentionDays: 'Session retention (days)',
+}
+
+/**
+ * One setting, in the house pattern's two-column row: label and hint left,
+ * control held right. `htmlFor`/`id` are what give the control its accessible
+ * name — the previous markup rendered a bare `<label>` beside an input with no
+ * `id`, so nothing was associated.
+ */
+function Field(props: { id: string; label: string; hint?: React.ReactNode; children?: React.ReactNode }) {
+  return React.createElement(
+    'div',
+    { 'data-review-row': '' },
+    React.createElement(
+      'div',
+      { 'data-review-row-text': '' },
+      React.createElement('label', { 'data-review-label': '', htmlFor: props.id }, props.label),
+      props.hint ? React.createElement('p', { 'data-review-hint': '' }, props.hint) : null,
+    ),
+    React.createElement('div', { 'data-review-control': '' }, props.children),
+  )
+}
+
+function SecretField(props: {
+  id: string
+  name: string
+  label: string
+  present: boolean
+  value: string
+  onChange: (v: string) => void
+  onSave: () => void
+  disabled: boolean
+}) {
+  return Field({
+    id: props.id,
+    label: props.label,
+    hint: props.present ? 'A value is stored. Leave blank to keep it.' : 'Not set.',
+    children: React.createElement(
+      'div',
+      { 'data-review-secret-group': '' },
+      React.createElement('input', {
+        id: props.id,
+        type: 'password',
+        value: props.value,
+        placeholder: props.present ? 'stored — type to replace' : 'not set',
+        disabled: props.disabled,
+        autoComplete: 'new-password',
+        'data-review-secret': '',
+        onChange: (e: any) => props.onChange(e.target.value),
+      }),
+      // The save belongs to this field: it stays disabled until the field
+      // holds something, and floating it below the row left it orphaned.
+      React.createElement('button', {
+        type: 'button',
+        disabled: props.disabled || props.value === '',
+        'data-review-save-secret': props.name,
+        onClick: props.onSave,
+      }, 'Save'),
+    ),
+  })
+}
+
+export function ReviewSettings(props: { rpcCall: RpcCall }) {
+  const { rpcCall } = props
+  const [cfg, setCfg] = React.useState<Cfg>({})
+  const [gitlabToken, setGitlabToken] = React.useState('')
+  const [webhookSecret, setWebhookSecret] = React.useState('')
+  const [busy, setBusy] = React.useState(false)
+  const [notice, setNotice] = React.useState<{ tone: 'ok' | 'bad'; text: string } | null>(null)
+
+  const fail = React.useCallback((e: unknown) => {
+    setNotice({ tone: 'bad', text: e instanceof Error ? e.message : String(e) })
+  }, [])
+
+  const refresh = React.useCallback(async () => {
+    setBusy(true)
+    try {
+      setCfg((await rpcCall('maestro.getConfig')) ?? {})
+    } catch (e) {
+      fail(e)
+    } finally {
+      setBusy(false)
+    }
+  }, [rpcCall, fail])
+
+  React.useEffect(() => {
+    void refresh()
+  }, [refresh])
+
+  const save = React.useCallback(
+    async (patch: Record<string, unknown>) => {
+      setBusy(true)
+      try {
+        await rpcCall('maestro.saveConfig', patch)
+        // Blank means keep, so the local field clears only after the save
+        // landed; otherwise a failed save would silently drop what was typed.
+        if ('gitlabToken' in patch) setGitlabToken('')
+        if ('webhookSecret' in patch) setWebhookSecret('')
+        setNotice({ tone: 'ok', text: 'Saved.' })
+        await refresh()
+      } catch (e) {
+        fail(e)
+      } finally {
+        setBusy(false)
+      }
+    },
+    [rpcCall, refresh, fail],
+  )
+
+  const text = (key: keyof Cfg, placeholder = '') =>
+    Field({
+      id: `review-${String(key)}`,
+      label: FIELD_LABELS[key] ?? String(key),
+      children: React.createElement('input', {
+        id: `review-${String(key)}`,
+        type: 'text',
+        value: (cfg[key] as string | number | undefined) ?? '',
+        placeholder,
+        disabled: busy,
+        'data-review-input': String(key),
+        onChange: (e: any) => setCfg((c) => ({ ...c, [key]: e.target.value })),
+        onBlur: (e: any) => void save({ [key]: e.target.value }),
+      }),
+    })
+
+  const toggle = (key: keyof Cfg) =>
+    Field({
+      id: `review-${String(key)}`,
+      label: FIELD_LABELS[key] ?? String(key),
+      children: React.createElement('input', {
+        id: `review-${String(key)}`,
+        type: 'checkbox',
+        checked: cfg[key] === true,
+        disabled: busy,
+        'data-review-toggle': String(key),
+        onChange: (e: any) => void save({ [key]: e.target.checked }),
+      }),
+    })
+
+  return React.createElement(
+    'div',
+    { 'data-review-root': '' },
+    // House header: badge, title, one-line status. The notice lives here so it
+    // reports without pushing the rows down.
+    React.createElement(
+      'div',
+      { 'data-review-header': '' },
+      React.createElement(BrandBadge as any, { style: { alignSelf: 'flex-start', marginTop: 2 } }),
+      React.createElement(
+        'div',
+        { 'data-review-heading': '' },
+        React.createElement('h2', { 'data-review-title': '' }, 'GitLab and Review'),
+        React.createElement(
+          'div',
+          { 'data-review-status': '' },
+          notice
+            ? React.createElement('p', { 'data-review-notice': '', 'data-tone': notice.tone, role: 'status' }, notice.text)
+            : React.createElement('span', null, 'GitLab credentials and review triggers.'),
+        ),
+      ),
+    ),
+
+    React.createElement('div', { 'data-review-actions': '' },
+      React.createElement('button', { type: 'button', disabled: busy, onClick: () => void refresh() }, 'Refresh'),
+    ),
+
+    text('gitlabBaseUrl', 'https://gitlab.example.com'),
+    text('botUsername', 'maestro-bot'),
+
+    SecretField({
+      id: 'review-gitlab-token',
+      name: 'gitlabToken',
+      label: 'GitLab token',
+      present: cfg.hasGitlabToken === true,
+      value: gitlabToken,
+      disabled: busy,
+      onChange: setGitlabToken,
+      onSave: () => void save({ gitlabToken }),
+    }),
+
+    SecretField({
+      id: 'review-webhook-secret',
+      name: 'webhookSecret',
+      label: 'Webhook secret',
+      present: cfg.hasWebhookSecret === true,
+      value: webhookSecret,
+      disabled: busy,
+      onChange: setWebhookSecret,
+      onSave: () => void save({ webhookSecret }),
+    }),
+
+    text('webhookPort', '3081'),
+    toggle('autoRereviewOnPush'),
+    toggle('autoReviewOnAssign'),
+    text('agentTimeoutMs', '600000'),
+    text('reviewSessionRetentionDays', '30'),
+  )
+}

package/src/client/review/styles.ts

@@ -0,0 +1,108 @@
+/**
+ * Token-native styling for the review settings section. Every colour and
+ * radius resolves through a `--dsw-*` alias, so the section follows the shell
+ * theme instead of carrying a palette of its own.
+ *
+ * The iOS block holds text fields at 16px on coarse pointers: iOS WebKit
+ * magnifies the viewport for a focused field below that size, and a magnified
+ * sheet never blurs back.
+ */
+export const REVIEW_CSS = `
+[data-review-root], [data-review-root] * { box-sizing: border-box; }
+[data-review-root] {
+  display: flex; flex-direction: column; gap: 12px;
+  color: var(--dsw-alias-label-primary);
+  font-size: 13px; line-height: 1.5;
+  min-width: 0; width: 100%; max-width: 640px;
+}
+
+/* House header: badge + title + one-line status. */
+[data-review-header] { display: flex; gap: 10px; align-items: flex-start; padding: 2px 2px 8px; }
+[data-review-heading] { display: flex; flex-direction: column; min-width: 0; }
+[data-review-title] { margin: 0; font-size: 15px; font-weight: 600; line-height: 22px; }
+[data-review-status] { font-size: 12px; line-height: 16px; color: var(--dsw-alias-label-secondary); overflow-wrap: anywhere; }
+[data-review-status] [data-review-notice] { margin: 0; }
+[data-review-status] [data-review-notice][data-tone="ok"] { color: var(--dsw-alias-state-success-primary); }
+[data-review-status] [data-review-notice][data-tone="bad"] { color: var(--dsw-alias-state-error-primary); }
+
+[data-review-actions] { display: flex; flex-wrap: wrap; gap: 8px; align-items: center; }
+[data-review-actions] button {
+  min-height: 32px; padding: 0 12px; border-radius: 8px;
+  border: 1px solid var(--dsw-alias-border-l2); background: var(--dsw-alias-bg-layer-1);
+  color: inherit; font: inherit; cursor: pointer;
+}
+[data-review-actions] button:disabled { opacity: 0.55; cursor: default; }
+[data-review-actions] button:focus-visible { outline: 2px solid var(--dsw-alias-border-l2); outline-offset: 2px; }
+
+/* House row: label and hint left, control held right, hairline between. */
+[data-review-row] {
+  display: flex; align-items: center; gap: 8px;
+  padding: 16px 0; border-bottom: 1px solid var(--dsw-alias-border-l2); min-width: 0;
+}
+[data-review-row]:last-of-type { border-bottom: none; }
+[data-review-row-text] { flex: 1; min-width: 0; display: flex; flex-direction: column; gap: 4px; padding-right: 48px; }
+[data-review-control] { flex: none; display: flex; align-items: center; justify-content: flex-end; gap: 8px; min-height: 36px; }
+/* Declared once. These two rules previously existed twice — the 12px/600 pair
+   sat AFTER the house values and won on source order at equal specificity, so
+   the whole tab rendered at the old weight and the old hint size. */
+[data-review-label] { font-size: 14px; font-weight: 400; line-height: 22px; color: var(--dsw-alias-label-primary); }
+[data-review-hint] { margin: 0; font-size: 12px; line-height: 18px; color: var(--dsw-alias-label-tertiary); }
+
+/* A secret whose value is committed by a button: input and save travel
+   together, the save under the input it writes. */
+[data-review-secret-group] { display: flex; flex-direction: column; align-items: stretch; gap: 8px; min-width: 220px; }
+[data-review-secret-group] button {
+  align-self: flex-end; min-height: 32px; padding: 0 12px; border-radius: 8px;
+  border: 1px solid var(--dsw-alias-border-l2); background: var(--dsw-alias-bg-layer-1);
+  color: inherit; font: inherit; cursor: pointer;
+}
+[data-review-secret-group] button:disabled { opacity: 0.55; cursor: default; }
+[data-review-secret-group] button:focus-visible { outline: 2px solid var(--dsw-alias-border-l2); outline-offset: 2px; }
+
+/* Every row control gets the same box. The password type belongs in this list:
+   without it the two secret fields rendered at the UA default — 21px tall, no
+   radius — beside 32px fields with an 8px radius in the same column. */
+[data-review-control] input[type="text"], [data-review-control] input[type="password"], [data-review-control] select {
+  min-height: 32px; padding: 0 10px; border-radius: 8px;
+  border: 1px solid var(--dsw-alias-border-l1); background: var(--dsw-alias-bg-layer-1);
+  color: inherit; font: inherit;
+}
+[data-review-control] input:focus-visible, [data-review-control] select:focus-visible {
+  outline: 2px solid var(--dsw-alias-border-l2); outline-offset: 2px;
+}
+/* The checkbox is the one control the harness draws at its own size; without
+   this it rendered at the UA's 13px. Same values as the reference row. */
+[data-review-control] input[type="checkbox"] {
+  width: 16px; height: 16px; margin: 0; flex: none;
+  accent-color: var(--dsw-alias-brand-primary, #0A84FF);
+}
+
+[data-review-pin], [data-review-lan] { display: flex; align-items: center; gap: 8px; flex-wrap: wrap; }
+[data-review-pin] code, [data-review-lan] code {
+  font-family: ui-monospace, SFMono-Regular, Menlo, monospace;
+  padding: 2px 6px; border-radius: 6px; background: var(--dsw-alias-bg-layer-2);
+}
+[data-review-pin] button, [data-review-lan] button {
+  min-height: 32px; padding: 0 10px; border-radius: 8px;
+  border: 1px solid var(--dsw-alias-border-l2); background: var(--dsw-alias-bg-layer-1);
+  color: inherit; font: inherit; cursor: pointer;
+}
+
+@media (max-width: 640px) {
+  /* Below the measure the row stacks: a right-held control has no room left,
+     and a wrapped one reads as a third column. */
+  [data-review-row] { flex-direction: column; align-items: stretch; gap: 8px; }
+  [data-review-row-text] { padding-right: 0; }
+  [data-review-control] { justify-content: flex-start; }
+}
+
+@media (max-width: 480px) {
+  [data-review-actions] button { flex: 1 1 auto; min-height: 40px; }
+}
+
+/* iOS 16px field floor: the magnifier fires below this on a focused field. */
+@media (max-width: 1023px) and (pointer: coarse) {
+  html[data-mobile-nav-ios] [data-review-root] input,
+  html[data-mobile-nav-ios] [data-review-root] select { font-size: 16px !important; }
+}
+`

package/src/client/settings-nav-icon.ts

@@ -0,0 +1,68 @@
+/**
+ * Mark this plugin's row in the DSH settings navigation so a style block can
+ * replace the shell's fallback gear with the maestro glyph.
+ *
+ * DSH 0.1.x projects only `id`, `order`, and `label` from a `settings.section`
+ * registration and picks icons from a closed built-in list, so each external
+ * plugin identifies its own localized row by visible text after the dialog
+ * mounts. The marker owns no shell structure and is removed on disposal.
+ */
+
+export const SETTINGS_NAV_MARKER = 'data-maestro-review-settings-nav';
+
+/** Minimal DOM surface used here; tests inject a stub instead of `document`. */
+type NodeSeq = Iterable<Element> & { forEach(fn: (el: Element) => void): unknown };
+
+interface DomScope {
+  querySelectorAll(selector: string): NodeSeq
+}
+
+type ElementLike = Element & {
+  setAttribute(name: string, value: string): void
+  removeAttribute(name: string): void
+  hasAttribute(name: string): boolean
+};
+
+export function registerSettingsNavIcon(
+  label: () => string,
+  root?: DomScope,
+): () => void {
+  if (typeof document === 'undefined' && root === undefined) {
+    // Node-side import safety (tests inject a stub root instead).
+    return () => {};
+  }
+  const scope = (root ?? document) as DomScope;
+
+  let disposed = false;
+
+  const sync = () => {
+    if (disposed) return;
+    const currentLabel = label().trim();
+    const buttons = scope.querySelectorAll('[role="dialog"] nav button');
+    for (const button of Array.from(buttons)) {
+      const el = button as ElementLike;
+      const matches =
+        currentLabel.length > 0 &&
+        button.textContent != null &&
+        button.textContent.trim() === currentLabel;
+      if (matches) el.setAttribute(SETTINGS_NAV_MARKER, '');
+      else if (el.hasAttribute(SETTINGS_NAV_MARKER)) el.removeAttribute(SETTINGS_NAV_MARKER);
+    }
+  };
+
+  sync();
+
+  let observer: MutationObserver | null = null;
+  if (typeof MutationObserver !== 'undefined') {
+    observer = new MutationObserver(sync);
+    observer.observe(document.body, { childList: true, subtree: true, characterData: true });
+  }
+
+  return () => {
+    disposed = true;
+    if (observer !== null) observer.disconnect();
+    for (const element of Array.from(scope.querySelectorAll(`[${SETTINGS_NAV_MARKER}]`))) {
+      (element as ElementLike).removeAttribute(SETTINGS_NAV_MARKER);
+    }
+  };
+}