@ddtcorex/dsh-maestro-config 0.3.0 → 0.4.0

package/lib/client.js

@@ -2906,12 +2906,96 @@ function ProjectMappingsEditor({ mappings, onChange, catalog, globalReviewModel
                 label: null
               })
             )
+          ),
+          // Row for per-project trigger overrides — tri-state: inherit the global toggle or force on/off.
+          (0, import_react.createElement)(
+            "div",
+            { "data-maestro-project-triggers-row": "", style: { display: "flex", gap: 12, flexWrap: "wrap", alignItems: "flex-start" } },
+            (0, import_react.createElement)(
+              "label",
+              { style: { ...fieldLabelStyle, flex: "1 1 160px", minWidth: 0 } },
+              "Re-review on push",
+              (0, import_react.createElement)(
+                "select",
+                {
+                  value: row.rereviewOnPush === void 0 ? "inherit" : row.rereviewOnPush ? "on" : "off",
+                  onChange: (e) => updateRow(i, "rereviewOnPush", e.target.value === "inherit" ? void 0 : e.target.value === "on"),
+                  "aria-label": `Re-review on push ${i + 1}`,
+                  style: {
+                    height: 36,
+                    width: "100%",
+                    padding: "0 14px",
+                    border: "none",
+                    borderRadius: 18,
+                    background: "var(--dsw-alias-bg-module-platform, #F5F6F7)",
+                    color: t.labelPrimary,
+                    font: "inherit",
+                    fontSize: 13
+                  }
+                },
+                (0, import_react.createElement)("option", { value: "inherit" }, "Inherit (global)"),
+                (0, import_react.createElement)("option", { value: "on" }, "On"),
+                (0, import_react.createElement)("option", { value: "off" }, "Off")
+              )
+            ),
+            (0, import_react.createElement)(
+              "label",
+              { style: { ...fieldLabelStyle, flex: "1 1 160px", minWidth: 0 } },
+              "Review on assign",
+              (0, import_react.createElement)(
+                "select",
+                {
+                  value: row.reviewOnAssign === void 0 ? "inherit" : row.reviewOnAssign ? "on" : "off",
+                  onChange: (e) => updateRow(i, "reviewOnAssign", e.target.value === "inherit" ? void 0 : e.target.value === "on"),
+                  "aria-label": `Review on assign ${i + 1}`,
+                  style: {
+                    height: 36,
+                    width: "100%",
+                    padding: "0 14px",
+                    border: "none",
+                    borderRadius: 18,
+                    background: "var(--dsw-alias-bg-module-platform, #F5F6F7)",
+                    color: t.labelPrimary,
+                    font: "inherit",
+                    fontSize: 13
+                  }
+                },
+                (0, import_react.createElement)("option", { value: "inherit" }, "Inherit (global)"),
+                (0, import_react.createElement)("option", { value: "on" }, "On"),
+                (0, import_react.createElement)("option", { value: "off" }, "Off")
+              )
+            )
           )
         )
       )
     )
   );
 }
+function SecretField({ placeholder, hasSaved, onSave, width }) {
+  const [draft, setDraft] = (0, import_react.useState)("");
+  (0, import_react.useEffect)(() => {
+    if (!hasSaved) setDraft("");
+  }, [hasSaved]);
+  const commit = () => {
+    if (draft !== "") {
+      onSave(draft);
+      setDraft("");
+    }
+  };
+  return (0, import_react.createElement)(FieldInput, {
+    placeholder: hasSaved === true ? "saved \u2014 type new value to replace" : placeholder,
+    type: "password",
+    autoComplete: "off",
+    value: draft,
+    onChange: (e) => setDraft(e.target.value),
+    onBlur: commit,
+    onKeyDown: (e) => {
+      if (e.key === "Enter") e.target.blur();
+    },
+    "aria-label": placeholder,
+    style: { width: width ?? 200 }
+  });
+}
 function LanAccess({ proxyStatus, lanPin }) {
   const urls = proxyStatus?.lanUrls ?? [];
   const [selected, setSelected] = (0, import_react.useState)(0);
@@ -3304,10 +3388,6 @@ function MaestroSettingsTab({ rpcCall, configRpcCall }) {
     call(MAESTRO_ENDPOINTS.getConfig, {}).then((saved) => setConfig((prev) => ({ ...prev, ...saved }))).catch(() => {
     });
     if (configRpcCall) {
-      configRpcCall("get", { domain: "supervisor" }).then((res) => {
-        if (res?.ok && res.value?.model) setConfig((prev) => ({ ...prev, supervisorModel: res.value.model }));
-      }).catch(() => {
-      });
       Promise.all([cfgGet("guard").catch(() => ({})), cfgGet("guardBlacklist").catch(() => ({ patterns: [], placeholders: {} })), cfgGet("supervisor").catch(() => ({})), cfgGet("notifier").catch(() => ({}))]).then(([g, bl, sup, not]) => {
         setGuard(g ?? {});
         const pats = Array.isArray(bl?.patterns) ? bl.patterns : [];
@@ -3413,18 +3493,28 @@ function MaestroSettingsTab({ rpcCall, configRpcCall }) {
       setBusy(false);
     }
   };
+  const SECRET_SAVE_FLAGS = { gitlabToken: "hasGitlabToken", webhookSecret: "hasWebhookSecret" };
   const saveField = async (field, value) => {
     setError(null);
-    setConfig((prev) => ({ ...prev, [field]: value }));
-    if (field === "supervisorModel" && configRpcCall) {
-      try {
-        const res = await configRpcCall("set", { domain: "supervisor", patch: { model: value } });
-        if (res?.ok) return;
-      } catch {
+    setConfig((prev) => {
+      const next = { ...prev, [field]: value };
+      const flag = SECRET_SAVE_FLAGS[field];
+      if (flag) {
+        delete next[field];
+        next[flag] = value !== "";
       }
-    }
+      return next;
+    });
     try {
-      await call(MAESTRO_ENDPOINTS.saveConfig, { [field]: value });
+      const saved = await call(MAESTRO_ENDPOINTS.saveConfig, { [field]: value });
+      if (saved && typeof saved === "object") {
+        setConfig((prev) => {
+          const next = { ...prev, ...saved };
+          const flag = SECRET_SAVE_FLAGS[field];
+          if (flag) delete next[field];
+          return next;
+        });
+      }
     } catch (err) {
       setError(err.message);
     }
@@ -3459,9 +3549,9 @@ function MaestroSettingsTab({ rpcCall, configRpcCall }) {
       "div",
       { style: { display: "flex", flexDirection: "column" } },
       (0, import_react.createElement)(SettingRow, { title: "GitLab base URL", description: "e.g. https://gitlab.example.com", control: (0, import_react.createElement)(FieldInput, { placeholder: "https://gitlab.example.com", value: config.gitlabBaseUrl ?? "", onChange: (e) => saveField("gitlabBaseUrl", e.target.value), style: { width: 260 } }) }),
-      (0, import_react.createElement)(SettingRow, { title: "GitLab token", description: "Personal access token with api scope.", control: (0, import_react.createElement)("div", { style: { display: "flex", gap: 8, alignItems: "center" } }, (0, import_react.createElement)(FieldInput, { type: "password", autoComplete: "off", value: config.hasGitlabToken ? "\u2022\u2022\u2022\u2022\u2022\u2022\u2022\u2022" : "", placeholder: "GitLab token", onChange: (e) => saveField("gitlabToken", e.target.value), style: { width: 200 } }), config.hasGitlabToken ? (0, import_react.createElement)(Button, { variant: "outline", size: "md", onClick: () => saveField("gitlabToken", "") }, "Clear") : null) }),
+      (0, import_react.createElement)(SettingRow, { title: "GitLab token", description: "Personal access token with api scope.", control: (0, import_react.createElement)("div", { style: { display: "flex", gap: 8, alignItems: "center" } }, (0, import_react.createElement)(SecretField, { placeholder: "GitLab token", hasSaved: config.hasGitlabToken === true, width: 200, onSave: (v) => saveField("gitlabToken", v) }), config.hasGitlabToken ? (0, import_react.createElement)(Button, { variant: "outline", size: "md", onClick: () => saveField("gitlabToken", "") }, "Clear") : null) }),
       (0, import_react.createElement)(SettingRow, { title: "Bot username", description: "Username of the bot that posts reviews.", control: (0, import_react.createElement)(FieldInput, { placeholder: "maestro-bot", value: config.botUsername ?? "", onChange: (e) => saveField("botUsername", e.target.value), style: { width: 220 } }) }),
-      (0, import_react.createElement)(SettingRow, { title: "Webhook secret", description: "Secret token for GitLab webhooks.", control: (0, import_react.createElement)("div", { style: { display: "flex", gap: 8, alignItems: "center" } }, (0, import_react.createElement)(FieldInput, { type: "password", autoComplete: "off", value: config.hasWebhookSecret ? "\u2022\u2022\u2022\u2022\u2022\u2022\u2022\u2022" : "", placeholder: "Webhook secret", onChange: (e) => saveField("webhookSecret", e.target.value), style: { width: 200 } }), (0, import_react.createElement)(Button, { variant: "outline", size: "md", onClick: () => saveField("webhookSecret", generateWebhookSecret()) }, "Generate")) }),
+      (0, import_react.createElement)(SettingRow, { title: "Webhook secret", description: "Secret token for GitLab webhooks.", control: (0, import_react.createElement)("div", { style: { display: "flex", gap: 8, alignItems: "center" } }, (0, import_react.createElement)(SecretField, { placeholder: "Webhook secret", hasSaved: config.hasWebhookSecret === true, width: 200, onSave: (v) => saveField("webhookSecret", v) }), (0, import_react.createElement)(Button, { variant: "outline", size: "md", onClick: () => saveField("webhookSecret", generateWebhookSecret()) }, "Generate")) }),
       (0, import_react.createElement)(
         "div",
         { style: { padding: "16px 0", display: "flex", flexDirection: "column", gap: 6 } },
@@ -3473,8 +3563,8 @@ function MaestroSettingsTab({ rpcCall, configRpcCall }) {
       "div",
       { style: { display: "flex", flexDirection: "column" } },
       (0, import_react.createElement)(ToggleRow, { title: "Re-review on push", description: "When new commits are pushed, trigger an automatic re-review.", checked: config.autoRereviewOnPush === true, onChange: (v) => saveField("autoRereviewOnPush", v) }),
+      (0, import_react.createElement)(ToggleRow, { title: "Review on assign", description: "When the bot is assigned as reviewer, trigger an automatic review.", checked: config.autoReviewOnAssign !== false, onChange: (v) => saveField("autoReviewOnAssign", v) }),
       (0, import_react.createElement)(SettingRow, { title: "Global review model", description: "Model for automated reviews. Empty = DSH default.", control: (0, import_react.createElement)(ReviewModelSelector, { value: config.reviewModel ?? null, catalog, fallbackValue: catalog?.current ?? null, fallbackLabel: "Use DSH default", onChange: (v) => saveField("reviewModel", v), label: null }) }),
-      (0, import_react.createElement)(SettingRow, { title: "Supervisor model", description: "Model for auto-fixing DSH Web crashes.", control: (0, import_react.createElement)(ReviewModelSelector, { value: config.supervisorModel ?? null, catalog, fallbackValue: catalog?.current ?? null, fallbackLabel: "Use DSH default", onChange: (v) => saveField("supervisorModel", v), label: null }) }),
       (0, import_react.createElement)(ProjectMappingsEditor, { mappings: config.projectMappings ?? [], onChange: (mappings) => saveField("projectMappings", mappings), catalog, globalReviewModel: config.reviewModel ?? null })
     ),
     guard: (0, import_react.createElement)(
@@ -3531,7 +3621,7 @@ function MaestroSettingsTab({ rpcCall, configRpcCall }) {
       "div",
       { style: { display: "flex", flexDirection: "column" } },
       (0, import_react.createElement)("div", { style: { padding: "12px 0", borderBottom: `1px solid ${t.borderL2}` } }, (0, import_react.createElement)("p", { style: captionStyle }, "Telegram bot settings for notifications: startup PIN, review digests, PIN rotation. Leave blank to disable.")),
-      (0, import_react.createElement)(SettingRow, { title: "Bot token", description: "Telegram bot token from @BotFather.", control: (0, import_react.createElement)("div", { style: { display: "flex", gap: 8, alignItems: "center" } }, (0, import_react.createElement)(FieldInput, { type: "password", autoComplete: "off", value: notifierCfg.telegram?.botToken ?? "", placeholder: "123456:ABC-DEF...", onChange: (e) => saveNotifierCfg({ telegram: { botToken: e.target.value } }), style: { width: 220 } }), notifierCfg.telegram?.botToken ? (0, import_react.createElement)(Button, { variant: "outline", size: "md", onClick: () => saveNotifierCfg({ telegram: { botToken: "" } }) }, "Clear") : null) }),
+      (0, import_react.createElement)(SettingRow, { title: "Bot token", description: "Telegram bot token from @BotFather.", control: (0, import_react.createElement)("div", { style: { display: "flex", gap: 8, alignItems: "center" } }, (0, import_react.createElement)(SecretField, { placeholder: "123456:ABC-DEF...", hasSaved: (notifierCfg.telegram?.botToken ?? "") !== "", width: 220, onSave: (v) => saveNotifierCfg({ telegram: { botToken: v } }) }), notifierCfg.telegram?.botToken ? (0, import_react.createElement)(Button, { variant: "outline", size: "md", onClick: () => saveNotifierCfg({ telegram: { botToken: "" } }) }, "Clear") : null) }),
       (0, import_react.createElement)(SettingRow, { title: "Chat ID", description: "Target chat, e.g. -1001234567890.", control: (0, import_react.createElement)(FieldInput, { value: notifierCfg.telegram?.chatId ?? "", placeholder: "-1001234567890", onChange: (e) => saveNotifierCfg({ telegram: { chatId: e.target.value } }), style: { width: 220 } }) }),
       (0, import_react.createElement)(ToggleRow, { title: "Review notifications", description: "Also notify about finished reviews.", checked: notifierCfg.policy?.reviewNotifications === true, onChange: (v) => saveNotifierCfg({ policy: { reviewNotifications: v } }) })
     )

package/lib/types/client/MaestroSettings.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"MaestroSettings.d.ts","sourceRoot":"","sources":["../../../src/client/MaestroSettings.tsx"],"names":[],"mappings":"AACA;;;;;;;;GAQG;AAisCH,wBAAgB,kBAAkB,CAAC,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;IAAE,OAAO,EAAE,GAAG,CAAC;IAAC,aAAa,CAAC,EAAE,GAAG,CAAA;CAAE;;;;;;;;;mBAkZmE,GAAG;;gBAoBzK"}
+{"version":3,"file":"MaestroSettings.d.ts","sourceRoot":"","sources":["../../../src/client/MaestroSettings.tsx"],"names":[],"mappings":"AACA;;;;;;;;GAQG;AAgwCH,wBAAgB,kBAAkB,CAAC,EAAE,OAAO,EAAE,aAAa,EAAE,EAAE;IAAE,OAAO,EAAE,GAAG,CAAC;IAAC,aAAa,CAAC,EAAE,GAAG,CAAA;CAAE;;;;;;;;;mBA4ZmE,GAAG;;gBAoBzK"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ddtcorex/dsh-maestro-config",
-  "version": "0.3.0",
+  "version": "0.4.0",
   "private": false,
   "description": "Maestro Config — shared settings service for the dsh-maestro-* suite over the single namespaced store (~/.dsh/maestro/settings.json)",
   "type": "module",

package/src/client/MaestroSettings.tsx

@@ -941,39 +941,102 @@ function ProjectMappingsEditor({ mappings, onChange, catalog, globalReviewModel
                   }),
                 ),
               ),
+              // Row for per-project trigger overrides — tri-state: inherit the global toggle or force on/off.
+              h(
+                'div',
+                { 'data-maestro-project-triggers-row': '', style: { display: 'flex', gap: 12, flexWrap: 'wrap' as const, alignItems: 'flex-start' } },
+                h(
+                  'label',
+                  { style: { ...fieldLabelStyle, flex: '1 1 160px', minWidth: 0 } },
+                  'Re-review on push',
+                  h(
+                    'select',
+                    {
+                      value: row.rereviewOnPush === undefined ? 'inherit' : row.rereviewOnPush ? 'on' : 'off',
+                      onChange: (e: any) => updateRow(i, 'rereviewOnPush', e.target.value === 'inherit' ? undefined : e.target.value === 'on'),
+                      'aria-label': `Re-review on push ${i + 1}`,
+                      style: {
+                        height: 36,
+                        width: '100%',
+                        padding: '0 14px',
+                        border: 'none',
+                        borderRadius: 18,
+                        background: 'var(--dsw-alias-bg-module-platform, #F5F6F7)' as string,
+                        color: t.labelPrimary as string,
+                        font: 'inherit',
+                        fontSize: 13,
+                      },
+                    },
+                    h('option', { value: 'inherit' }, 'Inherit (global)'),
+                    h('option', { value: 'on' }, 'On'),
+                    h('option', { value: 'off' }, 'Off'),
+                  ),
+                ),
+                h(
+                  'label',
+                  { style: { ...fieldLabelStyle, flex: '1 1 160px', minWidth: 0 } },
+                  'Review on assign',
+                  h(
+                    'select',
+                    {
+                      value: row.reviewOnAssign === undefined ? 'inherit' : row.reviewOnAssign ? 'on' : 'off',
+                      onChange: (e: any) => updateRow(i, 'reviewOnAssign', e.target.value === 'inherit' ? undefined : e.target.value === 'on'),
+                      'aria-label': `Review on assign ${i + 1}`,
+                      style: {
+                        height: 36,
+                        width: '100%',
+                        padding: '0 14px',
+                        border: 'none',
+                        borderRadius: 18,
+                        background: 'var(--dsw-alias-bg-module-platform, #F5F6F7)' as string,
+                        color: t.labelPrimary as string,
+                        font: 'inherit',
+                        fontSize: 13,
+                      },
+                    },
+                    h('option', { value: 'inherit' }, 'Inherit (global)'),
+                    h('option', { value: 'on' }, 'On'),
+                    h('option', { value: 'off' }, 'Off'),
+                  ),
+                ),
+              ),
             ),
           ),
         ),
   )
 }
 
-function SecretInput({ label, placeholder, hasSaved, onSave }: { label: string; placeholder: string; hasSaved?: boolean; onSave: (v: string) => void }) {
+// SecretField — control-sized secret input for SettingRow controls (no label).
+// The server never echoes secrets back (getConfig masks them to has* flags),
+// so the field stays EMPTY and commits a typed draft on blur / Enter; an
+// untouched field keeps the stored secret and Clear writes '' to erase it.
+// Never render mask bullets ('••••') as the input value: a controlled input
+// locked to a constant string swallows keystrokes and saves bullet-contaminated
+// text on the first change (the GitLab-token-not-editable regression).
+function SecretField({ placeholder, hasSaved, onSave, width }: { placeholder: string; hasSaved?: boolean; onSave: (v: string) => void; width?: number }) {
   const [draft, setDraft] = useState('')
-  const clear = () => {
-    setDraft('')
-    onSave('')
+  useEffect(() => {
+    if (!hasSaved) setDraft('')
+  }, [hasSaved])
+  const commit = () => {
+    if (draft !== '') {
+      onSave(draft)
+      setDraft('')
+    }
   }
-  return h(
-    'div',
-    null,
-    h('label', { style: fieldLabelStyle }, label),
-    h(
-      'div',
-      { style: { display: 'flex', gap: 8 } },
-      h(FieldInput as any, {
-        placeholder: hasSaved === true ? 'saved — leave blank to keep' : placeholder,
-        type: 'password',
-        autoComplete: 'off',
-        value: draft,
-        onChange: (e: any) => setDraft(e.target.value),
-        onBlur: () => {
-          if (draft !== '') onSave(draft)
-        },
-        style: { flex: 1 } as any,
-      }),
-      hasSaved === true ? h(Button as any, { variant: 'outline', size: 'sm', onClick: clear }, 'Clear') : null,
-    ),
-  )
+  return h(FieldInput as any, {
+    placeholder: hasSaved === true ? 'saved — type new value to replace' : placeholder,
+    type: 'password',
+    autoComplete: 'off',
+    value: draft,
+    onChange: (e: any) => setDraft(e.target.value),
+    onBlur: commit,
+    onKeyDown: (e: any) => {
+      if (e.key === 'Enter') (e.target as HTMLInputElement).blur()
+    },
+    'aria-label': placeholder,
+    style: { width: width ?? 200 } as any,
+  })
 }
 
 function ToggleField({ label, caption, checked, onChange }: { label: string; caption?: string; checked?: boolean; onChange: (v: boolean) => void }) {
@@ -1400,11 +1463,6 @@ export function MaestroSettingsTab({ rpcCall, configRpcCall }: { rpcCall: any; c
       .then((saved) => setConfig((prev: any) => ({ ...prev, ...saved })))
       .catch(() => {})
     if (configRpcCall) {
-      configRpcCall('get', { domain: 'supervisor' })
-        .then((res: any) => {
-          if (res?.ok && res.value?.model) setConfig((prev: any) => ({ ...prev, supervisorModel: res.value.model }))
-        })
-        .catch(() => {})
       Promise.all([cfgGet('guard').catch(() => ({})), cfgGet('guardBlacklist').catch(() => ({ patterns: [], placeholders: {} })), cfgGet('supervisor').catch(() => ({})), cfgGet('notifier').catch(() => ({}))])
         .then(([g, bl, sup, not]) => {
           setGuard(g ?? {})
@@ -1513,17 +1571,32 @@ export function MaestroSettingsTab({ rpcCall, configRpcCall }: { rpcCall: any; c
       setBusy(false)
     }
   }
+  const SECRET_SAVE_FLAGS: Record<string, string> = { gitlabToken: 'hasGitlabToken', webhookSecret: 'hasWebhookSecret' }
   const saveField = async (field: string, value: unknown) => {
     setError(null)
-    setConfig((prev: any) => ({ ...prev, [field]: value }))
-    if (field === 'supervisorModel' && configRpcCall) {
-      try {
-        const res = await configRpcCall('set', { domain: 'supervisor', patch: { model: value } })
-        if (res?.ok) return
-      } catch {}
-    }
+    // Optimistic update — for secrets only flip the has* presence flag, never
+    // stash the raw secret in state (the server never echoes it back).
+    setConfig((prev: any) => {
+      const next = { ...prev, [field]: value }
+      const flag = SECRET_SAVE_FLAGS[field]
+      if (flag) {
+        delete next[field]
+        next[flag] = value !== ''
+      }
+      return next
+    })
     try {
-      await call(MAESTRO_ENDPOINTS.saveConfig, { [field]: value })
+      // saveConfig returns the masked config — merge it so has* flags (and a
+      // cleared secret) sync without waiting for a reload.
+      const saved = await call(MAESTRO_ENDPOINTS.saveConfig, { [field]: value })
+      if (saved && typeof saved === 'object') {
+        setConfig((prev: any) => {
+          const next = { ...prev, ...(saved as object) }
+          const flag = SECRET_SAVE_FLAGS[field]
+          if (flag) delete next[field]
+          return next
+        })
+      }
     } catch (err: any) {
       setError(err.message)
     }
@@ -1561,9 +1634,9 @@ export function MaestroSettingsTab({ rpcCall, configRpcCall }: { rpcCall: any; c
         'div',
         { style: { display: 'flex', flexDirection: 'column' } },
         h(SettingRow as any, { title: 'GitLab base URL', description: 'e.g. https://gitlab.example.com', control: h(FieldInput as any, { placeholder: 'https://gitlab.example.com', value: config.gitlabBaseUrl ?? '', onChange: (e: any) => saveField('gitlabBaseUrl', e.target.value), style: { width: 260 } as any }) }),
-        h(SettingRow as any, { title: 'GitLab token', description: 'Personal access token with api scope.', control: h('div', { style: { display: 'flex', gap: 8, alignItems: 'center' } }, h(FieldInput as any, { type: 'password', autoComplete: 'off', value: config.hasGitlabToken ? '••••••••' : '', placeholder: 'GitLab token', onChange: (e: any) => saveField('gitlabToken', e.target.value), style: { width: 200 } as any }), config.hasGitlabToken ? h(Button as any, { variant: 'outline', size: 'md', onClick: () => saveField('gitlabToken', '') }, 'Clear') : null) }),
+        h(SettingRow as any, { title: 'GitLab token', description: 'Personal access token with api scope.', control: h('div', { style: { display: 'flex', gap: 8, alignItems: 'center' } }, h(SecretField as any, { placeholder: 'GitLab token', hasSaved: config.hasGitlabToken === true, width: 200, onSave: (v: string) => saveField('gitlabToken', v) }), config.hasGitlabToken ? h(Button as any, { variant: 'outline', size: 'md', onClick: () => saveField('gitlabToken', '') }, 'Clear') : null) }),
         h(SettingRow as any, { title: 'Bot username', description: 'Username of the bot that posts reviews.', control: h(FieldInput as any, { placeholder: 'maestro-bot', value: config.botUsername ?? '', onChange: (e: any) => saveField('botUsername', e.target.value), style: { width: 220 } as any }) }),
-        h(SettingRow as any, { title: 'Webhook secret', description: 'Secret token for GitLab webhooks.', control: h('div', { style: { display: 'flex', gap: 8, alignItems: 'center' } }, h(FieldInput as any, { type: 'password', autoComplete: 'off', value: config.hasWebhookSecret ? '••••••••' : '', placeholder: 'Webhook secret', onChange: (e: any) => saveField('webhookSecret', e.target.value), style: { width: 200 } as any }), h(Button as any, { variant: 'outline', size: 'md', onClick: () => saveField('webhookSecret', generateWebhookSecret()) }, 'Generate')) }),
+        h(SettingRow as any, { title: 'Webhook secret', description: 'Secret token for GitLab webhooks.', control: h('div', { style: { display: 'flex', gap: 8, alignItems: 'center' } }, h(SecretField as any, { placeholder: 'Webhook secret', hasSaved: config.hasWebhookSecret === true, width: 200, onSave: (v: string) => saveField('webhookSecret', v) }), h(Button as any, { variant: 'outline', size: 'md', onClick: () => saveField('webhookSecret', generateWebhookSecret()) }, 'Generate')) }),
         h('div', { style: { padding: '16px 0', display: 'flex', flexDirection: 'column', gap: 6 } },
           h('p', { style: captionStyle }, 'In GitLab: Settings → Webhooks, Secret token = this value, enable Merge request events. Webhook URL:'),
           h('div', { style: { fontFamily: 'ui-monospace, monospace', fontSize: 12, color: t.labelPrimary as string, wordBreak: 'break-all', padding: '10px 12px', borderRadius: 8, background: t.bgLayer3 as string, border: `1px solid ${t.borderL2}`, overflowWrap:'anywhere' as any } }, gitlabWebhookUrl(config.tunnelHostname)),
@@ -1573,8 +1646,8 @@ export function MaestroSettingsTab({ rpcCall, configRpcCall }: { rpcCall: any; c
         'div',
         { style: { display: 'flex', flexDirection: 'column' } },
         h(ToggleRow as any, { title: 'Re-review on push', description: 'When new commits are pushed, trigger an automatic re-review.', checked: config.autoRereviewOnPush === true, onChange: (v: boolean) => saveField('autoRereviewOnPush', v) }),
+        h(ToggleRow as any, { title: 'Review on assign', description: 'When the bot is assigned as reviewer, trigger an automatic review.', checked: config.autoReviewOnAssign !== false, onChange: (v: boolean) => saveField('autoReviewOnAssign', v) }),
         h(SettingRow as any, { title: 'Global review model', description: 'Model for automated reviews. Empty = DSH default.', control: h(ReviewModelSelector as any, { value: config.reviewModel ?? null, catalog, fallbackValue: catalog?.current ?? null, fallbackLabel: 'Use DSH default', onChange: (v: any) => saveField('reviewModel', v), label: null }) }),
-        h(SettingRow as any, { title: 'Supervisor model', description: 'Model for auto-fixing DSH Web crashes.', control: h(ReviewModelSelector as any, { value: config.supervisorModel ?? null, catalog, fallbackValue: catalog?.current ?? null, fallbackLabel: 'Use DSH default', onChange: (v: any) => saveField('supervisorModel', v), label: null }) }),
         h(ProjectMappingsEditor as any, { mappings: config.projectMappings ?? [], onChange: (mappings: any) => saveField('projectMappings', mappings), catalog, globalReviewModel: config.reviewModel ?? null }),
       ),
     guard: h(
@@ -1618,7 +1691,7 @@ export function MaestroSettingsTab({ rpcCall, configRpcCall }: { rpcCall: any; c
         'div',
         { style: { display: 'flex', flexDirection: 'column' } },
         h('div', { style: { padding: '12px 0', borderBottom: `1px solid ${t.borderL2}` } }, h('p', { style: captionStyle }, 'Telegram bot settings for notifications: startup PIN, review digests, PIN rotation. Leave blank to disable.')),
-        h(SettingRow as any, { title: 'Bot token', description: 'Telegram bot token from @BotFather.', control: h('div', { style: { display: 'flex', gap: 8, alignItems: 'center' } }, h(FieldInput as any, { type: 'password', autoComplete: 'off', value: notifierCfg.telegram?.botToken ?? '', placeholder: '123456:ABC-DEF...', onChange: (e: any) => saveNotifierCfg({ telegram: { botToken: e.target.value } }), style: { width: 220 } as any }), notifierCfg.telegram?.botToken ? h(Button as any, { variant: 'outline', size: 'md', onClick: () => saveNotifierCfg({ telegram: { botToken: '' } }) }, 'Clear') : null) }),
+        h(SettingRow as any, { title: 'Bot token', description: 'Telegram bot token from @BotFather.', control: h('div', { style: { display: 'flex', gap: 8, alignItems: 'center' } }, h(SecretField as any, { placeholder: '123456:ABC-DEF...', hasSaved: (notifierCfg.telegram?.botToken ?? '') !== '', width: 220, onSave: (v: string) => saveNotifierCfg({ telegram: { botToken: v } }) }), notifierCfg.telegram?.botToken ? h(Button as any, { variant: 'outline', size: 'md', onClick: () => saveNotifierCfg({ telegram: { botToken: '' } }) }, 'Clear') : null) }),
         h(SettingRow as any, { title: 'Chat ID', description: 'Target chat, e.g. -1001234567890.', control: h(FieldInput as any, { value: notifierCfg.telegram?.chatId ?? '', placeholder: '-1001234567890', onChange: (e: any) => saveNotifierCfg({ telegram: { chatId: e.target.value } }), style: { width: 220 } as any }) }),
         h(ToggleRow as any, { title: 'Review notifications', description: 'Also notify about finished reviews.', checked: notifierCfg.policy?.reviewNotifications === true, onChange: (v: boolean) => saveNotifierCfg({ policy: { reviewNotifications: v } }) }),
       ),

package/lib/types/client/maestro-card.d.ts

@@ -1,10 +0,0 @@
-export function MaestroSettingsTab({ rpcCall, configRpcCall }: {
-    rpcCall: any;
-    configRpcCall: any;
-}): import("react").DetailedReactHTMLElement<{
-    'data-maestro-settings-card': string;
-    style: {
-        maxWidth: number;
-    };
-}, HTMLElement>;
-//# sourceMappingURL=maestro-card.d.ts.map

package/lib/types/client/maestro-card.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"maestro-card.d.ts","sourceRoot":"","sources":["../../../src/client/maestro-card.jsx"],"names":[],"mappings":"AAweA;;;;;;;;gBA0dC"}