@dcl/schemas 4.13.1-20220524203836.commit-69688ca → 4.13.1-20220524210610.commit-ff19bdf

package/README.md

@@ -38,6 +38,17 @@ export namespace MyType {
 
 In that sense, MyType can be both used as type `const a: MyType` and as object `MyType.validate(a)`.
 
+Beware that `validate` has type `ValidateFunction<T>` which `ajv` creates automatically. When writing new
+validations always try to implement it as an ajv validation, even if custom code is needed. See [here](https://ajv.js.org/keywords.html#define-keyword-with-code-generation-function). 
+
+In particular, don't fall in the trap of doing this:
+```ts
+  const validator = generateValidator<MyType>(schema)
+  export const validate = (mt: MyType) => validator.validate(mt) && otherValidations(mt);
+```
+By doing this, all the errors reported by the `validator.validate` function are lost and never returned
+to the caller.
+
 ## Type ownership
 
 Please add types and schemas of your domain into the `src/<team>` folder, also add your team to the [CODEOWNERS](.github/CODEOWNERS) repository to make sure nobody accidentally changes it without your team noticing it.

package/package.json

@@ -1,5 +1,5 @@
 {
-  "version": "4.13.1-20220524203836.commit-69688ca",
+  "version": "4.13.1-20220524210610.commit-ff19bdf",
   "name": "@dcl/schemas",
   "main": "./dist/index.js",
   "typings": "./dist/index.d.ts",
@@ -32,5 +32,5 @@
   "files": [
     "dist"
   ],
-  "commit": "69688cadcd78fd26ca292ad37ae272619ca64074"
+  "commit": "ff19bdf5de2b832156a8e31622671ac9e71a71dc"
 }