@dcl/react-ecs 7.7.6-13418365922.commit-c459a2f → 7.7.6-13579862299.commit-06e2154

package/dist/reconciler/index.js

@@ -124,6 +124,7 @@ export function createReconciler(engine, pointerEvents) {
     }
     function removeChildEntity(instance) {
         changeEvents.delete(instance.entity);
+        clickEvents.delete(instance.entity);
         engine.removeEntity(instance.entity);
         for (const child of instance._child) {
             removeChildEntity(child);
@@ -170,13 +171,23 @@ export function createReconciler(engine, pointerEvents) {
         removeChildEntity(child);
     }
     function updateOnChange(entity, componentId, state) {
+        const hasEvent = changeEvents.has(entity);
         const event = changeEvents.get(entity) || changeEvents.set(entity, new Map()).get(entity);
-        const oldState = event.get(componentId);
         const onChangeCallback = state?.onChangeCallback;
         const onSubmitCallback = state?.onSubmitCallback;
-        const value = state?.value ?? oldState?.value;
-        const isSubmit = state?.isSubmit ?? oldState?.isSubmit;
-        event.set(componentId, { onChangeCallback, onSubmitCallback, value, isSubmit });
+        event.set(componentId, { onChangeCallback, onSubmitCallback });
+        // Create onChange callback if its the first callback event for this entity
+        if (!hasEvent) {
+            const resultComponentId = componentId === UiDropdown.componentId ? UiDropdownResult.componentId : UiInputResult.componentId;
+            engine.getComponent(resultComponentId).onChange(entity, (value) => {
+                if (value?.isSubmit) {
+                    const onSubmit = changeEvents.get(entity)?.get(componentId)?.onSubmitCallback;
+                    onSubmit && onSubmit(value?.value);
+                }
+                const onChange = changeEvents.get(entity)?.get(componentId)?.onChangeCallback;
+                onChange && onChange(value?.value);
+            });
+        }
     }
     const hostConfig = {
         ...noopConfig,
@@ -251,32 +262,8 @@ export function createReconciler(engine, pointerEvents) {
     const root = reconciler.createContainer({}, 0, null, false, null, '', 
     /* istanbul ignore next */
     function () { }, null);
-    // Maybe this could be something similar to Input system, but since we
-    // are going to use this only here, i prefer to scope it here.
-    function handleOnChange(componentId, resultComponent) {
-        for (const [entity, Result] of engine.getEntitiesWith(resultComponent)) {
-            const entityState = changeEvents.get(entity)?.get(componentId);
-            const isSubmit = !!Result.isSubmit;
-            if (entityState?.onChangeCallback && Result.value !== entityState.value) {
-                entityState.onChangeCallback(Result.value);
-            }
-            if (entityState?.onSubmitCallback && isSubmit && !entityState.isSubmit) {
-                entityState.onSubmitCallback(Result.value);
-            }
-            updateOnChange(entity, componentId, {
-                onChangeCallback: entityState?.onChangeCallback,
-                onSubmitCallback: entityState?.onSubmitCallback,
-                value: Result.value,
-                isSubmit
-            });
-        }
-    }
     return {
         update: function (component) {
-            if (changeEvents.size) {
-                handleOnChange(UiInput.componentId, UiInputResult);
-                handleOnChange(UiDropdown.componentId, UiDropdownResult);
-            }
             return reconciler.updateContainer(component, root, null);
         },
         getEntities: () => Array.from(entities)

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@dcl/react-ecs",
   "description": "Decentraland ECS",
-  "version": "7.7.6-13418365922.commit-c459a2f",
+  "version": "7.7.6-13579862299.commit-06e2154",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
   "dependencies": {
-    "@dcl/ecs": "7.7.6-13418365922.commit-c459a2f",
+    "@dcl/ecs": "7.7.6-13579862299.commit-06e2154",
     "react": "^18.2.0",
     "react-reconciler": "^0.29.0"
   },
@@ -40,5 +40,5 @@
     "tsconfig": "./tsconfig.json"
   },
   "types": "./dist/index.d.ts",
-  "commit": "c459a2f95046d73bbfa2142d06e4395f4f60a4b5"
+  "commit": "06e21544861e59ce4851a5a31fa1aa7c70a48181"
 }