@dcl/react-ecs 7.24.5-29334646366.commit-955c00d → 7.24.5-29428555187.commit-fb197d3

package/dist/system.d.ts

@@ -21,11 +21,6 @@ export interface ReactBasedUiSystem {
     destroy(): void;
     /**
      * Set the main UI renderer. Optional virtual size defines the global UI scale factor.
-     *
-     * When no virtual size is provided, a platform default is used: 1600x720 on
-     * mobile, 1920x1080 otherwise. Providing an invalid size (values \<= 0)
-     * disables the virtual screen (no UI scaling). On mobile, a provided 16:9
-     * virtual size is overridden to 1600x720 to fit phone screens.
      */
     setUiRenderer(ui: UiComponent, options?: UiRendererOptions): void;
     /**
@@ -40,8 +35,7 @@ export interface ReactBasedUiSystem {
      * @param entity - The entity to associate with this UI renderer. When the entity is removed,
      *                 the UI renderer is automatically cleaned up.
      * @param ui - The UI component to render
-     * @param options - Optional virtual size used for UI scale factor when main UI has none.
-     *                  Defaults and the mobile 16:9 override behave as in {@link ReactBasedUiSystem.setUiRenderer}.
+     * @param options - Optional virtual size used for UI scale factor when main UI has none
      */
     addUiRenderer(entity: Entity, ui: UiComponent, options?: UiRendererOptions): void;
     /**

package/dist/system.js

@@ -3,23 +3,6 @@ import * as ecsComponents from '@dcl/ecs/dist/components';
 import React from 'react';
 import { createReconciler } from './reconciler';
 import { getUiScaleFactor, resetInteractableArea, resetScreenInsetArea, resetUiScaleFactor, setInteractableArea, setScreenInsetArea, setUiScaleFactor } from './components/utils';
-import { isMobile } from './platform';
-/**
- * Default virtual screen size used on mobile platforms, and the size 16:9
- * virtual screens are overridden to on mobile (phone screens are much wider
- * than 16:9, so a 16:9 virtual canvas would letterbox the UI).
- */
-const DEFAULT_MOBILE_VIRTUAL_SIZE = { virtualWidth: 1600, virtualHeight: 720 };
-/**
- * Default virtual screen size used on non-mobile platforms.
- */
-const DEFAULT_VIRTUAL_SIZE = { virtualWidth: 1920, virtualHeight: 1080 };
-function isValidVirtualSize(options) {
-    return !!options && options.virtualWidth > 0 && options.virtualHeight > 0;
-}
-function is16by9(options) {
-    return options.virtualWidth * 9 === options.virtualHeight * 16;
-}
 /**
  * @public
  */
@@ -35,11 +18,6 @@ export function createReactBasedUiSystem(engine, pointerSystem) {
     const screenInsetAreaOwner = Symbol('react-ecs-screen-inset-area');
     // Unique owner for the interactable area module variable.
     const interactableAreaOwner = Symbol('react-ecs-interactable-area');
-    // Last 16:9 size we already logged the mobile override for, so the log
-    // fires once per provided size instead of every tick. Tracked as raw numbers
-    // to avoid allocating a comparison string every tick.
-    let loggedMobileOverrideW = 0;
-    let loggedMobileOverrideH = 0;
     function getActiveVirtualSize() {
         // Main renderer options win; otherwise use the first additional renderer option.
         if (virtualSize)
@@ -50,33 +28,6 @@ export function createReactBasedUiSystem(engine, pointerSystem) {
         }
         return undefined;
     }
-    /**
-     * Resolves the virtual screen to scale the UI against, or `undefined` when
-     * the virtual screen is disabled.
-     */
-    function resolveVirtualSize() {
-        const provided = getActiveVirtualSize();
-        const mobile = isMobile();
-        // No creator-provided size: fall back to the platform default.
-        if (!provided) {
-            return mobile ? DEFAULT_MOBILE_VIRTUAL_SIZE : DEFAULT_VIRTUAL_SIZE;
-        }
-        // An explicitly provided but invalid size (values <= 0) disables the
-        // virtual screen — no UI scaling at all.
-        if (!isValidVirtualSize(provided)) {
-            return undefined;
-        }
-        // On mobile, 16:9 virtual screens don't fit phone aspect ratios — override them.
-        if (mobile && is16by9(provided)) {
-            if (loggedMobileOverrideW !== provided.virtualWidth || loggedMobileOverrideH !== provided.virtualHeight) {
-                loggedMobileOverrideW = provided.virtualWidth;
-                loggedMobileOverrideH = provided.virtualHeight;
-                console.log(`Mobile platform detected: overriding 16:9 virtual screen size ${provided.virtualWidth}x${provided.virtualHeight} with ${DEFAULT_MOBILE_VIRTUAL_SIZE.virtualWidth}x${DEFAULT_MOBILE_VIRTUAL_SIZE.virtualHeight}`);
-            }
-            return DEFAULT_MOBILE_VIRTUAL_SIZE;
-        }
-        return provided;
-    }
     function ReactBasedUiSystem() {
         const components = [];
         // Add main UI component
@@ -117,16 +68,9 @@ export function createReactBasedUiSystem(engine, pointerSystem) {
         if (canvasInfo?.interactableArea) {
             setInteractableArea(canvasInfo.interactableArea, interactableAreaOwner);
         }
-        // The virtual screen (provided or defaulted) only applies while some
-        // renderer is registered; with no UI at all the scale factor is released.
-        if (uiComponent === undefined && additionalRenderers.size === 0) {
-            // Reset only if this system owns the scale factor.
-            resetUiScaleFactor(uiScaleFactorOwner);
-            return;
-        }
-        const activeVirtualSize = resolveVirtualSize();
+        const activeVirtualSize = getActiveVirtualSize();
         if (!activeVirtualSize) {
-            // Virtual screen explicitly disabled by an invalid provided size.
+            // Reset only if this system owns the scale factor.
             resetUiScaleFactor(uiScaleFactorOwner);
             return;
         }
@@ -134,6 +78,8 @@ export function createReactBasedUiSystem(engine, pointerSystem) {
             return;
         const { width, height, devicePixelRatio } = canvasInfo;
         const { virtualWidth, virtualHeight } = activeVirtualSize;
+        if (!virtualWidth || !virtualHeight)
+            return;
         // Normalize by devicePixelRatio so virtual px map to logical px (matching the
         // vw/vh path); without it the scale was inflated on high-dpr mobile screens.
         const ratio = devicePixelRatio || 1;

package/package.json

@@ -1,11 +1,11 @@
 {
   "name": "@dcl/react-ecs",
   "description": "Decentraland ECS",
-  "version": "7.24.5-29334646366.commit-955c00d",
+  "version": "7.24.5-29428555187.commit-fb197d3",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/js-sdk-toolchain/issues",
   "dependencies": {
-    "@dcl/ecs": "7.24.5-29334646366.commit-955c00d",
+    "@dcl/ecs": "7.24.5-29428555187.commit-fb197d3",
     "react": "^18.2.0",
     "react-reconciler": "^0.29.0"
   },
@@ -40,5 +40,5 @@
     "tsconfig": "./tsconfig.json"
   },
   "types": "./dist/index.d.ts",
-  "commit": "955c00dcfec264e375fa39058a34039205cf061d"
+  "commit": "fb197d38cdaec5a0de8d575b337ab142264644e7"
 }

package/dist/platform.d.ts

@@ -1,12 +0,0 @@
-/**
- * Injects the function used to detect whether the scene runs on a mobile
- * platform. Called by `@dcl/sdk` with its `isMobile()` platform helper.
- */
-export declare function setIsMobileProvider(provider: () => boolean): void;
-/**
- * Whether the scene is running on a mobile platform, according to the
- * injected provider. Platform detection is asynchronous on the SDK side, so
- * this may return false during the first ticks and flip to true once the
- * explorer information arrives.
- */
-export declare function isMobile(): boolean;

package/dist/platform.js

@@ -1,26 +0,0 @@
-/**
- * Platform detection hook for the UI scale system.
- *
- * react-ecs stays independent of the scene runtime (`~system/*` modules), so
- * it cannot ask the explorer which platform it runs on. Instead, the host SDK
- * injects the check at module-load time (see `@dcl/sdk/react-ecs`). Until a
- * provider is injected — or when none ever is — the platform is assumed to be
- * non-mobile.
- */
-let isMobileProvider = () => false;
-/**
- * Injects the function used to detect whether the scene runs on a mobile
- * platform. Called by `@dcl/sdk` with its `isMobile()` platform helper.
- */
-export function setIsMobileProvider(provider) {
-    isMobileProvider = provider;
-}
-/**
- * Whether the scene is running on a mobile platform, according to the
- * injected provider. Platform detection is asynchronous on the SDK side, so
- * this may return false during the first ticks and flip to true once the
- * explorer information arrives.
- */
-export function isMobile() {
-    return isMobileProvider();
-}