@dcl/ecs 7.8.15 → 7.8.16-15996225766.commit-f122eaa

package/dist/systems/crdt/index.d.ts

@@ -1,6 +1,7 @@
 import { Entity } from '../../engine/entity';
 import type { ComponentDefinition } from '../../engine';
 import { CrdtMessageType } from '../../serialization/crdt/types';
+export declare const LIVEKIT_MAX_SIZE = 12;
 /**
  * @public
  */

package/dist/systems/crdt/index.js

@@ -8,6 +8,8 @@ import { CrdtMessageType } from '../../serialization/crdt/types';
 import { PutNetworkComponentOperation } from '../../serialization/crdt/network/putComponentNetwork';
 import { NetworkEntity as defineNetworkEntity, NetworkParent as defineNetworkParent, Transform as defineTransform } from '../../components';
 import * as networkUtils from '../../serialization/crdt/network/utils';
+// NetworkMessages can only have a MAX_SIZE of 12kb. So we need to send it in chunks.
+export const LIVEKIT_MAX_SIZE = 12;
 /**
  * @internal
  */
@@ -206,8 +208,6 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
         // Send CRDT messages to transports
         const transportBuffer = new ReadWriteByteBuffer();
         for (const index in transports) {
-            // NetworkMessages can only have a MAX_SIZE of 13kb. So we need to send it in chunks.
-            const LIVEKIT_MAX_SIZE = 13;
             const __NetworkMessagesBuffer = [];
             const transportIndex = Number(index);
             const transport = transports[transportIndex];
@@ -218,9 +218,21 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
             const buffer = new ReadWriteByteBuffer();
             // Then we send all the new crdtMessages that the transport needs to process
             for (const message of crdtMessages) {
-                if (isNetworkTransport && transportBuffer.toBinary().byteLength / 1024 > LIVEKIT_MAX_SIZE) {
-                    __NetworkMessagesBuffer.push(transportBuffer.toBinary());
-                    transportBuffer.resetBuffer();
+                // Check if adding this message would exceed the size limit
+                const currentBufferSize = transportBuffer.toBinary().byteLength;
+                const messageSize = message.messageBuffer.byteLength;
+                if (isNetworkTransport && (currentBufferSize + messageSize) / 1024 > LIVEKIT_MAX_SIZE) {
+                    // If the current buffer has content, save it as a chunk
+                    if (currentBufferSize > 0) {
+                        __NetworkMessagesBuffer.push(transportBuffer.toCopiedBinary());
+                        transportBuffer.resetBuffer();
+                    }
+                    // If the message itself is larger than the limit, we need to handle it specially
+                    // For now, we'll skip it to prevent infinite loops
+                    if (messageSize / 1024 > LIVEKIT_MAX_SIZE) {
+                        console.error(`Message too large (${messageSize} bytes), skipping message for entity ${message.entityId}`);
+                        continue;
+                    }
                 }
                 // Avoid echo messages
                 if (message.transportId === transportIndex)

package/dist-cjs/systems/crdt/index.d.ts

@@ -1,6 +1,7 @@
 import { Entity } from '../../engine/entity';
 import type { ComponentDefinition } from '../../engine';
 import { CrdtMessageType } from '../../serialization/crdt/types';
+export declare const LIVEKIT_MAX_SIZE = 12;
 /**
  * @public
  */

package/dist-cjs/systems/crdt/index.js

@@ -23,7 +23,7 @@ var __importStar = (this && this.__importStar) || function (mod) {
     return result;
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.crdtSceneSystem = void 0;
+exports.crdtSceneSystem = exports.LIVEKIT_MAX_SIZE = void 0;
 const entity_1 = require("../../engine/entity");
 const ByteBuffer_1 = require("../../serialization/ByteBuffer");
 const crdt_1 = require("../../serialization/crdt");
@@ -34,6 +34,8 @@ const types_1 = require("../../serialization/crdt/types");
 const putComponentNetwork_1 = require("../../serialization/crdt/network/putComponentNetwork");
 const components_1 = require("../../components");
 const networkUtils = __importStar(require("../../serialization/crdt/network/utils"));
+// NetworkMessages can only have a MAX_SIZE of 12kb. So we need to send it in chunks.
+exports.LIVEKIT_MAX_SIZE = 12;
 /**
  * @internal
  */
@@ -232,8 +234,6 @@ function crdtSceneSystem(engine, onProcessEntityComponentChange) {
         // Send CRDT messages to transports
         const transportBuffer = new ByteBuffer_1.ReadWriteByteBuffer();
         for (const index in transports) {
-            // NetworkMessages can only have a MAX_SIZE of 13kb. So we need to send it in chunks.
-            const LIVEKIT_MAX_SIZE = 13;
             const __NetworkMessagesBuffer = [];
             const transportIndex = Number(index);
             const transport = transports[transportIndex];
@@ -244,9 +244,21 @@ function crdtSceneSystem(engine, onProcessEntityComponentChange) {
             const buffer = new ByteBuffer_1.ReadWriteByteBuffer();
             // Then we send all the new crdtMessages that the transport needs to process
             for (const message of crdtMessages) {
-                if (isNetworkTransport && transportBuffer.toBinary().byteLength / 1024 > LIVEKIT_MAX_SIZE) {
-                    __NetworkMessagesBuffer.push(transportBuffer.toBinary());
-                    transportBuffer.resetBuffer();
+                // Check if adding this message would exceed the size limit
+                const currentBufferSize = transportBuffer.toBinary().byteLength;
+                const messageSize = message.messageBuffer.byteLength;
+                if (isNetworkTransport && (currentBufferSize + messageSize) / 1024 > exports.LIVEKIT_MAX_SIZE) {
+                    // If the current buffer has content, save it as a chunk
+                    if (currentBufferSize > 0) {
+                        __NetworkMessagesBuffer.push(transportBuffer.toCopiedBinary());
+                        transportBuffer.resetBuffer();
+                    }
+                    // If the message itself is larger than the limit, we need to handle it specially
+                    // For now, we'll skip it to prevent infinite loops
+                    if (messageSize / 1024 > exports.LIVEKIT_MAX_SIZE) {
+                        console.error(`Message too large (${messageSize} bytes), skipping message for entity ${message.entityId}`);
+                        continue;
+                    }
                 }
                 // Avoid echo messages
                 if (message.transportId === transportIndex)

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dcl/ecs",
   "description": "Decentraland ECS",
-  "version": "7.8.15",
+  "version": "7.8.16-15996225766.commit-f122eaa",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/ecs/issues",
   "files": [
@@ -33,5 +33,5 @@
   },
   "types": "./dist/index.d.ts",
   "typings": "./dist/index.d.ts",
-  "commit": "2c7a51eab7d18a487984332013305b2464aff729"
+  "commit": "f122eaa2acaaed80db7ee0302e8d60ca7d2337bf"
 }