@dcl/ecs 7.28.0 → 7.28.1-34624845556.commit-7d0808b

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (51) hide show
  1. package/dist/components/index.d.ts +5 -0
  2. package/dist/components/index.js +5 -2
  3. package/dist/components/manual/CreatedBy.d.ts +9 -0
  4. package/dist/components/manual/CreatedBy.js +8 -0
  5. package/dist/components/manual/Transform.d.ts +9 -0
  6. package/dist/components/manual/Transform.js +3 -3
  7. package/dist/components/types.d.ts +1 -0
  8. package/dist/engine/component.d.ts +52 -1
  9. package/dist/engine/grow-only-value-set-component-definition.js +45 -2
  10. package/dist/engine/lww-element-set-component-definition.d.ts +3 -1
  11. package/dist/engine/lww-element-set-component-definition.js +68 -13
  12. package/dist/index.d.ts +2 -1
  13. package/dist/index.js +1 -0
  14. package/dist/serialization/crdt/authoritativePutComponent.d.ts +15 -0
  15. package/dist/serialization/crdt/authoritativePutComponent.js +47 -0
  16. package/dist/serialization/crdt/index.d.ts +1 -0
  17. package/dist/serialization/crdt/index.js +1 -0
  18. package/dist/serialization/crdt/types.d.ts +25 -3
  19. package/dist/serialization/crdt/types.js +3 -1
  20. package/dist/systems/crdt/index.d.ts +0 -1
  21. package/dist/systems/crdt/index.js +76 -143
  22. package/dist/systems/crdt/types.d.ts +10 -0
  23. package/dist/systems/events.js +47 -18
  24. package/dist-cjs/components/index.d.ts +5 -0
  25. package/dist-cjs/components/index.js +7 -3
  26. package/dist-cjs/components/manual/CreatedBy.d.ts +9 -0
  27. package/dist-cjs/components/manual/CreatedBy.js +10 -0
  28. package/dist-cjs/components/manual/Transform.d.ts +9 -0
  29. package/dist-cjs/components/manual/Transform.js +3 -3
  30. package/dist-cjs/components/types.d.ts +1 -0
  31. package/dist-cjs/engine/component.d.ts +52 -1
  32. package/dist-cjs/engine/grow-only-value-set-component-definition.js +44 -1
  33. package/dist-cjs/engine/lww-element-set-component-definition.d.ts +3 -1
  34. package/dist-cjs/engine/lww-element-set-component-definition.js +71 -14
  35. package/dist-cjs/index.d.ts +2 -1
  36. package/dist-cjs/index.js +2 -1
  37. package/dist-cjs/serialization/crdt/authoritativePutComponent.d.ts +15 -0
  38. package/dist-cjs/serialization/crdt/authoritativePutComponent.js +50 -0
  39. package/dist-cjs/serialization/crdt/index.d.ts +1 -0
  40. package/dist-cjs/serialization/crdt/index.js +1 -0
  41. package/dist-cjs/serialization/crdt/types.d.ts +25 -3
  42. package/dist-cjs/serialization/crdt/types.js +3 -1
  43. package/dist-cjs/systems/crdt/index.d.ts +0 -1
  44. package/dist-cjs/systems/crdt/index.js +76 -166
  45. package/dist-cjs/systems/crdt/types.d.ts +10 -0
  46. package/dist-cjs/systems/events.js +47 -18
  47. package/package.json +2 -2
  48. package/dist/serialization/crdt/network/utils.d.ts +0 -9
  49. package/dist/serialization/crdt/network/utils.js +0 -60
  50. package/dist-cjs/serialization/crdt/network/utils.d.ts +0 -9
  51. package/dist-cjs/serialization/crdt/network/utils.js +0 -67
@@ -1,24 +1,17 @@
1
1
  import { EntityState } from '../../engine/entity';
2
2
  import { ReadWriteByteBuffer } from '../../serialization/ByteBuffer';
3
- import { AppendValueOperation, CrdtMessageProtocol, DeleteComponentNetwork, DeleteEntityNetwork } from '../../serialization/crdt';
3
+ import { AppendValueOperation, CrdtMessageProtocol } from '../../serialization/crdt';
4
4
  import { DeleteComponent } from '../../serialization/crdt/deleteComponent';
5
5
  import { DeleteEntity } from '../../serialization/crdt/deleteEntity';
6
6
  import { PutComponentOperation } from '../../serialization/crdt/putComponent';
7
+ import { AuthoritativePutComponentOperation } from '../../serialization/crdt/authoritativePutComponent';
7
8
  import { CrdtMessageType } from '../../serialization/crdt/types';
8
- import { PutNetworkComponentOperation } from '../../serialization/crdt/network/putComponentNetwork';
9
- import { NetworkEntity as defineNetworkEntity, NetworkParent as defineNetworkParent, Transform as defineTransform } from '../../components';
10
- import * as networkUtils from '../../serialization/crdt/network/utils';
11
- // NetworkMessages can only have a MAX_SIZE of 12kb. So we need to send it in chunks.
12
- export const LIVEKIT_MAX_SIZE = 12;
13
9
  /**
14
10
  * @internal
15
11
  */
16
12
  export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
17
13
  const transports = [];
18
- // Components that we used on this system
19
- const NetworkEntity = defineNetworkEntity(engine);
20
- const NetworkParent = defineNetworkParent(engine);
21
- const Transform = defineTransform(engine);
14
+ // No network components needed - pure CRDT processing only
22
15
  // Messages that we received at transport.onMessage waiting to be processed
23
16
  const receivedMessages = [];
24
17
  // Messages already processed by the engine but that we need to broadcast to other transports.
@@ -43,27 +36,20 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
43
36
  if (header.type === CrdtMessageType.DELETE_COMPONENT) {
44
37
  message = DeleteComponent.read(buffer);
45
38
  }
46
- else if (header.type === CrdtMessageType.DELETE_COMPONENT_NETWORK) {
47
- message = DeleteComponentNetwork.read(buffer);
48
- }
49
39
  else if (header.type === CrdtMessageType.PUT_COMPONENT) {
50
40
  message = PutComponentOperation.read(buffer);
51
41
  }
52
- else if (header.type === CrdtMessageType.PUT_COMPONENT_NETWORK) {
53
- message = PutNetworkComponentOperation.read(buffer);
42
+ else if (header.type === CrdtMessageType.AUTHORITATIVE_PUT_COMPONENT) {
43
+ message = AuthoritativePutComponentOperation.read(buffer);
54
44
  }
55
45
  else if (header.type === CrdtMessageType.DELETE_ENTITY) {
56
46
  message = DeleteEntity.read(buffer);
57
47
  }
58
- else if (header.type === CrdtMessageType.DELETE_ENTITY_NETWORK) {
59
- message = DeleteEntityNetwork.read(buffer);
60
- }
61
48
  else if (header.type === CrdtMessageType.APPEND_VALUE) {
62
49
  message = AppendValueOperation.read(buffer);
63
- // Unknown message, we skip it
64
50
  }
65
51
  else {
66
- // consume the message
52
+ // Unknown message, we skip it (including NETWORK messages)
67
53
  buffer.incrementReadOffset(header.length);
68
54
  }
69
55
  if (message) {
@@ -85,20 +71,12 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
85
71
  return messagesToProcess;
86
72
  }
87
73
  /**
88
- * Find the local entityId associated to the network component message.
89
- * It's a mapping Network -> to Local
90
- * If it's not a network message, return the entityId received by the message
74
+ * Reserved-range entities (root/player/camera + avatars, entity number <
75
+ * RESERVED_STATIC_ENTITIES) are host-owned: only a transport flagged with
76
+ * `allowReservedEntities` (the host/renderer) may mutate or delete them.
91
77
  */
92
- function findNetworkId(msg) {
93
- const hasNetworkId = 'networkId' in msg;
94
- if (hasNetworkId) {
95
- for (const [entityId, network] of engine.getEntitiesWith(NetworkEntity)) {
96
- if (network.networkId === msg.networkId && network.entityId === msg.entityId) {
97
- return { entityId, network };
98
- }
99
- }
100
- }
101
- return { entityId: msg.entityId };
78
+ function isTrustedForReservedEntities(transportId) {
79
+ return transportId !== undefined && !!transports[transportId]?.allowReservedEntities;
102
80
  }
103
81
  /**
104
82
  * This fn will be called on every tick.
@@ -108,46 +86,68 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
108
86
  const messagesToProcess = getMessages(receivedMessages);
109
87
  const entitiesShouldBeCleaned = [];
110
88
  for (const msg of messagesToProcess) {
111
- let { entityId, network } = findNetworkId(msg);
112
- // We receive a new Entity. Create the localEntity and map it to the NetworkEntity component
113
- if (networkUtils.isNetworkMessage(msg) && !network) {
114
- entityId = engine.addEntity();
115
- network = { entityId: msg.entityId, networkId: msg.networkId };
116
- NetworkEntity.createOrReplace(entityId, network);
117
- }
118
- if (msg.type === CrdtMessageType.DELETE_ENTITY || msg.type === CrdtMessageType.DELETE_ENTITY_NETWORK) {
119
- entitiesShouldBeCleaned.push(entityId);
89
+ // Simple CRDT processing - no network logic
90
+ if (msg.type === CrdtMessageType.DELETE_ENTITY) {
91
+ // Reject an inbound DELETE_ENTITY on a reserved entity from an untrusted
92
+ // transport (a comms peer, or a scene-added transport). The allocator half
93
+ // is already guarded (engine.removeEntity is a no-op on this range); this
94
+ // closes the receive-side half.
95
+ const isReserved = engine.entityContainer.getEntityState(msg.entityId) === EntityState.Reserved;
96
+ if (isReserved && !isTrustedForReservedEntities(msg.transportId)) {
97
+ continue;
98
+ }
99
+ entitiesShouldBeCleaned.push(msg.entityId);
120
100
  broadcastMessages.push(msg);
121
101
  }
122
102
  else {
123
- const entityState = engine.entityContainer.getEntityState(entityId);
124
- // Skip updates from removed entityes
103
+ const entityState = engine.entityContainer.getEntityState(msg.entityId);
104
+ // Skip updates from removed entities
125
105
  if (entityState === EntityState.Removed)
126
106
  continue;
127
- // Entities with unknown entities should update its entity state
107
+ // Reject component operations (PUT/DELETE/APPEND, including AUTHORITATIVE_PUT
108
+ // which bypasses timestamps entirely) on reserved entities from untrusted
109
+ // transports. Dropping before updateFromCrdt keeps local LWW timestamps
110
+ // unpoisoned by forged high timestamps, and also prevents the
111
+ // unknown-component rebroadcast below from relaying forged reserved-entity
112
+ // data to other transports (including the renderer).
113
+ if (entityState === EntityState.Reserved && !isTrustedForReservedEntities(msg.transportId))
114
+ continue;
115
+ // Entities with unknown state should update its entity state
128
116
  if (entityState === EntityState.Unknown) {
129
- engine.entityContainer.updateUsedEntity(entityId);
130
- }
131
- const component = engine.getComponentOrNull(msg.componentId);
132
- /* istanbul ignore else */
133
- if (component) {
134
- if (msg.type === CrdtMessageType.PUT_COMPONENT &&
135
- component.componentId === Transform.componentId &&
136
- NetworkEntity.has(entityId) &&
137
- NetworkParent.has(entityId)) {
138
- msg.data = networkUtils.fixTransformParent(msg);
117
+ engine.entityContainer.updateUsedEntity(msg.entityId);
118
+ }
119
+ // Only process component-related messages (not DELETE_ENTITY)
120
+ if ('componentId' in msg) {
121
+ const component = engine.getComponentOrNull(msg.componentId);
122
+ if (component) {
123
+ // Handle authoritative messages differently - they force the state regardless of timestamp
124
+ const tryUpdate = () => {
125
+ try {
126
+ return msg.type === CrdtMessageType.AUTHORITATIVE_PUT_COMPONENT
127
+ ? component.__forceUpdateFromCrdt(msg)
128
+ : component.updateFromCrdt(msg);
129
+ }
130
+ catch (e) {
131
+ console.error('[receiveMessages] ERROR processing message', msg, e);
132
+ return null;
133
+ }
134
+ };
135
+ const result = tryUpdate();
136
+ if (!result)
137
+ continue;
138
+ const [conflictMessage, value] = result;
139
+ if (!conflictMessage) {
140
+ // Add message to broadcast queue when no conflict
141
+ broadcastMessages.push(msg);
142
+ onProcessEntityComponentChange && onProcessEntityComponentChange(msg.entityId, msg.type, component, value);
143
+ }
139
144
  }
140
- const [conflictMessage, value] = component.updateFromCrdt({ ...msg, entityId });
141
- if (!conflictMessage) {
142
- // Add message to transport queue to be processed by others transports
145
+ else {
146
+ // Component not found - still broadcast for editor compatibility
147
+ /* istanbul ignore next */
143
148
  broadcastMessages.push(msg);
144
- onProcessEntityComponentChange && onProcessEntityComponentChange(entityId, msg.type, component, value);
145
149
  }
146
150
  }
147
- else {
148
- // TODO: test this line, it is fundammental to make the editor work
149
- broadcastMessages.push(msg);
150
- }
151
151
  }
152
152
  }
153
153
  // the last stage of the syncrhonization is to delete the entities
@@ -161,16 +161,17 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
161
161
  }
162
162
  }
163
163
  /**
164
- * Iterates the dirty map and generates crdt messages to be send
164
+ * Simple CRDT message broadcasting - no network-specific logic
165
165
  */
166
166
  async function sendMessages(entitiesDeletedThisTick) {
167
- // CRDT Messages will be the merge between the recieved transport messages and the new crdt messages
167
+ // Get messages from broadcast queue and component updates
168
168
  const crdtMessages = getMessages(broadcastMessages);
169
169
  const buffer = new ReadWriteByteBuffer();
170
+ // Generate CRDT messages from component updates
170
171
  for (const component of engine.componentsIter()) {
171
172
  for (const message of component.getCrdtUpdates()) {
172
173
  const offset = buffer.currentWriteOffset();
173
- // Avoid creating messages if there is no transport that will handle it
174
+ // Only create messages if there's a transport that will handle it
174
175
  if (transports.some((t) => t.filter(message))) {
175
176
  if (message.type === CrdtMessageType.PUT_COMPONENT) {
176
177
  PutComponentOperation.write(message.entityId, message.timestamp, message.componentId, message.data, buffer);
@@ -194,7 +195,7 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
194
195
  }
195
196
  }
196
197
  }
197
- // After all updates, I execute the DeletedEntity messages
198
+ // Handle deleted entities
198
199
  for (const entityId of entitiesDeletedThisTick) {
199
200
  const offset = buffer.currentWriteOffset();
200
201
  DeleteEntity.write(entityId, buffer);
@@ -205,87 +206,19 @@ export function crdtSceneSystem(engine, onProcessEntityComponentChange) {
205
206
  });
206
207
  onProcessEntityComponentChange && onProcessEntityComponentChange(entityId, CrdtMessageType.DELETE_ENTITY);
207
208
  }
208
- // Send CRDT messages to transports
209
- const transportBuffer = new ReadWriteByteBuffer();
210
- for (const index in transports) {
211
- const __NetworkMessagesBuffer = [];
212
- const transportIndex = Number(index);
213
- const transport = transports[transportIndex];
214
- const isRendererTransport = transport.type === 'renderer';
215
- const isNetworkTransport = transport.type === 'network';
216
- // Reset Buffer for each Transport
217
- transportBuffer.resetBuffer();
218
- const buffer = new ReadWriteByteBuffer();
219
- // Then we send all the new crdtMessages that the transport needs to process
209
+ // Simple transport broadcasting - no network-specific transforms
210
+ for (const transport of transports) {
211
+ const transportBuffer = new ReadWriteByteBuffer();
220
212
  for (const message of crdtMessages) {
221
213
  // Avoid echo messages
222
- if (message.transportId === transportIndex)
214
+ if (message.transportId === transports.indexOf(transport))
223
215
  continue;
224
- // Redundant message for the transport
225
- if (!transport.filter(message))
226
- continue;
227
- // Check if adding this message would exceed the size limit
228
- const currentBufferSize = transportBuffer.toBinary().byteLength;
229
- const messageSize = message.messageBuffer.byteLength;
230
- if (isNetworkTransport && (currentBufferSize + messageSize) / 1024 > LIVEKIT_MAX_SIZE) {
231
- // If the current buffer has content, save it as a chunk
232
- if (currentBufferSize > 0) {
233
- __NetworkMessagesBuffer.push(transportBuffer.toCopiedBinary());
234
- transportBuffer.resetBuffer();
235
- }
236
- // If the message itself is larger than the limit, we need to handle it specially
237
- // For now, we'll skip it to prevent infinite loops
238
- if (messageSize / 1024 > LIVEKIT_MAX_SIZE) {
239
- console.error(`Message too large (${messageSize} bytes), skipping message for entity ${message.entityId}`);
240
- continue;
241
- }
216
+ // Check if transport wants this message
217
+ if (transport.filter(message)) {
218
+ transportBuffer.writeBuffer(message.messageBuffer, false);
242
219
  }
243
- const { entityId } = findNetworkId(message);
244
- const transformNeedsFix = 'componentId' in message &&
245
- message.componentId === Transform.componentId &&
246
- Transform.has(entityId) &&
247
- NetworkParent.has(entityId) &&
248
- NetworkEntity.has(entityId);
249
- // If there was a LOCAL change in the transform. Add the parent to that transform
250
- if (isRendererTransport && message.type === CrdtMessageType.PUT_COMPONENT && transformNeedsFix) {
251
- const parent = findNetworkId(NetworkParent.get(entityId));
252
- const transformData = networkUtils.fixTransformParent(message, Transform.get(entityId), parent.entityId);
253
- const offset = buffer.currentWriteOffset();
254
- PutComponentOperation.write(entityId, message.timestamp, message.componentId, transformData, buffer);
255
- transportBuffer.writeBuffer(buffer.buffer().subarray(offset, buffer.currentWriteOffset()), false);
256
- continue;
257
- }
258
- if (isRendererTransport && networkUtils.isNetworkMessage(message)) {
259
- // If it's the renderer transport and its a NetworkMessage, we need to fix the entityId field and convert it to a known Message.
260
- // PUT_NETWORK_COMPONENT -> PUT_COMPONENT
261
- let transformData = 'data' in message ? message.data : new Uint8Array();
262
- if (transformNeedsFix) {
263
- const parent = findNetworkId(NetworkParent.get(entityId));
264
- transformData = networkUtils.fixTransformParent(message, Transform.get(entityId), parent.entityId);
265
- }
266
- networkUtils.networkMessageToLocal({ ...message, data: transformData }, entityId, buffer, transportBuffer);
267
- // Iterate the next message
268
- continue;
269
- }
270
- // If its a network transport and its a PUT_COMPONENT that has a NetworkEntity component, we need to send this message
271
- // through comms with the EntityID and NetworkID from ther NetworkEntity so everyone can recieve this message and map to their custom entityID.
272
- if (isNetworkTransport && !networkUtils.isNetworkMessage(message)) {
273
- const networkData = NetworkEntity.getOrNull(message.entityId);
274
- // If it has networkData convert the message to PUT_NETWORK_COMPONENT.
275
- if (networkData) {
276
- networkUtils.localMessageToNetwork(message, networkData, buffer, transportBuffer);
277
- // Iterate the next message
278
- continue;
279
- }
280
- }
281
- // Common message
282
- transportBuffer.writeBuffer(message.messageBuffer, false);
283
- }
284
- if (isNetworkTransport && transportBuffer.currentWriteOffset()) {
285
- __NetworkMessagesBuffer.push(transportBuffer.toBinary());
286
220
  }
287
- const message = isNetworkTransport ? __NetworkMessagesBuffer : transportBuffer.toBinary();
288
- await transport.send(message);
221
+ await transport.send(transportBuffer.toBinary());
289
222
  }
290
223
  }
291
224
  /**
@@ -29,4 +29,14 @@ export type Transport = {
29
29
  onmessage?(message: Uint8Array): void;
30
30
  filter(message: Omit<TransportMessage, 'messageBuffer'>): boolean;
31
31
  type?: string;
32
+ /**
33
+ * Whether this transport is allowed to mutate reserved-range entities
34
+ * (root/player/camera + avatars, entity number below `RESERVED_STATIC_ENTITIES`).
35
+ * Only the trusted host/renderer transport sets this. An inbound DELETE_ENTITY
36
+ * or component operation (PUT_COMPONENT, DELETE_COMPONENT, APPEND_VALUE,
37
+ * AUTHORITATIVE_PUT_COMPONENT) on a reserved entity from a transport without
38
+ * this flag (a comms peer, or any scene-added transport) is rejected — see
39
+ * `receiveMessages`.
40
+ */
41
+ allowReservedEntities?: boolean;
32
42
  };
@@ -25,6 +25,16 @@ export function createPointerEventsSystem(engine, inputSystem) {
25
25
  function getEvent(entity) {
26
26
  return eventsMap.get(entity) || eventsMap.set(entity, new Map()).get(entity);
27
27
  }
28
+ // A cursor handler and a proximity handler are separate registrations that
29
+ // produce separate PointerEvents entries, so they need separate slots here
30
+ // too. Keying on the event type alone made onProximityDown evict whatever
31
+ // onPointerDown had left.
32
+ function eventKey(type, interactionType) {
33
+ return `${type}:${interactionType}`;
34
+ }
35
+ function setEvent(entity, type, cb, opts, interactionType = 0 /* InteractionType.CURSOR */) {
36
+ getEvent(entity).set(eventKey(type, interactionType), { cb, opts, eventType: type });
37
+ }
28
38
  function setPointerEvent(entity, type, opts, interactionType = 0 /* InteractionType.CURSOR */) {
29
39
  const pointerEvent = PointerEvents.getMutableOrNull(entity) || PointerEvents.create(entity);
30
40
  pointerEvent.pointerEvents.push({
@@ -42,13 +52,27 @@ export function createPointerEventsSystem(engine, inputSystem) {
42
52
  interactionType: interactionType ?? 0 /* InteractionType.CURSOR */
43
53
  });
44
54
  }
45
- function removePointerEvent(entity, type, button, interactionType = 0 /* InteractionType.CURSOR */) {
55
+ function removePointerEvent(entity, type, opts, interactionType = 0 /* InteractionType.CURSOR */) {
46
56
  const pointerEvent = PointerEvents.getMutableOrNull(entity);
47
57
  if (!pointerEvent)
48
58
  return;
49
- pointerEvent.pointerEvents = pointerEvent.pointerEvents.filter((pointer) => !(pointer.eventInfo?.button === button &&
50
- pointer.eventType === type &&
51
- pointer.interactionType === interactionType));
59
+ const sameSlot = (pointer) => pointer.eventType === type && pointer.interactionType === interactionType;
60
+ // onClick and onPointerDown both describe themselves as PET_DOWN, so the event
61
+ // type and button alone do not say which registration an entry belongs to. Match
62
+ // everything the entry was built from, or removing one handler can take the
63
+ // other's descriptor and leave the renderer advertising the wrong interaction.
64
+ const index = pointerEvent.pointerEvents.findIndex((pointer) => sameSlot(pointer) &&
65
+ pointer.eventInfo?.button === opts.button &&
66
+ pointer.eventInfo?.hoverText === opts.hoverText &&
67
+ pointer.eventInfo?.showFeedback === opts.showFeedback &&
68
+ pointer.eventInfo?.showHighlight === opts.showHighlight &&
69
+ pointer.eventInfo?.maxDistance === opts.maxDistance &&
70
+ pointer.eventInfo?.maxPlayerDistance === opts.maxPlayerDistance &&
71
+ pointer.eventInfo?.priority === opts.priority &&
72
+ pointer.eventInfo?.maxCameraDistance === opts.maxCameraDistance);
73
+ if (index === -1)
74
+ return;
75
+ pointerEvent.pointerEvents.splice(index, 1);
52
76
  }
53
77
  function getPointerEvent(eventType) {
54
78
  if (eventType === EventType.Up) {
@@ -70,11 +94,16 @@ export function createPointerEventsSystem(engine, inputSystem) {
70
94
  }
71
95
  function removeEvent(entity, type, interactionType = 0 /* InteractionType.CURSOR */) {
72
96
  const event = getEvent(entity);
73
- const pointerEvent = event.get(type);
74
- if (pointerEvent?.opts.hoverText) {
75
- removePointerEvent(entity, getPointerEvent(type), pointerEvent.opts.button);
97
+ const key = eventKey(type, interactionType);
98
+ const pointerEvent = event.get(key);
99
+ // Every registration adds an entry, not only the ones carrying a hoverText,
100
+ // so every removal has to take one away. Gating on hoverText left the
101
+ // renderer showing an interaction whose callback was already gone, and made
102
+ // re-registering grow the component by one entry each time.
103
+ if (pointerEvent) {
104
+ removePointerEvent(entity, getPointerEvent(type), pointerEvent.opts, interactionType);
76
105
  }
77
- event.delete(type);
106
+ event.delete(key);
78
107
  }
79
108
  engine.addSystem(function PointerEventSystem() {
80
109
  for (const [entity, event] of eventsMap) {
@@ -82,7 +111,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
82
111
  eventsMap.delete(entity);
83
112
  continue;
84
113
  }
85
- for (const [eventType, { cb, opts }] of event) {
114
+ for (const [, { cb, opts, eventType }] of event) {
86
115
  if (eventType === EventType.Click) {
87
116
  const command = inputSystem.getClick(opts.button, entity);
88
117
  if (command)
@@ -110,7 +139,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
110
139
  const { entity, opts } = data;
111
140
  const options = getDefaultOpts(opts);
112
141
  removeEvent(entity, EventType.Down);
113
- getEvent(entity).set(EventType.Down, { cb, opts: options });
142
+ setEvent(entity, EventType.Down, cb, options);
114
143
  setPointerEvent(entity, 1 /* PointerEventType.PET_DOWN */, options);
115
144
  };
116
145
  const onPointerUp = (...args) => {
@@ -121,7 +150,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
121
150
  const { entity, opts } = data;
122
151
  const options = getDefaultOpts(opts);
123
152
  removeEvent(entity, EventType.Up);
124
- getEvent(entity).set(EventType.Up, { cb, opts: options });
153
+ setEvent(entity, EventType.Up, cb, options);
125
154
  setPointerEvent(entity, 0 /* PointerEventType.PET_UP */, options);
126
155
  };
127
156
  const onPointerHoverEnter = (...args) => {
@@ -129,7 +158,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
129
158
  const { entity, opts } = data;
130
159
  const options = getDefaultOpts(opts);
131
160
  removeEvent(entity, EventType.HoverEnter);
132
- getEvent(entity).set(EventType.HoverEnter, { cb, opts: options });
161
+ setEvent(entity, EventType.HoverEnter, cb, options);
133
162
  setPointerEvent(entity, 2 /* PointerEventType.PET_HOVER_ENTER */, options);
134
163
  };
135
164
  const onPointerHoverLeave = (...args) => {
@@ -137,7 +166,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
137
166
  const { entity, opts } = data;
138
167
  const options = getDefaultOpts(opts);
139
168
  removeEvent(entity, EventType.HoverLeave);
140
- getEvent(entity).set(EventType.HoverLeave, { cb, opts: options });
169
+ setEvent(entity, EventType.HoverLeave, cb, options);
141
170
  setPointerEvent(entity, 3 /* PointerEventType.PET_HOVER_LEAVE */, options);
142
171
  };
143
172
  const onProximityDown = (...args) => {
@@ -145,7 +174,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
145
174
  const { entity, opts } = data;
146
175
  const options = getDefaultOpts(opts);
147
176
  removeEvent(entity, EventType.Down, 1 /* InteractionType.PROXIMITY */);
148
- getEvent(entity).set(EventType.Down, { cb, opts: options });
177
+ setEvent(entity, EventType.Down, cb, options, 1 /* InteractionType.PROXIMITY */);
149
178
  setPointerEvent(entity, 1 /* PointerEventType.PET_DOWN */, options, 1 /* InteractionType.PROXIMITY */);
150
179
  };
151
180
  const onProximityUp = (...args) => {
@@ -153,7 +182,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
153
182
  const { entity, opts } = data;
154
183
  const options = getDefaultOpts(opts);
155
184
  removeEvent(entity, EventType.Up, 1 /* InteractionType.PROXIMITY */);
156
- getEvent(entity).set(EventType.Up, { cb, opts: options });
185
+ setEvent(entity, EventType.Up, cb, options, 1 /* InteractionType.PROXIMITY */);
157
186
  setPointerEvent(entity, 0 /* PointerEventType.PET_UP */, options, 1 /* InteractionType.PROXIMITY */);
158
187
  };
159
188
  const onProximityEnter = (...args) => {
@@ -161,7 +190,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
161
190
  const { entity, opts } = data;
162
191
  const options = getDefaultOpts(opts);
163
192
  removeEvent(entity, EventType.ProximityEnter, 1 /* InteractionType.PROXIMITY */);
164
- getEvent(entity).set(EventType.ProximityEnter, { cb, opts: options });
193
+ setEvent(entity, EventType.ProximityEnter, cb, options, 1 /* InteractionType.PROXIMITY */);
165
194
  setPointerEvent(entity, 4 /* PointerEventType.PET_PROXIMITY_ENTER */, options, 1 /* InteractionType.PROXIMITY */);
166
195
  };
167
196
  const onProximityLeave = (...args) => {
@@ -169,7 +198,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
169
198
  const { entity, opts } = data;
170
199
  const options = getDefaultOpts(opts);
171
200
  removeEvent(entity, EventType.ProximityLeave, 1 /* InteractionType.PROXIMITY */);
172
- getEvent(entity).set(EventType.ProximityLeave, { cb, opts: options });
201
+ setEvent(entity, EventType.ProximityLeave, cb, options, 1 /* InteractionType.PROXIMITY */);
173
202
  setPointerEvent(entity, 5 /* PointerEventType.PET_PROXIMITY_LEAVE */, options, 1 /* InteractionType.PROXIMITY */);
174
203
  };
175
204
  return {
@@ -206,7 +235,7 @@ export function createPointerEventsSystem(engine, inputSystem) {
206
235
  // Clear previous event with over feedback included
207
236
  removeEvent(entity, EventType.Click);
208
237
  // Set new event
209
- getEvent(entity).set(EventType.Click, { cb, opts: options });
238
+ setEvent(entity, EventType.Click, cb, options);
210
239
  setPointerEvent(entity, 1 /* PointerEventType.PET_DOWN */, options);
211
240
  },
212
241
  onPointerDown,
@@ -23,6 +23,7 @@ import { TriggerAreaComponentDefinitionExtended } from './extended/TriggerArea';
23
23
  import { ParticleSystemComponentDefinitionExtended } from './extended/ParticleSystem';
24
24
  import { TouchScreenControlsComponentDefinitionExtended } from './extended/TouchScreenControls';
25
25
  import { TagsComponentDefinitionExtended } from './manual/Tags';
26
+ import { ICreatedByType } from './manual/CreatedBy';
26
27
  export * from './generated/index.gen';
27
28
  export type { GrowOnlyValueSetComponentDefinition, LastWriteWinElementSetComponentDefinition, LwwComponentGetter, GSetComponentGetter };
28
29
  export declare const Transform: LwwComponentGetter<TransformComponentExtended>;
@@ -57,5 +58,9 @@ export declare const NetworkEntity: (engine: Pick<IEngine, 'defineComponent'>) =
57
58
  * @alpha
58
59
  */
59
60
  export declare const NetworkParent: (engine: Pick<IEngine, 'defineComponent'>) => LastWriteWinElementSetComponentDefinition<INetowrkParentType>;
61
+ /**
62
+ * @public
63
+ */
64
+ export declare const CreatedBy: (engine: Pick<IEngine, 'defineComponent'>) => LastWriteWinElementSetComponentDefinition<ICreatedByType>;
60
65
  export { MediaState };
61
66
  export type { AudioAnalysisView };
@@ -17,7 +17,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
17
17
  return (mod && mod.__esModule) ? mod : { "default": mod };
18
18
  };
19
19
  Object.defineProperty(exports, "__esModule", { value: true });
20
- exports.MediaState = exports.NetworkParent = exports.NetworkEntity = exports.SyncComponents = exports.Tags = exports.Name = exports.TouchScreenControls = exports.ParticleSystem = exports.TriggerArea = exports.LightSource = exports.InputModifier = exports.VirtualCamera = exports.Tween = exports.MeshCollider = exports.MeshRenderer = exports.AudioStream = exports.AudioAnalysis = exports.AudioSource = exports.Animator = exports.Material = exports.Transform = void 0;
20
+ exports.MediaState = exports.CreatedBy = exports.NetworkParent = exports.NetworkEntity = exports.SyncComponents = exports.Tags = exports.Name = exports.TouchScreenControls = exports.ParticleSystem = exports.TriggerArea = exports.LightSource = exports.InputModifier = exports.VirtualCamera = exports.Tween = exports.MeshCollider = exports.MeshRenderer = exports.AudioStream = exports.AudioAnalysis = exports.AudioSource = exports.Animator = exports.Material = exports.Transform = void 0;
21
21
  const Animator_1 = require("./extended/Animator");
22
22
  const AudioSource_1 = require("./extended/AudioSource");
23
23
  const AudioAnalysis_1 = require("./extended/AudioAnalysis");
@@ -40,6 +40,7 @@ const TriggerArea_1 = require("./extended/TriggerArea");
40
40
  const ParticleSystem_1 = require("./extended/ParticleSystem");
41
41
  const TouchScreenControls_1 = require("./extended/TouchScreenControls");
42
42
  const Tags_1 = __importDefault(require("./manual/Tags"));
43
+ const CreatedBy_1 = __importDefault(require("./manual/CreatedBy"));
43
44
  __exportStar(require("./generated/index.gen"), exports);
44
45
  /* @__PURE__ */
45
46
  const Transform = (engine) => (0, Transform_1.defineTransformComponent)(engine);
@@ -104,12 +105,15 @@ exports.SyncComponents = SyncComponents;
104
105
  /**
105
106
  * @alpha
106
107
  */
107
- /* @__PURE__ */
108
108
  const NetworkEntity = (engine) => (0, NetworkEntity_1.default)(engine);
109
109
  exports.NetworkEntity = NetworkEntity;
110
110
  /**
111
111
  * @alpha
112
112
  */
113
- /* @__PURE__ */
114
113
  const NetworkParent = (engine) => (0, NetworkParent_1.default)(engine);
115
114
  exports.NetworkParent = NetworkParent;
115
+ /**
116
+ * @public
117
+ */
118
+ const CreatedBy = (engine) => (0, CreatedBy_1.default)(engine);
119
+ exports.CreatedBy = CreatedBy;
@@ -0,0 +1,9 @@
1
+ import { IEngine, LastWriteWinElementSetComponentDefinition } from '../../engine/types';
2
+ export interface ICreatedByType {
3
+ address: string;
4
+ }
5
+ export type ICreatedBy = LastWriteWinElementSetComponentDefinition<ICreatedByType>;
6
+ declare function defineCreatedBy(engine: Pick<IEngine, 'defineComponent'>): import("../../engine/types").MapComponentDefinition<import("../..").MapResult<{
7
+ address: import("../../schemas").ISchema<string>;
8
+ }>>;
9
+ export default defineCreatedBy;
@@ -0,0 +1,10 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ const schemas_1 = require("../../schemas");
4
+ function defineCreatedBy(engine) {
5
+ const CreatedBy = engine.defineComponent('core-schema::Created-By', {
6
+ address: schemas_1.Schemas.String
7
+ });
8
+ return CreatedBy;
9
+ }
10
+ exports.default = defineCreatedBy;
@@ -1,5 +1,6 @@
1
1
  import { LastWriteWinElementSetComponentDefinition, IEngine } from '../../engine';
2
2
  import { Entity } from '../../engine/entity';
3
+ import type { ISchema } from '../../schemas/ISchema';
3
4
  import type { Vector3Type } from '../../schemas/custom/Vector3';
4
5
  /**
5
6
  * @public
@@ -24,6 +25,10 @@ export interface TransformComponentExtended extends TransformComponent {
24
25
  */
25
26
  localToWorldDirection(entity: Entity, localDirection: Vector3Type): Vector3Type;
26
27
  }
28
+ /**
29
+ * @public
30
+ */
31
+ export declare const COMPONENT_ID = 1;
27
32
  /**
28
33
  * @public
29
34
  */
@@ -46,6 +51,10 @@ export type TransformType = {
46
51
  };
47
52
  parent?: Entity;
48
53
  };
54
+ /** @public */
55
+ export declare const TRANSFORM_LENGTH = 44;
56
+ /** @public */
57
+ export declare const TransformSchema: ISchema<TransformType>;
49
58
  /**
50
59
  * @public
51
60
  */
@@ -29,12 +29,12 @@ exports.defineTransformComponent = exports.TransformSchema = exports.TRANSFORM_L
29
29
  // getters via __importStar in CJS), so by the time methods are called all exports are available.
30
30
  const treeHelpers = __importStar(require("../../runtime/helpers/tree"));
31
31
  /**
32
- * @internal
32
+ * @public
33
33
  */
34
34
  exports.COMPONENT_ID = 1;
35
- /** @internal */
35
+ /** @public */
36
36
  exports.TRANSFORM_LENGTH = 44;
37
- /** @internal */
37
+ /** @public */
38
38
  exports.TransformSchema = {
39
39
  serialize(value, builder) {
40
40
  const ptr = builder.incrementWriteOffset(exports.TRANSFORM_LENGTH);
@@ -13,6 +13,7 @@ export type { TagsComponentDefinitionExtended, TagsType } from './manual/Tags';
13
13
  export type { ISyncComponents, ISyncComponentsType } from './manual/SyncComponents';
14
14
  export type { INetowrkEntity, INetowrkEntityType } from './manual/NetworkEntity';
15
15
  export type { INetowrkParent, INetowrkParentType } from './manual/NetworkParent';
16
+ export type { ICreatedBy, ICreatedByType } from './manual/CreatedBy';
16
17
  export type { InputModifierHelper, InputModifierComponentDefinitionExtended } from './extended/InputModifier';
17
18
  export type { LightSourceHelper, LightSourceComponentDefinitionExtended } from './extended/LightSource';
18
19
  export type { TriggerAreaComponentDefinitionExtended } from './extended/TriggerArea';