@dcl/ecs 7.27.1-34480514651.commit-2778e4b → 7.27.1-34485770520.commit-5ec1a8a

package/dist/engine/lww-element-set-component-definition.js

@@ -201,12 +201,16 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
             return data.has(entity);
         },
         deleteFrom(entity, markAsDirty = true) {
+            // Presence, not truthiness: a component defined from a primitive schema can
+            // legitimately hold 0, false or an empty string, and deleting one must still
+            // return the value that was there.
+            const had = data.has(entity);
             const component = data.get(entity);
             if (data.delete(entity) && markAsDirty) {
                 dirtyIterator.add(entity);
             }
             lastSentData.delete(entity);
-            return component || null;
+            return had ? component : null;
         },
         entityDeleted(entity, markAsDirty) {
             if (data.delete(entity) && markAsDirty) {
@@ -215,19 +219,20 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
             lastSentData.delete(entity);
         },
         getOrNull(entity) {
-            const component = data.get(entity);
-            return component ? deepReadonly(component) : null;
+            // Presence, not truthiness: a component defined from a primitive schema
+            // can legitimately hold 0, false or an empty string.
+            if (!data.has(entity))
+                return null;
+            return deepReadonly(data.get(entity));
         },
         get(entity) {
-            const component = data.get(entity);
-            if (!component) {
+            if (!data.has(entity)) {
                 throw new Error(`[getFrom] Component ${componentName} for entity #${entity} not found`);
             }
-            return deepReadonly(component);
+            return deepReadonly(data.get(entity));
         },
         create(entity, value) {
-            const component = data.get(entity);
-            if (component) {
+            if (data.has(entity)) {
                 throw new Error(`[create] Component ${componentName} for ${entity} already exists`);
             }
             const usedValue = value === undefined ? schema.create() : schema.extend ? schema.extend(value) : value;
@@ -243,21 +248,22 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
             return usedValue;
         },
         getMutableOrNull(entity) {
-            const component = data.get(entity);
-            if (!component) {
+            // Presence, not truthiness, so a falsy primitive value is still mutable.
+            if (!data.has(entity)) {
                 return null;
             }
             dirtyIterator.add(entity);
-            return component;
+            return data.get(entity);
         },
         getOrCreateMutable(entity, value) {
-            const component = data.get(entity);
-            if (!component) {
+            // Presence, not truthiness: a stored 0/false/'' must not be treated as absent,
+            // which would send this through create() and throw "already exists".
+            if (!data.has(entity)) {
                 return this.create(entity, value);
             }
             else {
                 dirtyIterator.add(entity);
-                return component;
+                return data.get(entity);
             }
         },
         getMutable(entity) {

package/dist/engine/readonly.d.ts

@@ -16,7 +16,7 @@ export type DeepReadonlyObject<T> = {
 /**
  * @public
  */
-export type ReadonlyPrimitive = number | string | number[] | string[] | boolean | boolean[];
+export type ReadonlyPrimitive = number | string | boolean;
 /**
  * @public
  */

package/dist/engine/readonly.js

@@ -2,5 +2,15 @@
  * @internal
  */
 export function deepReadonly(val) {
+    // A component can be defined straight from a primitive or array schema, not
+    // only from a Map, which is why this is no longer constrained to an object.
+    // Spreading those threw the value away: a number came back as {}, an array
+    // as an object keyed by index.
+    if (val === null || typeof val !== 'object') {
+        return val;
+    }
+    if (Array.isArray(val)) {
+        return Object.freeze([...val]);
+    }
     return Object.freeze({ ...val });
 }

package/dist-cjs/engine/lww-element-set-component-definition.js

@@ -208,12 +208,16 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
             return data.has(entity);
         },
         deleteFrom(entity, markAsDirty = true) {
+            // Presence, not truthiness: a component defined from a primitive schema can
+            // legitimately hold 0, false or an empty string, and deleting one must still
+            // return the value that was there.
+            const had = data.has(entity);
             const component = data.get(entity);
             if (data.delete(entity) && markAsDirty) {
                 dirtyIterator.add(entity);
             }
             lastSentData.delete(entity);
-            return component || null;
+            return had ? component : null;
         },
         entityDeleted(entity, markAsDirty) {
             if (data.delete(entity) && markAsDirty) {
@@ -222,19 +226,20 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
             lastSentData.delete(entity);
         },
         getOrNull(entity) {
-            const component = data.get(entity);
-            return component ? (0, readonly_1.deepReadonly)(component) : null;
+            // Presence, not truthiness: a component defined from a primitive schema
+            // can legitimately hold 0, false or an empty string.
+            if (!data.has(entity))
+                return null;
+            return (0, readonly_1.deepReadonly)(data.get(entity));
         },
         get(entity) {
-            const component = data.get(entity);
-            if (!component) {
+            if (!data.has(entity)) {
                 throw new Error(`[getFrom] Component ${componentName} for entity #${entity} not found`);
             }
-            return (0, readonly_1.deepReadonly)(component);
+            return (0, readonly_1.deepReadonly)(data.get(entity));
         },
         create(entity, value) {
-            const component = data.get(entity);
-            if (component) {
+            if (data.has(entity)) {
                 throw new Error(`[create] Component ${componentName} for ${entity} already exists`);
             }
             const usedValue = value === undefined ? schema.create() : schema.extend ? schema.extend(value) : value;
@@ -250,21 +255,22 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
             return usedValue;
         },
         getMutableOrNull(entity) {
-            const component = data.get(entity);
-            if (!component) {
+            // Presence, not truthiness, so a falsy primitive value is still mutable.
+            if (!data.has(entity)) {
                 return null;
             }
             dirtyIterator.add(entity);
-            return component;
+            return data.get(entity);
         },
         getOrCreateMutable(entity, value) {
-            const component = data.get(entity);
-            if (!component) {
+            // Presence, not truthiness: a stored 0/false/'' must not be treated as absent,
+            // which would send this through create() and throw "already exists".
+            if (!data.has(entity)) {
                 return this.create(entity, value);
             }
             else {
                 dirtyIterator.add(entity);
-                return component;
+                return data.get(entity);
             }
         },
         getMutable(entity) {

package/dist-cjs/engine/readonly.d.ts

@@ -16,7 +16,7 @@ export type DeepReadonlyObject<T> = {
 /**
  * @public
  */
-export type ReadonlyPrimitive = number | string | number[] | string[] | boolean | boolean[];
+export type ReadonlyPrimitive = number | string | boolean;
 /**
  * @public
  */

package/dist-cjs/engine/readonly.js

@@ -5,6 +5,16 @@ exports.deepReadonly = void 0;
  * @internal
  */
 function deepReadonly(val) {
+    // A component can be defined straight from a primitive or array schema, not
+    // only from a Map, which is why this is no longer constrained to an object.
+    // Spreading those threw the value away: a number came back as {}, an array
+    // as an object keyed by index.
+    if (val === null || typeof val !== 'object') {
+        return val;
+    }
+    if (Array.isArray(val)) {
+        return Object.freeze([...val]);
+    }
     return Object.freeze({ ...val });
 }
 exports.deepReadonly = deepReadonly;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dcl/ecs",
   "description": "Decentraland ECS",
-  "version": "7.27.1-34480514651.commit-2778e4b",
+  "version": "7.27.1-34485770520.commit-5ec1a8a",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/ecs/issues",
   "files": [
@@ -34,5 +34,5 @@
   "dependencies": {},
   "types": "./dist/index.d.ts",
   "typings": "./dist/index.d.ts",
-  "commit": "2778e4bb891f1626a98380a8c906e5e793b74024"
+  "commit": "5ec1a8a1536e07acf2fb58bc8ddbac856c200794"
 }