@dcl/ecs 7.27.1-34244650155.commit-6b7c358 → 7.27.1-34408294078.commit-b42ad9d

package/dist/systems/cyclicParentingChecker.js

@@ -16,17 +16,22 @@ import * as components from '../components';
  */
 export function cyclicParentingChecker(engine) {
     const Transform = components.Transform(engine);
+    // Reused by every walk: the checker is synchronous, so only one is ever in
+    // flight. A cycle anywhere above the entity has to end the walk, not only one
+    // the entity is part of, otherwise the ancestors repeat forever.
+    const visited = new Set();
     return () => {
         for (const entity of Transform.dirtyIterator()) {
+            visited.clear();
+            visited.add(entity);
             let transform = Transform.getOrNull(entity);
             while (transform && transform.parent) {
-                if (transform.parent === entity) {
+                if (visited.has(transform.parent)) {
                     console.error(`There is a cyclic parent with entity ${entity}`);
                     break;
                 }
-                else {
-                    transform = Transform.getOrNull(transform.parent);
-                }
+                visited.add(transform.parent);
+                transform = Transform.getOrNull(transform.parent);
             }
         }
     };

package/dist-cjs/systems/cyclicParentingChecker.js

@@ -42,17 +42,22 @@ const components = __importStar(require("../components"));
  */
 function cyclicParentingChecker(engine) {
     const Transform = components.Transform(engine);
+    // Reused by every walk: the checker is synchronous, so only one is ever in
+    // flight. A cycle anywhere above the entity has to end the walk, not only one
+    // the entity is part of, otherwise the ancestors repeat forever.
+    const visited = new Set();
     return () => {
         for (const entity of Transform.dirtyIterator()) {
+            visited.clear();
+            visited.add(entity);
             let transform = Transform.getOrNull(entity);
             while (transform && transform.parent) {
-                if (transform.parent === entity) {
+                if (visited.has(transform.parent)) {
                     console.error(`There is a cyclic parent with entity ${entity}`);
                     break;
                 }
-                else {
-                    transform = Transform.getOrNull(transform.parent);
-                }
+                visited.add(transform.parent);
+                transform = Transform.getOrNull(transform.parent);
             }
         }
     };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dcl/ecs",
   "description": "Decentraland ECS",
-  "version": "7.27.1-34244650155.commit-6b7c358",
+  "version": "7.27.1-34408294078.commit-b42ad9d",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/ecs/issues",
   "files": [
@@ -34,5 +34,5 @@
   "dependencies": {},
   "types": "./dist/index.d.ts",
   "typings": "./dist/index.d.ts",
-  "commit": "6b7c3586376cb30b71f30104367f22ee9da49fe5"
+  "commit": "b42ad9d34df95c6eca43a979e5d2255114246548"
 }