@dcl/ecs 7.27.1-33752500148.commit-5ae3ef7 → 7.27.1-33755622021.commit-da82bfb

package/dist/composite/instance.js

@@ -56,7 +56,9 @@ export function getComponentDefinition(engine, component) {
  */
 export function getEntityMapping(engine, compositeEntity, mappedEntities, { entityMapping }) {
     const existingEntity = mappedEntities.get(compositeEntity);
-    if (existingEntity) {
+    // RootEntity is 0, so a mapping onto it is falsy. Testing the value here made
+    // an already-mapped entity look unmapped and allocated a second one.
+    if (existingEntity !== undefined) {
         return existingEntity;
     }
     if (entityMapping?.type === EntityMappingMode.EMM_DIRECT_MAPPING) {
@@ -93,7 +95,7 @@ export function instanceComposite(engine, compositeResource, compositeProvider,
     // First entity that I want to map, the root entity from the composite to the target entity in the engine
     // If there is no `rootEntity` passed, we assign one from `getNextAvailableEntity`
     const compositeRootEntity = rootEntity ?? getCompositeEntity(0);
-    if (rootEntity) {
+    if (rootEntity !== undefined) {
         mappedEntities.set(0, rootEntity);
     }
     // ## 2 ##

package/dist/schemas/Optional.js

@@ -4,7 +4,10 @@
 export const IOptional = (spec) => {
     return {
         serialize(value, builder) {
-            if (value) {
+            // Only the absence of a value means absent. Testing the value itself made
+            // `false`, `0` and `''` indistinguishable from unset, so they could never
+            // be written and came back as undefined.
+            if (value !== undefined && value !== null) {
                 builder.writeInt8(1);
                 spec.serialize(value, builder);
             }

package/dist-cjs/composite/instance.js

@@ -84,7 +84,9 @@ exports.getComponentDefinition = getComponentDefinition;
  */
 function getEntityMapping(engine, compositeEntity, mappedEntities, { entityMapping }) {
     const existingEntity = mappedEntities.get(compositeEntity);
-    if (existingEntity) {
+    // RootEntity is 0, so a mapping onto it is falsy. Testing the value here made
+    // an already-mapped entity look unmapped and allocated a second one.
+    if (existingEntity !== undefined) {
         return existingEntity;
     }
     if (entityMapping?.type === EntityMappingMode.EMM_DIRECT_MAPPING) {
@@ -122,7 +124,7 @@ function instanceComposite(engine, compositeResource, compositeProvider, options
     // First entity that I want to map, the root entity from the composite to the target entity in the engine
     // If there is no `rootEntity` passed, we assign one from `getNextAvailableEntity`
     const compositeRootEntity = rootEntity ?? getCompositeEntity(0);
-    if (rootEntity) {
+    if (rootEntity !== undefined) {
         mappedEntities.set(0, rootEntity);
     }
     // ## 2 ##

package/dist-cjs/schemas/Optional.js

@@ -7,7 +7,10 @@ exports.IOptional = void 0;
 const IOptional = (spec) => {
     return {
         serialize(value, builder) {
-            if (value) {
+            // Only the absence of a value means absent. Testing the value itself made
+            // `false`, `0` and `''` indistinguishable from unset, so they could never
+            // be written and came back as undefined.
+            if (value !== undefined && value !== null) {
                 builder.writeInt8(1);
                 spec.serialize(value, builder);
             }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dcl/ecs",
   "description": "Decentraland ECS",
-  "version": "7.27.1-33752500148.commit-5ae3ef7",
+  "version": "7.27.1-33755622021.commit-da82bfb",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/ecs/issues",
   "files": [
@@ -34,5 +34,5 @@
   "dependencies": {},
   "types": "./dist/index.d.ts",
   "typings": "./dist/index.d.ts",
-  "commit": "5ae3ef7c921887bc7c78d88284f22fc91b1be4d4"
+  "commit": "da82bfb0c7b437a9410e353b085ed08ad81aeff4"
 }