@dcl/ecs 7.22.2 → 7.22.3-23869239837.commit-39ea50a

package/dist/engine/lww-element-set-component-definition.d.ts

@@ -4,5 +4,5 @@ import { PutComponentMessageBody, DeleteComponentMessageBody, CrdtMessageBody }
 import { Entity } from './entity';
 export declare function incrementTimestamp(entity: Entity, timestamps: Map<Entity, number>): number;
 export declare function createDumpLwwFunctionFromCrdt(componentId: number, timestamps: Map<Entity, number>, schema: Pick<ISchema<any>, 'serialize' | 'deserialize'>, data: Map<Entity, unknown>): (buffer: ByteBuffer, filterEntity?: ((entity: Entity) => boolean) | undefined) => void;
-export declare function createUpdateLwwFromCrdt(componentId: number, timestamps: Map<Entity, number>, schema: Pick<ISchema<any>, 'serialize' | 'deserialize'>, data: Map<Entity, unknown>): (msg: CrdtMessageBody) => [null | PutComponentMessageBody | DeleteComponentMessageBody, any];
-export declare function createGetCrdtMessagesForLww(componentId: number, timestamps: Map<Entity, number>, dirtyIterator: Set<Entity>, schema: Pick<ISchema<any>, 'serialize'>, data: Map<Entity, unknown>): () => Generator<PutComponentMessageBody | DeleteComponentMessageBody, void, unknown>;
+export declare function createUpdateLwwFromCrdt(componentId: number, timestamps: Map<Entity, number>, schema: Pick<ISchema<any>, 'serialize' | 'deserialize'>, data: Map<Entity, unknown>, lastSentData: Map<Entity, Uint8Array>): (msg: CrdtMessageBody) => [null | PutComponentMessageBody | DeleteComponentMessageBody, any];
+export declare function createGetCrdtMessagesForLww(componentId: number, timestamps: Map<Entity, number>, dirtyIterator: Set<Entity>, schema: Pick<ISchema<any>, 'serialize'>, data: Map<Entity, unknown>, lastSentData: Map<Entity, Uint8Array>): () => Generator<PutComponentMessageBody | DeleteComponentMessageBody, void, unknown>;

package/dist/engine/lww-element-set-component-definition.js

@@ -30,7 +30,7 @@ export function createDumpLwwFunctionFromCrdt(componentId, timestamps, schema, d
         }
     };
 }
-export function createUpdateLwwFromCrdt(componentId, timestamps, schema, data) {
+export function createUpdateLwwFromCrdt(componentId, timestamps, schema, data, lastSentData) {
     /**
      * Process the received message only if the lamport number recieved is higher
      * than the stored one. If its lower, we spread it to the network to correct the peer.
@@ -96,9 +96,11 @@ export function createUpdateLwwFromCrdt(componentId, timestamps, schema, data) {
                 if (msg.type === CrdtMessageType.PUT_COMPONENT || msg.type === CrdtMessageType.PUT_COMPONENT_NETWORK) {
                     const buf = new ReadWriteByteBuffer(msg.data);
                     data.set(entity, schema.deserialize(buf));
+                    lastSentData.set(entity, new Uint8Array(msg.data));
                 }
                 else {
                     data.delete(entity);
+                    lastSentData.delete(entity);
                 }
                 return [null, data.get(entity)];
             }
@@ -134,23 +136,34 @@ export function createUpdateLwwFromCrdt(componentId, timestamps, schema, data) {
         return [null, data.get(entity)];
     };
 }
-export function createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data) {
+export function createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data, lastSentData) {
     return function* () {
+        const writeBuffer = new ReadWriteByteBuffer();
         for (const entity of dirtyIterator) {
-            const newTimestamp = incrementTimestamp(entity, timestamps);
             if (data.has(entity)) {
-                const writeBuffer = new ReadWriteByteBuffer();
+                writeBuffer.resetBuffer();
                 schema.serialize(data.get(entity), writeBuffer);
+                // Compare against last-sent snapshot using the zero-copy subarray view.
+                // Only allocate a copy when bytes actually differ.
+                const previousBytes = lastSentData.get(entity);
+                if (previousBytes && dataCompare(writeBuffer.toBinary(), previousBytes) === 0) {
+                    continue;
+                }
+                const currentBytes = writeBuffer.toCopiedBinary();
+                const newTimestamp = incrementTimestamp(entity, timestamps);
+                lastSentData.set(entity, currentBytes);
                 const msg = {
                     type: CrdtMessageType.PUT_COMPONENT,
                     componentId,
                     entityId: entity,
-                    data: writeBuffer.toBinary(),
+                    data: currentBytes,
                     timestamp: newTimestamp
                 };
                 yield msg;
             }
             else {
+                lastSentData.delete(entity);
+                const newTimestamp = incrementTimestamp(entity, timestamps);
                 const msg = {
                     type: CrdtMessageType.DELETE_COMPONENT,
                     componentId,
@@ -170,6 +183,7 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
     const data = new Map();
     const dirtyIterator = new Set();
     const timestamps = new Map();
+    const lastSentData = new Map();
     const onChangeCallbacks = new Map();
     return {
         get componentId() {
@@ -191,12 +205,14 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
             if (data.delete(entity) && markAsDirty) {
                 dirtyIterator.add(entity);
             }
+            lastSentData.delete(entity);
             return component || null;
         },
         entityDeleted(entity, markAsDirty) {
             if (data.delete(entity) && markAsDirty) {
                 dirtyIterator.add(entity);
             }
+            lastSentData.delete(entity);
         },
         getOrNull(entity) {
             const component = data.get(entity);
@@ -223,6 +239,7 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
             const usedValue = value === undefined ? schema.create() : schema.extend ? schema.extend(value) : value;
             data.set(entity, usedValue);
             dirtyIterator.add(entity);
+            lastSentData.delete(entity);
             return usedValue;
         },
         getMutableOrNull(entity) {
@@ -260,8 +277,8 @@ export function createComponentDefinitionFromSchema(componentName, componentId,
                 yield entity;
             }
         },
-        getCrdtUpdates: createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data),
-        updateFromCrdt: createUpdateLwwFromCrdt(componentId, timestamps, schema, data),
+        getCrdtUpdates: createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data, lastSentData),
+        updateFromCrdt: createUpdateLwwFromCrdt(componentId, timestamps, schema, data, lastSentData),
         dumpCrdtStateToBuffer: createDumpLwwFunctionFromCrdt(componentId, timestamps, schema, data),
         onChange(entity, cb) {
             const cbs = onChangeCallbacks.get(entity) ?? [];

package/dist-cjs/engine/lww-element-set-component-definition.d.ts

@@ -4,5 +4,5 @@ import { PutComponentMessageBody, DeleteComponentMessageBody, CrdtMessageBody }
 import { Entity } from './entity';
 export declare function incrementTimestamp(entity: Entity, timestamps: Map<Entity, number>): number;
 export declare function createDumpLwwFunctionFromCrdt(componentId: number, timestamps: Map<Entity, number>, schema: Pick<ISchema<any>, 'serialize' | 'deserialize'>, data: Map<Entity, unknown>): (buffer: ByteBuffer, filterEntity?: ((entity: Entity) => boolean) | undefined) => void;
-export declare function createUpdateLwwFromCrdt(componentId: number, timestamps: Map<Entity, number>, schema: Pick<ISchema<any>, 'serialize' | 'deserialize'>, data: Map<Entity, unknown>): (msg: CrdtMessageBody) => [null | PutComponentMessageBody | DeleteComponentMessageBody, any];
-export declare function createGetCrdtMessagesForLww(componentId: number, timestamps: Map<Entity, number>, dirtyIterator: Set<Entity>, schema: Pick<ISchema<any>, 'serialize'>, data: Map<Entity, unknown>): () => Generator<PutComponentMessageBody | DeleteComponentMessageBody, void, unknown>;
+export declare function createUpdateLwwFromCrdt(componentId: number, timestamps: Map<Entity, number>, schema: Pick<ISchema<any>, 'serialize' | 'deserialize'>, data: Map<Entity, unknown>, lastSentData: Map<Entity, Uint8Array>): (msg: CrdtMessageBody) => [null | PutComponentMessageBody | DeleteComponentMessageBody, any];
+export declare function createGetCrdtMessagesForLww(componentId: number, timestamps: Map<Entity, number>, dirtyIterator: Set<Entity>, schema: Pick<ISchema<any>, 'serialize'>, data: Map<Entity, unknown>, lastSentData: Map<Entity, Uint8Array>): () => Generator<PutComponentMessageBody | DeleteComponentMessageBody, void, unknown>;

package/dist-cjs/engine/lww-element-set-component-definition.js

@@ -35,7 +35,7 @@ function createDumpLwwFunctionFromCrdt(componentId, timestamps, schema, data) {
     };
 }
 exports.createDumpLwwFunctionFromCrdt = createDumpLwwFunctionFromCrdt;
-function createUpdateLwwFromCrdt(componentId, timestamps, schema, data) {
+function createUpdateLwwFromCrdt(componentId, timestamps, schema, data, lastSentData) {
     /**
      * Process the received message only if the lamport number recieved is higher
      * than the stored one. If its lower, we spread it to the network to correct the peer.
@@ -101,9 +101,11 @@ function createUpdateLwwFromCrdt(componentId, timestamps, schema, data) {
                 if (msg.type === crdt_1.CrdtMessageType.PUT_COMPONENT || msg.type === crdt_1.CrdtMessageType.PUT_COMPONENT_NETWORK) {
                     const buf = new ByteBuffer_1.ReadWriteByteBuffer(msg.data);
                     data.set(entity, schema.deserialize(buf));
+                    lastSentData.set(entity, new Uint8Array(msg.data));
                 }
                 else {
                     data.delete(entity);
+                    lastSentData.delete(entity);
                 }
                 return [null, data.get(entity)];
             }
@@ -140,23 +142,34 @@ function createUpdateLwwFromCrdt(componentId, timestamps, schema, data) {
     };
 }
 exports.createUpdateLwwFromCrdt = createUpdateLwwFromCrdt;
-function createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data) {
+function createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data, lastSentData) {
     return function* () {
+        const writeBuffer = new ByteBuffer_1.ReadWriteByteBuffer();
         for (const entity of dirtyIterator) {
-            const newTimestamp = incrementTimestamp(entity, timestamps);
             if (data.has(entity)) {
-                const writeBuffer = new ByteBuffer_1.ReadWriteByteBuffer();
+                writeBuffer.resetBuffer();
                 schema.serialize(data.get(entity), writeBuffer);
+                // Compare against last-sent snapshot using the zero-copy subarray view.
+                // Only allocate a copy when bytes actually differ.
+                const previousBytes = lastSentData.get(entity);
+                if (previousBytes && (0, utils_1.dataCompare)(writeBuffer.toBinary(), previousBytes) === 0) {
+                    continue;
+                }
+                const currentBytes = writeBuffer.toCopiedBinary();
+                const newTimestamp = incrementTimestamp(entity, timestamps);
+                lastSentData.set(entity, currentBytes);
                 const msg = {
                     type: crdt_1.CrdtMessageType.PUT_COMPONENT,
                     componentId,
                     entityId: entity,
-                    data: writeBuffer.toBinary(),
+                    data: currentBytes,
                     timestamp: newTimestamp
                 };
                 yield msg;
             }
             else {
+                lastSentData.delete(entity);
+                const newTimestamp = incrementTimestamp(entity, timestamps);
                 const msg = {
                     type: crdt_1.CrdtMessageType.DELETE_COMPONENT,
                     componentId,
@@ -177,6 +190,7 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
     const data = new Map();
     const dirtyIterator = new Set();
     const timestamps = new Map();
+    const lastSentData = new Map();
     const onChangeCallbacks = new Map();
     return {
         get componentId() {
@@ -198,12 +212,14 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
             if (data.delete(entity) && markAsDirty) {
                 dirtyIterator.add(entity);
             }
+            lastSentData.delete(entity);
             return component || null;
         },
         entityDeleted(entity, markAsDirty) {
             if (data.delete(entity) && markAsDirty) {
                 dirtyIterator.add(entity);
             }
+            lastSentData.delete(entity);
         },
         getOrNull(entity) {
             const component = data.get(entity);
@@ -230,6 +246,7 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
             const usedValue = value === undefined ? schema.create() : schema.extend ? schema.extend(value) : value;
             data.set(entity, usedValue);
             dirtyIterator.add(entity);
+            lastSentData.delete(entity);
             return usedValue;
         },
         getMutableOrNull(entity) {
@@ -267,8 +284,8 @@ function createComponentDefinitionFromSchema(componentName, componentId, schema)
                 yield entity;
             }
         },
-        getCrdtUpdates: createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data),
-        updateFromCrdt: createUpdateLwwFromCrdt(componentId, timestamps, schema, data),
+        getCrdtUpdates: createGetCrdtMessagesForLww(componentId, timestamps, dirtyIterator, schema, data, lastSentData),
+        updateFromCrdt: createUpdateLwwFromCrdt(componentId, timestamps, schema, data, lastSentData),
         dumpCrdtStateToBuffer: createDumpLwwFunctionFromCrdt(componentId, timestamps, schema, data),
         onChange(entity, cb) {
             const cbs = onChangeCallbacks.get(entity) ?? [];

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dcl/ecs",
   "description": "Decentraland ECS",
-  "version": "7.22.2",
+  "version": "7.22.3-23869239837.commit-39ea50a",
   "author": "DCL",
   "bugs": "https://github.com/decentraland/ecs/issues",
   "files": [
@@ -34,5 +34,5 @@
   "dependencies": {},
   "types": "./dist/index.d.ts",
   "typings": "./dist/index.d.ts",
-  "commit": "5f7f8a09410c9cb0e2e0e0d669dfc3733e76a8e8"
+  "commit": "39ea50ab3f0b3b45ee9c369a5d76b83e2d597590"
 }