@dcl/ecs 7.0.3-3583938384.commit-827bc9a → 7.0.3-3584900424.commit-d08747d

package/README.md

@@ -8,18 +8,3 @@ Run `make build`
 
 ## Testing
 Run `make test`, you can also debug the test in VS code, selecting the launch `Jest current file` or just `Jest` (this will run all test)
-
-## Wishlist
-Use this project as template for TypeScript libraries
-- [x] as any MutableGroupOf
-- [x] Tests for system
-- [ ] Basic Components ( Transform ) w/Tests
-- [ ] Sync Component W/Tests
-- [x] CRDT System
-- [ ] Kindof Scene Tests. Component & Systems. Maybe physics system? SolarSystem
-- [ ] Integration with old ecs ( CRDT/Door Scene )
-- [ ] RPC Transport. JSON { entityId, componentId, data: } vs Protocol Buffers
-- [ ] EntityID generator
-- [ ] Static vs Dynamic entities.
-- [ ] Sync Components ?
-- [ ] Where the state lives ? State cross realms/islands ? StateFull questions. StorableComponent ?

package/dist/engine/entity-utils.d.ts

@@ -11,7 +11,6 @@ export declare namespace EntityUtils {
     const RESERVED_ENTITIES_RANGE: EntityRange;
     const STATIC_ENTITIES_RANGE: EntityRange;
     const DYNAMIC_ENTITIES_RANGE: EntityRange;
-    function isDynamicEntity(entity: Entity): boolean;
     function isStaticEntity(entity: Entity): boolean;
     function isReservedEntity(entity: Entity): boolean;
 }

package/dist/engine/entity-utils.js

@@ -9,7 +9,8 @@ export var EntityUtils;
     ];
     EntityUtils.STATIC_ENTITIES_RANGE = [
         EntityUtils.RESERVED_STATIC_ENTITIES,
-        EntityUtils.DYNAMIC_ENTITIES_START_AT - 1
+        EntityUtils.MAX_ENTITIES
+        // DYNAMIC_ENTITIES_START_AT - 1
     ];
     EntityUtils.DYNAMIC_ENTITIES_RANGE = [
         EntityUtils.DYNAMIC_ENTITIES_START_AT,
@@ -18,6 +19,7 @@ export var EntityUtils;
     function isInRange(entity, range) {
         return entity >= range[0] && entity <= range[1];
     }
+    // @internal
     function isDynamicEntity(entity) {
         return isInRange(entity, EntityUtils.DYNAMIC_ENTITIES_RANGE);
     }

package/dist/engine/entity.js

@@ -4,7 +4,11 @@ export function EntityContainer() {
     const dynamicEntity = Entity(EntityUtils.DYNAMIC_ENTITIES_RANGE);
     return {
         generateEntity(dynamic = false) {
+            /* istanbul ignore next */
             if (dynamic) {
+                // Dynamic entities are not being used, but since we dont know the future of the dynamic entities
+                // I prefer to comment the code instead of removing all the logic
+                /* istanbul ignore next */
                 return dynamicEntity.generateEntity();
             }
             else {

package/dist/engine/index.js

@@ -5,6 +5,7 @@ import { defineComponent as defComponent } from './component';
 import { EntityContainer } from './entity';
 import { SystemContainer, SYSTEMS_REGULAR_PRIORITY } from './systems';
 export * from './input';
+import { checkNotThenable } from '../runtime/invariant';
 export * from './readonly';
 export * from './types';
 function preEngine() {
@@ -17,17 +18,13 @@ function preEngine() {
     function removeSystem(selector) {
         return systems.remove(selector);
     }
-    function addEntity(dynamic = false) {
-        // entitiesCompnonent.set(entity, new Set())
-        const entity = entityContainer.generateEntity(dynamic);
+    function addEntity() {
+        const entity = entityContainer.generateEntity();
         return entity;
     }
     function entityExists(entity) {
         return entityContainer.entityExists(entity);
     }
-    function addDynamicEntity() {
-        return addEntity(true);
-    }
     function removeEntity(entity) {
         for (const [, component] of componentsDefinition) {
             if (component.has(entity)) {
@@ -91,7 +88,6 @@ function preEngine() {
         entityExists,
         componentsDefinition,
         addEntity,
-        addDynamicEntity,
         removeEntity,
         addSystem,
         getSystems,
@@ -114,11 +110,7 @@ export function Engine() {
         crdtSystem.receiveMessages();
         for (const system of engine.getSystems()) {
             const ret = system.fn(dt);
-            if (globalThis.DEBUG) {
-                if (ret && typeof ret === 'object' && typeof ret.then === 'function') {
-                    throw new Error(`A system (${system.name || 'anonymous'}) returned a thenable. Systems cannot be async functions. Documentation: https://dcl.gg/sdk/sync-systems`);
-                }
-            }
+            checkNotThenable(ret, `A system (${system.name || 'anonymous'}) returned a thenable. Systems cannot be async functions. Documentation: https://dcl.gg/sdk/sync-systems`);
         }
         // TODO: Perf tip
         // Should we add some dirtyIteratorSet at engine level so we dont have
@@ -157,12 +149,10 @@ export function Engine() {
     }
     return {
         addEntity: engine.addEntity,
-        addDynamicEntity: engine.addDynamicEntity,
         removeEntity: engine.removeEntity,
         removeEntityWithChildren,
         addSystem: engine.addSystem,
         removeSystem: engine.removeSystem,
-        // TODO: fix this type
         defineComponent: engine.defineComponent,
         defineComponentFromSchema: engine.defineComponentFromSchema,
         getEntitiesWith: engine.getEntitiesWith,

package/dist/engine/types.d.ts

@@ -26,10 +26,6 @@ export declare type IEngine = {
      * @returns the next entity unused
      */
     addEntity(dynamic?: boolean): Entity;
-    /**
-     * An alias of engine.addEntity(true)
-     */
-    addDynamicEntity(): Entity;
     /**
      * Remove all components of an entity
      * @param entity - entity

package/dist/runtime/invariant.d.ts

@@ -1 +1,3 @@
-export declare function checkNotThenable<T>(t: T, error: string): T;
+declare type K = unknown | Promise<unknown>;
+export declare function checkNotThenable<T extends K>(t: T, error: string): T;
+export {};

package/dist/runtime/invariant.js

@@ -1,6 +1,8 @@
 export function checkNotThenable(t, error) {
     if (globalThis.DEBUG) {
-        if (t && typeof t === 'object' && typeof t.then === 'function') {
+        if (t &&
+            typeof t === 'object' &&
+            typeof t.then === 'function') {
             throw new Error(error);
         }
     }

package/dist/schemas/Map.js

@@ -5,14 +5,12 @@ export function IMap(spec) {
     return {
         serialize(value, builder) {
             for (const key in spec) {
-                // TODO: as any
                 spec[key].serialize(value[key], builder);
             }
         },
         deserialize(reader) {
             const newValue = {};
             for (const key in spec) {
-                // TODO: as any
                 ;
                 newValue[key] = spec[key].deserialize(reader);
             }
@@ -21,7 +19,6 @@ export function IMap(spec) {
         create() {
             const newValue = {};
             for (const key in spec) {
-                // TODO: as any
                 ;
                 newValue[key] = spec[key].create();
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dcl/ecs",
-  "version": "7.0.3-3583938384.commit-827bc9a",
+  "version": "7.0.3-3584900424.commit-d08747d",
   "description": "Decentraland ECS",
   "main": "./dist/index.js",
   "typings": "./dist/index.d.ts",
@@ -35,5 +35,5 @@
     "dist",
     "etc"
   ],
-  "commit": "827bc9acb5825d817445521eb790ee256788a01c"
+  "commit": "d08747dea26ba46738fda26e28689bbc03603b71"
 }