@dcl-regenesislabs/opendcl 0.1.4-22555336781.commit-12e2bc1 → 0.1.4-22626562583.commit-09a1d03

package/README.md

@@ -32,7 +32,7 @@ The result: **more creators building more scenes, faster.**
 - **Integrated commands** — `/init` to scaffold, `/preview` to launch the dev server, `/tasks` to manage running processes, `/review` to audit code
 - **TypeScript validation** — catches type errors immediately after writing code
 - **Free asset catalogs** — 2,700+ Creator Hub 3D models, 900+ CC0-licensed models, and 50 audio files the agent proactively suggests when building scenes
-- **Permission gate** — prompts for confirmation before destructive bash commands or writes to sensitive files
+- **Permission gate** — prompts for confirmation before destructive bash commands, writes to sensitive files, or any file access outside the working directory
 - **Compact tool output** — write shows path + size instead of file content, read shows a 5-line preview instead of 10
 - **Session persistence** — pick up where you left off across sessions
 

package/extensions/permissions/index.ts

@@ -7,25 +7,53 @@
  */
 
 import type { ExtensionFactory } from "@mariozechner/pi-coding-agent";
-import { classifyBashCommand, classifyFilePath } from "./utils.js";
+import { classifyBashCommand, classifyFilePath, isOutsideCwd, OUTSIDE_CWD_REASON } from "./utils.js";
+import { resolve } from "node:path";
 
-function blockResult(reason: string, detail: string): { block: true; reason: string } {
+type BlockResult = { block: true; reason: string };
+
+function blockResult(reason: string, detail: string): BlockResult {
   return {
     block: true,
     reason: `Blocked: ${reason}\n${detail}\nUse --no-permissions to allow in non-interactive mode.`,
   };
 }
 
-function denyResult(reason: string): { block: true; reason: string } {
+function denyResult(reason: string): BlockResult {
   return { block: true, reason: `User denied: ${reason}` };
 }
 
-const ALLOW = "Allow";
-const ALWAYS = "Always allow";
-const DENY = "Deny";
+const CHOICES = ["Allow", "Always allow", "Deny"] as const;
 
 const extension: ExtensionFactory = (pi) => {
   const sessionAllow = new Set<string>();
+  const allowedPaths = new Set<string>();
+
+  function isPathAllowed(resolvedPath: string): boolean {
+    for (const allowed of allowedPaths) {
+      if (resolvedPath === allowed || resolvedPath.startsWith(allowed + "/")) return true;
+    }
+    return false;
+  }
+
+  /**
+   * Prompts the user for confirmation and handles their choice.
+   * Returns a BlockResult to deny, or undefined to allow.
+   */
+  async function promptOrBlock(
+    ctx: { hasUI: boolean; ui: { select: (title: string, options: string[]) => Promise<string | null> } },
+    reason: string,
+    detail: string,
+    onAlways: () => void,
+  ): Promise<BlockResult | undefined> {
+    if (!ctx.hasUI) return blockResult(reason, detail);
+
+    const choice = await ctx.ui.select(`${reason}\n${detail}`, [...CHOICES]);
+
+    if (choice === "Always allow") { onAlways(); return; }
+    if (choice === "Allow") return;
+    return denyResult(reason);
+  }
 
   pi.registerFlag("no-permissions", {
     description: "Disable permission gate (skip confirmation prompts for dangerous operations)",
@@ -43,33 +71,36 @@ const extension: ExtensionFactory = (pi) => {
       const reason = classifyBashCommand(command);
       if (!reason || sessionAllow.has(reason)) return;
 
-      if (!ctx.hasUI) return blockResult(reason, `Command: ${command}`);
-
-      const choice = await ctx.ui.select(
-        `${reason}\nCommand: ${command}`,
-        [ALLOW, ALWAYS, DENY],
-      );
-
-      if (choice === ALWAYS) { sessionAllow.add(reason); return; }
-      if (choice === ALLOW) return;
-      return denyResult(reason);
+      return promptOrBlock(ctx, reason, `Command: ${command}`, () => sessionAllow.add(reason));
     }
 
     if (toolName === "write" || toolName === "edit") {
       const filePath = (event.input as { path?: string }).path ?? "";
       const reason = filePath ? classifyFilePath(filePath, ctx.cwd) : null;
-      if (!reason || sessionAllow.has(reason)) return;
+      if (!reason) return;
 
-      if (!ctx.hasUI) return blockResult(reason, `Path: ${filePath}`);
+      if (reason === OUTSIDE_CWD_REASON) {
+        const resolved = resolve(ctx.cwd, filePath);
+        if (isPathAllowed(resolved)) return;
+
+        return promptOrBlock(ctx, reason, `File: ${filePath}`, () => allowedPaths.add(resolved));
+      }
+
+      if (sessionAllow.has(reason)) return;
+
+      return promptOrBlock(ctx, reason, `Path: ${filePath}`, () => sessionAllow.add(reason));
+    }
+
+    if (toolName === "read" || toolName === "grep" || toolName === "find" || toolName === "ls") {
+      const filePath = (event.input as { path?: string }).path ?? "";
+      if (!filePath) return;
 
-      const choice = await ctx.ui.select(
-        `${reason}\nFile: ${filePath}`,
-        [ALLOW, ALWAYS, DENY],
-      );
+      const resolved = resolve(ctx.cwd, filePath);
+      const reason = isOutsideCwd(filePath, ctx.cwd);
+      if (!reason) return;
+      if (isPathAllowed(resolved)) return;
 
-      if (choice === ALWAYS) { sessionAllow.add(reason); return; }
-      if (choice === ALLOW) return;
-      return denyResult(reason);
+      return promptOrBlock(ctx, reason, `Path: ${filePath}`, () => allowedPaths.add(resolved));
     }
   });
 };

package/extensions/permissions/utils.ts

@@ -5,6 +5,8 @@
 
 import { resolve, relative } from "node:path";
 
+export const OUTSIDE_CWD_REASON = "Accesses path outside working directory";
+
 interface DenylistEntry {
   pattern: RegExp;
   reason: string;
@@ -75,8 +77,20 @@ export function classifyFilePath(filePath: string, projectRoot: string): string
   const rel = relative(projectRoot, resolved);
 
   if (rel.startsWith("..")) {
-    return "File is outside the project root";
+    return OUTSIDE_CWD_REASON;
   }
 
   return findMatchingReason(SENSITIVE_FILE_PATTERNS, filePath);
 }
+
+/**
+ * Returns a reason string if the file path resolves outside the given cwd,
+ * or null if inside (or empty).
+ */
+export function isOutsideCwd(filePath: string, cwd: string): string | null {
+  if (!filePath) return null;
+  const resolved = resolve(cwd, filePath);
+  const rel = relative(cwd, resolved);
+  if (rel.startsWith("..")) return OUTSIDE_CWD_REASON;
+  return null;
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dcl-regenesislabs/opendcl",
-  "version": "0.1.4-22555336781.commit-12e2bc1",
+  "version": "0.1.4-22626562583.commit-09a1d03",
   "description": "AI coding assistant for Decentraland SDK7 scene development",
   "type": "module",
   "bin": {
@@ -66,5 +66,5 @@
     "prompts/",
     "context/"
   ],
-  "commit": "12e2bc1a70db6216feafebf6564faa40515c72c0"
+  "commit": "09a1d037c3a42a9041ce7baccd6d22411cb365ed"
 }