@dboio/cli 0.15.0 → 0.15.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dboio/cli",
-  "version": "0.15.0",
+  "version": "0.15.1",
   "description": "CLI for the DBO.io framework",
   "type": "module",
   "bin": {

package/src/commands/push.js

@@ -20,7 +20,7 @@ import { BINS_DIR, ENTITY_DIR_NAMES, loadStructureFile, findBinByPath } from '..
 import { ensureTrashIcon, setFileTag } from '../lib/tagging.js';
 import { checkToeStepping } from '../lib/toe-stepping.js';
 import { runPendingMigrations } from '../lib/migrations.js';
-import { findUnaddedFiles, detectBinFile, submitAdd } from './add.js';
+// AUTO-ADD DISABLED: import { findUnaddedFiles, detectBinFile, submitAdd } from './add.js';
 
 function _getMetaCompanionPaths(meta, metaPath) {
   const dir = dirname(metaPath);
@@ -96,7 +96,7 @@ export const pushCommand = new Command('push')
       const transactionKey = await resolveTransactionKey(options);
 
       // Process pending deletions from synchronize.json
-      await processPendingDeletes(client, options, modifyKey, transactionKey);
+      const deletedCount = await processPendingDeletes(client, options, modifyKey, transactionKey) || 0;
 
       // ── Resolution order ──────────────────────────────────────────
       // 1. Commas → UID list
@@ -135,7 +135,7 @@ export const pushCommand = new Command('push')
             log.dim(`  Found: ${relative(process.cwd(), resolved)}`);
             const resolvedStat = await stat(resolved);
             if (resolvedStat.isDirectory()) {
-              await pushDirectory(resolved, client, options, modifyKey, transactionKey);
+              await pushDirectory(resolved, client, options, modifyKey, transactionKey, deletedCount);
             } else {
               await pushSingleFile(resolved, client, options, modifyKey, transactionKey);
             }
@@ -156,7 +156,7 @@ export const pushCommand = new Command('push')
       }
 
       if (pathStat.isDirectory()) {
-        await pushDirectory(targetPath, client, options, modifyKey, transactionKey);
+        await pushDirectory(targetPath, client, options, modifyKey, transactionKey, deletedCount);
       } else {
         await pushSingleFile(targetPath, client, options, modifyKey, transactionKey);
       }
@@ -171,18 +171,27 @@ export const pushCommand = new Command('push')
  */
 async function processPendingDeletes(client, options, modifyKey = null, transactionKey = 'RowUID') {
   const sync = await loadSynchronize();
-  if (!sync.delete || sync.delete.length === 0) return;
+  if (!sync.delete || sync.delete.length === 0) return 0;
 
   log.info(`Processing ${sync.delete.length} pending deletion(s)...`);
 
   const remaining = [];
   const deletedUids = [];
 
+  // Load stored ticket once for all deletions (same as main push loop)
+  const { getGlobalTicket, getRecordTicket } = await import('../lib/ticketing.js');
+  const globalTicket = !options.ticket ? await getGlobalTicket() : null;
+
   for (const entry of sync.delete) {
     log.info(`Deleting "${entry.name}" (${entry.entity}:${entry.RowID})`);
 
     const extraParams = { '_confirm': options.confirm || 'true' };
-    if (options.ticket) extraParams['_OverrideTicketID'] = options.ticket;
+    if (options.ticket) {
+      extraParams['_OverrideTicketID'] = options.ticket;
+    } else {
+      const ticket = await getRecordTicket(entry.UID) || globalTicket;
+      if (ticket) extraParams['_OverrideTicketID'] = ticket;
+    }
     if (modifyKey) extraParams['_modify_key'] = modifyKey;
     const cachedUser2 = getSessionUserOverride();
     if (cachedUser2) extraParams['_OverrideUserID'] = cachedUser2;
@@ -244,6 +253,8 @@ async function processPendingDeletes(client, options, modifyKey = null, transact
   if (remaining.length > 0) {
     log.warn(`${remaining.length} deletion(s) failed and remain staged.`);
   }
+
+  return deletedUids.length;
 }
 
 /**
@@ -343,27 +354,12 @@ async function pushSingleFile(filePath, client, options, modifyKey = null, trans
       try { meta = JSON.parse(await readFile(metaPath, 'utf8')); } catch {}
     }
     if (!meta) {
-      // Try auto-detecting as a bin content/media file and add it first
-      const binMeta = await detectBinFile(filePath);
-      if (binMeta) {
-        log.info(`No metadata found — auto-adding "${basename(filePath)}" first`);
-        try {
-          await submitAdd(binMeta.meta, binMeta.metaPath, filePath, client, options);
-          // After successful add, re-read the metadata (now has UID)
-          metaPath = binMeta.metaPath;
-          // The metadata file may have been renamed with ~UID, so scan for it
-          const updatedMeta = await findMetadataForCompanion(filePath);
-          if (updatedMeta) metaPath = updatedMeta;
-          meta = JSON.parse(await readFile(metaPath, 'utf8'));
-          log.info(`Successfully added — now pushing updates`);
-        } catch (err) {
-          log.error(`Auto-add failed for "${basename(filePath)}": ${err.message}`);
-          process.exit(1);
-        }
-      } else {
-        log.error(`No metadata found for "${basename(filePath)}". Pull the record first with "dbo pull".`);
-        process.exit(1);
-      }
+      // AUTO-ADD DISABLED: local-file-first approach is being replaced by server-first workflow.
+      // New records should be created via the DBO REST API first, then `dbo pull` to populate locally.
+      // The auto-add code (detectBinFile + submitAdd) has been commented out intentionally.
+      // See: .claude/2_specs/auto-deploy-config-generation.md — "server-first approach"
+      log.error(`No metadata found for "${basename(filePath)}". Create the record on the server first, then run "dbo pull".`);
+      process.exit(1);
     }
   }
 
@@ -473,61 +469,16 @@ async function ensureManifestMetadata() {
 /**
  * Push all records found in a directory (recursive)
  */
-async function pushDirectory(dirPath, client, options, modifyKey = null, transactionKey = 'RowUID') {
+async function pushDirectory(dirPath, client, options, modifyKey = null, transactionKey = 'RowUID', deletedCount = 0) {
   // Auto-create manifest.metadata.json if manifest.json exists at root without companion metadata
   await ensureManifestMetadata();
 
-  // ── Auto-add: detect un-added files and create+submit them before push ──
-  const ig = await loadIgnore();
-  const justAddedUIDs = new Set(); // Track UIDs added in this invocation — skip from push loop
-
-  const unadded = await findUnaddedFiles(dirPath, ig);
-  if (unadded.length > 0) {
-    // Filter to files that detectBinFile can auto-classify (content/media in bins)
-    const autoAddable = [];
-    for (const filePath of unadded) {
-      const binMeta = await detectBinFile(filePath);
-      if (binMeta) autoAddable.push({ filePath, ...binMeta });
-    }
-
-    if (autoAddable.length > 0) {
-      log.info(`Found ${autoAddable.length} new file(s) to add before push:`);
-      for (const { filePath } of autoAddable) {
-        log.plain(`  ${relative(process.cwd(), filePath)}`);
-      }
-
-      const doAdd = async () => {
-        for (const { meta, metaPath, filePath } of autoAddable) {
-          try {
-            await submitAdd(meta, metaPath, filePath, client, options);
-            // After submitAdd, meta.UID is set if successful
-            if (meta.UID) justAddedUIDs.add(meta.UID);
-          } catch (err) {
-            log.error(`Failed to add ${relative(process.cwd(), filePath)}: ${err.message}`);
-          }
-        }
-      };
-
-      if (!options.yes) {
-        const inquirer = (await import('inquirer')).default;
-        const { proceed } = await inquirer.prompt([{
-          type: 'confirm',
-          name: 'proceed',
-          message: `Add ${autoAddable.length} file(s) to the server before pushing?`,
-          default: true,
-        }]);
-        if (!proceed) {
-          log.dim('Skipping auto-add — continuing with push');
-        } else {
-          await doAdd();
-        }
-      } else {
-        await doAdd();
-      }
-      if (justAddedUIDs.size > 0) log.plain('');
-    }
-  }
+  // AUTO-ADD DISABLED: local-file-first approach is being replaced by server-first workflow.
+  // New records should be created via the DBO REST API first, then `dbo pull` to populate locally.
+  // The auto-add code (findUnaddedFiles + detectBinFile + submitAdd) has been commented out.
+  // See: .claude/2_specs/auto-deploy-config-generation.md — "server-first approach"
 
+  const ig = await loadIgnore();
   const metaFiles = await findMetadataFiles(dirPath, ig);
 
   // ── Load scripts config early (before delta detection) ──────────────
@@ -614,16 +565,16 @@ async function pushDirectory(dirPath, client, options, modifyKey = null, transac
       continue;
     }
 
-    // Skip records that were just auto-added in this invocation — they're already on the server
-    if (meta.UID && justAddedUIDs.has(meta.UID)) {
-      log.dim(`  Skipped (just added): ${basename(metaPath)}`);
-      continue;
-    }
+    // AUTO-ADD DISABLED: justAddedUIDs skip removed (server-first workflow)
 
-    // Compound output files: handle root + all inline children together
-    // These have _entity='output' and inline children under .children
-    if (meta._entity === 'output' && meta.children) {
-      outputCompoundFiles.push({ meta, metaPath });
+    // Output hierarchy entities: only push compound output files (root with inline children).
+    // Flat output metadata without .children are skipped — they are pushed as part of
+    // their parent compound file, or via `dbo deploy`. Never as standalone records.
+    if (meta._entity === 'output' || meta._entity === 'output_value'
+        || meta._entity === 'output_value_filter' || meta._entity === 'output_value_entity_column_rel') {
+      if (meta._entity === 'output' && meta.children) {
+        outputCompoundFiles.push({ meta, metaPath });
+      }
       continue;
     }
 
@@ -719,23 +670,44 @@ async function pushDirectory(dirPath, client, options, modifyKey = null, transac
     }
   } catch { /* structure file missing or bin lookup failed — skip */ }
 
-  if (toPush.length === 0 && outputCompoundFiles.length === 0 && binPushItems.length === 0) {
-    if (metaFiles.length === 0) {
+  // Pre-filter compound output files: run delta detection early so unchanged outputs
+  // are excluded from the record count and ticket prompt (avoids false-positive prompts).
+  const outputsWithChanges = [];
+  for (const item of outputCompoundFiles) {
+    if (baseline) {
+      try {
+        const delta = await detectOutputChanges(item.metaPath, baseline);
+        const totalChanges = delta.root.length +
+          (delta.children ? Object.values(delta.children).reduce((s, c) => s + c.length, 0) : 999);
+        if (totalChanges === 0) {
+          log.dim(`  Skipping ${basename(item.metaPath)} — no changes detected`);
+          skipped++;
+          continue;
+        }
+      } catch { /* delta detection failed — include in push for safety */ }
+    }
+    outputsWithChanges.push(item);
+  }
+
+  if (toPush.length === 0 && outputsWithChanges.length === 0 && binPushItems.length === 0) {
+    if (metaFiles.length === 0 && deletedCount === 0) {
       log.warn(`No .metadata.json files found in "${dirPath}".`);
+    } else if (deletedCount > 0) {
+      log.info(`${deletedCount} deletion(s) processed. No other changes to push.`);
     } else {
       log.info('No changes to push');
     }
     return;
   }
 
-  log.info(`Found ${metaFiles.length} record(s) to push`);
+  log.info(`Found ${toPush.length + outputsWithChanges.length + binPushItems.length} record(s) to push`);
 
   // Pre-flight ticket validation (only if no --ticket flag)
-  const totalRecords = toPush.length + outputCompoundFiles.length + binPushItems.length;
+  const totalRecords = toPush.length + outputsWithChanges.length + binPushItems.length;
   if (!options.ticket && totalRecords > 0) {
     const recordSummary = [
       ...toPush.map(r => { const p = parseMetaFilename(basename(r.metaPath)); return p ? p.naturalBase : basename(r.metaPath, '.metadata.json'); }),
-      ...outputCompoundFiles.map(r => basename(r.metaPath, '.json')),
+      ...outputsWithChanges.map(r => basename(r.metaPath, '.json')),
       ...binPushItems.map(r => `bin:${r.meta.Name}`),
     ].join(', ');
     const ticketCheck = await checkStoredTicket(options, `${totalRecords} record(s): ${recordSummary}`);
@@ -835,8 +807,8 @@ async function pushDirectory(dirPath, client, options, modifyKey = null, transac
     }
   }
 
-  // Process compound output files (root + inline children)
-  for (const { meta, metaPath } of outputCompoundFiles) {
+  // Process compound output files (root + inline children) — already pre-filtered for changes
+  for (const { meta, metaPath } of outputsWithChanges) {
     try {
       const result = await pushOutputCompound(meta, metaPath, client, options, baseline, modifyKey, transactionKey);
       if (result.pushed > 0) {