npm - @dazn/kopytko-framework - Versions diffs - 1.3.2 → 1.3.4 - Mend

@dazn/kopytko-framework 1.3.2 → 1.3.4

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (4) hide show

package/package.json +1 -1
package/src/components/renderer/KopytkoDOM.brs +6 -1
package/src/components/store/Store.facade.brs +15 -10
package/CHANGELOG.md +0 -103

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "@dazn/kopytko-framework",
-  "version": "1.3.2",
+  "version": "1.3.4",
   "description": "A modern Roku's Brightscript framework",
   "keywords": [
     "brightscript",

package/src/components/renderer/KopytkoDOM.brs CHANGED Viewed

@@ -3,6 +3,8 @@ function KopytkoDOM() as Object
   prototype.componentsMapping = {}
+  prototype._renderedElements = {}
   ' Renders an element based on the given virtual node
   ' @param {Object} vNode - The virtual node
   ' @param {Object} parentElement - The parent element where the element will be rendered
@@ -45,6 +47,8 @@ function KopytkoDOM() as Object
       parentElement.appendChild(element)
     end if
+    m._renderedElements[element.id] = element
     m._setElementSelector(element)
   end sub
@@ -94,7 +98,7 @@ function KopytkoDOM() as Object
     rootElement = m._getRootComponent()
     for each elementId in elements
-      element = rootElement.top.findNode(elementId)
+      element = m._renderedElements[elementId]
       if (element <> Invalid)
         m._destroyKopytkoElement(element)
@@ -106,6 +110,7 @@ function KopytkoDOM() as Object
       end if
       rootElement.delete(elementId)
+      m._renderedElements.delete(elementId)
     end for
   end sub

package/src/components/store/Store.facade.brs CHANGED Viewed

@@ -1,4 +1,5 @@
 ' @import /components/getType.brs from @dazn/kopytko-utils
+' @import /components/uuid.brs from @dazn/kopytko-utils
 ' @import /components/utils/KopytkoGlobalNode.brs
 function StoreFacade() as Object
   if (m._store <> Invalid)
@@ -15,7 +16,7 @@ function StoreFacade() as Object
   prototype = {}
   prototype._store = _global.store
-  prototype._subscriptions = []
+  prototype._subscriptions = {}
   prototype.updateNode = sub (key as String, value as Dynamic)
     data = m.get(key)
@@ -94,20 +95,20 @@ function StoreFacade() as Object
   prototype.subscribeOnce = sub (key as String, callback as Function)
     m._handleSubscriber(key)
-    m._subscriptions.push({ key: key, callback: [callback], once: true })
+    m._subscriptions[m._getRandomizedKey(key)] = { key: key, callback: [callback], once: true }
   end sub
   prototype.subscribe = sub (key as String, callback as Function)
     m._handleSubscriber(key)
-    m._subscriptions.push({ key: key, callback: [callback], once: false })
+    m._subscriptions[m._getRandomizedKey(key)] = { key: key, callback: [callback], once: false }
   end sub
   prototype.unsubscribe = sub (key as String, callback as Function)
-    for i = 0 to m._subscriptions.count() - 1
-      listener = m._subscriptions[i]
+    for each subscriptionKey in m._subscriptions
+      listener = m._subscriptions[subscriptionKey]
       if (listener <> Invalid AND listener.key = key AND listener.callback[0] = callback)
-        m._subscriptions.delete(i)
+        m._subscriptions.delete(subscriptionKey)
       end if
     end for
   end sub
@@ -139,14 +140,14 @@ function StoreFacade() as Object
   prototype._notify = sub (key as String, data as Object)
     value = data.value
-    for i = 0 to m._subscriptions.count() - 1
-      listener = m._subscriptions[i]
+    for each subscriptionKey in m._subscriptions
+      listener = m._subscriptions[subscriptionKey]
-      if (listener.key = key)
+      if (listener <> Invalid AND listener.key = key)
         listener.callback[0](value)
         if (listener.once)
-          m._subscriptions.delete(i)
+          m._subscriptions.delete(subscriptionKey)
         end if
       end if
     end for
@@ -164,6 +165,10 @@ function StoreFacade() as Object
     end if
   end sub
+  prototype._getRandomizedKey = function (key as String) as String
+    return key + "_" + uuid()
+  end function
   m._store = prototype
   return m._store

package/CHANGELOG.md DELETED Viewed

@@ -1,103 +0,0 @@
-## [1.3.2](https://github.com/getndazn/kopytko-framework/compare/v1.3.1...v1.3.2) (2022-09-01)
-### Bug Fixes
-* Ignoring Invalid elements when calculating elements' index in children array ([#31](https://github.com/getndazn/kopytko-framework/issues/31)) ([73aed6e](https://github.com/getndazn/kopytko-framework/commit/73aed6e2e7ba38b946c81fe18ceecf414f7bbcf2))
-## [1.3.1](https://github.com/getndazn/kopytko-framework/compare/v1.3.0...v1.3.1) (2022-08-05)
-### Bug Fixes
-* update dependencies ([#35](https://github.com/getndazn/kopytko-framework/issues/35)) ([7e317e0](https://github.com/getndazn/kopytko-framework/commit/7e317e0850cec411832318bf1491c8375c219cad))
-# [1.3.0](https://github.com/getndazn/kopytko-framework/compare/v1.2.0...v1.3.0) (2022-08-01)
-### Features
-* enhanced destroyKopytkoRoot to call destroyKopytko ([#34](https://github.com/getndazn/kopytko-framework/issues/34)) ([c21c2bb](https://github.com/getndazn/kopytko-framework/commit/c21c2bb61bae0f165d2a68341aa1cfb75d13a6b8))
-# [1.2.0](https://github.com/getndazn/kopytko-framework/compare/v1.1.2...v1.2.0) (2022-08-01)
-### Features
-* introduced KopytkoRoot that makes integration easier ([#32](https://github.com/getndazn/kopytko-framework/issues/32)) ([11efb22](https://github.com/getndazn/kopytko-framework/commit/11efb228d1e75d0020e1279f61ef1075dcc0f3e4))
-## [1.1.2](https://github.com/getndazn/kopytko-framework/compare/v1.1.1...v1.1.2) (2022-07-14)
-### Bug Fixes
-* allow to render array of elements in root component ([#30](https://github.com/getndazn/kopytko-framework/issues/30)) ([8609122](https://github.com/getndazn/kopytko-framework/commit/8609122e3008009802eaa1865f5ee7756392afa3))
-## [1.1.1](https://github.com/getndazn/kopytko-framework/compare/v1.1.0...v1.1.1) (2022-06-02)
-### Bug Fixes
-* validating parent when removing children from Kopytko component ([#29](https://github.com/getndazn/kopytko-framework/issues/29)) ([fefe313](https://github.com/getndazn/kopytko-framework/commit/fefe31360aa3d90ab7f97ecd5ac422530fe9351e))
-# [1.1.0](https://github.com/getndazn/kopytko-framework/compare/v1.0.6...v1.1.0) (2022-05-20)
-### Features
-* added enqueueUpdate function to reduce number of rerenders ([#28](https://github.com/getndazn/kopytko-framework/issues/28)) ([4c80273](https://github.com/getndazn/kopytko-framework/commit/4c80273af7c20ded4bc41cdb94647142b209695f))
-## [1.0.6](https://github.com/getndazn/kopytko-framework/compare/v1.0.5...v1.0.6) (2022-05-20)
-### Bug Fixes
-* not calling state update callbacks if kopytko is not mounted ([#27](https://github.com/getndazn/kopytko-framework/issues/27)) ([27d5618](https://github.com/getndazn/kopytko-framework/commit/27d5618909e7fd266db71e88acfa63071b037921))
-## [1.0.5](https://github.com/getndazn/kopytko-framework/compare/v1.0.4...v1.0.5) (2022-05-19)
-### Bug Fixes
-* expose response headers in HttpResponse ([#26](https://github.com/getndazn/kopytko-framework/issues/26)) ([5517ff2](https://github.com/getndazn/kopytko-framework/commit/5517ff2eaff9d11a8d81ada9ea390288eb049d15))
-## [1.0.4](https://github.com/getndazn/kopytko-framework/compare/v1.0.3...v1.0.4) (2022-04-11)
-### Bug Fixes
-* active route should skip is omitted in history ([#24](https://github.com/getndazn/kopytko-framework/issues/24)) ([970ff96](https://github.com/getndazn/kopytko-framework/commit/970ff9662376a909f1018b452a04b4cf5378a446))
-## [1.0.3](https://github.com/getndazn/kopytko-framework/compare/v1.0.2...v1.0.3) (2022-03-04)
-### Bug Fixes
-* update dependencies ([#19](https://github.com/getndazn/kopytko-framework/issues/19)) ([4652ec2](https://github.com/getndazn/kopytko-framework/commit/4652ec2201292083b8202acb624674de8cd8275e))
-## [1.0.2](https://github.com/getndazn/kopytko-framework/compare/v1.0.1...v1.0.2) (2021-12-03)
-### Bug Fixes
-* **deps:** Fixed npm urls ([#17](https://github.com/getndazn/kopytko-framework/issues/17)) ([32443a2](https://github.com/getndazn/kopytko-framework/commit/32443a2eb3973640fd2315dcf85b6abc1d54e2d3))
-## [1.0.1](https://github.com/getndazn/kopytko-framework/compare/v1.0.0...v1.0.1) (2021-10-01)
-### Bug Fixes
-* Fixed Modal property ([#16](https://github.com/getndazn/kopytko-framework/issues/16)) ([ed36d04](https://github.com/getndazn/kopytko-framework/commit/ed36d04379b859afaa9411769554ee0ef2b3cd08))
-# 1.0.0 (2021-10-01)
-### Bug Fixes
-* Removed ThemeFacade import in ModalComponent ([#8](https://github.com/getndazn/kopytko-framework/issues/8)) ([ad60b1a](https://github.com/getndazn/kopytko-framework/commit/ad60b1a3ad2d0ee77c21d83a92f8b34a62c30e78))
-### Features
-* Added Registry docs ([#6](https://github.com/getndazn/kopytko-framework/issues/6)) ([37be695](https://github.com/getndazn/kopytko-framework/commit/37be69596e900ef898f671435fd1311387702b72))
-* EventBus docs added ([#11](https://github.com/getndazn/kopytko-framework/issues/11)) ([7c968c3](https://github.com/getndazn/kopytko-framework/commit/7c968c3ef3e53b499543ba5ef5bda733798d8363))