@davmash/bygone 0.9.2 → 0.9.5

package/out/standalone-main.js

@@ -2452,6 +2452,10 @@ var init_gitHistory = __esm({
           shortCommit: commit.shortCommit,
           summary: commit.summary,
           timestamp: commit.timestamp,
+          author: commit.author,
+          authorEmail: commit.authorEmail,
+          message: commit.message,
+          parents: commit.parents,
           parentSummary: parentMetadata.summary,
           parentTimestamp: parentMetadata.timestamp,
           leftLabel: `${fileName} @ ${parentCommit.slice(0, 7)}`,
@@ -2468,6 +2472,10 @@ var init_gitHistory = __esm({
           shortCommit: entry.shortCommit,
           summary: entry.summary,
           timestamp: entry.timestamp,
+          author: entry.author,
+          authorEmail: entry.authorEmail,
+          message: entry.message,
+          parents: entry.parents,
           parentSummary: entry.parentSummary,
           parentTimestamp: entry.parentTimestamp,
           leftLabel: entry.leftLabel,
@@ -2490,7 +2498,7 @@ var init_gitHistory = __esm({
             "--max-count",
             String(maxCommits),
             "--follow",
-            "--format=%H%x09%h%x09%cI%x09%s%x09%P",
+            "--format=%H%x00%h%x00%cI%x00%s%x00%P%x00%an%x00%ae%x00%B%x1e",
             "--",
             relativePath
           ], {
@@ -2559,21 +2567,19 @@ var init_gitHistory = __esm({
         }, /* @__PURE__ */ new Map());
       }
       parseHistoryCommitRecords(logOutput) {
-        return logOutput.split("\n").map((line) => line.trim()).filter((line) => line.length > 0).map((line) => {
-          const parts = line.split("	");
-          const commit = parts[0];
-          const shortCommit = parts[1];
-          const timestamp = parts[2];
-          const hasParentField = parts.length >= 5;
-          const parentField = hasParentField ? parts[parts.length - 1] || "" : "";
-          const summaryParts = hasParentField ? parts.slice(3, -1) : parts.slice(3);
-          const firstParentCommit = parentField.split(" ").find((candidate) => candidate.length > 0);
+        return logOutput.split("").map((record) => record.replace(/^\n+|\n+$/g, "")).filter(Boolean).map((record) => {
+          const [commit, shortCommit, timestamp, summary, parentField, author, authorEmail, message] = record.split("\0");
+          const parents = parentField.split(" ").filter(Boolean);
           return {
             commit,
             shortCommit,
             timestamp,
-            summary: summaryParts.join("	"),
-            parentCommit: firstParentCommit
+            summary,
+            author,
+            authorEmail,
+            message: message.trimEnd(),
+            parents,
+            parentCommit: parents[0]
           };
         });
       }
@@ -15989,11 +15995,11 @@ var require_tourHistory = __commonJS({
       return input;
     }
     function listCommitHistory(root, commit) {
-      const output = git(root, ["log", "--topo-order", "--format=%x1e%H%x00%P%x00%s%x00%cI%x00", commit, "--"]);
+      const output = git(root, ["log", "--topo-order", "--format=%x1e%H%x00%P%x00%s%x00%cI%x00%an%x00%ae%x00%B%x00", commit, "--"]);
       const entries = [];
       for (const record of output.split("").slice(1)) {
         const fields = record.split("\0");
-        const [oid, parents, summary, timestamp] = fields;
+        const [oid, parents, summary, timestamp, author, authorEmail, message] = fields;
         if (!oid) continue;
         entries.push({
           commit: oid,
@@ -16002,7 +16008,10 @@ var require_tourHistory = __commonJS({
           parents: parents.split(" ").filter(Boolean),
           shortCommit: oid.slice(0, 7),
           summary,
-          timestamp
+          timestamp,
+          author,
+          authorEmail,
+          message: message.trimEnd()
         });
       }
       return entries;
@@ -16261,7 +16270,7 @@ var require_tourHistory = __commonJS({
             "--topo-order",
             "--follow",
             "-M",
-            "--format=%x1e%H%x00%P%x00%s%x00%cI%x00",
+            "--format=%x1e%H%x00%P%x00%s%x00%cI%x00%an%x00%ae%x00%B%x00",
             "--name-status",
             "-z",
             commit,
@@ -16272,8 +16281,8 @@ var require_tourHistory = __commonJS({
           let historicalPath = filePath;
           for (const record of output.split("").slice(1)) {
             const fields = record.split("\0");
-            const [oid, parents, summary, timestamp] = fields;
-            const changes = parseNameStatusZ2(fields.slice(4).join("\0").replace(/^\0?\n/, ""));
+            const [oid, parents, summary, timestamp, author, authorEmail, message] = fields;
+            const changes = parseNameStatusZ2(fields.slice(7).join("\0").replace(/^\0?\n/, ""));
             const change = changes.find((item) => item.path === historicalPath || item.previousPath === historicalPath) || changes[0];
             if (!change) continue;
             entries.push({
@@ -16283,6 +16292,10 @@ var require_tourHistory = __commonJS({
               shortCommit: oid.slice(0, 7),
               summary,
               timestamp,
+              author,
+              authorEmail,
+              message: message.trimEnd(),
+              parents: parents.split(" ").filter(Boolean),
               path: change.path,
               ...change.previousPath ? { previousPath: change.previousPath } : {}
             });
@@ -16961,6 +16974,12 @@ var require_workspaceHost = __commonJS({
                 commit: entry.commit,
                 label: `${entry.shortCommit} ${entry.summary}`.trim(),
                 meta: entry.timestamp,
+                summary: entry.summary,
+                timestamp: entry.timestamp,
+                author: entry.author,
+                authorEmail: entry.authorEmail,
+                message: entry.message,
+                parents: entry.parents || (entry.parentCommit ? [entry.parentCommit] : []),
                 selectionEnabled: index < history.entries.length,
                 selected: current.draft.includes(entry.commit),
                 active: active === entry.commit,
@@ -17116,7 +17135,7 @@ var require_workspaceHost = __commonJS({
         const workspaceAction = message.type.startsWith("workspace");
         const current = host.getSession();
         const derived = Boolean(current.workspaceView);
-        const sharedAction = message.type === "toggleHistorySelection" || message.type === "selectHistoryEntry";
+        const sharedAction = ["toggleHistorySelection", "selectHistoryEntry", "compareHistoryEntry"].includes(message.type);
         const derivedAction = derived && ["refreshSession", "selectHistoryEntry", "historyBack", "historyForward", "openDirectoryEntry", "navigateFile", "multiAddPanel", "multiRemovePanel", "historyToggleStaged", "historyToggleSkipUnchanged"].includes(message.type);
         if (!workspaceAction && !sharedAction && !derivedAction) return false;
         ensure();
@@ -17170,15 +17189,21 @@ var require_workspaceHost = __commonJS({
             } finally {
               if (!accepted) tour?.dispose?.();
             }
+          } else if (message.type === "compareHistoryEntry") {
+            const entry = backend().entries[message.index];
+            if (entry?.parentCommit) {
+              const next = makeSession("compare", [entry.parentCommit, entry.commit], activePath());
+              if (await leave()) await install(makeSession("compare", next.workspaceView.revisions, next.workspaceView.path), "compare");
+            }
           } else if (message.type === "selectHistoryEntry" && state.mode === "compare") {
             const revision = backend().entries[message.index]?.commit;
             const panel = current.multi?.files.find((item) => item.revision === revision);
             if (panel) {
               current.multi.activePanelId = panel.id;
               host.send({ type: "focusHistoryPanel", panelId: panel.id });
-            } else {
-              state.status = "Select commits with the checkboxes, then choose Compare selected.";
-              update();
+            } else if (revision) {
+              const next = makeSession("history", windowAround(backend().entries, message.index, Math.max(2, current.multi?.files.length || 2)), activePath());
+              if (await leave()) await install(makeSession("history", next.workspaceView.revisions, next.workspaceView.path), "history");
             }
           } else if (derivedAction) {
             if (message.type === "refreshSession") {
@@ -17921,7 +17946,11 @@ function createWorkspaceHistory(context, options = {}) {
       parentCommit: entry.parentCommit,
       shortCommit: entry.shortCommit,
       summary: entry.summary,
-      timestamp: entry.timestamp
+      timestamp: entry.timestamp,
+      author: entry.author,
+      authorEmail: entry.authorEmail,
+      message: entry.message,
+      parents: entry.parents
     }))
   ];
   const changedCommitsCache = /* @__PURE__ */ new Map();
@@ -18177,7 +18206,7 @@ function readCommitMetadataBatch(repoRoot, selectedRoots, axis) {
     "log",
     "--topo-order",
     "--reverse",
-    "--format=%H%x00%h%x00%cI%x00%s%x00%P%x1e",
+    "--format=%H%x00%h%x00%cI%x00%s%x00%P%x00%an%x00%ae%x00%B%x1e",
     ...selectedRoots.slice().sort()
   ], repoRoot, MAX_GIT_METADATA_BYTES);
   const axisSet = new Set(axis);
@@ -18187,7 +18216,7 @@ function readCommitMetadataBatch(repoRoot, selectedRoots, axis) {
     if (!record) {
       continue;
     }
-    const [commit = "", shortCommit = "", timestamp = "", summary = "", parentField = ""] = record.split("\0");
+    const [commit = "", shortCommit = "", timestamp = "", summary = "", parentField = "", author = "", authorEmail = "", message = ""] = record.split("\0");
     if (!axisSet.has(commit)) {
       continue;
     }
@@ -18196,6 +18225,10 @@ function readCommitMetadataBatch(repoRoot, selectedRoots, axis) {
       shortCommit: shortCommit || commit.slice(0, 7),
       timestamp,
       summary,
+      author,
+      authorEmail,
+      message: message.trimEnd(),
+      parents: parentField.split(" ").filter(Boolean),
       parentCommit: parentField.split(" ").find(Boolean) ?? null
     });
   }
@@ -18752,7 +18785,7 @@ var require_package = __commonJS({
       displayName: "Bygone",
       desktopName: "com.davidmashburn.bygone.desktop",
       description: "See how change happened. Visual diff and file history for VS Code.",
-      version: "0.9.2",
+      version: "0.9.5",
       author: "David Mashburn",
       license: "MIT",
       private: false,
@@ -32452,6 +32485,141 @@ ${error.message}`);
         assert.equal(session2().multi.files.at(-1).editable, true);
         const checkboxes = await evaluate("document.querySelectorAll('#history-rail [role=checkbox]').length");
         assert.ok(checkboxes >= 4, `Expected all commits, got ${checkboxes}`);
+        const hoverElapsed = await evaluate(`new Promise((resolve, reject) => {
+            document.dispatchEvent(new Event('pointerdown', { bubbles: true }));
+            const details = document.querySelector('.commit-hover-details');
+            const started = performance.now();
+            const timeout = setTimeout(() => { observer.disconnect(); reject(new Error('Commit hover did not open')); }, 5000);
+            const observer = new MutationObserver(() => {
+                if (details.hidden) return;
+                observer.disconnect(); clearTimeout(timeout); resolve(performance.now() - started);
+            });
+            observer.observe(details, { attributes: true, attributeFilter: ['hidden'] });
+            document.querySelector('[data-commit-row] .history-rail-entry').dispatchEvent(
+                new MouseEvent('mouseover', { bubbles: true, relatedTarget: document.querySelector('[data-commit-row] [data-rail-menu]') }));
+        })`);
+        assert.ok(hoverElapsed >= 480, `Commit details wait for the shared 500ms hover delay (got ${hoverElapsed}ms)`);
+        const overlays = await evaluate(`(async () => {
+            const row = document.querySelector('[data-commit-row]');
+            const details = document.querySelector('.commit-hover-details');
+            const selected = document.querySelectorAll('[aria-checked=true]').length;
+            const detailStyle = getComputedStyle(details);
+            const hover = { visible: !details.hidden, background: detailStyle.backgroundColor, font: detailStyle.fontFamily };
+            row.dispatchEvent(new MouseEvent('contextmenu', { bubbles: true, cancelable: true, clientX: 40, clientY: 200 }));
+            const menu = document.querySelector('.commit-context-menu');
+            const menuStyle = getComputedStyle(menu);
+            const buttonStyle = getComputedStyle(menu.querySelector('button'));
+            const result = { hover, menuVisible: !menu.hidden, background: menuStyle.backgroundColor,
+                font: menuStyle.fontFamily, buttonFont: buttonStyle.fontFamily,
+                singleNavigationTooltip: ['previous-file', 'next-file'].every(id => {
+                    const button = document.getElementById(id);
+                    return button.hasAttribute('data-tooltip') && !button.hasAttribute('title');
+                }),
+                selectionUnchanged: selected === document.querySelectorAll('[aria-checked=true]').length };
+            document.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }));
+            await new Promise(resolve => setTimeout(resolve, 700));
+            result.dismissed = menu.hidden && details.hidden;
+            return result;
+        })()`);
+        assert.equal(overlays.hover.visible, true);
+        assert.equal(overlays.menuVisible, true);
+        assert.equal(overlays.selectionUnchanged, true);
+        assert.equal(overlays.singleNavigationTooltip, true, "File navigation must not show both managed and native tooltips");
+        assert.equal(overlays.dismissed, true, "Escape must not reopen the tooltip through focus restoration");
+        for (const [surface, background] of Object.entries({ details: overlays.hover.background, menu: overlays.background })) {
+          assert.match(background, /^rgb\(/, `${surface} must be opaque: ${JSON.stringify(overlays)}`);
+        }
+        assert.match(overlays.hover.font, /system-ui/);
+        assert.match(overlays.font, /system-ui/);
+        assert.equal(overlays.buttonFont, overlays.font);
+        const canceledCommitHover = await evaluate(`(async () => {
+            const entry = document.querySelector('[data-commit-row] .history-rail-entry');
+            entry.dispatchEvent(new MouseEvent('mouseover', { bubbles: true, relatedTarget: document.body }));
+            document.dispatchEvent(new KeyboardEvent('keydown', { key: 'Escape', bubbles: true }));
+            await new Promise(resolve => setTimeout(resolve, 700));
+            return document.querySelector('.commit-hover-details').hidden;
+        })()`);
+        assert.equal(canceledCommitHover, true, "Escape cancels pending commit hovers as well as visible ones");
+        const tooltipChecks = await evaluate(`(async () => {
+            const tooltip = document.getElementById('bygone-ui-tooltip');
+            const toolbar = document.getElementById('directory-tree-toolbar');
+            const originallyHidden = toolbar.hidden;
+            toolbar.hidden = false;
+            const hover = async (button, dismiss = true) => {
+                document.dispatchEvent(new Event('pointerdown', { bubbles: true }));
+                const started = performance.now();
+                const elapsed = await new Promise((resolve, reject) => {
+                    const timeout = setTimeout(() => { observer.disconnect(); reject(new Error('Tooltip did not open for ' + button.id)); }, 5000);
+                    const observer = new MutationObserver(() => {
+                        if (tooltip.hidden) return;
+                        observer.disconnect(); clearTimeout(timeout); resolve(performance.now() - started);
+                    });
+                    observer.observe(tooltip, { attributes: true, attributeFilter: ['hidden'] });
+                    const svg = button.querySelector('svg') || button;
+                    svg.dispatchEvent(new MouseEvent('mouseover', { bubbles: true, relatedTarget: document.body }));
+                    // Moving across the icon must not restart or cancel the timer.
+                    (svg.querySelector('path') || svg).dispatchEvent(new MouseEvent('mouseover', { bubbles: true, relatedTarget: svg }));
+                });
+                const style = getComputedStyle(tooltip);
+                const anchor = button.getBoundingClientRect();
+                const bounds = tooltip.getBoundingClientRect();
+                const result = { id: button.id, elapsed, text: tooltip.textContent, nativeTitle: button.hasAttribute('title'),
+                    opacity: style.opacity, background: style.backgroundColor, font: style.fontFamily,
+                    placedBelow: Math.abs(bounds.top - anchor.bottom - 8) < 1,
+                    inViewport: bounds.left >= 8 && bounds.right <= innerWidth - 8,
+                    pseudoContent: getComputedStyle(button, '::after').content };
+                if (dismiss) button.dispatchEvent(new MouseEvent('mouseout', { bubbles: true, relatedTarget: document.body }));
+                result.dismissed = tooltip.hidden;
+                return result;
+            };
+            const checks = [];
+            for (const id of ['directory-expand-all', 'directory-collapse-all', 'directory-collapse-unchanged', 'previous-file', 'next-file']) {
+                const button = document.getElementById(id);
+                const originallyHidden = button.hidden;
+                button.hidden = false;
+                checks.push(await hover(button));
+                button.hidden = originallyHidden;
+            }
+            const button = document.getElementById('directory-expand-all');
+            const oldText = button.dataset.tooltip;
+            button.title = 'Updated tooltip';
+            await Promise.resolve();
+            checks.push({ updatedTitle: button.dataset.tooltip === 'Updated tooltip' && !button.hasAttribute('title') });
+            button.title = oldText;
+            document.dispatchEvent(new Event('pointerdown', { bubbles: true }));
+            const modal = document.createElement('dialog');
+            const action = document.createElement('button');
+            action.id = 'modal-tooltip-smoke';
+            action.title = 'Tooltip inside modal';
+            action.textContent = 'Action';
+            modal.appendChild(action);
+            document.body.appendChild(modal);
+            modal.showModal();
+            const modalCheck = await hover(action, false);
+            modalCheck.parentIsModal = tooltip.parentElement === modal;
+            modal.close();
+            await Promise.resolve();
+            modalCheck.modalDismissed = tooltip.hidden && tooltip.parentElement === document.body;
+            modal.remove();
+            checks.push(modalCheck);
+            toolbar.hidden = originallyHidden;
+            return checks;
+        })()`);
+        const modalCheck = tooltipChecks.pop();
+        assert.ok(
+          modalCheck.text === "Tooltip inside modal" && modalCheck.parentIsModal && modalCheck.modalDismissed,
+          "Modal tooltips render in the top layer and close with their dialog"
+        );
+        assert.equal(tooltipChecks.pop().updatedTitle, true, "Dynamic title updates use the managed tooltip");
+        for (const check of tooltipChecks) {
+          assert.ok(check.elapsed >= 480, `${check.id} must wait 500ms: ${JSON.stringify(check)}`);
+          assert.ok(check.text && !check.nativeTitle && check.dismissed, JSON.stringify(check));
+          assert.equal(check.opacity, "1", "Tooltip opacity is independent of disabled buttons");
+          assert.match(check.background, /^rgb\(/);
+          assert.match(check.font, /system-ui/);
+          assert.equal(check.pseudoContent, "none", "No CSS bubble can appear instantly");
+          assert.ok(check.placedBelow && check.inViewport, JSON.stringify(check));
+        }
         await evaluate("document.querySelectorAll('#history-rail [role=checkbox]')[1].click()");
         await waitFor("document.querySelector('[data-action=workspaceApply]').textContent.includes('(1)')");
         await evaluate("document.querySelectorAll('#history-rail [role=checkbox]')[2].click()");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@davmash/bygone",
-  "version": "0.9.2",
+  "version": "0.9.5",
   "description": "See how change happened. Visual diff and file history.",
   "author": "David Mashburn",
   "license": "MIT",

package/standalone/index.html

@@ -30,13 +30,13 @@
             <div id="change-toolbar" class="change-toolbar header-align-diff" hidden>
                 <div class="change-toolbar-main">
                     <div class="change-toolbar-nav">
-                        <button id="previous-file" class="change-button icon-button" type="button" title="Open previous file" data-tooltip="Open previous file" aria-label="Previous file">
+                        <button id="previous-file" class="change-button icon-button" type="button" data-tooltip="Open previous file" aria-label="Previous file">
                             <svg viewBox="0 0 24 24" aria-hidden="true">
                                 <path d="M17 11l-5-5-5 5"></path>
                                 <path d="M17 18l-5-5-5 5" opacity="0.7"></path>
                             </svg>
                         </button>
-                        <button id="next-file" class="change-button change-button-primary icon-button" type="button" title="Open next file" data-tooltip="Open next file" aria-label="Next file">
+                        <button id="next-file" class="change-button change-button-primary icon-button" type="button" data-tooltip="Open next file" aria-label="Next file">
                             <svg viewBox="0 0 24 24" aria-hidden="true">
                                 <path d="M7 13l5 5 5-5"></path>
                                 <path d="M7 6l5 5 5-5" opacity="0.7"></path>
@@ -102,14 +102,14 @@
                     <div id="history-left-time" class="history-time"></div>
                 </div>
                 <div class="history-nav">
-                    <button id="history-back" class="history-button icon-button" type="button" title="Open older commit (Alt+Left)" data-tooltip="Open older commit" aria-label="Older commit">
+                    <button id="history-back" class="history-button icon-button" type="button" data-tooltip="Open older commit (Alt+Left)" aria-label="Older commit">
                         <svg viewBox="0 0 24 24" aria-hidden="true">
                             <path d="M15 18l-6-6 6-6"></path>
                             <path d="M10 18l-6-6 6-6" opacity="0.7"></path>
                         </svg>
                     </button>
                     <div id="history-position" class="history-position" role="status" aria-live="polite" aria-atomic="true"></div>
-                    <button id="history-forward" class="history-button icon-button" type="button" title="Open newer commit (Alt+Right)" data-tooltip="Open newer commit" aria-label="Newer commit">
+                    <button id="history-forward" class="history-button icon-button" type="button" data-tooltip="Open newer commit (Alt+Right)" aria-label="Newer commit">
                         <svg viewBox="0 0 24 24" aria-hidden="true">
                             <path d="M9 18l6-6-6-6"></path>
                             <path d="M14 18l6-6-6-6" opacity="0.7"></path>

package/web/index.html

@@ -177,13 +177,13 @@
             <div id="change-toolbar" class="change-toolbar header-align-diff" hidden>
                 <div class="change-toolbar-main">
                     <div class="change-toolbar-nav">
-                        <button id="previous-file" class="change-button icon-button" type="button" title="Open previous file" data-tooltip="Open previous file" aria-label="Previous file">
+                        <button id="previous-file" class="change-button icon-button" type="button" data-tooltip="Open previous file" aria-label="Previous file">
                             <svg viewBox="0 0 24 24" aria-hidden="true">
                                 <path d="M17 11l-5-5-5 5"></path>
                                 <path d="M17 18l-5-5-5 5"></path>
                             </svg>
                         </button>
-                        <button id="next-file" class="change-button icon-button" type="button" title="Open next file" data-tooltip="Open next file" aria-label="Next file">
+                        <button id="next-file" class="change-button icon-button" type="button" data-tooltip="Open next file" aria-label="Next file">
                             <svg viewBox="0 0 24 24" aria-hidden="true">
                                 <path d="M7 13l5 5 5-5"></path>
                                 <path d="M7 6l5 5 5-5"></path>
@@ -249,14 +249,14 @@
                     <div id="history-left-time" class="history-time"></div>
                 </div>
                 <div class="history-nav">
-                    <button id="history-back" class="history-button icon-button" type="button" title="Open older commit" data-tooltip="Open older commit" aria-label="Older commit">
+                    <button id="history-back" class="history-button icon-button" type="button" data-tooltip="Open older commit" aria-label="Older commit">
                         <svg viewBox="0 0 24 24" aria-hidden="true">
                             <path d="M15 18l-6-6 6-6"></path>
                             <path d="M10 18l-6-6 6-6" opacity="0.7"></path>
                         </svg>
                     </button>
                     <div id="history-position" class="history-position" role="status" aria-live="polite" aria-atomic="true"></div>
-                    <button id="history-forward" class="history-button icon-button" type="button" title="Open newer commit" data-tooltip="Open newer commit" aria-label="Newer commit">
+                    <button id="history-forward" class="history-button icon-button" type="button" data-tooltip="Open newer commit" aria-label="Newer commit">
                         <svg viewBox="0 0 24 24" aria-hidden="true">
                             <path d="M9 18l6-6-6-6"></path>
                             <path d="M14 18l6-6-6-6" opacity="0.7"></path>

package/web/presenter.css

@@ -253,12 +253,18 @@ body.tour-mode #container {
 }
 
 .tour-coverage-item {
+    position: relative;
     display: grid;
     gap: 5px;
     padding-left: 8px;
     border-left: 2px solid var(--tour-accent-bright);
 }
 
+.tour-coverage-item:focus-visible {
+    outline: 2px solid var(--tour-accent-bright);
+    outline-offset: 3px;
+}
+
 .tour-coverage-item[data-metric="assignment"] {
     border-left-color: #74d6ad;
 }