@davidwells/extract-deps 0.0.4 → 0.0.6

package/tests/dep-graph.test.js

@@ -0,0 +1,358 @@
+// Build and verify dependency graph
+const { test } = require('uvu')
+const assert = require('uvu/assert')
+const path = require('path')
+const { depGraph, resolveDepPaths } = require('../src/dep-graph.js')
+
+const CJS_FIXTURE_PATH = path.resolve(__dirname, './fixtures/cjs-example/index.js')
+const ESM_FIXTURE_PATH = path.resolve(__dirname, './fixtures/esm-fixture/index.js')
+const CJS_DEEP_FIXTURE_PATH = path.resolve(__dirname, './fixtures/cjs-deep-example/index.js')
+
+test('should build graph by default', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH)
+  assert.ok(graph instanceof Map, 'Should return a Map by default')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+})
+
+test('should verify by default', () => {
+  assert.not.throws(() => {
+    depGraph(CJS_FIXTURE_PATH)
+  }, 'Should verify imports by default')
+})
+
+test('should build graph for valid CJS fixture', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH)
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+
+  const entries = Array.from(graph.keys())
+  const hasIndexFile = entries.some(key => key.includes('cjs-example/index.js'))
+  assert.ok(hasIndexFile, 'Graph should include the index.js file')
+})
+
+test('should build graph for valid ESM fixture', () => {
+  const graph = depGraph(ESM_FIXTURE_PATH)
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+
+  const entries = Array.from(graph.keys())
+  const hasIndexFile = entries.some(key => key.includes('esm-fixture/index.js'))
+  assert.ok(hasIndexFile, 'Graph should include the index.js file')
+})
+
+test('should return undefined when buildGraph is false', () => {
+  const result = depGraph(CJS_FIXTURE_PATH, { buildGraph: false })
+  assert.is(result, undefined, 'Should return undefined when buildGraph is false')
+})
+
+test('should build correct dependency graph for CJS fixture', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH)
+
+  const indexPath = Array.from(graph.keys()).find(key => key.includes('cjs-example/index.js'))
+  assert.ok(indexPath, 'Should have index.js in graph')
+
+  const indexDeps = graph.get(indexPath)
+  assert.ok(Array.isArray(indexDeps), 'Dependencies should be an array')
+  assert.is(indexDeps.length, 1, 'index.js should have 1 dependency')
+
+  const hasOneDep = indexDeps.some(dep => dep.includes('one.js'))
+  assert.ok(hasOneDep, 'index.js should depend on one.js')
+})
+
+test('should build correct dependency graph for ESM fixture', () => {
+  const graph = depGraph(ESM_FIXTURE_PATH)
+
+  const indexPath = Array.from(graph.keys()).find(key => key.includes('esm-fixture/index.js'))
+  assert.ok(indexPath, 'Should have index.js in graph')
+
+  const indexDeps = graph.get(indexPath)
+  assert.ok(Array.isArray(indexDeps), 'Dependencies should be an array')
+  assert.is(indexDeps.length, 1, 'index.js should have 1 dependency')
+
+  const hasOneDep = indexDeps.some(dep => dep.includes('one.js'))
+  assert.ok(hasOneDep, 'index.js should depend on one.js')
+})
+
+test('should include all files in graph', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH)
+
+  const filePaths = Array.from(graph.keys())
+
+  // Should have index, one, two, three
+  assert.ok(filePaths.some(p => p.includes('index.js')), 'Should include index.js')
+  assert.ok(filePaths.some(p => p.includes('one.js')), 'Should include one.js')
+  assert.ok(filePaths.some(p => p.includes('two.js')), 'Should include two.js')
+  assert.ok(filePaths.some(p => p.includes('three.js')), 'Should include three.js')
+})
+
+test('should handle files with no dependencies', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH)
+
+  const threePath = Array.from(graph.keys()).find(key => key.includes('three.js'))
+  assert.ok(threePath, 'Should have three.js in graph')
+
+  const threeDeps = graph.get(threePath)
+  assert.ok(Array.isArray(threeDeps), 'Dependencies should be an array')
+  assert.is(threeDeps.length, 0, 'three.js should have no dependencies')
+})
+
+test('should skip verification when verifyGraph is false', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH, { verifyGraph: false })
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+})
+
+test('should work with all options combined', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH, {
+    buildGraph: true,
+    verifyGraph: false,
+    throwOnFirstError: false
+  })
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+})
+
+// resolveDepPaths tests
+test('resolveDepPaths should return an array', () => {
+  const deps = resolveDepPaths(CJS_FIXTURE_PATH)
+  assert.ok(Array.isArray(deps), 'Should return an array')
+})
+
+test('resolveDepPaths should return deduplicated paths', () => {
+  const deps = resolveDepPaths(CJS_DEEP_FIXTURE_PATH)
+  const uniqueDeps = [...new Set(deps)]
+
+  assert.is(deps.length, uniqueDeps.length, 'Should not have duplicate paths')
+})
+
+test('resolveDepPaths should include all files from graph', () => {
+  const graph = depGraph(CJS_FIXTURE_PATH)
+  const deps = resolveDepPaths(CJS_FIXTURE_PATH)
+
+  assert.is(deps.length, graph.size, 'Should have same number of files as graph')
+
+  // All graph keys should be in deps
+  for (const key of graph.keys()) {
+    assert.ok(deps.includes(key), `Should include ${path.basename(key)}`)
+  }
+})
+
+test('resolveDepPaths should return paths in topological order (dependencies first)', () => {
+  const deps = resolveDepPaths(CJS_FIXTURE_PATH)
+
+  // Find indices
+  const threeIdx = deps.findIndex(p => p.includes('three.js'))
+  const twoIdx = deps.findIndex(p => p.includes('two.js'))
+  const oneIdx = deps.findIndex(p => p.includes('one.js'))
+  const indexIdx = deps.findIndex(p => p.includes('index.js'))
+
+  // three.js has no dependencies, should come first
+  assert.ok(threeIdx < twoIdx, 'three.js should come before two.js')
+  assert.ok(twoIdx < oneIdx, 'two.js should come before one.js')
+  assert.ok(oneIdx < indexIdx, 'one.js should come before index.js')
+})
+
+test('resolveDepPaths should work with ESM fixtures', () => {
+  const deps = resolveDepPaths(ESM_FIXTURE_PATH)
+
+  assert.ok(Array.isArray(deps), 'Should return an array')
+  assert.ok(deps.length > 0, 'Should have dependencies')
+
+  // Check files are included
+  assert.ok(deps.some(p => p.includes('index.js')), 'Should include index.js')
+  assert.ok(deps.some(p => p.includes('one.js')), 'Should include one.js')
+  assert.ok(deps.some(p => p.includes('two.js')), 'Should include two.js')
+  assert.ok(deps.some(p => p.includes('three.js')), 'Should include three.js')
+})
+
+test('resolveDepPaths should have entry point last', () => {
+  const deps = resolveDepPaths(CJS_FIXTURE_PATH)
+  const lastFile = deps[deps.length - 1]
+
+  assert.ok(lastFile.includes('index.js'), 'Entry point (index.js) should be last')
+})
+
+test('resolveDepPaths should have leaf nodes first', () => {
+  const deps = resolveDepPaths(CJS_FIXTURE_PATH)
+  const firstFile = deps[0]
+
+  // three.js has no dependencies - it's a leaf node
+  assert.ok(firstFile.includes('three.js'), 'Leaf node (three.js) should be first')
+})
+
+test('resolveDepPaths should handle complex graphs with shared dependencies', () => {
+  const deps = resolveDepPaths(CJS_DEEP_FIXTURE_PATH)
+
+  // Should be deduplicated
+  const uniqueDeps = [...new Set(deps)]
+  assert.is(deps.length, uniqueDeps.length, 'Should deduplicate shared dependencies')
+
+  // Find d-three.js which is shared by d-two.js, d-two-a.js, d-two-b.js
+  const threeIdx = deps.findIndex(p => p.includes('d-three.js'))
+  const twoIdx = deps.findIndex(p => p.includes('d-two.js'))
+  const twoAIdx = deps.findIndex(p => p.includes('d-two-a.js'))
+  const twoBIdx = deps.findIndex(p => p.includes('d-two-b.js'))
+
+  // d-three.js should come before all files that depend on it
+  assert.ok(threeIdx < twoIdx, 'd-three.js should come before d-two.js')
+  assert.ok(threeIdx < twoAIdx, 'd-three.js should come before d-two-a.js')
+  assert.ok(threeIdx < twoBIdx, 'd-three.js should come before d-two-b.js')
+})
+
+test('resolveDepPaths should pass options to depGraph', () => {
+  const deps = resolveDepPaths(CJS_FIXTURE_PATH, { verifyGraph: false })
+
+  assert.ok(Array.isArray(deps), 'Should work with options')
+  assert.ok(deps.length > 0, 'Should return dependencies')
+})
+
+// verifyNodeModules tests
+test('verifyNodeModules should default to false', () => {
+  // CJS_DEEP_FIXTURE_PATH requires 'lodash' but without verifyNodeModules
+  // it should not check if lodash is installed
+  assert.not.throws(() => {
+    depGraph(CJS_DEEP_FIXTURE_PATH)
+  }, 'Should not verify node_modules by default')
+})
+
+test('verifyNodeModules: false should skip node_modules verification', () => {
+  const graph = depGraph(CJS_DEEP_FIXTURE_PATH, { verifyNodeModules: false })
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+})
+
+test('verifyNodeModules: true should verify installed packages', () => {
+  // CJS_DEEP_FIXTURE_PATH requires 'lodash' which should be installed
+  assert.not.throws(() => {
+    depGraph(CJS_DEEP_FIXTURE_PATH, { verifyNodeModules: true })
+  }, 'Should verify and find installed packages')
+})
+
+test('verifyNodeModules: true should build graph successfully with valid packages', () => {
+  const graph = depGraph(CJS_DEEP_FIXTURE_PATH, { verifyNodeModules: true })
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+})
+
+test('verifyNodeModules: true should throw error for missing packages', () => {
+  const fs = require('fs')
+  const testFile = path.resolve(__dirname, 'fixtures/test-missing-pkg.js')
+
+  // Create temporary test file with missing package
+  fs.writeFileSync(testFile, `const fake = require('this-package-does-not-exist-xyz-12345')\nmodule.exports = { fake }`)
+
+  try {
+    assert.throws(() => {
+      depGraph(testFile, { verifyNodeModules: true })
+    }, 'Should throw error for missing package')
+  } finally {
+    fs.unlinkSync(testFile)
+  }
+})
+
+test('verifyNodeModules: true error message should be helpful', () => {
+  const fs = require('fs')
+  const testFile = path.resolve(__dirname, 'fixtures/test-missing-pkg-2.js')
+  const missingPkg = 'nonexistent-package-xyz'
+
+  fs.writeFileSync(testFile, `const fake = require('${missingPkg}')\nmodule.exports = { fake }`)
+
+  try {
+    let errorMessage = ''
+    try {
+      depGraph(testFile, { verifyNodeModules: true })
+    } catch (error) {
+      errorMessage = error.message
+    }
+
+    assert.ok(errorMessage.includes(missingPkg), 'Error should mention the missing package name')
+    assert.ok(errorMessage.includes('could not be resolved'), 'Error should say it could not be resolved')
+  } finally {
+    fs.unlinkSync(testFile)
+  }
+})
+
+test('verifyNodeModules: true should work with both CJS and ESM', () => {
+  // Both fixtures should work (they only have relative imports)
+  assert.not.throws(() => {
+    depGraph(CJS_FIXTURE_PATH, { verifyNodeModules: true })
+  }, 'Should work with CJS')
+
+  assert.not.throws(() => {
+    depGraph(ESM_FIXTURE_PATH, { verifyNodeModules: true })
+  }, 'Should work with ESM')
+})
+
+test('verifyNodeModules should work with all other options', () => {
+  const graph = depGraph(CJS_DEEP_FIXTURE_PATH, {
+    buildGraph: true,
+    verifyGraph: true,
+    verifyNodeModules: true,
+    throwOnFirstError: false
+  })
+
+  assert.ok(graph instanceof Map, 'Should return a Map')
+  assert.ok(graph.size > 0, 'Graph should not be empty')
+})
+
+test('verifyNodeModules with throwOnFirstError: true should throw immediately', () => {
+  const fs = require('fs')
+  const testFile = path.resolve(__dirname, 'fixtures/test-throw-first.js')
+
+  fs.writeFileSync(testFile, `
+const missing1 = require('missing-package-1')
+const missing2 = require('missing-package-2')
+module.exports = { missing1, missing2 }
+`)
+
+  try {
+    let errorThrown = false
+
+    try {
+      depGraph(testFile, { verifyNodeModules: true, throwOnFirstError: true })
+    } catch (error) {
+      errorThrown = true
+      // When throwOnFirstError is true, should throw immediately on first error
+      assert.ok(error.message.includes('missing-package-1'), 'Should throw on first missing package')
+    }
+
+    assert.ok(errorThrown, 'Should throw an error')
+  } finally {
+    fs.unlinkSync(testFile)
+  }
+})
+
+test('verifyNodeModules with throwOnFirstError: false should collect all errors', () => {
+  const fs = require('fs')
+  const testFile = path.resolve(__dirname, 'fixtures/test-collect-errors.js')
+
+  fs.writeFileSync(testFile, `
+const missing1 = require('missing-package-1')
+const missing2 = require('missing-package-2')
+module.exports = { missing1, missing2 }
+`)
+
+  try {
+    let errorMessage = ''
+
+    try {
+      depGraph(testFile, { verifyNodeModules: true, throwOnFirstError: false })
+    } catch (error) {
+      errorMessage = error.message
+    }
+
+    assert.ok(errorMessage.includes('missing-package-1'), 'Should include first error')
+    assert.ok(errorMessage.includes('missing-package-2'), 'Should include second error')
+    assert.ok(errorMessage.includes('2 validation error'), 'Should mention 2 errors')
+  } finally {
+    fs.unlinkSync(testFile)
+  }
+})
+
+test.run()

package/tests/fixtures/cjs-broken-example/index.js

@@ -0,0 +1,8 @@
+const lodash = require('lodash')
+const { one, two, three, fake } = require('./one')
+
+module.exports = {
+  one,
+  two,
+  three
+}

package/tests/fixtures/cjs-broken-example/one.js

@@ -0,0 +1,9 @@
+const { two, three } = require('./sub-folder/two')
+
+const one = 'one'
+
+module.exports = {
+  one,
+  two,
+  three
+}

package/tests/fixtures/cjs-broken-example/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "cjs-example",
+  "version": "1.0.0",
+  "description": "CJS fixture for testing",
+  "main": "./index.js",
+  "type": "commonjs"
+}

package/tests/fixtures/cjs-broken-example/sub-folder/sub-sub-folder/three.js

@@ -0,0 +1,6 @@
+
+const three = 'three'
+
+module.exports = {
+  three
+}

package/tests/fixtures/cjs-broken-example/sub-folder/two.js

@@ -0,0 +1,8 @@
+const { three } = require('./sub-sub-folder/three')
+
+const two = 'two'
+
+module.exports = {
+  two,
+  three
+}

package/tests/fixtures/cjs-deep-example/d-one.js

@@ -0,0 +1,10 @@
+const { two, three } = require('./d-sub-folder/d-two')
+const { twoA } = require('./d-sub-folder/d-two-a')
+const { twoB } = require('./d-sub-folder/d-two-b')
+const one = 'one'
+
+module.exports = {
+  one,
+  two,
+  three
+}

package/tests/fixtures/cjs-deep-example/d-sub-folder/d-sub-sub-folder/d-three.js

@@ -0,0 +1,7 @@
+const { parent } = require('../../../cjs-parent')
+
+const three = 'three'
+
+module.exports = {
+  three
+}

package/tests/fixtures/cjs-deep-example/d-sub-folder/d-two-a.js

@@ -0,0 +1,8 @@
+const { three } = require('./d-sub-sub-folder/d-three')
+
+const twoA = 'twoA'
+
+module.exports = {
+  twoA,
+  three
+}

package/tests/fixtures/cjs-deep-example/d-sub-folder/d-two-b.js

@@ -0,0 +1,8 @@
+const { three } = require('./d-sub-sub-folder/d-three')
+
+const twoB = 'twoB'
+
+module.exports = {
+  twoB,
+  three
+}

package/tests/fixtures/cjs-deep-example/d-sub-folder/d-two.js

@@ -0,0 +1,8 @@
+const { three } = require('./d-sub-sub-folder/d-three')
+
+const two = 'twoB'
+
+module.exports = {
+  two,
+  three
+}

package/tests/fixtures/cjs-deep-example/index.js

@@ -0,0 +1,8 @@
+const lodash = require('lodash')
+const { one, two, three } = require('./d-one')
+
+module.exports = {
+  one,
+  two,
+  three
+}

package/tests/fixtures/cjs-deep-example/package.json

@@ -0,0 +1,15 @@
+{
+  "name": "cjs-deep-example",
+  "version": "1.0.0",
+  "description": "Complex CJS fixture for testing with multiple entry points",
+  "main": "./index.js",
+  "module": "./d-one.js",
+  "exports": {
+    ".": {
+      "require": "./index.js",
+      "import": "./d-one.js"
+    },
+    "./one": "./d-one.js",
+    "./sub": "./d-sub-folder/d-two.js"
+  }
+}

package/tests/fixtures/cjs-example/index.js

@@ -0,0 +1,8 @@
+const lodash = require('lodash')
+const { one, two, three } = require('./one')
+
+module.exports = {
+  one,
+  two,
+  three
+}

package/tests/fixtures/cjs-example/one.js

@@ -0,0 +1,9 @@
+const { two, three } = require('./sub-folder/two')
+
+const one = 'one'
+
+module.exports = {
+  one,
+  two,
+  three
+}

package/tests/fixtures/cjs-example/package.json

@@ -0,0 +1,7 @@
+{
+  "name": "cjs-example",
+  "version": "1.0.0",
+  "description": "CJS fixture for testing",
+  "main": "./index.js",
+  "type": "commonjs"
+}

package/tests/fixtures/cjs-example/sub-folder/sub-sub-folder/three.js

@@ -0,0 +1,6 @@
+
+const three = 'three'
+
+module.exports = {
+  three
+}

package/tests/fixtures/cjs-example/sub-folder/two.js

@@ -0,0 +1,8 @@
+const { three } = require('./sub-sub-folder/three')
+
+const two = 'two'
+
+module.exports = {
+  two,
+  three
+}

package/tests/fixtures/cjs-parent.js

@@ -0,0 +1,5 @@
+const parent = 'parent'
+
+module.exports = {
+  parent
+}

package/tests/fixtures/esm-broken-fixture/index.js

@@ -0,0 +1,8 @@
+import lodash from 'lodash'
+import { one, two, three } from './one.js'
+
+export {
+  one,
+  two,
+  three,
+}

package/tests/fixtures/esm-broken-fixture/one.js

@@ -0,0 +1,9 @@
+import { two, three, four } from './sub-folder/two.js'
+
+const one = 'one'
+
+export {
+  one,
+  two,
+  three
+}

package/tests/fixtures/esm-broken-fixture/package.json

@@ -0,0 +1,15 @@
+{
+  "name": "esm-fixture",
+  "version": "1.0.0",
+  "description": "ESM fixture for testing",
+  "main": "./index.js",
+  "module": "./index.js",
+  "type": "module",
+  "exports": {
+    ".": "./index.js",
+    "./valid": "./valid.js",
+    "./deep/deep": "./sub-folder/sub-sub-folder-two/deep.js",
+    "./test-deep-missing-import-ref": "./one.js",
+    "./non-existent-file": "./non-existent-file.js"
+  }
+}

package/tests/fixtures/esm-broken-fixture/sub-folder/sub-sub-folder/three.js

@@ -0,0 +1,6 @@
+
+const three = 'three'
+
+export {
+  three
+}

package/tests/fixtures/esm-broken-fixture/sub-folder/sub-sub-folder-two/deep.js

@@ -0,0 +1,6 @@
+import { wowDeep } from './even-deeper/wow-deep.js'
+const deep = 'deep'
+
+export {
+  deep
+}

package/tests/fixtures/esm-broken-fixture/sub-folder/sub-sub-folder-two/even-deeper/wow-deep.js

@@ -0,0 +1,5 @@
+const wowDeep = 'wowDeep'
+
+export {
+  wowDeep
+}

package/tests/fixtures/esm-broken-fixture/sub-folder/two.js

@@ -0,0 +1,8 @@
+import { three } from './sub-sub-folder/three.js'
+
+const two = 'two'
+
+export {
+  two,
+  three
+}

package/tests/fixtures/esm-broken-fixture/valid.js

@@ -0,0 +1,7 @@
+import { three } from './sub-folder/sub-sub-folder/three.js'
+const valid = 'valid'
+
+export {
+  valid,
+  three
+}

package/tests/fixtures/esm-fixture/index.js

@@ -0,0 +1,8 @@
+import lodash from 'lodash'
+import { one, two, three } from './one.js'
+
+export {
+  one,
+  two,
+  three
+}

package/tests/fixtures/esm-fixture/one.js

@@ -0,0 +1,9 @@
+import { two, three } from './sub-folder/two.js'
+
+const one = 'one'
+
+export {
+  one,
+  two,
+  three
+}

package/tests/fixtures/esm-fixture/package.json

@@ -0,0 +1,11 @@
+{
+  "name": "esm-fixture",
+  "version": "1.0.0",
+  "description": "ESM fixture for testing",
+  "main": "./index.js",
+  "module": "./index.js",
+  "type": "module",
+  "exports": {
+    ".": "./index.js"
+  }
+}

package/tests/fixtures/esm-fixture/sub-folder/sub-sub-folder/three.js

@@ -0,0 +1,6 @@
+
+const three = 'three'
+
+export {
+  three
+}

package/tests/fixtures/esm-fixture/sub-folder/two.js

@@ -0,0 +1,8 @@
+import { three } from './sub-sub-folder/three.js'
+
+const two = 'two'
+
+export {
+  two,
+  three
+}