@davidvornholt/standards 0.8.0 → 0.9.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -12,7 +12,7 @@ standards github --check
12
12
  standards github --apply
13
13
  ```
14
14
 
15
- `github --check` compares the live GitHub repository (merge settings and rulesets) against the merged declaration in `.github/settings.json` + `.github/settings.local.json`; `github --apply` converges the live repository to exactly the declared state. `check` runs the same comparison whenever `.github/settings.json` is present.
15
+ `github --check` compares the live GitHub repository (merge settings and rulesets) against the merged declaration in `.github/settings.json` + `.github/settings.local.json`; `github --apply` converges the live repository to exactly the declared state. `check` runs the same comparison whenever `.github/settings.json` is present. A repository whose GitHub plan cannot enforce rulesets can declare that in the seam (see `rulesetEnforcement` below); both commands then skip rulesets, still converge repository merge settings, and print an unprotected-branch notice on every run.
16
16
 
17
17
  `structure` enforces the canonical monorepo structure contract: workspace scripts (`check-types`, `lint`, `lint:fix`, `test`), root gate scripts, filtered Turbo convenience aliases, internal `0.0.0`/`workspace:*` versioning, package `exports`, shared tsconfig inheritance, and browser a11y wiring. Only a workspace containing an explicit `*.a11y.ts` suite must provide a `test:a11y` script and direct `@axe-core/playwright` and `@playwright/test` dependencies. `check` includes `structure`, so these rules gate every consumer PR.
18
18
 
@@ -21,6 +21,7 @@ standards github --apply
21
21
  ## Configuration
22
22
 
23
23
  - **`sync-standards.local.json`** (optional) — consumer-owned sync policy at the repo root, validated by `doctor`/`check` and every `init`/`sync` even when an explicit ref or local source makes its `"ref"` irrelevant. All fields optional; a missing file means the defaults. `"ref"` is a non-empty single-line string that pins a tag, branch, or full commit sha to sync from instead of `main` (an explicit `--ref` overrides it; a local-path `--from` source is used as-is and ignores only the validated pin). `"autoSync": false` is read by the standards-sync workflow, not the CLI, and skips the weekly scheduled run. Version 0.7.0 removes the legacy `STANDARDS_AUTO_SYNC` and `STANDARDS_SYNC_REF` variable behavior; consumers must upgrade the package and lockfile before adopting a policy file.
24
+ - **`.github/settings.local.json` `"rulesetEnforcement": "unavailable-on-plan"`** (optional) — declares that the repository's GitHub plan cannot enforce rulesets (private repositories on GitHub Free, both personal accounts and organizations). `github --check` and `--apply` then skip rulesets instead of comparing them, because a comparison cannot be trusted there: personal accounts answer ruleset reads with HTTP 403, and free-plan organizations report declared rulesets as active while silently not enforcing them. Repository merge settings are still checked and converged, and both commands print an unprotected-branch notice on every run. The only accepted value is `"unavailable-on-plan"` (enforcement is the default; omit the key on paid plans), and combining the opt-out with additional local rulesets is rejected. After upgrading the plan, remove the declaration and run `bun standards github --apply` to restore enforcement.
24
25
  - **`GH_TOKEN` / `GITHUB_TOKEN`** (optional) — GitHub API token for the `github` command and the GitHub portion of `check`. When neither is set, the token from the local `gh` CLI is used; with no token at all, reads still work on public repositories. `--apply` and private-repo reads need an authenticated token, and repo merge settings are only visible (and thus verifiable) to admin tokens — non-admin runs report them as unverifiable.
25
26
 
26
27
  See the standards repository README for the ownership model and adoption workflow.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@davidvornholt/standards",
3
- "version": "0.8.0",
3
+ "version": "0.9.0",
4
4
  "description": "Bootstrap, synchronize, and validate davidvornholt/standards consumers",
5
5
  "license": "MIT",
6
6
  "repository": {
@@ -22,8 +22,10 @@
22
22
  "src/cli.ts",
23
23
  "src/github-api.ts",
24
24
  "src/github-apply.ts",
25
+ "src/github-command-shared.ts",
25
26
  "src/github-commands.ts",
26
27
  "src/github-diff.ts",
28
+ "src/github-settings-parse.ts",
27
29
  "src/github-settings.ts",
28
30
  "src/structure-check.ts",
29
31
  "src/structure-profile.ts",
package/src/cli.ts CHANGED
@@ -493,7 +493,7 @@ const runCheck = async (consumer: string): Promise<boolean> => {
493
493
  const problems = results.filter((p): p is string => p !== null);
494
494
  if (problems.length > 0) {
495
495
  console.error(
496
- `standards: ${problems.length} canonical file(s) drifted from upstream:`,
496
+ `standards: ${problems.length} canonical file(s) drifted from the last synced state:`,
497
497
  );
498
498
  console.error(problems.join('\n'));
499
499
  console.error(
@@ -502,7 +502,7 @@ const runCheck = async (consumer: string): Promise<boolean> => {
502
502
  return false;
503
503
  }
504
504
  console.log(
505
- `standards: ${Object.keys(lock.files).length} canonical file(s) match upstream`,
505
+ `standards: ${Object.keys(lock.files).length} canonical file(s) match the last synced state`,
506
506
  );
507
507
  return true;
508
508
  };
package/src/github-api.ts CHANGED
@@ -8,10 +8,10 @@ import { readFile } from 'node:fs/promises';
8
8
  import { join } from 'node:path';
9
9
  import process from 'node:process';
10
10
  import {
11
- isRecord,
12
11
  type LoadedGithubSettings,
13
12
  loadGithubSettings,
14
13
  } from './github-settings';
14
+ import { isRecord } from './github-settings-parse';
15
15
 
16
16
  const API_ROOT = 'https://api.github.com';
17
17
 
@@ -32,6 +32,7 @@ const quietExec = (
32
32
  try {
33
33
  const out = execFileSync(file, [...args], {
34
34
  encoding: 'utf8',
35
+ env: process.env,
35
36
  stdio: ['ignore', 'pipe', 'ignore'],
36
37
  }).trim();
37
38
  return out.length > 0 ? out : null;
@@ -10,8 +10,40 @@ import {
10
10
  HTTP_OK,
11
11
  request,
12
12
  } from './github-api';
13
- import { diffRuleset } from './github-diff';
14
- import type { GithubSettings } from './github-settings';
13
+ import { diffRepositorySettings, diffRuleset } from './github-diff';
14
+ import type { GithubSettings } from './github-settings-parse';
15
+
16
+ export const applyRepositorySettings = async (
17
+ token: string,
18
+ repo: string,
19
+ repository: Readonly<Record<string, unknown>>,
20
+ liveRepository: Readonly<Record<string, unknown>>,
21
+ ): Promise<ReadonlyArray<string>> => {
22
+ const diff = diffRepositorySettings(repository, liveRepository);
23
+ if (diff.drifted.length === 0 && diff.unverifiable.length === 0) {
24
+ return [];
25
+ }
26
+ const patched = await request(token, 'PATCH', `/repos/${repo}`, repository);
27
+ if (patched.status !== HTTP_OK) {
28
+ throw new Error(apiError('updating repository settings', patched));
29
+ }
30
+ return ['updated repository merge settings'];
31
+ };
32
+
33
+ export const applySummary = (
34
+ repo: string,
35
+ actions: ReadonlyArray<string>,
36
+ rulesetsSkipped: boolean,
37
+ ): string => {
38
+ if (rulesetsSkipped) {
39
+ return actions.length === 0
40
+ ? `standards github: repository settings already converged for ${repo}; rulesets skipped`
41
+ : `standards github: repository settings apply complete for ${repo}; rulesets skipped`;
42
+ }
43
+ return actions.length === 0
44
+ ? 'standards github: already converged; no changes'
45
+ : `standards github: apply complete for ${repo}`;
46
+ };
15
47
 
16
48
  const reconcileRuleset = async (
17
49
  token: string,
@@ -0,0 +1,11 @@
1
+ import type { GithubSettings } from './github-settings-parse';
2
+
3
+ export const optOutEligibilityProblem = (
4
+ repo: string,
5
+ declared: GithubSettings,
6
+ liveRepository: Readonly<Record<string, unknown>>,
7
+ ): string | null =>
8
+ declared.rulesetEnforcement === 'unavailable-on-plan' &&
9
+ liveRepository.private !== true
10
+ ? `.github/settings.local.json "rulesetEnforcement" may only be declared for a private repository; ${repo} is public`
11
+ : null;
@@ -12,9 +12,19 @@ import {
12
12
  resolveGithubRepo,
13
13
  resolveToken,
14
14
  } from './github-api';
15
- import { applyRulesets } from './github-apply';
15
+ import {
16
+ applyRepositorySettings,
17
+ applyRulesets,
18
+ applySummary,
19
+ } from './github-apply';
20
+ import { optOutEligibilityProblem } from './github-command-shared';
16
21
  import { diffRepositorySettings, diffRulesets } from './github-diff';
17
- import { type GithubSettings, isRecord } from './github-settings';
22
+ import { type GithubSettings, isRecord } from './github-settings-parse';
23
+
24
+ // Printed on every check and apply while the opt-out is declared: the skip
25
+ // must stay louder than the comfort of a green gate.
26
+ const UNENFORCEABLE_NOTICE =
27
+ 'standards github: rulesets are declared unenforceable on this GitHub plan (.github/settings.local.json "rulesetEnforcement"); the default branch is NOT protected. After upgrading the plan, remove the declaration, then run `bun standards github --apply`.';
18
28
 
19
29
  const reportProblems = (problems: ReadonlyArray<string>): void => {
20
30
  console.error(
@@ -23,6 +33,53 @@ const reportProblems = (problems: ReadonlyArray<string>): void => {
23
33
  console.error(problems.map((problem) => ` - ${problem}`).join('\n'));
24
34
  };
25
35
 
36
+ const repositoryDrift = async (
37
+ token: string | null,
38
+ repo: string,
39
+ declared: GithubSettings,
40
+ ): Promise<ReadonlyArray<string>> => {
41
+ const repoResponse = await request(token, 'GET', `/repos/${repo}`);
42
+ if (repoResponse.status !== HTTP_OK || !isRecord(repoResponse.body)) {
43
+ return [apiError(`reading repository ${repo}`, repoResponse)];
44
+ }
45
+ const eligibilityProblem = optOutEligibilityProblem(
46
+ repo,
47
+ declared,
48
+ repoResponse.body,
49
+ );
50
+ if (eligibilityProblem !== null) {
51
+ return [eligibilityProblem];
52
+ }
53
+ const diff = diffRepositorySettings(declared.repository, repoResponse.body);
54
+ if (diff.unverifiable.length > 0) {
55
+ console.log(
56
+ `standards github: repository setting(s) not visible to this token, verify with admin auth: ${diff.unverifiable.join(', ')}`,
57
+ );
58
+ }
59
+ return diff.drifted;
60
+ };
61
+
62
+ const rulesetDrift = async (
63
+ token: string | null,
64
+ repo: string,
65
+ declared: GithubSettings,
66
+ ): Promise<ReadonlyArray<string>> => {
67
+ if (declared.rulesetEnforcement === 'unavailable-on-plan') {
68
+ return [];
69
+ }
70
+ const live = await fetchLiveRulesets(token, repo);
71
+ if (live.rulesets === null) {
72
+ return [live.problem ?? 'unable to read rulesets'];
73
+ }
74
+ const diff = diffRulesets(declared.rulesets, live.rulesets);
75
+ if (diff.unverifiable.length > 0) {
76
+ console.log(
77
+ `standards github: ruleset field(s) not visible to this token, verify with admin auth: ${diff.unverifiable.join('; ')}`,
78
+ );
79
+ }
80
+ return diff.drifted;
81
+ };
82
+
26
83
  const collectLiveDrift = async (
27
84
  consumer: string,
28
85
  declared: GithubSettings,
@@ -32,45 +89,23 @@ const collectLiveDrift = async (
32
89
  return ['cannot determine the GitHub repository from the origin remote'];
33
90
  }
34
91
  const token = resolveToken();
35
- const problems: Array<string> = [];
36
92
  try {
37
- const repoResponse = await request(token, 'GET', `/repos/${repo}`);
38
- if (repoResponse.status !== HTTP_OK || !isRecord(repoResponse.body)) {
39
- problems.push(apiError(`reading repository ${repo}`, repoResponse));
40
- } else {
41
- const diff = diffRepositorySettings(
42
- declared.repository,
43
- repoResponse.body,
44
- );
45
- problems.push(...diff.drifted);
46
- if (diff.unverifiable.length > 0) {
47
- console.log(
48
- `standards github: repository setting(s) not visible to this token, verify with admin auth: ${diff.unverifiable.join(', ')}`,
49
- );
50
- }
51
- }
52
- const live = await fetchLiveRulesets(token, repo);
53
- if (live.rulesets === null) {
54
- problems.push(live.problem ?? 'unable to read rulesets');
55
- } else {
56
- const rulesetDiff = diffRulesets(declared.rulesets, live.rulesets);
57
- problems.push(...rulesetDiff.drifted);
58
- if (rulesetDiff.unverifiable.length > 0) {
59
- console.log(
60
- `standards github: ruleset field(s) not visible to this token, verify with admin auth: ${rulesetDiff.unverifiable.join('; ')}`,
61
- );
62
- }
63
- }
93
+ return [
94
+ ...(await repositoryDrift(token, repo, declared)),
95
+ ...(await rulesetDrift(token, repo, declared)),
96
+ ];
64
97
  } catch (error) {
65
- problems.push(
98
+ return [
66
99
  `GitHub API unreachable: ${error instanceof Error ? error.message : String(error)}`,
67
- );
100
+ ];
68
101
  }
69
- return problems;
70
102
  };
71
103
 
72
104
  export const runGithubCheck = async (consumer: string): Promise<boolean> => {
73
105
  const declared = await loadDeclared(consumer);
106
+ if (declared.merged?.rulesetEnforcement === 'unavailable-on-plan') {
107
+ console.log(UNENFORCEABLE_NOTICE);
108
+ }
74
109
  const problems = [...declared.problems];
75
110
  if (declared.merged !== null) {
76
111
  problems.push(...(await collectLiveDrift(consumer, declared.merged)));
@@ -83,13 +118,18 @@ export const runGithubCheck = async (consumer: string): Promise<boolean> => {
83
118
  return false;
84
119
  }
85
120
  console.log(
86
- 'standards github: live GitHub settings match the declared configuration',
121
+ declared.merged?.rulesetEnforcement === 'unavailable-on-plan'
122
+ ? 'standards github: live repository settings match the declared configuration (rulesets skipped)'
123
+ : 'standards github: live GitHub settings match the declared configuration',
87
124
  );
88
125
  return true;
89
126
  };
90
127
 
91
128
  export const runGithubApply = async (consumer: string): Promise<boolean> => {
92
129
  const declared = await loadDeclared(consumer);
130
+ if (declared.merged?.rulesetEnforcement === 'unavailable-on-plan') {
131
+ console.log(UNENFORCEABLE_NOTICE);
132
+ }
93
133
  if (declared.merged === null || declared.problems.length > 0) {
94
134
  reportProblems(declared.problems);
95
135
  return false;
@@ -109,36 +149,35 @@ export const runGithubApply = async (consumer: string): Promise<boolean> => {
109
149
  return false;
110
150
  }
111
151
  try {
112
- const actions: Array<string> = [];
113
152
  const repoResponse = await request(token, 'GET', `/repos/${repo}`);
114
153
  if (repoResponse.status !== HTTP_OK || !isRecord(repoResponse.body)) {
115
154
  throw new Error(apiError(`reading repository ${repo}`, repoResponse));
116
155
  }
117
- const diff = diffRepositorySettings(
118
- declared.merged.repository,
156
+ const eligibilityProblem = optOutEligibilityProblem(
157
+ repo,
158
+ declared.merged,
119
159
  repoResponse.body,
120
160
  );
121
- if (diff.drifted.length > 0 || diff.unverifiable.length > 0) {
122
- const patched = await request(
161
+ if (eligibilityProblem !== null) {
162
+ throw new Error(eligibilityProblem);
163
+ }
164
+ const actions = [
165
+ ...(await applyRepositorySettings(
123
166
  token,
124
- 'PATCH',
125
- `/repos/${repo}`,
167
+ repo,
126
168
  declared.merged.repository,
127
- );
128
- if (patched.status !== HTTP_OK) {
129
- throw new Error(apiError('updating repository settings', patched));
130
- }
131
- actions.push('updated repository merge settings');
169
+ repoResponse.body,
170
+ )),
171
+ ];
172
+ const rulesetsSkipped =
173
+ declared.merged.rulesetEnforcement === 'unavailable-on-plan';
174
+ if (!rulesetsSkipped) {
175
+ actions.push(...(await applyRulesets(token, repo, declared.merged)));
132
176
  }
133
- actions.push(...(await applyRulesets(token, repo, declared.merged)));
134
177
  for (const action of actions) {
135
178
  console.log(` ${action}`);
136
179
  }
137
- console.log(
138
- actions.length === 0
139
- ? 'standards github: already converged; no changes'
140
- : `standards github: apply complete for ${repo}`,
141
- );
180
+ console.log(applySummary(repo, actions, rulesetsSkipped));
142
181
  return true;
143
182
  } catch (error) {
144
183
  console.error(
@@ -1,7 +1,7 @@
1
1
  // Drift comparison between declared GitHub settings (github-settings.ts) and
2
2
  // the live state returned by the GitHub API. Pure logic; no network.
3
3
 
4
- import { isRecord } from './github-settings';
4
+ import { isRecord } from './github-settings-parse';
5
5
 
6
6
  export type SettingsDiff = {
7
7
  readonly drifted: ReadonlyArray<string>;
@@ -0,0 +1,120 @@
1
+ // Shape parsing for a single declarative GitHub settings file: the canonical
2
+ // `.github/settings.json` or the repo-owned `.github/settings.local.json`
3
+ // extension. Seam merging lives in github-settings.ts, drift comparison in
4
+ // github-diff.ts, and the API interaction in github-api.ts. Like cli.ts, this
5
+ // module is zero-dependency so `bunx` can execute the published package.
6
+
7
+ // GitHub only enforces rulesets on private repositories on paid plans. The
8
+ // seam can declare that fact so the gate skips rulesets loudly instead of
9
+ // failing closed forever (personal accounts) or trusting rulesets the API
10
+ // reports as active but a free-plan organization silently does not enforce.
11
+ export type RulesetEnforcement = 'enforced' | 'unavailable-on-plan';
12
+
13
+ export type GithubSettings = {
14
+ readonly repository: Readonly<Record<string, unknown>>;
15
+ readonly rulesets: ReadonlyArray<Readonly<Record<string, unknown>>>;
16
+ readonly rulesetEnforcement: RulesetEnforcement;
17
+ };
18
+
19
+ export type ParsedGithubSettings = {
20
+ readonly repository: Readonly<Record<string, unknown>> | null;
21
+ readonly rulesets: ReadonlyArray<unknown> | null;
22
+ readonly rulesetEnforcement: RulesetEnforcement | null;
23
+ };
24
+
25
+ export const isRecord = (value: unknown): value is Record<string, unknown> =>
26
+ typeof value === 'object' && value !== null && !Array.isArray(value);
27
+
28
+ export const isNamedRuleset = (
29
+ value: unknown,
30
+ ): value is Readonly<Record<string, unknown>> & { readonly name: string } =>
31
+ isRecord(value) && typeof value.name === 'string' && value.name.length > 0;
32
+
33
+ export const SETTINGS_KEYS: ReadonlySet<string> = new Set([
34
+ 'repository',
35
+ 'rulesets',
36
+ ]);
37
+ export const LOCAL_SETTINGS_KEYS: ReadonlySet<string> = new Set([
38
+ ...SETTINGS_KEYS,
39
+ 'rulesetEnforcement',
40
+ ]);
41
+
42
+ export const ENFORCEMENT_OPT_OUT = 'unavailable-on-plan';
43
+
44
+ export type ParseResult = {
45
+ readonly settings: ParsedGithubSettings | null;
46
+ readonly problems: ReadonlyArray<string>;
47
+ };
48
+
49
+ const parseRulesetEnforcement = (value: unknown): RulesetEnforcement | null => {
50
+ if (value === undefined) {
51
+ return 'enforced';
52
+ }
53
+ return value === ENFORCEMENT_OPT_OUT ? ENFORCEMENT_OPT_OUT : null;
54
+ };
55
+
56
+ const rulesetListProblems = (
57
+ rulesets: ReadonlyArray<unknown>,
58
+ label: string,
59
+ ): ReadonlyArray<string> => {
60
+ const problems: Array<string> = [];
61
+ const names = new Set<string>();
62
+ for (const [index, ruleset] of rulesets.entries()) {
63
+ if (!isNamedRuleset(ruleset)) {
64
+ problems.push(
65
+ `${label} rulesets[${index}] must be an object with a non-empty "name"`,
66
+ );
67
+ } else if (names.has(ruleset.name)) {
68
+ problems.push(
69
+ `${label} declares ruleset "${ruleset.name}" more than once`,
70
+ );
71
+ } else {
72
+ names.add(ruleset.name);
73
+ }
74
+ }
75
+ return problems;
76
+ };
77
+
78
+ export const parseSettings = (
79
+ raw: unknown,
80
+ label: string,
81
+ allowedKeys: ReadonlySet<string>,
82
+ ): ParseResult => {
83
+ if (!isRecord(raw)) {
84
+ return { settings: null, problems: [`${label} must be a JSON object`] };
85
+ }
86
+ const problems: Array<string> = [];
87
+ for (const key of Object.keys(raw)) {
88
+ if (!allowedKeys.has(key)) {
89
+ problems.push(`${label} has unknown key "${key}"`);
90
+ }
91
+ }
92
+ const repository = raw.repository ?? {};
93
+ if (!isRecord(repository)) {
94
+ problems.push(`${label} "repository" must be an object`);
95
+ }
96
+ const rulesets = raw.rulesets ?? [];
97
+ if (Array.isArray(rulesets)) {
98
+ problems.push(...rulesetListProblems(rulesets, label));
99
+ } else {
100
+ problems.push(`${label} "rulesets" must be an array`);
101
+ }
102
+ // Only the opt-out value is accepted: enforcement is the default, and an
103
+ // explicit "enforced" would be a second way to spell the same state.
104
+ if (
105
+ raw.rulesetEnforcement !== undefined &&
106
+ raw.rulesetEnforcement !== ENFORCEMENT_OPT_OUT
107
+ ) {
108
+ problems.push(
109
+ `${label} "rulesetEnforcement" must be "${ENFORCEMENT_OPT_OUT}" when present; omit it on plans where GitHub enforces rulesets`,
110
+ );
111
+ }
112
+ return {
113
+ settings: {
114
+ repository: isRecord(repository) ? repository : null,
115
+ rulesets: Array.isArray(rulesets) ? rulesets : null,
116
+ rulesetEnforcement: parseRulesetEnforcement(raw.rulesetEnforcement),
117
+ },
118
+ problems,
119
+ };
120
+ };
@@ -1,125 +1,134 @@
1
- // Declarative GitHub repository settings: parsing and seam merging for the
2
- // canonical `.github/settings.json` and the repo-owned
3
- // `.github/settings.local.json` extension. Pure logic only; drift comparison
4
- // lives in github-diff.ts and the API interaction in github-api.ts. Like
5
- // cli.ts, this module is zero-dependency so `bunx` can execute the published
6
- // package.
1
+ // Merge canonical GitHub settings with the repo-owned extension. Parsing,
2
+ // drift, and API work live in named modules; this stays dependency-free.
7
3
 
8
- export type GithubSettings = {
9
- readonly repository: Readonly<Record<string, unknown>>;
10
- readonly rulesets: ReadonlyArray<Readonly<Record<string, unknown>>>;
11
- };
4
+ import {
5
+ ENFORCEMENT_OPT_OUT,
6
+ type GithubSettings,
7
+ isNamedRuleset,
8
+ LOCAL_SETTINGS_KEYS,
9
+ type ParsedGithubSettings,
10
+ parseSettings,
11
+ SETTINGS_KEYS,
12
+ } from './github-settings-parse';
12
13
 
13
14
  export type LoadedGithubSettings = {
14
15
  readonly merged: GithubSettings | null;
15
16
  readonly problems: ReadonlyArray<string>;
16
17
  };
17
18
 
18
- export const isRecord = (value: unknown): value is Record<string, unknown> =>
19
- typeof value === 'object' && value !== null && !Array.isArray(value);
20
-
21
- const SETTINGS_KEYS = new Set(['repository', 'rulesets']);
22
-
23
- type ParseResult = {
24
- readonly settings: GithubSettings | null;
25
- readonly problems: ReadonlyArray<string>;
19
+ const completeSettings = (
20
+ parsed: ParsedGithubSettings | null,
21
+ ): GithubSettings | null => {
22
+ if (
23
+ parsed === null ||
24
+ parsed.repository === null ||
25
+ parsed.rulesets === null ||
26
+ parsed.rulesetEnforcement === null
27
+ ) {
28
+ return null;
29
+ }
30
+ const rulesets = parsed.rulesets.filter(isNamedRuleset);
31
+ if (rulesets.length !== parsed.rulesets.length) {
32
+ return null;
33
+ }
34
+ return {
35
+ repository: parsed.repository,
36
+ rulesets,
37
+ rulesetEnforcement: parsed.rulesetEnforcement,
38
+ };
26
39
  };
27
40
 
28
- const rulesetListProblems = (
29
- rulesets: ReadonlyArray<unknown>,
30
- label: string,
41
+ const enforcementMergeProblems = (
42
+ local: ParsedGithubSettings | null,
31
43
  ): ReadonlyArray<string> => {
32
- const problems: Array<string> = [];
33
- const names = new Set<string>();
34
- for (const [index, ruleset] of rulesets.entries()) {
35
- if (
36
- !(
37
- isRecord(ruleset) &&
38
- typeof ruleset.name === 'string' &&
39
- ruleset.name.length > 0
40
- )
41
- ) {
42
- problems.push(
43
- `${label} rulesets[${index}] must be an object with a non-empty "name"`,
44
- );
45
- } else if (names.has(ruleset.name)) {
46
- problems.push(
47
- `${label} declares ruleset "${ruleset.name}" more than once`,
48
- );
49
- } else {
50
- names.add(ruleset.name);
51
- }
44
+ if (
45
+ local?.rulesetEnforcement !== ENFORCEMENT_OPT_OUT ||
46
+ local.rulesets === null ||
47
+ local.rulesets.length === 0
48
+ ) {
49
+ return [];
52
50
  }
53
- return problems;
51
+ return [
52
+ `.github/settings.local.json declares additional rulesets while "rulesetEnforcement" is "${ENFORCEMENT_OPT_OUT}"; remove the rulesets or the opt-out`,
53
+ ];
54
54
  };
55
55
 
56
- const parseSettings = (raw: unknown, label: string): ParseResult => {
57
- if (!isRecord(raw)) {
58
- return { settings: null, problems: [`${label} must be a JSON object`] };
59
- }
60
- const problems: Array<string> = [];
61
- for (const key of Object.keys(raw)) {
62
- if (!SETTINGS_KEYS.has(key)) {
63
- problems.push(`${label} has unknown key "${key}"`);
64
- }
65
- }
66
- const repository = raw.repository ?? {};
67
- if (!isRecord(repository)) {
68
- problems.push(`${label} "repository" must be an object`);
69
- }
70
- const rulesets = raw.rulesets ?? [];
71
- if (Array.isArray(rulesets)) {
72
- problems.push(...rulesetListProblems(rulesets, label));
73
- } else {
74
- problems.push(`${label} "rulesets" must be an array`);
75
- }
76
- if (problems.length > 0) {
77
- return { settings: null, problems };
56
+ const repositoryMergeProblems = (
57
+ canonical: ParsedGithubSettings | null,
58
+ local: ParsedGithubSettings | null,
59
+ ): ReadonlyArray<string> => {
60
+ if (
61
+ canonical === null ||
62
+ canonical.repository === null ||
63
+ local === null ||
64
+ local.repository === null
65
+ ) {
66
+ return [];
78
67
  }
79
- return {
80
- settings: {
81
- repository: repository as Record<string, unknown>,
82
- rulesets: rulesets as ReadonlyArray<Record<string, unknown>>,
83
- },
84
- problems: [],
85
- };
68
+ const canonicalRepository = canonical.repository;
69
+ return Object.keys(local.repository)
70
+ .filter((key) => key in canonicalRepository)
71
+ .map(
72
+ (key) =>
73
+ `.github/settings.local.json repository."${key}" would override a canonical value; canonical settings are read-only`,
74
+ );
86
75
  };
87
76
 
88
- type MergeResult = {
89
- readonly merged: GithubSettings | null;
90
- readonly problems: ReadonlyArray<string>;
77
+ const rulesetMergeProblems = (
78
+ canonical: ParsedGithubSettings | null,
79
+ local: ParsedGithubSettings | null,
80
+ ): ReadonlyArray<string> => {
81
+ if (
82
+ canonical === null ||
83
+ canonical.rulesets === null ||
84
+ local === null ||
85
+ local.rulesets === null
86
+ ) {
87
+ return [];
88
+ }
89
+ const canonicalNames = new Set(
90
+ canonical.rulesets.filter(isNamedRuleset).map((ruleset) => ruleset.name),
91
+ );
92
+ return local.rulesets
93
+ .filter(isNamedRuleset)
94
+ .filter((ruleset) => canonicalNames.has(ruleset.name))
95
+ .map(
96
+ (ruleset) =>
97
+ `.github/settings.local.json ruleset "${ruleset.name}" collides with a canonical ruleset; add a separately named ruleset to tighten further`,
98
+ );
91
99
  };
92
100
 
93
101
  // The seam may only add. Overriding a canonical repository key or redefining a
94
102
  // canonical ruleset could weaken the canonical floor; GitHub layers multiple
95
- // rulesets strictest-wins, so adding a ruleset is always safe.
103
+ // rulesets strictest-wins, so adding a ruleset is always safe. The one
104
+ // subtractive declaration is the ruleset-enforcement opt-out, which skips the
105
+ // ruleset gate entirely rather than weakening any single rule.
96
106
  const mergeSettings = (
97
- canonical: GithubSettings,
98
- local: GithubSettings,
99
- ): MergeResult => {
100
- const problems: Array<string> = [];
101
- for (const key of Object.keys(local.repository)) {
102
- if (key in canonical.repository) {
103
- problems.push(
104
- `.github/settings.local.json repository."${key}" would override a canonical value; canonical settings are read-only`,
105
- );
106
- }
107
- }
108
- const canonicalNames = new Set(canonical.rulesets.map((r) => r.name));
109
- for (const ruleset of local.rulesets) {
110
- if (canonicalNames.has(ruleset.name)) {
111
- problems.push(
112
- `.github/settings.local.json ruleset "${ruleset.name}" collides with a canonical ruleset; add a separately named ruleset to tighten further`,
113
- );
114
- }
115
- }
116
- if (problems.length > 0) {
107
+ canonical: ParsedGithubSettings | null,
108
+ local: ParsedGithubSettings | null,
109
+ ) => {
110
+ const problems = [
111
+ ...enforcementMergeProblems(local),
112
+ ...repositoryMergeProblems(canonical, local),
113
+ ...rulesetMergeProblems(canonical, local),
114
+ ];
115
+ const completeCanonical = completeSettings(canonical);
116
+ const completeLocal = completeSettings(local);
117
+ if (
118
+ problems.length > 0 ||
119
+ completeCanonical === null ||
120
+ completeLocal === null
121
+ ) {
117
122
  return { merged: null, problems };
118
123
  }
119
124
  return {
120
125
  merged: {
121
- repository: { ...canonical.repository, ...local.repository },
122
- rulesets: [...canonical.rulesets, ...local.rulesets],
126
+ repository: {
127
+ ...completeCanonical.repository,
128
+ ...completeLocal.repository,
129
+ },
130
+ rulesets: [...completeCanonical.rulesets, ...completeLocal.rulesets],
131
+ rulesetEnforcement: completeLocal.rulesetEnforcement,
123
132
  },
124
133
  problems: [],
125
134
  };
@@ -160,15 +169,32 @@ export const loadGithubSettings = (
160
169
  if (localJson !== null && localJson.problem !== null) {
161
170
  problems.push(localJson.problem);
162
171
  }
163
- if (problems.length > 0) {
164
- return { merged: null, problems };
172
+ const canonical =
173
+ canonicalJson.problem === null
174
+ ? parseSettings(
175
+ canonicalJson.value,
176
+ '.github/settings.json',
177
+ SETTINGS_KEYS,
178
+ )
179
+ : null;
180
+ const local =
181
+ localJson?.problem === null
182
+ ? parseSettings(
183
+ localJson.value,
184
+ '.github/settings.local.json',
185
+ LOCAL_SETTINGS_KEYS,
186
+ )
187
+ : null;
188
+ if (canonical !== null) {
189
+ problems.push(...canonical.problems);
165
190
  }
166
- const canonical = parseSettings(canonicalJson.value, '.github/settings.json');
167
- const local = parseSettings(localJson?.value, '.github/settings.local.json');
168
- problems.push(...canonical.problems, ...local.problems);
169
- if (canonical.settings === null || local.settings === null) {
170
- return { merged: null, problems };
191
+ if (local !== null) {
192
+ problems.push(...local.problems);
171
193
  }
172
- const merged = mergeSettings(canonical.settings, local.settings);
173
- return { merged: merged.merged, problems: [...problems, ...merged.problems] };
194
+ const merged = mergeSettings(
195
+ canonical?.settings ?? null,
196
+ local?.settings ?? null,
197
+ );
198
+ problems.push(...merged.problems);
199
+ return { merged: problems.length === 0 ? merged.merged : null, problems };
174
200
  };
@@ -1,7 +1,7 @@
1
1
  import { existsSync } from 'node:fs';
2
2
  import { readdir, readFile } from 'node:fs/promises';
3
3
  import { isAbsolute, join } from 'node:path';
4
- import { isRecord } from './github-settings';
4
+ import { isRecord } from './github-settings-parse';
5
5
  import {
6
6
  missingPublishedCliProblems,
7
7
  rootScriptExpectations,
@@ -1,4 +1,4 @@
1
- import { isRecord } from './github-settings';
1
+ import { isRecord } from './github-settings-parse';
2
2
 
3
3
  // Structure validation profiles. `consumer` is the contract every downstream
4
4
  // repo satisfies. `source` is the standards template repository itself, which
@@ -1,6 +1,6 @@
1
1
  import { readdir, readFile } from 'node:fs/promises';
2
2
  import { join } from 'node:path';
3
- import { isRecord } from './github-settings';
3
+ import { isRecord } from './github-settings-parse';
4
4
  import {
5
5
  inspectVersionAndExports,
6
6
  type StructureProfile,