@davidvornholt/standards 0.19.0 → 0.21.0

package/src/poller-protocol.ts

@@ -76,8 +76,6 @@ const GATE_WIRING_FILES: ReadonlySet<string> = new Set([
 const HOST_SECRETS_FILE = /(?:^|\/)secrets\.yaml$/u;
 const WORKSPACE_GATE_CONFIG =
   /(?:^|\/)(?:biome\.jsonc|turbo\.json|tsconfig(?:\.[^.]+)?\.json|vitest\.config\.[cm]?[jt]s|playwright\.config\.[cm]?[jt]s)$/u;
-const QUALITY_SCRIPT = /^(?:check|lint|test|typecheck)(?::|$)/u;
-const WORKSPACE_MANIFEST = /^(?:apps|packages)\/[^/]+\/package\.json$/u;
 
 const isEncryptedSecret = (path: string): boolean =>
   !path.endsWith('.example.yaml') &&
@@ -101,46 +99,6 @@ export const forbiddenDiffPaths = (
   );
 };
 
-const qualityScripts = (
-  manifest: unknown,
-): Readonly<Record<string, string>> => {
-  if (
-    typeof manifest !== 'object' ||
-    manifest === null ||
-    !('scripts' in manifest) ||
-    typeof manifest.scripts !== 'object' ||
-    manifest.scripts === null
-  ) {
-    return {};
-  }
-  return Object.fromEntries(
-    Object.entries(manifest.scripts)
-      .filter(
-        (entry): entry is [string, string] =>
-          QUALITY_SCRIPT.test(entry[0]) && typeof entry[1] === 'string',
-      )
-      .sort(([left], [right]) => left.localeCompare(right)),
-  );
-};
-
-export const changesWorkspaceQualityScripts = (
-  path: string,
-  before: string,
-  after: string,
-): boolean => {
-  if (path === 'package.json' || !WORKSPACE_MANIFEST.test(path)) {
-    return false;
-  }
-  try {
-    return (
-      JSON.stringify(qualityScripts(JSON.parse(before) as unknown)) !==
-      JSON.stringify(qualityScripts(JSON.parse(after) as unknown))
-    );
-  } catch {
-    return true;
-  }
-};
-
 export const branchNameForIssue = (
   issueNumber: number,
   approvalId: string,

package/src/poller-review-publication.ts

@@ -1,10 +1,7 @@
 import type { ClaimBinding } from './poller-claim';
 import type { PullRequest } from './poller-github-pulls';
 import { failJob, type JobDeps, type JobLabels } from './poller-job-shared';
-import {
-  changedWorkspaceQualityManifests,
-  lockedPathsOf,
-} from './poller-protected-paths';
+import { lockedPathsOf } from './poller-protected-paths';
 import { forbiddenDiffPaths, type ReviewOutcome } from './poller-protocol';
 import { publishReviewArtifacts } from './poller-review-artifacts';
 import {
@@ -89,10 +86,7 @@ export const finishReviewedJob = async (options: {
   const { deps, labels, pr, claim, workDir, outcome } = options;
   const commits = commitCount(workDir, pr.headSha);
   const paths = commits > 0 ? changedPaths(workDir, pr.headSha) : [];
-  const forbidden = [
-    ...forbiddenDiffPaths(paths, await lockedPathsOf(workDir)),
-    ...changedWorkspaceQualityManifests(workDir, pr.headSha, paths),
-  ];
+  const forbidden = forbiddenDiffPaths(paths, await lockedPathsOf(workDir));
   if (forbidden.length > 0) {
     await failJob(
       deps,

package/src/poller-review-validation.ts

@@ -7,10 +7,7 @@ import {
   createValidationWorktree,
   isAncestor,
 } from './poller-output-integrity';
-import {
-  changedWorkspaceQualityManifests,
-  lockedPathsOf,
-} from './poller-protected-paths';
+import { lockedPathsOf } from './poller-protected-paths';
 import { forbiddenDiffPaths } from './poller-protocol';
 import type { ReviewPublicationPlan } from './poller-review-output';
 
@@ -47,14 +44,10 @@ export const validateSealedReviewOutput = async (options: {
     ),
   );
   try {
-    const forbidden = [
-      ...forbiddenDiffPaths(paths, await lockedPathsOf(workspace.dir)),
-      ...changedWorkspaceQualityManifests(
-        workspace.dir,
-        plan.approvedHead,
-        paths,
-      ),
-    ];
+    const forbidden = forbiddenDiffPaths(
+      paths,
+      await lockedPathsOf(workspace.dir),
+    );
     if (forbidden.length > 0) {
       throw new Error(
         `publication blocked: sealed review modified protected paths:\n${forbidden.join('\n')}`,