@davidvornholt/standards 0.19.0 → 0.20.0

package/src/creds-store-lock.ts

@@ -1,12 +1,17 @@
-// Broker store lock: a mkdir-based mutex serializing read-modify-write
-// cycles on broker.yaml. Store writes are sub-second, so a lock directory
-// older than the staleness window can only belong to a dead process and is
-// broken automatically; the timeout error names the directory and the manual
-// remediation for the pathological rest.
+// Broker store lock: a fully initialized generation is atomically renamed into
+// place before its operation starts. A worker-thread lease remains live while
+// synchronous SOPS/Nix blocks the main event loop. Cleanup unlinks the exact
+// generation token before removing the directory, so an old owner cannot
+// remove a replacement.
 
-import { mkdir, rmdir, stat } from 'node:fs/promises';
+import { mkdir } from 'node:fs/promises';
 import { dirname } from 'node:path';
-import { isRecord } from './github-settings-parse';
+import {
+  type HeldBrokerLock,
+  releaseBrokerLock,
+  tryAcquireBrokerLock,
+} from './creds-store-lock-holder';
+import { inspectBrokerLock } from './creds-store-lock-inspection';
 
 const OWNER_ONLY_DIR_MODE = 0o700;
 
@@ -23,59 +28,30 @@ const DEFAULT_STALE_MS = 30_000;
 const sleep = (ms: number): Promise<void> =>
   new Promise((resolve) => setTimeout(resolve, ms));
 
-const tryAcquire = async (lockPath: string): Promise<boolean> => {
-  try {
-    await mkdir(lockPath, { mode: OWNER_ONLY_DIR_MODE });
-    return true;
-  } catch (error) {
-    if (isRecord(error) && error.code === 'EEXIST') {
-      return false;
-    }
-    throw error;
-  }
-};
-
-// True when the contender may immediately retry: the lock vanished, or it
-// was stale and this process removed it (losing the removal race to another
-// contender also lands here — the retry's mkdir arbitrates).
-const breakIfStale = async (
-  lockPath: string,
-  staleMs: number,
-): Promise<boolean> => {
-  try {
-    const info = await stat(lockPath);
-    if (Date.now() - info.mtimeMs < staleMs) {
-      return false;
-    }
-    await rmdir(lockPath);
-    return true;
-  } catch {
-    return true;
-  }
-};
-
 // One acquisition attempt: acquired, or cleared a stale/vanished lock (retry
-// immediately), or waited one retry slot; a live lock past the deadline
-// throws with the remediation hint.
+// immediately), or waited one retry slot. Proven-live generations do not
+// consume the recovery deadline; incomplete or ambiguous generations do.
 const attemptAcquire = async (
   lockPath: string,
   staleMs: number,
   retryMs: number,
   deadline: number,
-): Promise<boolean> => {
-  if (await tryAcquire(lockPath)) {
-    return true;
+): Promise<HeldBrokerLock | null> => {
+  const held = await tryAcquireBrokerLock(lockPath, staleMs);
+  if (held !== null) {
+    return held;
   }
-  if (await breakIfStale(lockPath, staleMs)) {
-    return false;
+  const availability = await inspectBrokerLock(lockPath, staleMs);
+  if (availability === 'retry') {
+    return null;
   }
-  if (Date.now() >= deadline) {
+  if (availability === 'blocked' && Date.now() >= deadline) {
     throw new Error(
       `lock timeout: another creds process holds ${lockPath}; if none is running, remove that directory and retry`,
     );
   }
   await sleep(retryMs);
-  return false;
+  return null;
 };
 
 export const withBrokerLock = async <T>(
@@ -89,14 +65,14 @@ export const withBrokerLock = async <T>(
   const lockPath = `${path}.lock`;
   await mkdir(dirname(path), { recursive: true, mode: OWNER_ONLY_DIR_MODE });
   const deadline = Date.now() + timeoutMs;
-  let acquired = false;
-  while (!acquired) {
+  let held: HeldBrokerLock | null = null;
+  while (held === null) {
     // biome-ignore lint/performance/noAwaitInLoops: lock acquisition retries are inherently sequential.
-    acquired = await attemptAcquire(lockPath, staleMs, retryMs, deadline);
+    held = await attemptAcquire(lockPath, staleMs, retryMs, deadline);
   }
   try {
     return await operation();
   } finally {
-    await rmdir(lockPath);
+    await releaseBrokerLock(held);
   }
 };

package/src/creds-store.ts

@@ -6,23 +6,24 @@ import { basename, dirname, join } from 'node:path';
 import process from 'node:process';
 import { parse as parseYaml, stringify as stringifyYaml } from 'yaml';
 import { isCloudflareAccountId } from './creds-cloudflare-account';
+import {
+  type GithubBrokerApp,
+  githubStoreDocument,
+  parseGithubApps,
+  validateGithubApps,
+} from './creds-store-github';
 import { withBrokerLock } from './creds-store-lock';
 import { isNonEmptyString, isRecord } from './github-settings-parse';
-export type GithubBrokerApp = {
-  readonly appId: number;
-  readonly slug: string;
-  readonly htmlUrl: string;
-  readonly clientId: string;
-  readonly privateKey: string;
-};
+
+export type { GithubBrokerApp } from './creds-store-github';
 export type CloudflareBrokerAccount = Readonly<
   Record<'accountId' | 'token', string>
 >;
 export type BrokerStore = {
-  readonly github: GithubBrokerApp | null;
+  readonly github: ReadonlyArray<GithubBrokerApp>;
   readonly cloudflare: ReadonlyArray<CloudflareBrokerAccount>;
 };
-export const EMPTY_BROKER_STORE: BrokerStore = { github: null, cloudflare: [] };
+export const EMPTY_BROKER_STORE: BrokerStore = { github: [], cloudflare: [] };
 const OWNER_ONLY_FILE_MODE = 0o600;
 const OWNER_ONLY_DIR_MODE = 0o700;
 const FILE_MODE_MODULUS = 0o1000;
@@ -48,29 +49,6 @@ export const resolveBrokerPath = (): string =>
     process.env.XDG_CONFIG_HOME ?? join(homedir(), '.config'),
     'standards/broker.yaml',
   );
-const parseGithub = (raw: unknown): GithubBrokerApp | null => {
-  if (raw === undefined || raw === null) {
-    return null;
-  }
-  if (
-    !isRecord(raw) ||
-    typeof raw.app_id !== 'number' ||
-    !Number.isInteger(raw.app_id) ||
-    !isNonEmptyString(raw.slug) ||
-    !isNonEmptyString(raw.html_url) ||
-    !isNonEmptyString(raw.client_id) ||
-    !isNonEmptyString(raw.private_key)
-  ) {
-    throw new Error('invalid github: run `standards creds login github`');
-  }
-  return {
-    appId: raw.app_id,
-    slug: raw.slug,
-    htmlUrl: raw.html_url,
-    clientId: raw.client_id,
-    privateKey: raw.private_key,
-  };
-};
 const validateCloudflareAccounts = (
   accounts: ReadonlyArray<CloudflareBrokerAccount>,
   path: string,
@@ -131,7 +109,7 @@ export const readBrokerStore = async (path: string): Promise<BrokerStore> => {
     throw new Error(`${path} must contain a YAML mapping`);
   }
   return {
-    github: parseGithub(raw.github),
+    github: parseGithubApps(raw.github, path),
     cloudflare: parseCloudflare(raw.cloudflare, path),
   };
 };
@@ -142,21 +120,14 @@ export const updateBrokerStore = async (
 ): Promise<void> =>
   withBrokerLock(path, async () => {
     const store = await update(await readBrokerStore(path));
+    validateGithubApps(store.github, path);
     validateCloudflareAccounts(store.cloudflare, path);
     await writeBrokerStoreUnlocked(path, store, sync);
   });
 const storeDocument = (store: BrokerStore): unknown => ({
-  ...(store.github === null
+  ...(store.github.length === 0
     ? {}
-    : {
-        github: {
-          app_id: store.github.appId,
-          slug: store.github.slug,
-          html_url: store.github.htmlUrl,
-          client_id: store.github.clientId,
-          private_key: store.github.privateKey,
-        },
-      }),
+    : { github: githubStoreDocument(store.github) }),
   ...(store.cloudflare.length === 0
     ? {}
     : {

package/src/github-command-shared.ts

@@ -33,7 +33,14 @@ export const optOutEligibilityProblem = (
     : null;
 
 export const ADMIN_VISIBILITY_ADVICE =
-  'Use a token with read access to repository administration (in CI: ci.github_settings_read_token in secrets/ci.yaml), or verify locally with admin auth';
+  'Use a user-scoped token with read access to repository administration, or verify locally with admin auth; a CI token cannot hold that access, so widening what CI reads with is not the fix';
+
+// Merge settings have a different remedy from everything else this advice used
+// to cover. GraphQL serves them to read-only tokens by design, so reaching this
+// message means the fallback request itself failed — pointing the reader at a
+// permission they cannot obtain would send them after the wrong cause.
+export const MERGE_SETTINGS_VISIBILITY_ADVICE =
+  'REST serves repository merge settings only to write-level viewers, and the GraphQL fallback that answers them for a read-only token did not respond, so this is more likely a failed request than a permission gap: re-run the check, and if it keeps failing verify locally with admin auth';
 
 // Declared state the token cannot see is a gate failure, not a pass with a
 // log line: a gate that cannot perform its comparison fails closed. The advice

package/src/github-live-drift.ts

@@ -13,8 +13,8 @@ import {
 } from './github-api';
 import { resolveHiddenBypassActors } from './github-bypass-actors';
 import {
-  ADMIN_VISIBILITY_ADVICE,
   enforceableRepositorySettings,
+  MERGE_SETTINGS_VISIBILITY_ADVICE,
   optOutEligibilityProblem,
   unverifiableProblem,
 } from './github-command-shared';
@@ -35,7 +35,7 @@ import {
 import { type GithubSettings, isRecord } from './github-settings-parse';
 
 const LABEL_VISIBILITY_PROBLEM =
-  'declared labels not visible to this token, so the gate cannot verify them. In CI, use a valid ci.github_settings_read_token from secrets/ci.yaml with read-only "Issues" access (or "Pull requests" read); locally use a token with one of those permissions';
+  'declared labels not visible to this token, so the gate cannot verify them. Label reads need issues: read (or pull-requests: read); the canonical github-settings job already grants issues: read, so in CI this points at a stale synced workflow or an organization policy restricting the workflow token rather than anything to change in the declaration. Locally, use a token with one of those permissions';
 const PERMISSION_DENIAL_MESSAGES: ReadonlySet<string> = new Set([
   'Resource not accessible by integration',
   'Resource not accessible by personal access token',
@@ -87,7 +87,7 @@ const repositoryDrift = async (
     ...unverifiableProblem(
       'repository setting(s)',
       rediff.unverifiable,
-      ADMIN_VISIBILITY_ADVICE,
+      MERGE_SETTINGS_VISIBILITY_ADVICE,
     ),
   ];
 };

package/src/poller-closing-reference.ts

@@ -0,0 +1,179 @@
+const CLOSING_KEYWORD_PATTERN = String.raw`(?:close(?:s|d)?|fix(?:es|ed)?|resolve(?:s|d)?):?[ \t]+#`;
+const FENCE_OPEN_PATTERN = /^ {0,3}(?<marker>`{3,}|~{3,})(?<info>[^\r\n]*)$/u;
+const BODY_LINE_PATTERN = /\r?\n/u;
+const INDENTED_CODE_PATTERN = /^ {0,3}\t|^ {4}/u;
+const COMMENT_START = '<!--';
+const COMMENT_END = '-->';
+
+type BacktickRun = {
+  readonly start: number;
+  readonly end: number;
+};
+
+const isEscaped = (line: string, index: number): boolean => {
+  let backslashes = 0;
+  for (
+    let cursor = index - 1;
+    cursor >= 0 && line[cursor] === '\\';
+    cursor -= 1
+  ) {
+    backslashes += 1;
+  }
+  return backslashes % 2 === 1;
+};
+
+const nextBacktickRun = (line: string, from: number): BacktickRun | null => {
+  let start = line.indexOf('`', from);
+  while (start !== -1) {
+    let end = start + 1;
+    while (line[end] === '`') {
+      end += 1;
+    }
+    if (!isEscaped(line, start)) {
+      return { start, end };
+    }
+    start = line.indexOf('`', end);
+  }
+  return null;
+};
+
+const matchingBacktickRun = (
+  line: string,
+  opener: BacktickRun,
+): BacktickRun | null => {
+  const ticks = opener.end - opener.start;
+  let candidate = nextBacktickRun(line, opener.end);
+  while (candidate !== null) {
+    if (candidate.end - candidate.start === ticks) {
+      return candidate;
+    }
+    candidate = nextBacktickRun(line, candidate.end);
+  }
+  return null;
+};
+
+const nextActiveCommentStart = (line: string, from: number): number => {
+  let cursor = from;
+  while (cursor < line.length) {
+    const comment = line.indexOf(COMMENT_START, cursor);
+    const opener = nextBacktickRun(line, cursor);
+    if (
+      comment !== -1 &&
+      !isEscaped(line, comment) &&
+      (opener === null || comment < opener.start)
+    ) {
+      return comment;
+    }
+    if (opener === null) {
+      return -1;
+    }
+    const closer = matchingBacktickRun(line, opener);
+    cursor = closer === null ? opener.end : closer.end;
+  }
+  return -1;
+};
+
+const commentIsOpenAfter = (line: string, initiallyOpen: boolean): boolean => {
+  let open = initiallyOpen;
+  let cursor = 0;
+  while (cursor < line.length) {
+    const marker = open
+      ? line.indexOf(COMMENT_END, cursor)
+      : nextActiveCommentStart(line, cursor);
+    if (marker === -1) {
+      return open;
+    }
+    open = !open;
+    cursor = marker + (open ? COMMENT_START.length : COMMENT_END.length);
+  }
+  return open;
+};
+
+const isIndentedCodeLine = (
+  lines: ReadonlyArray<string>,
+  index: number,
+): boolean => {
+  if (!INDENTED_CODE_PATTERN.test(lines[index] ?? '')) {
+    return false;
+  }
+  for (let cursor = index - 1; cursor >= 0; cursor -= 1) {
+    const previous = lines[cursor] ?? '';
+    if (previous.trim().length === 0) {
+      return true;
+    }
+    if (!INDENTED_CODE_PATTERN.test(previous)) {
+      return false;
+    }
+  }
+  return true;
+};
+
+const commentStateAfterContentLine = (
+  lines: ReadonlyArray<string>,
+  index: number,
+  initiallyOpen: boolean,
+): boolean => {
+  if (!initiallyOpen && isIndentedCodeLine(lines, index)) {
+    return false;
+  }
+  return commentIsOpenAfter(lines[index] ?? '', initiallyOpen);
+};
+
+const fenceCloseForLine = (line: string): RegExp | null => {
+  const groups = FENCE_OPEN_PATTERN.exec(line)?.groups;
+  const marker = groups?.marker;
+  if (
+    marker === undefined ||
+    (marker[0] === '`' && (groups?.info ?? '').includes('`'))
+  ) {
+    return null;
+  }
+  return new RegExp(`^ {0,3}${marker[0]}{${marker.length},}[ \\t]*$`, 'u');
+};
+
+type MarkdownState = {
+  readonly fenceClose: RegExp | null;
+  readonly commentOpen: boolean;
+};
+
+const markdownStateAfterContentLine = (
+  lines: ReadonlyArray<string>,
+  index: number,
+  state: MarkdownState,
+): MarkdownState => {
+  const line = lines[index] ?? '';
+  if (state.fenceClose !== null) {
+    return {
+      fenceClose: state.fenceClose.test(line) ? null : state.fenceClose,
+      commentOpen: state.commentOpen,
+    };
+  }
+  const fenceClose = state.commentOpen ? null : fenceCloseForLine(line);
+  return {
+    fenceClose,
+    commentOpen:
+      fenceClose === null
+        ? commentStateAfterContentLine(lines, index, state.commentOpen)
+        : state.commentOpen,
+  };
+};
+
+export const hasClosingReferenceToIssue = (
+  body: string,
+  issueNumber: number,
+): boolean => {
+  const reference = new RegExp(
+    `^${CLOSING_KEYWORD_PATTERN}${issueNumber}$`,
+    'iu',
+  );
+  const lines = body.split(BODY_LINE_PATTERN);
+  if (!reference.test(lines.at(-1) ?? '')) {
+    return false;
+  }
+  let state: MarkdownState = { fenceClose: null, commentOpen: false };
+  const content = lines.slice(0, -1);
+  for (const [index] of content.entries()) {
+    state = markdownStateAfterContentLine(content, index, state);
+  }
+  return state.fenceClose === null && !state.commentOpen;
+};

package/src/poller-fix-outcome.ts

@@ -1,3 +1,4 @@
+import type { CodexRunResult } from './poller-codex';
 import type { FixPublication } from './poller-fix-publication';
 import { createComment } from './poller-github-write';
 import {
@@ -6,8 +7,16 @@ import {
   type JobLabels,
   releaseLabels,
 } from './poller-job-shared';
+import { readFixOutcome } from './poller-outcome';
 import type { FixOutcome } from './poller-protocol';
 
+export const readFixRunOutcome = (
+  run: CodexRunResult,
+  workDir: string,
+  issueNumber: number,
+): Promise<FixOutcome | null> =>
+  run.succeeded ? readFixOutcome(workDir, issueNumber) : Promise.resolve(null);
+
 export const handleNonFixedOutcome = async (
   job: FixPublication,
   labels: JobLabels,

package/src/poller-fix-publication.ts

@@ -16,10 +16,7 @@ import {
   type JobLabels,
   releaseLabels,
 } from './poller-job-shared';
-import {
-  changedWorkspaceQualityManifests,
-  lockedPathsOf,
-} from './poller-protected-paths';
+import { lockedPathsOf } from './poller-protected-paths';
 import {
   APPROVED_FOR_REVIEW,
   type FixOutcome,
@@ -150,14 +147,10 @@ export const finishFixedJob = async (
     return `#${issue.number}: failed (fixed without commits)`;
   }
   const paths = changedPaths(workspace.dir, workspace.baseSha);
-  const forbidden = [
-    ...forbiddenDiffPaths(paths, await lockedPathsOf(workspace.dir)),
-    ...changedWorkspaceQualityManifests(
-      workspace.dir,
-      workspace.baseSha,
-      paths,
-    ),
-  ];
+  const forbidden = forbiddenDiffPaths(
+    paths,
+    await lockedPathsOf(workspace.dir),
+  );
   if (forbidden.length > 0) {
     await failJob(
       deps,

package/src/poller-fix-run.ts

@@ -5,7 +5,7 @@ import { hasLabel } from './github-label-identity';
 import { approvalIsCurrent, issueRevision } from './poller-approval';
 import { startClaim, withClaimReleasedOnFailure } from './poller-claim';
 import { runCodex } from './poller-codex';
-import { handleNonFixedOutcome } from './poller-fix-outcome';
+import { handleNonFixedOutcome, readFixRunOutcome } from './poller-fix-outcome';
 import { readSealedFixOutput } from './poller-fix-output';
 import {
   type FixPublication,
@@ -21,7 +21,6 @@ import {
   type JobResult,
   jobPreamble,
 } from './poller-job-shared';
-import { readFixOutcome } from './poller-outcome';
 import { fixPrompt } from './poller-prompts';
 import {
   APPROVED_FOR_FIX,
@@ -170,7 +169,7 @@ export const runFixJob = async (
       config,
     });
     await validateFixClaim(job);
-    const outcome = run.succeeded ? await readFixOutcome(workspace.dir) : null;
+    const outcome = await readFixRunOutcome(run, workspace.dir, issue.number);
     if (outcome === null) {
       await failJob(
         deps,

package/src/poller-fix-validation.ts

@@ -1,4 +1,5 @@
 import { join } from 'node:path';
+import { hasClosingReferenceToIssue } from './poller-closing-reference';
 import type { SealedFixOutput } from './poller-fix-output';
 import type { JobDeps } from './poller-job-shared';
 import {
@@ -7,10 +8,7 @@ import {
   createValidationWorktree,
   isAncestor,
 } from './poller-output-integrity';
-import {
-  changedWorkspaceQualityManifests,
-  lockedPathsOf,
-} from './poller-protected-paths';
+import { lockedPathsOf } from './poller-protected-paths';
 import { forbiddenDiffPaths } from './poller-protocol';
 
 export const validateSealedFixOutput = async (
@@ -27,6 +25,7 @@ export const validateSealedFixOutput = async (
     output.repo !== job.deps.repo ||
     output.issueNumber !== job.issueNumber ||
     output.approvalId !== job.approvalId ||
+    !hasClosingReferenceToIssue(output.body, job.issueNumber) ||
     !isAncestor(job.cloneDir, output.baseSha, job.defaultBranch) ||
     !isAncestor(job.cloneDir, output.baseSha, output.generatedHead) ||
     commitCountBetween(job.cloneDir, output.baseSha, output.generatedHead) !==
@@ -49,10 +48,10 @@ export const validateSealedFixOutput = async (
     ),
   );
   try {
-    const forbidden = [
-      ...forbiddenDiffPaths(paths, await lockedPathsOf(workspace.dir)),
-      ...changedWorkspaceQualityManifests(workspace.dir, output.baseSha, paths),
-    ];
+    const forbidden = forbiddenDiffPaths(
+      paths,
+      await lockedPathsOf(workspace.dir),
+    );
     if (forbidden.length > 0) {
       throw new Error(
         `sealed fix output modified protected paths:\n${forbidden.join('\n')}`,

package/src/poller-outcome.ts

@@ -7,6 +7,7 @@ import { existsSync, rmSync } from 'node:fs';
 import { readFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { isNonEmptyString, isRecord } from './github-settings-parse';
+import { hasClosingReferenceToIssue } from './poller-closing-reference';
 import {
   type FixOutcome,
   OUTCOME_FILE,
@@ -59,6 +60,7 @@ const PR_TITLE_PATTERN = /^[a-z]+(?:\([^)]+\))?!?: .+/u;
 
 export const readFixOutcome = async (
   workDir: string,
+  issueNumber: number,
 ): Promise<FixOutcome | null> => {
   const raw = await readOutcomeRaw(workDir);
   if (
@@ -78,7 +80,8 @@ export const readFixOutcome = async (
     !(
       isNonEmptyString(raw.prTitle) &&
       PR_TITLE_PATTERN.test(raw.prTitle) &&
-      isNonEmptyString(raw.prBody)
+      isNonEmptyString(raw.prBody) &&
+      hasClosingReferenceToIssue(raw.prBody, issueNumber)
     )
   ) {
     return null;

package/src/poller-protected-paths.ts

@@ -1,11 +1,7 @@
-import { existsSync, readFileSync } from 'node:fs';
+import { existsSync } from 'node:fs';
 import { readFile } from 'node:fs/promises';
 import { join } from 'node:path';
 import { isRecord } from './github-settings-parse';
-import { changesWorkspaceQualityScripts } from './poller-protocol';
-import { runGit } from './poller-workspace';
-
-const WORKSPACE_MANIFEST = /^(?:apps|packages)\/[^/]+\/package\.json$/u;
 
 export const lockedPathsOf = async (
   workDir: string,
@@ -29,23 +25,3 @@ export const lockedPathsOf = async (
     );
   }
 };
-
-export const changedWorkspaceQualityManifests = (
-  workDir: string,
-  baseSha: string,
-  paths: ReadonlyArray<string>,
-): ReadonlyArray<string> =>
-  paths.filter((path) => {
-    if (!WORKSPACE_MANIFEST.test(path)) {
-      return false;
-    }
-    try {
-      return changesWorkspaceQualityScripts(
-        path,
-        runGit(['-C', workDir, 'show', `${baseSha}:${path}`], null),
-        readFileSync(join(workDir, path), 'utf8'),
-      );
-    } catch {
-      return true;
-    }
-  });

package/src/poller-protocol.ts

@@ -76,8 +76,6 @@ const GATE_WIRING_FILES: ReadonlySet<string> = new Set([
 const HOST_SECRETS_FILE = /(?:^|\/)secrets\.yaml$/u;
 const WORKSPACE_GATE_CONFIG =
   /(?:^|\/)(?:biome\.jsonc|turbo\.json|tsconfig(?:\.[^.]+)?\.json|vitest\.config\.[cm]?[jt]s|playwright\.config\.[cm]?[jt]s)$/u;
-const QUALITY_SCRIPT = /^(?:check|lint|test|typecheck)(?::|$)/u;
-const WORKSPACE_MANIFEST = /^(?:apps|packages)\/[^/]+\/package\.json$/u;
 
 const isEncryptedSecret = (path: string): boolean =>
   !path.endsWith('.example.yaml') &&
@@ -101,46 +99,6 @@ export const forbiddenDiffPaths = (
   );
 };
 
-const qualityScripts = (
-  manifest: unknown,
-): Readonly<Record<string, string>> => {
-  if (
-    typeof manifest !== 'object' ||
-    manifest === null ||
-    !('scripts' in manifest) ||
-    typeof manifest.scripts !== 'object' ||
-    manifest.scripts === null
-  ) {
-    return {};
-  }
-  return Object.fromEntries(
-    Object.entries(manifest.scripts)
-      .filter(
-        (entry): entry is [string, string] =>
-          QUALITY_SCRIPT.test(entry[0]) && typeof entry[1] === 'string',
-      )
-      .sort(([left], [right]) => left.localeCompare(right)),
-  );
-};
-
-export const changesWorkspaceQualityScripts = (
-  path: string,
-  before: string,
-  after: string,
-): boolean => {
-  if (path === 'package.json' || !WORKSPACE_MANIFEST.test(path)) {
-    return false;
-  }
-  try {
-    return (
-      JSON.stringify(qualityScripts(JSON.parse(before) as unknown)) !==
-      JSON.stringify(qualityScripts(JSON.parse(after) as unknown))
-    );
-  } catch {
-    return true;
-  }
-};
-
 export const branchNameForIssue = (
   issueNumber: number,
   approvalId: string,