@datarailsshared/dr_renderer 1.5.66 → 1.5.72

package/.github/workflows/release.yml

@@ -37,10 +37,9 @@ jobs:
   publish-gh-packages:
     name: Publish to GitHub Packages
     needs: publish-npm
-    uses: datarails/dr_github_reusable/.github/workflows/npm-publish-gh-packages.yml@DEVOPS-628
+    uses: datarails/dr_github_reusable/.github/workflows/npm-publish-gh-packages.yml@main
     with:
       node_version: '14.16.1'
       package_scope: '@datarails'
-      use_auto_increment: true
-      version_prefix: '1.5'
+      version: ${{ needs.publish-npm.outputs.version }}
     secrets: inherit

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.5.66",
+  "version": "1.5.72",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/highcharts_renderer.js

@@ -3738,6 +3738,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     }
 
     highchartsRenderer.rhPivotCount = function (arg, widget_values_format, is_graph, render_options, calculated_info) {
+        render_options = lodash.cloneDeep(render_options);
         var attr = arg[0];
         return function (data, rowKey, colKey) {
             return {
@@ -3819,6 +3820,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     };
 
     highchartsRenderer.rhPivotAggregatorUniqValues = function (arg, widget_values_format, is_graph, render_options, calculated_info) {
+        render_options = lodash.cloneDeep(render_options);
         var attr;
         attr = arg[0];
         var sep = '<br>';
@@ -3894,6 +3896,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     };
 
     highchartsRenderer.rhPivotAggregatorSum = function (arg, widget_values_format, is_graph, render_options, calculated_info) {
+        render_options = lodash.cloneDeep(render_options);
         var attr = arg[0];
         return function (data, rowKey, colKey) {
             return {
@@ -3987,6 +3990,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     };
 
     highchartsRenderer.rhPivotAggregatorMin = function (arg, widget_values_format, is_graph, render_options, calculated_info) {
+        render_options = lodash.cloneDeep(render_options);
         var attr = arg[0];
         return function (data, rowKey, colKey) {
             return {
@@ -4079,6 +4083,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     };
 
     highchartsRenderer.rhPivotAggregatorMax = function (arg, widget_values_format, is_graph, render_options, calculated_info) {
+        render_options = lodash.cloneDeep(render_options);
         var attr = arg[0];
         return function (data, rowKey, colKey) {
             return {
@@ -4171,6 +4176,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     };
 
     highchartsRenderer.rhPivotAggregatorAverage = function (arg, widget_values_format, is_graph, render_options, calculated_info) {
+        render_options = lodash.cloneDeep(render_options);
         var attr = arg[0];
         return function (data, rowKey, colKey) {
             return {

package/tests/highcharts_renderer.test.js

@@ -2361,6 +2361,30 @@ describe('highcharts_renderer', () => {
         });
 
         describe('Aggregators functions', () => {
+            const testMutationIsolation = (factory) => {
+                // Use mockImplementationOnce to override the mock only for this test
+                let appliedOptions = null;
+                getAggregatorPercentageValueIfRequiredMock
+                    .mockImplementationOnce((value, opts) => {
+                        appliedOptions = lodash.cloneDeep(opts);
+                        return 'INITIAL';
+                    })
+                    .mockImplementationOnce((value, opts) => {
+                        const mutated = !lodash.isEqual(opts, appliedOptions);
+                        return mutated ? 'MUTATED' : 'INITIAL';
+                    });
+
+                const render_options = { chartOptions: { delta_column: { is_percentage: true } } };
+                const aggregatorFn = factory([], '#,###%', true, render_options, {});
+                const agg = aggregatorFn({}, [], []);
+                const before = agg.format(100, false);
+                render_options.chartOptions.delta_column.is_percentage = false;
+                const after = agg.format(100, false);
+
+                expect(before).toBe('INITIAL');
+                expect(after).toBe('INITIAL');
+            };
+
             describe('Sum aggregator', () => {
                 let arg;
                 let widget_values_format;
@@ -2415,6 +2439,10 @@ describe('highcharts_renderer', () => {
                     expect(aggObject.numInputs).toBe(1);
                 });
 
+                it('Should ignore external mutations after initialization', () => {
+                    testMutationIsolation(highchartsRenderer.rhPivotAggregatorSum);
+                });
+
                 describe('Push method', () => {
                     beforeEach(() => {
                         aggregator = highchartsRenderer.rhPivotAggregatorSum(arg, widget_values_format, is_graph, render_options, calculated_info);
@@ -2620,6 +2648,10 @@ describe('highcharts_renderer', () => {
                     expect(aggObject.numInputs).toBe(1);
                 });
 
+                it('Should ignore external mutations after initialization', () => {
+                    testMutationIsolation(highchartsRenderer.rhPivotCount);
+                });
+
                 describe('Push method', () => {
                     beforeEach(() => {
                         aggregator = highchartsRenderer.rhPivotCount(arg, widget_values_format, is_graph, render_options, calculated_info);
@@ -2822,6 +2854,10 @@ describe('highcharts_renderer', () => {
                     expect(aggObject.numInputs).toBe(1);
                 });
 
+                it('Should ignore external mutations after initialization', () => {
+                    testMutationIsolation(highchartsRenderer.rhPivotAggregatorUniqValues);
+                });
+
                 describe('Push method', () => {
                     beforeEach(() => {
                         aggregator = highchartsRenderer.rhPivotAggregatorUniqValues(arg, widget_values_format, is_graph, render_options, calculated_info);
@@ -2975,6 +3011,10 @@ describe('highcharts_renderer', () => {
                     expect(aggObject.numInputs).toBe(1);
                 });
 
+                it('Should ignore external mutations after initialization', () => {
+                    testMutationIsolation(highchartsRenderer.rhPivotAggregatorAverage);
+                });
+
                 describe('Push method', () => {
                     beforeEach(() => {
                         aggregator = highchartsRenderer.rhPivotAggregatorAverage(arg, widget_values_format, is_graph, render_options, calculated_info);
@@ -3183,6 +3223,10 @@ describe('highcharts_renderer', () => {
                     expect(aggObject.numInputs).toBe(1);
                 });
 
+                it('Should ignore external mutations after initialization', () => {
+                    testMutationIsolation(highchartsRenderer.rhPivotAggregatorMin);
+                });
+
                 describe('Push method', () => {
                     beforeEach(() => {
                         aggregator = highchartsRenderer.rhPivotAggregatorMin(arg, widget_values_format, is_graph, render_options, calculated_info);
@@ -3389,6 +3433,10 @@ describe('highcharts_renderer', () => {
                     expect(aggObject.numInputs).toBe(1);
                 });
 
+                it('Should ignore external mutations after initialization', () => {
+                    testMutationIsolation(highchartsRenderer.rhPivotAggregatorMax);
+                });
+
                 describe('Push method', () => {
                     beforeEach(() => {
                         aggregator = highchartsRenderer.rhPivotAggregatorMax(arg, widget_values_format, is_graph, render_options, calculated_info);