@datarailsshared/dr_renderer 1.5.133 → 1.5.147

package/tests/options-builder.test.js

@@ -1,6 +1,6 @@
 /**
  * @fileoverview Unit tests for the options builder module.
- * 
+ *
  * Tests the standalone options builder module components:
  * - Constants
  * - Element factories
@@ -26,7 +26,7 @@ const {
     LABEL_DEFAULT_OPTIONS,
     SUBOPTIONS_FONT_SIZE_VALUES,
     DEFAULT_CATEGORY_CLASS,
-    
+
     // Element factories
     createToggle,
     createCheckbox,
@@ -40,7 +40,7 @@ const {
     createFontStylingGroup,
     createLabelStyleGroup,
     createTooltipStyleGroup,
-    
+
     // Builders
     withLabel,
     withLabelPie,
@@ -76,7 +76,7 @@ const {
     withGaugeGoal,
     withGaugeSegments,
     withGaugeIsAbsolute,
-    
+
     // Presets
     CHART_PRESETS,
     BUILDER_KEY_MAP,
@@ -86,16 +86,16 @@ const {
     buildSuboptions,
     getChartTypes,
     hasPreset,
-    
+
     // Helpers
     chartHasVerticalDataLabelsOption,
-    
+
     // Disabled conditions
     LABEL_DISABLED_CONDITION,
     LABEL_PIE_DISABLED_CONDITION,
     TOOLTIP_DISABLED_CONDITION,
     TOOLTIP_PIE_DISABLED_CONDITION,
-    
+
     // Reusable elements
     LABEL_SHOW_TOGGLE,
     LABEL_PIE_SHOW_TOGGLE,
@@ -103,17 +103,17 @@ const {
     TOOLTIP_SHOW_TOGGLE,
     TOOLTIP_PIE_SHOW_TOGGLE,
     GAUGE_SHOW_TOGGLE,
-    
+
     // Factory
     createDefaultSuboptions,
 } = options;
 
 describe('Options Builder Module', () => {
-    
+
     // =========================================================================
     // Constants Tests
     // =========================================================================
-    
+
     describe('Constants', () => {
         describe('CHART_TYPES', () => {
             it('should contain all expected chart types', () => {
@@ -440,12 +440,12 @@ describe('Options Builder Module', () => {
     // =========================================================================
     // Element Factory Tests
     // =========================================================================
-    
+
     describe('Element Factories', () => {
         describe('createToggle', () => {
             it('should create a toggle element with required properties', () => {
                 const toggle = createToggle('show', 'Show', true);
-                
+
                 expect(toggle).toEqual({
                     element_type: 'toggle',
                     element_label: 'Show',
@@ -462,7 +462,7 @@ describe('Options Builder Module', () => {
             it('should merge additional options', () => {
                 const showFn = jest.fn();
                 const toggle = createToggle('show', 'Show', true, { showFn });
-                
+
                 expect(toggle.showFn).toBe(showFn);
             });
 
@@ -472,7 +472,7 @@ describe('Options Builder Module', () => {
                     disabled_str: '!{var}.other',
                     disabled_fn,
                 });
-                
+
                 expect(toggle.disabled_str).toBe('!{var}.other');
                 expect(toggle.disabled_fn).toBe(disabled_fn);
             });
@@ -481,7 +481,7 @@ describe('Options Builder Module', () => {
         describe('createCheckbox', () => {
             it('should create a checkbox element with required properties', () => {
                 const checkbox = createCheckbox('enabled', 'Enabled', true);
-                
+
                 expect(checkbox).toEqual({
                     element_type: 'checkbox',
                     element_label: 'Enabled',
@@ -498,7 +498,7 @@ describe('Options Builder Module', () => {
             it('should support clickFn option', () => {
                 const clickFn = jest.fn();
                 const checkbox = createCheckbox('value', 'Value', true, { clickFn });
-                
+
                 expect(checkbox.clickFn).toBe(clickFn);
             });
 
@@ -511,7 +511,7 @@ describe('Options Builder Module', () => {
         describe('createInput', () => {
             it('should create an input element with required properties', () => {
                 const input = createInput('name', 'Name', 'default');
-                
+
                 expect(input).toEqual({
                     element_type: 'input',
                     element_label: 'Name',
@@ -554,7 +554,7 @@ describe('Options Builder Module', () => {
 
             it('should create a select element with required properties', () => {
                 const select = createSelect('font', 'Font', fontOptions, 'Arial');
-                
+
                 expect(select.element_type).toBe('select');
                 expect(select.element_label).toBe('Font');
                 expect(select.value_name).toBe('font');
@@ -565,7 +565,7 @@ describe('Options Builder Module', () => {
             it('should support string array as options', () => {
                 const stringOptions = ['Arial', 'Poppins', 'Helvetica'];
                 const select = createSelect('font', 'Font', stringOptions, 'Arial');
-                
+
                 expect(select.element_options).toEqual(stringOptions);
             });
 
@@ -584,7 +584,7 @@ describe('Options Builder Module', () => {
 
             it('should create a radio element with required properties', () => {
                 const radio = createRadio('align', 'Alignment', alignOptions, 'left');
-                
+
                 expect(radio.element_type).toBe('radio');
                 expect(radio.element_label).toBe('Alignment');
                 expect(radio.value_name).toBe('align');
@@ -608,7 +608,7 @@ describe('Options Builder Module', () => {
         describe('createColorPicker', () => {
             it('should create a color picker element with required properties', () => {
                 const colorPicker = createColorPicker('color', 'Color', '#ff0000');
-                
+
                 expect(colorPicker).toEqual({
                     element_type: 'color_picker',
                     element_label: 'Color',
@@ -626,14 +626,14 @@ describe('Options Builder Module', () => {
         describe('createDivider', () => {
             it('should create a divider element without label', () => {
                 const divider = createDivider();
-                
+
                 expect(divider.element_type).toBe('devider');
                 expect(divider.element_label).toBeUndefined();
             });
 
             it('should create a divider element with label', () => {
                 const divider = createDivider('Section Title');
-                
+
                 expect(divider.element_type).toBe('devider');
                 expect(divider.element_label).toBe('Section Title');
             });
@@ -642,7 +642,7 @@ describe('Options Builder Module', () => {
         describe('createTextarea', () => {
             it('should create a textarea element with required properties', () => {
                 const textarea = createTextarea('description', 'Description', 'default text');
-                
+
                 expect(textarea).toEqual({
                     element_type: 'textarea',
                     element_label: 'Description',
@@ -660,7 +660,7 @@ describe('Options Builder Module', () => {
         describe('createTag', () => {
             it('should create a tag element with required properties', () => {
                 const tag = createTag('tags', 'Tags', ['tag1', 'tag2']);
-                
+
                 expect(tag.element_type).toBe('tag');
                 expect(tag.element_label).toBe('Tags');
                 expect(tag.value_name).toBe('tags');
@@ -674,7 +674,7 @@ describe('Options Builder Module', () => {
 
             it('should set tag options with defaults', () => {
                 const tag = createTag('tags', 'Tags');
-                
+
                 expect(tag.element_options).toEqual({
                     add_new_tag: true,
                     searchable: true,
@@ -688,7 +688,7 @@ describe('Options Builder Module', () => {
                     searchable: false,
                     multiple: false,
                 });
-                
+
                 expect(tag.element_options).toEqual({
                     add_new_tag: false,
                     searchable: false,
@@ -705,20 +705,20 @@ describe('Options Builder Module', () => {
 
             it('should contain font_style select, font_size select, and font_color picker', () => {
                 const group = createFontStylingGroup();
-                
+
                 expect(group[0].value_name).toBe('font_style');
                 expect(group[0].element_type).toBe('select');
-                
+
                 expect(group[1].value_name).toBe('font_size');
                 expect(group[1].element_type).toBe('select');
-                
+
                 expect(group[2].value_name).toBe('font_color');
                 expect(group[2].element_type).toBe('color_picker');
             });
 
             it('should use label defaults when no custom defaults provided', () => {
                 const group = createFontStylingGroup();
-                
+
                 expect(group[0].default_value).toBe(LABEL_DEFAULT_SETTINGS.FONT_FAMILY);
                 expect(group[1].default_value).toBe(LABEL_DEFAULT_SETTINGS.FONT_SIZE);
                 expect(group[2].default_value).toBe(LABEL_DEFAULT_SETTINGS.FONT_COLOR);
@@ -730,7 +730,7 @@ describe('Options Builder Module', () => {
                     fontSize: '14',
                     fontColor: '#000000',
                 });
-                
+
                 expect(group[0].default_value).toBe('Arial');
                 expect(group[1].default_value).toBe('14');
                 expect(group[2].default_value).toBe('#000000');
@@ -740,7 +740,7 @@ describe('Options Builder Module', () => {
         describe('createLabelStyleGroup', () => {
             it('should return array with dividers and font styling', () => {
                 const group = createLabelStyleGroup();
-                
+
                 // Should have 2 dividers + 3 font styling elements
                 expect(group).toHaveLength(5);
                 expect(group[0].element_type).toBe('devider');
@@ -752,7 +752,7 @@ describe('Options Builder Module', () => {
         describe('createTooltipStyleGroup', () => {
             it('should return array with dividers and font styling', () => {
                 const group = createTooltipStyleGroup();
-                
+
                 // Should have 2 dividers + 3 font styling elements
                 expect(group).toHaveLength(5);
                 expect(group[0].element_type).toBe('devider');
@@ -762,7 +762,7 @@ describe('Options Builder Module', () => {
 
             it('should use tooltip defaults', () => {
                 const group = createTooltipStyleGroup();
-                
+
                 expect(group[2].default_value).toBe(TOOLTIP_DEFAULT_SETTINGS.FONT_FAMILY);
                 expect(group[3].default_value).toBe(TOOLTIP_DEFAULT_SETTINGS.FONT_SIZE);
                 expect(group[4].default_value).toBe(TOOLTIP_DEFAULT_SETTINGS.FONT_COLOR);
@@ -773,7 +773,7 @@ describe('Options Builder Module', () => {
     // =========================================================================
     // Builder Tests
     // =========================================================================
-    
+
     describe('Builders', () => {
         // Helper to validate SuboptionDefinition structure
         const expectValidSuboptionDefinition = (def) => {
@@ -823,7 +823,7 @@ describe('Options Builder Module', () => {
                     const fontStyle = result.elements.find(e => e.value_name === 'font_style');
                     const fontSize = result.elements.find(e => e.value_name === 'font_size');
                     const fontColor = result.elements.find(e => e.value_name === 'font_color');
-                    
+
                     expect(fontStyle).toBeDefined();
                     expect(fontSize).toBeDefined();
                     expect(fontColor).toBeDefined();
@@ -845,7 +845,7 @@ describe('Options Builder Module', () => {
                     const result = withLabelPie();
                     const useAreaColor = result.elements.find(e => e.value_name === 'use_area_color');
                     const showPercentage = result.elements.find(e => e.value_name === 'show_percentage_in_labels');
-                    
+
                     expect(useAreaColor).toBeDefined();
                     expect(showPercentage).toBeDefined();
                 });
@@ -866,25 +866,19 @@ describe('Options Builder Module', () => {
                     const result = withLabelGauge();
                     const showPercentageInValue = result.elements.find(e => e.value_name === 'show_percentage_in_value');
                     const showGoalName = result.elements.find(e => e.value_name === 'show_goal_name');
-                    
+
                     expect(showPercentageInValue).toBeDefined();
                     expect(showGoalName).toBeDefined();
                 });
 
-                it('should use hasFeature config for goal_name visibility', () => {
-                    const hasFeature = jest.fn().mockReturnValue(true);
-                    const result = withLabelGauge({
-                        hasFeature,
-                        ENABLE_GAUGE_DYNAMIC_GOAL: 'test_feature',
-                    });
-                    
+                it('should use enableGaugeDynamicGoal config for goal_name visibility', () => {
+                    const result = withLabelGauge({ enableGaugeDynamicGoal: true });
+
                     const goalName = result.elements.find(e => e.value_name === 'goal_name');
                     expect(goalName).toBeDefined();
                     expect(goalName.showFn).toBeDefined();
-                    
-                    // Call showFn to trigger hasFeature
-                    goalName.showFn();
-                    expect(hasFeature).toHaveBeenCalledWith('test_feature');
+
+                    expect(goalName.showFn()).toBe(true);
                 });
             });
 
@@ -898,7 +892,7 @@ describe('Options Builder Module', () => {
                     const result = withLabelWithPercentage();
                     const presentTotal = result.elements.find(e => e.value_name === 'present_total');
                     const showPercentage = result.elements.find(e => e.value_name === 'show_percentage');
-                    
+
                     expect(presentTotal).toBeDefined();
                     expect(showPercentage).toBeDefined();
                 });
@@ -929,7 +923,7 @@ describe('Options Builder Module', () => {
                     const result = withTooltip();
                     const show = result.elements.find(e => e.value_name === 'show');
                     const showValue = result.elements.find(e => e.value_name === 'show_value');
-                    
+
                     expect(show).toBeDefined();
                     expect(showValue).toBeDefined();
                 });
@@ -978,7 +972,7 @@ describe('Options Builder Module', () => {
                     const result = withAxisY();
                     const min = result.elements.find(e => e.value_name === 'min');
                     const max = result.elements.find(e => e.value_name === 'max');
-                    
+
                     expect(min).toBeDefined();
                     expect(max).toBeDefined();
                 });
@@ -994,7 +988,7 @@ describe('Options Builder Module', () => {
                     const result = withAxisYPercentStacked();
                     const min = result.elements.find(e => e.value_name === 'min');
                     const max = result.elements.find(e => e.value_name === 'max');
-                    
+
                     expect(min).toBeUndefined();
                     expect(max).toBeUndefined();
                 });
@@ -1031,7 +1025,7 @@ describe('Options Builder Module', () => {
                     const result = withTableOptions();
                     const showColumnTotal = result.elements.find(e => e.value_name === 'show_column_total');
                     const showRowTotal = result.elements.find(e => e.value_name === 'show_row_total');
-                    
+
                     expect(showColumnTotal).toBeDefined();
                     expect(showRowTotal).toBeDefined();
                 });
@@ -1046,7 +1040,7 @@ describe('Options Builder Module', () => {
                 it('should have transpose disabled by default', () => {
                     const result = withTableOptionsTranspose();
                     const transpose = result.elements.find(e => e.value_name === 'transpose_table');
-                    
+
                     expect(transpose).toBeDefined();
                     expect(transpose.default_value).toBe(false);
                 });
@@ -1232,13 +1226,13 @@ describe('Options Builder Module', () => {
                         { from: 0, to: 100, color: 'green', title: 'Good' },
                     ];
                     const result = withGaugeSegments({ defaultSegments: customSegments });
-                    
+
                     expect(result.default_value).toEqual(customSegments);
                 });
 
                 it('should use fallback segments when not provided', () => {
                     const result = withGaugeSegments();
-                    
+
                     expect(result.default_value).toBeDefined();
                     expect(Array.isArray(result.default_value)).toBe(true);
                     expect(result.default_value.length).toBeGreaterThan(0);
@@ -1267,7 +1261,7 @@ describe('Options Builder Module', () => {
     // =========================================================================
     // Preset Tests
     // =========================================================================
-    
+
     describe('Presets', () => {
         describe('CHART_PRESETS', () => {
             it('should be defined', () => {
@@ -1284,7 +1278,7 @@ describe('Options Builder Module', () => {
 
             it('should have arrays of builder functions', () => {
                 const lineChartPreset = CHART_PRESETS[CHART_TYPES.LINE_CHART];
-                
+
                 expect(Array.isArray(lineChartPreset)).toBe(true);
                 lineChartPreset.forEach(builder => {
                     expect(typeof builder).toBe('function');
@@ -1324,14 +1318,14 @@ describe('Options Builder Module', () => {
         describe('getPresetForChart', () => {
             it('should return preset for known chart type', () => {
                 const preset = getPresetForChart(CHART_TYPES.LINE_CHART);
-                
+
                 expect(preset).toBeDefined();
                 expect(Array.isArray(preset)).toBe(true);
             });
 
             it('should include expected builders for line chart', () => {
                 const preset = getPresetForChart(CHART_TYPES.LINE_CHART);
-                
+
                 expect(preset).toContain(withLabel);
                 expect(preset).toContain(withTooltip);
                 expect(preset).toContain(withAxisY);
@@ -1341,7 +1335,7 @@ describe('Options Builder Module', () => {
 
             it('should include pie-specific builders for pie chart', () => {
                 const preset = getPresetForChart(CHART_TYPES.PIE_CHART);
-                
+
                 expect(preset).toContain(withLabelPie);
                 expect(preset).toContain(withTooltipPie);
                 expect(preset).not.toContain(withLabel);
@@ -1350,7 +1344,7 @@ describe('Options Builder Module', () => {
 
             it('should include gauge-specific builders for gauge chart', () => {
                 const preset = getPresetForChart(CHART_TYPES.GAUGE_CHART_ENHANCED);
-                
+
                 expect(preset).toContain(withLabelGauge);
                 expect(preset).toContain(withTooltipGauge);
                 expect(preset).toContain(withGaugeGoal);
@@ -1366,14 +1360,14 @@ describe('Options Builder Module', () => {
         describe('buildSuboptionsForChart', () => {
             it('should build suboptions object for a chart type', () => {
                 const result = buildSuboptionsForChart(CHART_TYPES.LINE_CHART);
-                
+
                 expect(result).toBeDefined();
                 expect(typeof result).toBe('object');
             });
 
             it('should include expected keys for line chart', () => {
                 const result = buildSuboptionsForChart(CHART_TYPES.LINE_CHART);
-                
+
                 expect(result).toHaveProperty('label');
                 expect(result).toHaveProperty('tooltips');
                 expect(result).toHaveProperty('axisY');
@@ -1382,7 +1376,7 @@ describe('Options Builder Module', () => {
 
             it('should include pie-specific keys for pie chart', () => {
                 const result = buildSuboptionsForChart(CHART_TYPES.PIE_CHART);
-                
+
                 expect(result).toHaveProperty('label_pie');
                 expect(result).toHaveProperty('tooltips_pie');
                 expect(result).not.toHaveProperty('label');
@@ -1391,14 +1385,14 @@ describe('Options Builder Module', () => {
 
             it('should return empty object for unknown chart type', () => {
                 const result = buildSuboptionsForChart('unknown-chart');
-                
+
                 expect(result).toEqual({});
             });
 
             it('should pass config to builders', () => {
                 const config = { CHART_TYPES };
                 const result = buildSuboptionsForChart(CHART_TYPES.COLUMN_CHART, config);
-                
+
                 // Should still work with config
                 expect(result).toHaveProperty('table_options');
             });
@@ -1407,7 +1401,7 @@ describe('Options Builder Module', () => {
         describe('buildSuboptions', () => {
             it('should build suboptions from an array of builders', () => {
                 const result = buildSuboptions([withLabel, withTooltip]);
-                
+
                 expect(Object.keys(result)).toHaveLength(2);
                 expect(result).toHaveProperty('label');
                 expect(result).toHaveProperty('tooltips');
@@ -1419,19 +1413,15 @@ describe('Options Builder Module', () => {
             });
 
             it('should pass config to builders', () => {
-                const hasFeature = jest.fn().mockReturnValue(true);
-                const result = buildSuboptions([withLabelGauge], {
-                    hasFeature,
-                    ENABLE_GAUGE_DYNAMIC_GOAL: 'test',
-                });
-                
+                const result = buildSuboptions([withLabelGauge], { enableGaugeDynamicGoal: true });
+
                 expect(result).toHaveProperty('label_gauge');
             });
 
             it('should skip unknown builders', () => {
                 const unknownBuilder = () => ({});
                 const result = buildSuboptions([withLabel, unknownBuilder, withTooltip]);
-                
+
                 expect(Object.keys(result)).toHaveLength(2);
                 expect(result).toHaveProperty('label');
                 expect(result).toHaveProperty('tooltips');
@@ -1441,14 +1431,14 @@ describe('Options Builder Module', () => {
         describe('getChartTypes', () => {
             it('should return array of chart types', () => {
                 const result = getChartTypes();
-                
+
                 expect(Array.isArray(result)).toBe(true);
                 expect(result.length).toBeGreaterThan(0);
             });
 
             it('should contain all expected chart types', () => {
                 const result = getChartTypes();
-                
+
                 expect(result).toContain('line-chart');
                 expect(result).toContain('column-chart');
                 expect(result).toContain('bar-chart');
@@ -1474,7 +1464,7 @@ describe('Options Builder Module', () => {
     // =========================================================================
     // Helper Tests
     // =========================================================================
-    
+
     describe('Helpers', () => {
         describe('chartHasVerticalDataLabelsOption', () => {
             it('should return true for charts that support vertical labels', () => {
@@ -1504,12 +1494,12 @@ describe('Options Builder Module', () => {
     // =========================================================================
     // Index/Factory Tests
     // =========================================================================
-    
+
     describe('Index Exports and createDefaultSuboptions', () => {
         describe('createDefaultSuboptions', () => {
             it('should create a complete suboptions object', () => {
                 const result = createDefaultSuboptions();
-                
+
                 expect(result).toBeDefined();
                 expect(typeof result).toBe('object');
             });
@@ -1552,7 +1542,7 @@ describe('Options Builder Module', () => {
                     'gauge_segments',
                     'gauge_is_absolute',
                 ];
-                
+
                 expectedKeys.forEach(key => {
                     expect(result).toHaveProperty(key);
                 });
@@ -1564,23 +1554,21 @@ describe('Options Builder Module', () => {
             });
 
             it('should pass config to builders that need it', () => {
-                const hasFeature = jest.fn().mockReturnValue(true);
                 const customSegments = [{ from: 0, to: 100, color: 'green', title: 'Good' }];
-                
+
                 const result = createDefaultSuboptions({
                     CHART_TYPES,
-                    hasFeature,
-                    ENABLE_GAUGE_DYNAMIC_GOAL: 'test_feature',
+                    enableGaugeDynamicGoal: true,
                     defaultGaugeSegments: customSegments,
                 });
-                
+
                 // Gauge segments should use custom segments
                 expect(result.gauge_segments.default_value).toEqual(customSegments);
             });
 
             it('should create valid SuboptionDefinition for each suboption', () => {
                 const result = createDefaultSuboptions();
-                
+
                 Object.values(result).forEach(suboption => {
                     expect(suboption).toHaveProperty('category_class');
                     expect(suboption).toHaveProperty('category_label');