@datarailsshared/dr_renderer 1.4.99 → 1.4.108

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.4.99",
+  "version": "1.4.108",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/highcharts_renderer.js

@@ -5308,7 +5308,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                     break;
             }
             options.comboOptions.seriesOptions.push(deltaColumnSeries);
-            options.comboOptions.secondaryAxisSettings.name = options.chartOptions.delta_column.name.replace('_', '');
             options.comboOptions.secondaryAxisSettings.is_percentage = options.chartOptions.delta_column.is_percentage;
         }
     };

package/src/value.formatter.js

@@ -7,7 +7,7 @@ function getAggregatorPercentageValueIfRequired(value, render_options, data, row
     const isVariance = currentRowName.replace('_', '').toLowerCase() === deltaColumnName.replace('_', '').toLowerCase();
     const baseRowKey = data && data.rowKeys && data.rowKeys.length ? data.rowKeys[0] : null;
     const currentColKey = colKey ? colKey : [];
-    const agg = data ? data.getAggregator(baseRowKey, currentColKey) : null;
+    const agg = data && baseRowKey ? data.getAggregator(baseRowKey, currentColKey) : null;
     
     if (isPercentage && isVariance && baseRowKey && agg) {
         const baseValue = agg.value();

package/tests/highcharts_renderer.test.js

@@ -2071,7 +2071,7 @@ describe('highcharts_renderer', () => {
                 highchartsRenderer.updateBackwardCompatibleWidgetOptions(currentOptions, null);
                 expect(currentOptions.comboOptions).toEqual({
                     secondaryAxisSettings: {
-                        name: 'TESTtest',
+                        name: 'Secondary Axis',
                         max: null,
                         min: null,
                         is_percentage: true

package/tests/value.formatter.test.js

@@ -60,6 +60,26 @@ describe('Function getAggregatorPercentageValueIfRequired', () => {
         const result = getAggregatorPercentageValueIfRequired(50, render_options, data, rowKey, colKey);
         expect(result).toBeNull();
     });
+
+    it('should return null if data is null', () => {
+        const result = getAggregatorPercentageValueIfRequired(50, render_options, null, rowKey, colKey);
+        expect(result).toBeNull();
+    });
+
+    it('should return null if data is undefined', () => {
+        const result = getAggregatorPercentageValueIfRequired(50, render_options, undefined, rowKey, colKey);
+        expect(result).toBeNull();
+    });
+
+    it('should return null if baseRowKey is null even when data exists', () => {
+        const data = {
+            rowKeys: [null],
+            getAggregator: jest.fn()
+        };
+        const result = getAggregatorPercentageValueIfRequired(50, render_options, data, rowKey, colKey);
+        expect(result).toBeNull();
+        expect(data.getAggregator).not.toHaveBeenCalled();
+    });
 });
 
 describe('Function getPercentageValue', () => {