@datarailsshared/dr_renderer 1.4.121 → 1.4.128

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.4.121",
+  "version": "1.4.128",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/value.formatter.js

@@ -31,7 +31,7 @@ function isAbsoluteValue(formula) {
     if (!formula)
         return false;
     
-    return lodash.includes(formula.replace(/\s+/g, ''), 'x2-x1');
+    return !lodash.includes(formula.replace(/\s+/g, ''), '/');
 };
 
 module.exports = {

package/tests/value.formatter.test.js

@@ -9,7 +9,8 @@ describe('Function getAggregatorPercentageValueIfRequired', () => {
             chartOptions: { 
                 delta_column: { 
                     name: 'Variance',
-                    formula: 'x2-x1' 
+                    formula: 'x2-x1',
+                    is_percentage: false
                 } 
             }
         };
@@ -17,7 +18,7 @@ describe('Function getAggregatorPercentageValueIfRequired', () => {
         colKey = ['SomeCol'];
     });
 
-    it('should return percentage string when all conditions are met', () => {
+    it('should return percentage string when secondaryAxisSettings.is_percentage is true but delta_column.is_percentage is false', () => {
         const data = {
             rowKeys: ['Variance'],
             getAggregator: jest.fn(() => ({
@@ -28,6 +29,19 @@ describe('Function getAggregatorPercentageValueIfRequired', () => {
         expect(result).toBe('25%');
     });
 
+    it('should return percentage string when secondaryAxisSettings.is_percentage is false but delta_column.is_percentage is true', () => {
+        const data = {
+            rowKeys: ['Variance'],
+            getAggregator: jest.fn(() => ({
+                value: () => 200
+            }))
+        };
+        render_options.comboOptions.secondaryAxisSettings.is_percentage = false;
+        render_options.chartOptions.delta_column.is_percentage = true;
+        const result = getAggregatorPercentageValueIfRequired(50, render_options, data, rowKey, colKey);
+        expect(result).toBe('25%');
+    });
+
     it('should return null if is_percentage is false', () => {
         const data = {
             rowKeys: ['Variance'],
@@ -111,20 +125,19 @@ describe('Function isAbsoluteValue', () => {
         expect(isAbsoluteValue(null)).toBe(false);
     });
 
-    it('should return false if formula does not contain "x2-x1"', () => {
-        expect(isAbsoluteValue('x2 + x1')).toBe(false);
-        expect(isAbsoluteValue('x1-x2')).toBe(false);
-        expect(isAbsoluteValue('')).toBe(false);
+    it('should return false if formula contains "/"', () => {
+        expect(isAbsoluteValue('/')).toBe(false);
+        expect(isAbsoluteValue(' / ')).toBe(false);
     });
 
-    it('should return true if formula contains "x2-x1"', () => {
+    it('should return true if formula does not contain "/"', () => {
         expect(isAbsoluteValue('x2-x1')).toBe(true);
-        expect(isAbsoluteValue(' x2 - x1 ')).toBe(true);
+        expect(isAbsoluteValue(' x1 - x2 ')).toBe(true);
         expect(isAbsoluteValue('some text x2-x1 more text')).toBe(true);
     });
 
     it('should ignore spaces in formula', () => {
         expect(isAbsoluteValue('x2 - x1')).toBe(true);
-        expect(isAbsoluteValue('  x2   -   x1  ')).toBe(true);
+        expect(isAbsoluteValue('  x1   -   x2  ')).toBe(true);
     });
 });