@datarailsshared/dr_renderer 1.4.114 → 1.4.116

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.4.114",
+  "version": "1.4.116",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/highcharts_renderer.js

@@ -641,7 +641,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     highchartsRenderer.persantageValueLabelsFormatter = function (pivotData, opts) {
         var func = function () {
             var value = parseFloat(this.value);
-            return $.pivotUtilities.getFormattedNumber(value, null, null) + "%";
+            return $.pivotUtilities.getFormattedNumber(value * 100, null, null) + "%";
         };
         return func;
     };
@@ -1918,9 +1918,9 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             lodash.forEach(series.data, function (it, index) {
                 if (pivotData.rowKeys && pivotData.rowKeys.length && pivotData.colKeys && pivotData.colKeys.length) {
                     const agg = pivotData.getAggregator([pivotData.rowKeys[0]], pivotData.colKeys[index]);
-                    if (agg) {
+                    if (agg && valueFormatter.isAbsoluteValue(delta_column_options.formula)) {
                         const baseValue = pivotData.getAggregator([pivotData.rowKeys[0]], pivotData.colKeys[index]).value();
-                        it.y = valueFormatter.getPercentageValue(it.y, baseValue);
+                        it.y = valueFormatter.getRelatedValue(it.y, baseValue);
                     }
                 }
             });
@@ -2130,7 +2130,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
 
     highchartsRenderer.addSecondYAxis = function (pivotData, chartOptions, additionOptions, opts) {
         const varianceColor = (additionOptions && additionOptions.delta_column.color) || (highchartsRenderer && highchartsRenderer.variance_color) || Highcharts.getOptions().colors[7];
-        const forcePercentage = lodash.get(opts, 'comboOptions.secondaryAxisSettings.is_percentage', false);
+        const forcePercentage = lodash.get(opts, 'comboOptions.secondaryAxisSettings.is_percentage', false) || lodash.get(additionOptions, 'delta_column.is_percentage', false);
 
         chartOptions.yAxis = [chartOptions.yAxis];
         chartOptions.yAxis[1] = {
@@ -3749,8 +3749,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     }
 
     highchartsRenderer.isRowKeyShouldBePercentage = function(render_options, rowKey) {
-        if (render_options && render_options.comboOptions && render_options.comboOptions.secondaryAxisSettings &&
-            render_options.comboOptions.secondaryAxisSettings.is_percentage) {
+        if (lodash.get(render_options, 'comboOptions.secondaryAxisSettings.is_percentage', false) || lodash.get(render_options, 'chartOptions.delta_column.is_percentage', false)) {
             const rowKeyString = rowKey.join(highchartsRenderer.delimer);
             const rowKeyOptions = lodash.find(render_options.comboOptions.seriesOptions, {series: rowKeyString});
             if (rowKeyOptions && rowKeyOptions.secondaryAxis) {
@@ -5308,7 +5307,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                     break;
             }
             options.comboOptions.seriesOptions.push(deltaColumnSeries);
-            options.comboOptions.secondaryAxisSettings.is_percentage = options.chartOptions.delta_column.is_percentage;
         }
     };
 

package/src/value.formatter.js

@@ -1,30 +1,41 @@
 const lodash = require('lodash');
 
 function getAggregatorPercentageValueIfRequired(value, render_options, data, rowKey, colKey) {
-    const isPercentage = lodash.get(render_options, 'comboOptions.secondaryAxisSettings.is_percentage', false);
-    const deltaColumnName = lodash.get(render_options, 'chartOptions.delta_column.name', '');
+    const deltaColumn = lodash.get(render_options, 'chartOptions.delta_column', null);
+    const isPercentage = lodash.get(render_options, 'comboOptions.secondaryAxisSettings.is_percentage', false) || deltaColumn && deltaColumn.is_percentage;
     const currentRowName = rowKey && rowKey.length ? String(rowKey[0]) : '';
-    const isVariance = currentRowName.replace('_', '').toLowerCase() === deltaColumnName.replace('_', '').toLowerCase();
+    const isVariance = deltaColumn && currentRowName.replace('_', '').toLowerCase() === deltaColumn.name.replace('_', '').toLowerCase();
     const baseRowKey = data && data.rowKeys && data.rowKeys.length ? data.rowKeys[0] : null;
     const currentColKey = colKey ? colKey : [];
     const agg = data && baseRowKey ? data.getAggregator(baseRowKey, currentColKey) : null;
     
     if (isPercentage && isVariance && baseRowKey && agg) {
-        const baseValue = agg.value();
-        return getPercentageValue(value, baseValue) + '%';
+        if (deltaColumn && isAbsoluteValue(deltaColumn.formula)) {
+            value = getRelatedValue(value, agg.value());
+        }
+        
+        return Math.round(value * 100) + '%';
     }
 
     return null;
 };
 
-function getPercentageValue(value, baseValue) {
+function getRelatedValue(value, baseValue) {
     if (!baseValue)
-        return value < 0 ? -100 : 100;
+        return value < 0 ? -1 : 1;
 
-    return Math.round(value / baseValue * 100);
+    return value / baseValue;
+};
+
+function isAbsoluteValue(formula) {
+    if (!formula)
+        return false;
+    
+    return lodash.includes(formula.replace(/\s+/g, ''), 'x2-x1');
 };
 
 module.exports = {
     getAggregatorPercentageValueIfRequired,
-    getPercentageValue
+    getRelatedValue,
+    isAbsoluteValue
 };

package/tests/highcharts_renderer.test.js

@@ -453,7 +453,7 @@ describe('highcharts_renderer', () => {
             let funcContext = { value: '12345.678' };
             let persantageValueLabelsFormatterFn = highchartsRenderer.persantageValueLabelsFormatter(null, {})
             let result = persantageValueLabelsFormatterFn.call(funcContext)
-            expect(result).toBe('12,345.678%');
+            expect(result).toBe('1,234,567.8%');
         });
     });
 
@@ -2057,7 +2057,7 @@ describe('highcharts_renderer', () => {
                         field: 'series',
                         name: 'TEST_test',
                         same_yaxis: true,
-                        is_percentage: true,
+                        is_percentage: false,
                     }
                 }
             };
@@ -2074,7 +2074,7 @@ describe('highcharts_renderer', () => {
                         name: 'Secondary Axis',
                         max: null,
                         min: null,
-                        is_percentage: true
+                        is_percentage: false
                     },
                     seriesOptions: [{
                         series: 'TEST_test',

package/tests/value.formatter.test.js

@@ -1,4 +1,4 @@
-const { getAggregatorPercentageValueIfRequired, getPercentageValue } = require('../src/value.formatter');
+const { getAggregatorPercentageValueIfRequired, getRelatedValue, isAbsoluteValue } = require('../src/value.formatter');
 
 describe('Function getAggregatorPercentageValueIfRequired', () => {
     let render_options, rowKey, colKey;
@@ -6,7 +6,12 @@ describe('Function getAggregatorPercentageValueIfRequired', () => {
     beforeEach(() => {
         render_options = {
             comboOptions: { secondaryAxisSettings: { is_percentage: true } },
-            chartOptions: { delta_column: { name: 'Variance' } }
+            chartOptions: { 
+                delta_column: { 
+                    name: 'Variance',
+                    formula: 'x2-x1' 
+                } 
+            }
         };
         rowKey = ['Variance'];
         colKey = ['SomeCol'];
@@ -82,18 +87,44 @@ describe('Function getAggregatorPercentageValueIfRequired', () => {
     });
 });
 
-describe('Function getPercentageValue', () => {
-    it('should return -100 when baseValue is falsy and value < 0', () => {
-        expect(getPercentageValue(-50, 0)).toBe(-100);
+describe('Function getRelatedValue', () => {
+    it('should return -1 when baseValue is falsy and value < 0', () => {
+        expect(getRelatedValue(-50, 0)).toBe(-1);
     });
 
-    it('should return 100 when baseValue is falsy and value >= 0', () => {
-        expect(getPercentageValue(50, null)).toBe(100);
+    it('should return 1 when baseValue is falsy and value >= 0', () => {
+        expect(getRelatedValue(50, null)).toBe(1);
     });
 
-    it('should return rounded percentage when baseValue is truthy', () => {
-        expect(getPercentageValue(25, 200)).toBe(13);
-        expect(getPercentageValue(50, 200)).toBe(25);
-        expect(getPercentageValue(200, 200)).toBe(100);
+    it('should return related value when baseValue is truthy', () => {
+        expect(getRelatedValue(50, 200)).toBe(0.25);
+        expect(getRelatedValue(200, 200)).toBe(1);
+    });
+});
+
+describe('Function isAbsoluteValue', () => {
+    it('should return false if formula is undefined', () => {
+        expect(isAbsoluteValue(undefined)).toBe(false);
+    });
+
+    it('should return false if formula is null', () => {
+        expect(isAbsoluteValue(null)).toBe(false);
+    });
+
+    it('should return false if formula does not contain "x2-x1"', () => {
+        expect(isAbsoluteValue('x2 + x1')).toBe(false);
+        expect(isAbsoluteValue('x1-x2')).toBe(false);
+        expect(isAbsoluteValue('')).toBe(false);
+    });
+
+    it('should return true if formula contains "x2-x1"', () => {
+        expect(isAbsoluteValue('x2-x1')).toBe(true);
+        expect(isAbsoluteValue(' x2 - x1 ')).toBe(true);
+        expect(isAbsoluteValue('some text x2-x1 more text')).toBe(true);
+    });
+
+    it('should ignore spaces in formula', () => {
+        expect(isAbsoluteValue('x2 - x1')).toBe(true);
+        expect(isAbsoluteValue('  x2   -   x1  ')).toBe(true);
     });
 });