@datarailsshared/dr_renderer 1.3.23 → 1.3.25

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.3.23",
+  "version": "1.3.25",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/charts/dr_gauge_chart.js

@@ -80,8 +80,8 @@ function DrGaugeChart(pivotData, opts) {
         return DrGaugeChart.highchartsRenderer.getSingleValueAgg(opts, aggfunc, base);
     };
 
-    this.isLeftQuarter = function (value, max = this.max) {
-        return value < max / 2;
+    this.isLeftQuarter = function (value, max = this.max, min = this.min) {
+        return (value - min) < (max - min) / 2;
     };
 
     this.createPlotBands = function (options) {

package/src/highcharts_renderer.js

@@ -1298,7 +1298,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                 );
             });
 
-            if (additionOptions.series_colors) {
+            if (additionOptions && additionOptions.series_colors) {
                 ob.color = additionOptions.series_colors[row_n_value] || undefined;
             } else if (colors && colors[i]) {
                 ob.color = colors[i];
@@ -1493,7 +1493,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                 ob.data.push(tmoobj);
             });
 
-            if (additionOptions.series_colors) {
+            if (additionOptions && additionOptions.series_colors) {
                 ob.color = additionOptions.series_colors[row_n_value] || undefined;
             } else if (colors && colors[i]) {
                 ob.color = colors[i];
@@ -1923,7 +1923,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             // check string contains hebrew
             ob.initialName = (/[\u0590-\u05FF]/).test(key) ? ('\u200E' + key) : key;
 
-            if (additionOptions.series_colors) {
+            if (additionOptions && additionOptions.series_colors) {
                 ob.color = additionOptions.series_colors[key] || undefined;
             }
 

package/tests/dr_gauge_chart.test.js

@@ -115,15 +115,19 @@ describe("DrGaugeChart", () => {
 
     describe("isLeftQuarter", () => {
         it("should check in which quarter the chart value is", () => {
-            expect(chart.isLeftQuarter(20, 100)).toBe(true);
-            expect(chart.isLeftQuarter(20, 30)).toBe(false);
-            expect(chart.isLeftQuarter(20, 20)).toBe(false);
-            expect(chart.isLeftQuarter(100, 200)).toBe(false);
-            expect(chart.isLeftQuarter(99, 200)).toBe(true);
+            expect(chart.isLeftQuarter(20, 100, 0)).toBe(true);
+            expect(chart.isLeftQuarter(20, 30, 0)).toBe(false);
+            expect(chart.isLeftQuarter(20, 20, 0)).toBe(false);
+            expect(chart.isLeftQuarter(100, 200, 0)).toBe(false);
+            expect(chart.isLeftQuarter(99, 200, 0)).toBe(true);
+
+            expect(chart.isLeftQuarter(59, 100, 20)).toBe(true);
+            expect(chart.isLeftQuarter(60, 100, 20)).toBe(false);
         });
 
-        it("should use default #max parameter", () => {
+        it("should use default #max  and #min parameters", () => {
             // Max = 180
+            // Min = 0
             expect(chart.isLeftQuarter(20)).toBe(true);
             expect(chart.isLeftQuarter(120)).toBe(false);
         });