@datarailsshared/dr_renderer 1.2.459 → 1.2.461

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.2.459",
+  "version": "1.2.461",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/dataformatter.js

@@ -1,3 +1,5 @@
+const _ = require('lodash');
+
 var _createClass = function () { function defineProperties(target, props) { for (var i = 0; i < props.length; i++) { var descriptor = props[i]; descriptor.enumerable = descriptor.enumerable || false; descriptor.configurable = true; if ("value" in descriptor) descriptor.writable = true; Object.defineProperty(target, descriptor.key, descriptor); } } return function (Constructor, protoProps, staticProps) { if (protoProps) defineProperties(Constructor.prototype, protoProps); if (staticProps) defineProperties(Constructor, staticProps); return Constructor; }; }();
 
 function _defineProperty(obj, key, value) { if (key in obj) { Object.defineProperty(obj, key, { value: value, enumerable: true, configurable: true, writable: true }); } else { obj[key] = value; } return obj; }
@@ -350,7 +352,7 @@ var DataFormatterImpl = function () {
 
             n = this.roundDecimals(n, decimals).toString().split('.');
             var integerPart = n[0];
-            var decimalPart = String(n[1] || 0).padEnd(decimals, '0');
+            var decimalPart = _.padEnd(String(n[1] || 0), decimals, '0');
 
             return this.applyNumberPattern(integerPart, patternIntegerPart) + this.locale.decimalSeparator + this.applyNumberPattern(decimalPart, patternDecimalPart, n[1] && n[1][0] == '0' ? '' : 'right');
         }

package/src/highcharts_renderer.js

@@ -1569,12 +1569,8 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             totalSeries.className = 'totalSeries';
             totalSeries.name = 'Total';
             totalSeries.data = [];
-            
-            // DEV_FF: DR-31422
-            if (opts.devFixDrollDownByTotal) {
-                totalSeries.initialName = 'Total';
-                totalSeries.isTotal = true;
-            }
+            totalSeries.initialName = 'Total';
+            totalSeries.isTotal = true;
 
             if (colors && colors[i]) {
                 totalSeries.color = colors[i];

package/tests/highcharts_renderer.test.js

@@ -6604,8 +6604,9 @@ describe('highcharts_renderer', () => {
                             fontWeight: 'normal'
                         }
                     },
-                    initialName: 'row 2',
-                    name: 'Total'
+                    name: "Total",
+                    initialName: "Total",
+                    isTotal: true,
                 }
             ]);
         });
@@ -7038,11 +7039,10 @@ describe('highcharts_renderer', () => {
                 name: 'Total'
             }];
   
-            it("should mark the series as total if the feature flag is on", () => {
+            it("should mark the series as total", () => {
                 additionalOptionsMock = {};
                 opts = {
-                    total: true,
-                    devFixDrollDownByTotal: true,
+                    total: true
                 };
                 pivotDataMock.colTotals = {
                     "col 1": { value: () => 123450 },
@@ -7070,31 +7070,6 @@ describe('highcharts_renderer', () => {
                 };
                 expect(value).toEqual(fixedResponse);
             });
-  
-            it("should not change the original series if the feature flag is off", () => {
-                additionalOptionsMock = {};
-                opts = {
-                    total: true,
-                    devFixDrollDownByTotal: false,
-                };
-                pivotDataMock.colTotals = {
-                    "col 1": { value: () => 123450 },
-                    "col 2": { value: () => 123451 },
-                    DR_Others: { value: () => 123452 },
-                };
-                const value = highchartsRenderer.ptCreateColumnSeries(
-                    pivotDataMock,
-                    colors,
-                    onlyNumbers,
-                    isUniqueVals,
-                    isNotDrillDown,
-                    additionalOptionsMock,
-                    opts,
-                    chartOptions,
-                    chartType
-                );
-                expect(value).toEqual(originResponse);
-            });
         });
     });
     describe('Function ptCreateBasicLineSeries', () => {