@datarailsshared/dr_renderer 1.2.399 → 1.2.401

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.2.399",
+  "version": "1.2.401",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/dr_pivottable.js

@@ -158,11 +158,6 @@ let initDRPivotTable = function($, window, document) {
             return key;
         };
 
-        DRPivotData.prototype.getInsight = function(colKey, rowKey) {
-            const key = [rowKey, colKey].join(delim);
-            return this.insights.get(key);
-        }
-
         DRPivotData.prototype.getAttrsKeys = function(record, attrs) {
             const keys = [];
             for (let k = 0; k < attrs.length; k++) {
@@ -179,53 +174,7 @@ let initDRPivotTable = function($, window, document) {
             return keys.join(delim);
         }
 
-        DRPivotData.prototype.buildInsights = function(rows, useServerTotalsCalculation) {
-            for (let index = 0; index < rows.length; index++) {
-                const record = rows[index];
-                const insight = record.insight;
-                delete record.insight;
-
-                if (!insight) continue;
-
-                if (useServerTotalsCalculation) {
-                    const flatRowKey = this.getFlatKey(record, this.rowAttrs);
-                    const flatColKey = this.getFlatKey(record, this.colAttrs);
-
-                    if (flatRowKey || flatColKey) {
-                        this.insights.set([flatRowKey, flatColKey].join(delim), insight);
-                    }
-                    continue;
-                }
-
-                const recordValues = _.values(record);
-                const containsAverage = _.includes(recordValues, 'DR_Average');
-                const containsOthers = _.includes(recordValues, 'DR_Others');
-
-                const rowKey = processKey(record, this.rowTotals, this.rowKeys, this.rowAttrs, containsAverage, containsOthers,  (function(_this) {
-                    return function(key) {
-                        return _this.aggregator(_this, key, []);
-                    };
-                })(this));
-
-                const colKey = processKey(record, this.colTotals, this.colKeys, this.colAttrs, containsAverage, containsOthers, (function(_this) {
-                    return function(key) {
-                        return _this.aggregator(_this, [], key);
-                    };
-                })(this));
-
-                const flatRowKey = rowKey.join(delim);
-                const flatColKey = colKey.join(delim);
-
-                if (flatRowKey || flatColKey) {
-                    this.insights.set([flatRowKey, flatColKey].join(delim), insight);
-                }
-            }
-        }
-
         DRPivotData.prototype.processRecord = function(record, useTotalsCalculation) {
-            const insight = record.insight;
-            delete record.insight;
-            
             if (useTotalsCalculation) {
                 if (!this.notFirst) {
                     this.keysLength = _.filter(_.keys(record), key => !_.includes(['data_types', 'formats', 'values_formats'], key)).length - 1;
@@ -277,9 +226,6 @@ let initDRPivotTable = function($, window, document) {
                     this.tree[flatRowKey][flatColKey].push(record);
                 }
 
-                if (insight && (flatRowKey || flatColKey)) {
-                    this.insights.set([flatRowKey, flatColKey].join(delim), insight);
-                }
                 return;
             }
 
@@ -303,15 +249,6 @@ let initDRPivotTable = function($, window, document) {
                 };
             })(this));
 
-            if (insight) {
-                const flatRowKeyForInsight = rowKey.join(delim);
-                const flatColKeyForInsight = colKey.join(delim);
-
-                if (flatRowKeyForInsight || flatColKeyForInsight) {
-                    this.insights.set([flatRowKeyForInsight, flatColKeyForInsight].join(delim), insight);
-                }
-            }
-
             m = rowKey.length - 1;
             n = colKey.length - 1;
             if (m < 0 || n < 0) {

package/src/graph-table-renderer.js

@@ -15,7 +15,6 @@
 
 /**
  * @typedef {Object} PivotModel
- * @property {(rows: Rows, useTotalsCalculation: boolean) => void} buildInsights
  */
 
 /**

package/src/highcharts_renderer.js

@@ -713,33 +713,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         return func;
     };
 
-    highchartsRenderer.customFormatterTooltipInsights = function(pivotData, opts) {
-        return {
-        useHTML: true,
-        outside: true,
-        backgroundColor: 'transparent',
-        borderWidth: 0,
-        borderRadius: 0,
-        shadow: false,
-        shape: 'square',
-        padding: 0,
-        stickOnContact: true,
-        hideDelay: 300,
-        destroyWhenHiding: true,
-        formatter: function () {
-            const rowKey = pivotData.rowAttrs.length ? lodash.get(this.point, 'series.name') || "" : "";
-            const colKey = lodash.get(this.point, 'initialName') || lodash.get(this.point, 'name') || this.x.name[0] || "";
-
-            const insight = pivotData.getInsight(colKey, rowKey) || {};
-            setTimeout(() => {
-                var aggr = highchartsRenderer.defaultFormatterToTooltip(pivotData, opts);
-                const formatted_value_to_return = aggr.bind(this)();
-                opts.insightsTooltipFunc(lodash.merge(lodash.cloneDeep(this), { formatted_value_to_return }, insight));
-            });
-        }
-    }
-    }
-
     highchartsRenderer.defaultFormatterToTooltip = function (pivotData, opts, is_drill_down_pie) {
         var variant_name = null;
         var variant_name_default_name = null;
@@ -1471,7 +1444,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             }
         }
 
-        let weights = { line: 2,spline: 3 ,area:-2, areaspline: -1, scatter:4, column: 1 };
         if (opts.comboOptions && lodash.includes(chartType,'combo') && !lodash.isEqual(row_n_keys, EMPTY_ROW_N_KEYS)) {
             chart_series.forEach((series, seriesIndex) => {
                 const savedSeriesOption = lodash.find(opts.comboOptions.seriesOptions, {series: series.name});
@@ -1538,10 +1510,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
 
         highchartsRenderer.moveSeriesToSecondYAxisIfNeeded(chart_series, pivotData, chartOptions, additionOptions, opts, opts.total && opts.totalSeriesSettings && opts.totalSeriesSettings.secondaryAxis);
 
-        chart_series.sort((a,b) => {
-            return (weights[a.type] || 0) > (weights[b.type] || 0) ? 1 : (weights[a.type] || 0) < (weights[b.type] || 0) ? -1 : 0
-        });
-
         return chart_series;
     }
 
@@ -2684,17 +2652,10 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
-        chartOptions.tooltip = opts.insightsTooltipFunc
-            ? highchartsRenderer.customFormatterTooltipInsights(pivotData, opts)
-            : {
-                formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
-                valueDecimals: 2,
-            };
+        chartOptions.tooltip = {
+            formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
+            valueDecimals: 2,
+        };
 
         chartOptions.xAxis = {
             categories: highchartsRenderer.getFormattedColKeys(pivotData, null),
@@ -2770,11 +2731,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.tooltip = {
             formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
             valueDecimals: 2,
@@ -2867,11 +2823,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.tooltip = {
             formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
             valueDecimals: 2,
@@ -3108,12 +3059,10 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         }
 
 
-        chartOptions.tooltip = opts.insightsTooltipFunc
-            ? highchartsRenderer.customFormatterTooltipInsights(pivotData, opts)
-            : {
-                formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
-                valueDecimals: 2,
-            };
+        chartOptions.tooltip = {
+            formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
+            valueDecimals: 2,
+        };
 
         highchartsRenderer.handleGridLines(additionOptions, chartOptions);
 
@@ -3153,11 +3102,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.legend = highchartsRenderer.getOptionsForLegends(additionOptions, rowAttrs.length, false);
 
         chartOptions.drilldown = highchartsRenderer.getDataLabelsStylesForDrillDown(additionOptions);
@@ -3241,12 +3185,10 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
 
         chartOptions.legend = highchartsRenderer.getOptionsForLegends(additionOptions, rowAttrs.length, false);
 
-        chartOptions.tooltip = opts.insightsTooltipFunc
-            ? highchartsRenderer.customFormatterTooltipInsights(pivotData, opts)
-            : {
-                formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
-                valueDecimals: 2,
-            };
+        chartOptions.tooltip = {
+            formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
+            valueDecimals: 2,
+        };
 
         if (additionOptions && additionOptions.chart) {
             chartOptions.colors = highchartsRenderer.getColorsWithOffset(additionOptions.chart.colors_offset);
@@ -3287,11 +3229,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.xAxis = {
             type: 'category',
             crosshair: true,
@@ -3428,12 +3365,10 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         if (additionOptions) {
             highchartsRenderer.setYAxisMinMax(chartOptions.yAxis, additionOptions.axisY);
         }
-        chartOptions.tooltip = opts.insightsTooltipFunc
-            ? highchartsRenderer.customFormatterTooltipInsights(pivotData, opts)
-            : {
-                formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
-                valueDecimals: 2,
-            };
+        chartOptions.tooltip = {
+            formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts),
+            valueDecimals: 2,
+        };
 
         if (additionOptions && additionOptions.chart) {
             chartOptions.colors = highchartsRenderer.getColorsWithOffset(additionOptions.chart.colors_offset);
@@ -3479,11 +3414,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.legend = highchartsRenderer.getOptionsForLegends(additionOptions, rowAttrs.length, false);
 
         return highchartsRenderer.ptCreateElementAndDraw(chartOptions, opts);
@@ -3542,11 +3472,9 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         chartOptions.legend = highchartsRenderer.getOptionsForLegends(additionOptions, rowAttrs.length, false);
         chartOptions.legend.reversed = true;
 
-        chartOptions.tooltip = opts.insightsTooltipFunc
-            ? highchartsRenderer.customFormatterTooltipInsights(pivotData, opts)
-            : {
-                formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts)
-            };
+        chartOptions.tooltip = {
+            formatter: highchartsRenderer.defaultFormatterToTooltip(pivotData, opts)
+        };
 
         if (additionOptions && additionOptions.chart) {
             chartOptions.colors = highchartsRenderer.getColorsWithOffset(additionOptions.chart.colors_offset);
@@ -3568,11 +3496,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.xAxis = {
             categories: highchartsRenderer.getFormattedColKeys(pivotData, null),
             title: {
@@ -3684,11 +3607,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         chartOptions.legend = highchartsRenderer.getOptionsForLegends(additionOptions, 3, false);
         chartOptions.legend.useHTML = true;
         chartOptions.legend.labelFormatter = function() {
@@ -3805,11 +3723,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             };
         }
 
-        if (lodash.get(chartOptions, 'plotOptions.series.point.events')) {
-            chartOptions.plotOptions.series.point.events.mouseOver = opts.trackUserInsightsTooltipFunc;
-            chartOptions.plotOptions.series.point.events.mouseOut = opts.trackUserInsightsTooltipFunc;
-        }
-
         if (waterfallOptions.colors) {
             chartOptions.legend = highchartsRenderer.getOptionsForLegends(additionOptions, 3, false);
             chartOptions.legend.useHTML = true;
@@ -5535,7 +5448,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         options.chartOptions = lodash.merge(defaultOptions, options.chartOptions);
     };
 
-    highchartsRenderer.addPivotOptions = function (selectedTemplateWOData, widgetOptions, drilldownFunction, drillDownListFunction, insightsTooltipFunction, trackUserInsightsTooltipFunction) {
+    highchartsRenderer.addPivotOptions = function (selectedTemplateWOData, widgetOptions, drilldownFunction, drillDownListFunction) {
         // Check if not rendered data, than it will render
 
         var fields = highchartsRenderer.objectCopyJsonMethod(selectedTemplateWOData.fields);
@@ -5545,8 +5458,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         var valuesFields = [];
         var drilldownFunc = drilldownFunction;
         var drillDownListFunc = drillDownListFunction;
-        var insightsTooltipFunc = insightsTooltipFunction;
-        var trackUserInsightsTooltipFunc = trackUserInsightsTooltipFunction;
 
         // fill value fields
         lodash.forEach(widgetOptions.vals, function (valObj) {
@@ -5601,7 +5512,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         widgetOptions.pivot.valuesArray = valuesFields;
         widgetOptions.pivot.chartType = widgetOptions.chart_type;
         widgetOptions.pivot.chartOptions = widgetOptions.options;
-        widgetOptions.pivot.chartRender = highchartsRenderer.getChartRendererFunction(widgetOptions.pivot.chartType, drilldownFunc, drillDownListFunc, insightsTooltipFunc, trackUserInsightsTooltipFunc);
+        widgetOptions.pivot.chartRender = highchartsRenderer.getChartRendererFunction(widgetOptions.pivot.chartType, drilldownFunc, drillDownListFunc);
 
         if (highchartsRenderer.isSortingOnBackendEnabled) return;
         // TODO: remove this logic after BE sort is implemented
@@ -6130,7 +6041,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         return toReturn;
     };
 
-    highchartsRenderer.getChartRendererFunction = function (newChartType, drilldownFunc, drillDownListFunc, insightsTooltipFunc, trackUserInsightsTooltipFunc) {
+    highchartsRenderer.getChartRendererFunction = function (newChartType, drilldownFunc, drillDownListFunc) {
         var fnToReturn = null;
 
         if (newChartType == highchartsRenderer.richTextSubType.type) {
@@ -6161,8 +6072,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                     highchartsRenderer.modifyEventPointForDrilldown(e, pivotData);
                     drillDownListFunc(e);
                 };
-                opt.insightsTooltipFunc = insightsTooltipFunc;
-                opt.trackUserInsightsTooltipFunc = trackUserInsightsTooltipFunc;
             } else {
                 opt.drillDownListFunc = null;
             }

package/src/pivottable.js

@@ -688,7 +688,6 @@ let initPivotTable = function($, window, document) {
                 return true;
             });
             this.tree = {};
-            this.insights = new Map();
 
             this.isKeysSortingDoneOnBackendSide = opts.keysObject && typeof opts.keysObject === 'object' && helpers.backendSortingKeysAreNotEmpty(opts.keysObject);
             if (this.isKeysSortingDoneOnBackendSide) {

package/tests/highcharts_renderer.test.js

@@ -6475,24 +6475,24 @@ describe('highcharts_renderer', () => {
                         {
                             initialName: 'col 1',
                             name: 'col 1',
-                            y: 123450,
+                            y: 12345,
                             drilldown: true
                         },
                         {
                             initialName: 'col 2',
                             name: 'col 2',
-                            y: 11111,
+                            y: 54321,
                             drilldown: true
                         },
                         {
                             initialName: 'Others',
                             name: 'Others',
-                            y: 99991,
+                            y: 99999,
                             drilldown: true
                         }
                     ],
-                    initialName: 'row 2',
-                    name: 'row 2',
+                    initialName: 'row 1',
+                    name: 'row 1',
                     dataLabels: {
                         style: {
                             fontSize: '11',
@@ -6504,31 +6504,36 @@ describe('highcharts_renderer', () => {
                         enabled: true,
                         formatter: expect.any(Function)
                     },
-                    color: '#b3060e'
+                    color: '#5ecfb9',
+                    type: 'line',
+                    lineColor: '#5ecfb9',
+                    marker: {
+                        lineColor: '#5ecfb9'
+                    }
                 },
                 {
                     data: [
                         {
                             initialName: 'col 1',
                             name: 'col 1',
-                            y: 12345,
+                            y: 123450,
                             drilldown: true
                         },
                         {
                             initialName: 'col 2',
                             name: 'col 2',
-                            y: 54321,
+                            y: 11111,
                             drilldown: true
                         },
                         {
                             initialName: 'Others',
                             name: 'Others',
-                            y: 99999,
+                            y: 99991,
                             drilldown: true
                         }
                     ],
-                    initialName: 'row 1',
-                    name: 'row 1',
+                    initialName: 'row 2',
+                    name: 'row 2',
                     dataLabels: {
                         style: {
                             fontSize: '11',
@@ -6540,13 +6545,8 @@ describe('highcharts_renderer', () => {
                         enabled: true,
                         formatter: expect.any(Function)
                     },
-                    color: '#5ecfb9',
-                    type: 'line',
-                    lineColor: '#5ecfb9',
-                    marker: {
-                        lineColor: '#5ecfb9'
-                    }
-                }
+                    color: '#b3060e'
+                },
             ]);
         });
         it('should prepare appropriate chart series, when additional options have delta column \'only variant\'', ()=> {

package/tests/mock/widgets.json

@@ -345,7 +345,6 @@
           "variance_color": "#3DC5AA"
         }
       },
-      "insightsTooltipFunc": null,
       "chart_series": [
         "Actuals"
       ],

package/types/graph-table-renderer.d.ts

@@ -12,7 +12,6 @@
  */
 /**
  * @typedef {Object} PivotModel
- * @property {(rows: Rows, useTotalsCalculation: boolean) => void} buildInsights
  */
 /**
  * @typedef {Object} GTROptions
@@ -57,9 +56,7 @@ export type PivotUtilities = {
 export type JQuery = {
     pivotUtilities: PivotUtilities;
 };
-export type PivotModel = {
-    buildInsights: (rows: Rows, useTotalsCalculation: boolean) => void;
-};
+export type PivotModel = Object;
 export type GTROptions = Object;
 /**
  * - BE data response