@datarailsshared/dr_renderer 1.2.352 → 1.2.356

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.2.352",
+  "version": "1.2.356",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/highcharts_renderer.js

@@ -167,6 +167,19 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         }
     }
 
+    // remove highcharts tooltip from the dom instead of hiding if option is passed
+    Highcharts.wrap(Highcharts.Tooltip.prototype, 'hide', function(proceed, delay) {
+        if (!this.options.destroyWhenHiding) {
+            proceed.call(this, delay);
+        } else {
+            Highcharts.clearTimeout(this.hideTimer);
+            delay = Highcharts.pick(delay, this.options.hideDelay);
+            this.hideTimer = Highcharts.syncTimeout(() => {
+                this.destroy();
+            }, delay);
+        }
+    });
+
     if(!moment_lib){
         moment_lib = moment;
     }
@@ -701,6 +714,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         padding: 0,
         stickOnContact: true,
         hideDelay: 1500,
+        destroyWhenHiding: true,
         formatter: function () {
             const rowKey = pivotData.rowAttrs.length ? lodash.get(this.point, 'series.name') || "" : "";
             const colKey = lodash.get(this.point, 'name') || this.x.name[0] || "";
@@ -1493,7 +1507,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                 totalSeries.color = colors[i];
             }
 
-        if (!lodash.isEmpty(pivotData.colTotals)) {
+
             col_n_keys.forEach(columnKey => {
                 let key = columnKey;
                 let totalKey = columnKey;
@@ -1504,18 +1518,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                 const value = pivotData.colTotals[totalKey] ? pivotData.colTotals[totalKey].value() : 0;
                 totalSeries.data.push({name: lodash.unescape(key), y: value});
             });
-        } else {
-            lodash.forEach(row_n_keys, (rowKey, index) => {
-                let key = rowKey;
-                let totalKey = rowKey;
-                if (lodash.isArray(rowKey)) {
-                    key = col_n_keys[index];
-                    totalKey = totalKey.join(highchartsRenderer.delimer);
-                }
-                const value = pivotData.rowTotals[totalKey] ? pivotData.rowTotals[totalKey].value() : 0;
-                totalSeries.data.push({name: lodash.unescape(key), y: value});
-            });
-        }
 
             chart_series.push(totalSeries);
         }
@@ -8985,6 +8987,8 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             res = highchartsRenderer.addTotalsToWalkthroughRowData(widget_obj, res);
         }
 
+        res = highchartsRenderer.fixIncompatibleCalculatedValuesTotals(widget_obj, res);
+
         let pivot = {};
 
         let templateNoData = lodash.find(templates, {id: widget_obj.template_id});
@@ -9494,6 +9498,73 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         }));
     }
 
+    // We are receiving not correct format for subtotals from BE for now - so we modyfing the response
+    // in order to transform it to acceptable one. It is complex to fix currently on BE side.
+    // TODO: remove it when fixed on BE side
+    highchartsRenderer.fixIncompatibleCalculatedValuesTotals = function(widget, res) {
+
+        // if it is FE side calculation or empty response - just return unmodified
+        if (!highchartsRenderer.useTotalsCalculation || !lodash.get(res, 'length')) return res;
+
+        const calculatedValuesInValsCount = lodash.filter(
+            widget.calculated_values, calcVal => lodash.some(widget.vals, { field: calcVal.field })
+        ).length;
+
+        // do transformations only if widget has calculated in values
+        if (calculatedValuesInValsCount) {
+            const fieldWithDrValuesNames = lodash.reduce(
+                widget.calculated_values,
+                (fieldNames, calcVal) => {
+                    const fieldName = lodash.get(lodash.find(widget.vals, { field: calcVal.field }), 'name');
+                    return fieldName ? lodash.concat(fieldNames, [fieldName]) : fieldNames;
+                },
+                []
+            );
+
+            const existingRecords = [];
+            lodash.forEach(res, (record) => {
+
+                // example: replace record { Type: "Discount", City: "Brest", DR_Values: "Normal 1", Amount: 52585.14 }
+                // with { Type: "Discount", City: "Brest", DR_Values: "Normal 1", value: 52585.14 }
+                if (widget.vals.length > 1 && !widget.rows.length) {
+                    const valueFieldNameFound = lodash.find(fieldWithDrValuesNames, name => record[name]);
+                    if (valueFieldNameFound) {
+                        record.value = record[valueFieldNameFound];
+                        delete record[valueFieldNameFound];
+                    }
+                }
+
+                // in response from BE we have currently improper column subtotals:
+                // they returned with 'DR_Values' not empty - same as for regular cell values
+                // so we have two records with same column values and can't define which is subtotal
+                const isSameColValuesWasBefore = lodash.some(existingRecords, existingRecord =>
+                    lodash.every(
+                        lodash.concat(['DR_Values'], lodash.map(widget.cols, 'name')), fieldName => existingRecord[fieldName] === record[fieldName]
+                    )
+                );
+                const isNoRowValues = lodash.every(widget.rows, field => typeof record[field.name] === 'undefined');
+                const isSubtotal = isSameColValuesWasBefore && isNoRowValues;
+
+                // we need to remove DR_Values for response records which suppose to be subtotals
+                if (isSubtotal) {
+                    delete record.DR_Values;
+                }
+
+                existingRecords.push(record);
+            });
+
+            // Another BE issue - it is not returning correct subtotals for case we have more than one calculated values
+            // It is just not counting sum there. So we remove it in order not to show improper values
+            if ((calculatedValuesInValsCount > 1 || calculatedValuesInValsCount && widget.vals.length > 1) && !widget.rows.length) {
+                res = lodash.filter(res, record => {
+                    const isColsTotal = typeof record['DR_Values'] === 'undefined';
+                    return !isColsTotal;
+                })
+            }
+        }
+        return res;
+    }
+
     return highchartsRenderer;
 };
 

package/tests/highcharts_renderer.test.js

@@ -36,7 +36,9 @@ describe('highcharts_renderer', () => {
             opt: {},
             setOptions: function(value) {Highcharts.opt = value;},
             numberFormat: function(value) { return value ;},
-            getOptions: function() { return Highcharts.opt; }
+            getOptions: function() { return Highcharts.opt; },
+            Tooltip: {},
+            wrap: () => {},
         };
         _window.DataFormatter = DataFormatter;
         initPivotTable($, _window, _document);