@datarailsshared/dr_renderer 1.2.351 → 1.2.355

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.2.351",
+  "version": "1.2.355",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/highcharts_renderer.js

@@ -144,7 +144,6 @@ const FEATURES = {
     ENABLE_SERVER_TOTALS_CALCULATION: 'enable_server_totals_calculation',
     FORMAT_AXIS: 'use_default_table_format_for_axis',
     FORMAT_DATES_AS_OTHER_AXIS_TYPES: 'format_dates_as_other_axis_types',
-    DASHBOARD_INSIGHT_TOOLTIP_RELATIVE_POSITION: 'dashboard_insight_tooltip_relative_position',
     MULTIPLE_DIMENSION_TAGS: 'multiple_dimension_tags',
     USE_NEW_SCENARIO_TAG: 'use_new_scenario_tag',
 }
@@ -168,6 +167,19 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         }
     }
 
+    // remove highcharts tooltip from the dom instead of hiding if option is passed
+    Highcharts.wrap(Highcharts.Tooltip.prototype, 'hide', function(proceed, delay) {
+        if (!this.options.destroyWhenHiding) {
+            proceed.call(this, delay);
+        } else {
+            Highcharts.clearTimeout(this.hideTimer);
+            delay = Highcharts.pick(delay, this.options.hideDelay);
+            this.hideTimer = Highcharts.syncTimeout(() => {
+                this.destroy();
+            }, delay);
+        }
+    });
+
     if(!moment_lib){
         moment_lib = moment;
     }
@@ -179,7 +191,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
 
     highchartsRenderer.useTotalsCalculation = false;
     highchartsRenderer.enabledNewWidgetValueFormatting = false;
-    highchartsRenderer.relativePositionForInsightTooltips = false;
     let disableAnimation = false;
 
     highchartsRenderer.hasFeature = function(featureFlagKey) {
@@ -190,7 +201,6 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         highchartsRenderer.useTotalsCalculation = highchartsRenderer.hasFeature(FEATURES.ENABLE_SERVER_TOTALS_CALCULATION);
         disableAnimation = document.ReportHippo.user.organization && document.ReportHippo.user.organization.settings && document.ReportHippo.user.organization.settings.disable_animation
         highchartsRenderer.enabledNewWidgetValueFormatting = highchartsRenderer.hasFeature(FEATURES.ENABLE_NEW_WIDGET_VALUE_FORMATTING);
-        highchartsRenderer.relativePositionForInsightTooltips = highchartsRenderer.hasFeature(FEATURES.DASHBOARD_INSIGHT_TOOLTIP_RELATIVE_POSITION);
     }
 
     // fix issue of use tootip.stickOnContact with tooltip.outside , source: https://github.com/highcharts/highcharts/pull/15960
@@ -695,7 +705,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     highchartsRenderer.customFormatterTooltipInsights = function(pivotData, opts) {
         return {
         useHTML: true,
-        outside: !highchartsRenderer.relativePositionForInsightTooltips,
+        outside: true,
         backgroundColor: 'transparent',
         borderWidth: 0,
         borderRadius: 0,
@@ -704,6 +714,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         padding: 0,
         stickOnContact: true,
         hideDelay: 1500,
+        destroyWhenHiding: true,
         formatter: function () {
             const rowKey = pivotData.rowAttrs.length ? lodash.get(this.point, 'series.name') || "" : "";
             const colKey = lodash.get(this.point, 'name') || this.x.name[0] || "";

package/tests/highcharts_renderer.test.js

@@ -36,7 +36,9 @@ describe('highcharts_renderer', () => {
             opt: {},
             setOptions: function(value) {Highcharts.opt = value;},
             numberFormat: function(value) { return value ;},
-            getOptions: function() { return Highcharts.opt; }
+            getOptions: function() { return Highcharts.opt; },
+            Tooltip: {},
+            wrap: () => {},
         };
         _window.DataFormatter = DataFormatter;
         initPivotTable($, _window, _document);