@datarailsshared/dr_renderer 1.2.208 → 1.2.210-dragons

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datarailsshared/dr_renderer",
-  "version": "1.2.208",
+  "version": "1.2.210-dragons",
   "description": "DataRails charts and tables renderer",
   "keywords": [
     "datarails",

package/src/dr_pivottable.js

@@ -2421,8 +2421,14 @@ let initDRPivotTable = function($, window, document) {
             if (colAttrs.length > 0 && colKeys.length > 0) {
                 colHeaders = processKeys(colKeys, "pvtColLabel", 'cols', colAttrs);
             }
-            var tableClasses = useNewUx && opts.chartOptions.table_options.use_new_table_design ? 'pvtTable newPvtTable' : 'pvtTable';
-            result = createElement("table", tableClasses , null, {
+            var tableClasses = ['pvtTable'];
+            if (opts.chartOptions.table_options.use_new_table_design) {
+                tableClasses.push('newPvtTable');
+            }
+            if (!pivotData.aggregator().uniq) {
+                tableClasses.push('numbers-to-right');
+            }
+            result = createElement("table", tableClasses.join(' ') , null, {
                 style: "display: none;"
             });
 

package/src/highcharts_renderer.js

@@ -87,6 +87,10 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         EXCEL_VIEWER: 'excel_viewer',
     };
 
+    highchartsRenderer.VIRTUAL_FIELDS = {
+        WATERFALL_VARIANCE: 'DR_WATERFALL_VARIANCE',
+    };
+
     highchartsRenderer.highcharts_theme = {
         "colors": highchartsRenderer.defaults_colors,
         "chart": {
@@ -1339,15 +1343,11 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         return chart_series;
     }
 
-    highchartsRenderer.ptCreateWaterfallBreakdownSeries = function (pivotData, onlyNumbers, additionOptions, opts) {
+    highchartsRenderer.ptCreateWaterfallBreakdownSeries = function (pivotData, additionOptions, opts) {
         const colorOptions = opts.breakdown_options.colors;
-        var chart_series = [],
-            row_n_keys = pivotData.getRowKeys(),
-            col_n_keys = pivotData.getColKeys();
-
-        if (row_n_keys.length === 0) {
-            row_n_keys.push([]);
-        }
+        const chart_series = [];
+        const row_n_keys = pivotData.getRowKeys();
+        const col_n_keys = pivotData.getColKeys();
 
         let resultObject = {
             data: [],
@@ -1363,61 +1363,48 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
         };
         resultObject = highchartsRenderer.getDataLabelsOptions(additionOptions, resultObject);
 
-        const breakdownValues = [];
         lodash.forEach(col_n_keys, function(col_n_value, col_index) {
-            breakdownValues.push([]);
-            lodash.forEach(row_n_keys, function (row_n_value, row_index) {
-                var agg = pivotData.getAggregator(row_n_value, col_n_value);
-                var val = agg.value();
-
-                if (val != null && $.isNumeric(val)) {
-                    val = parseFloat(val);
-                } else if (onlyNumbers) {
-                    val = NaN;
-                } else {
-                    val = 0;
-                }
 
-                breakdownValues[col_index][row_index] = val;
+            const totalColumnValue = pivotData.getAggregator([], col_n_value).value();
+            const nextTotalColumnKey = col_n_keys[col_index + 1];
+            const nextTotalColumnValue = nextTotalColumnKey ? pivotData.getAggregator([], nextTotalColumnKey).value() : null;
+            resultObject.data.push({
+                y: totalColumnValue,
+                name: lodash.unescape(col_n_value).replace('DR_Others', highchartsRenderer.getOthersName(opts)),
+                isSum: !!col_index,
+                isTotal: true,
+                color: colorOptions.total,
+            });
 
-                if (col_index) {
-                    const value = val - breakdownValues[col_index - 1][row_index];
+            if (col_index !== col_n_keys.length - 1) {
+                lodash.forEach(row_n_keys, function (row_n_value) {
+                    const agg = pivotData.getAggregator(row_n_value, col_n_value);
+                    let val = agg.value();
 
-                    if (value) {
-                        var tmoobj = {};
-                        var key = row_n_value;
-                        if (lodash.isArray(row_n_value)) {
-                            key = row_n_value[0];
-                        }
+                    val = $.isNumeric(val) ? parseFloat(val) : 0;
+                    if (val) {
+                        const tmoobj = {};
+                        const key = lodash.isArray(row_n_value) ? row_n_value[0] : row_n_value;
                         tmoobj.name = lodash.unescape(key);
-        
+
                         if (tmoobj.name) {
                             tmoobj.name = tmoobj.name.replace('DR_Others', highchartsRenderer.getOthersName(opts));
                         }
-        
                         if (lodash.isEmpty(String(tmoobj.name))) {
                             tmoobj.name = lodash.unescape(col_n_value);
                             tmoobj.visible = false;
                         }
-                        tmoobj.y = value;
+
+                        tmoobj.y = val;
                         tmoobj.colKeys = [lodash.unescape(col_n_keys[col_index - 1]), lodash.unescape(col_n_value)];
                         resultObject.data.push(tmoobj);
                     }
-                }
-            });
 
-            const totalValueAgg = pivotData.getAggregator([], col_n_value);
-            resultObject.data.push({
-                y: totalValueAgg.value(),
-                name: lodash.unescape(col_n_value).replace('DR_Others', highchartsRenderer.getOthersName(opts)),
-                isSum: !!col_index,
-                isTotal: true,
-                color: colorOptions.total,
-            });
+                });
+            }
         });
 
         chart_series.push(resultObject);
-
         opts.chart_series = [];
         if (!lodash.isEqual(row_n_keys, EMPTY_ROW_N_KEYS)) {
             chart_series.forEach(series => {
@@ -3191,6 +3178,8 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             ? opts.chartOptions
             : highchartsRenderer.getDefaultValueForChart(highchartsRenderer.CHART_TYPES.WATERFALL_BREAKDOWN);
 
+        pivotData.colKeys = lodash.map(lodash.keys(pivotData.colTotals), key => [key]);
+
         chartOptions.chart = {
             type: 'waterfall',
             zoomType: additionOptions && additionOptions.chart && additionOptions.chart.zoom_type ? additionOptions.chart.zoom_type : 'None',
@@ -3241,7 +3230,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             chartOptions.colors = opts.paletteOptions.dashboardPalette.colors;
         }
         chartOptions.series = highchartsRenderer
-            .ptCreateWaterfallBreakdownSeries(pivotData, null, additionOptions, opts);
+            .ptCreateWaterfallBreakdownSeries(pivotData, additionOptions, opts);
 
         chartOptions = highchartsRenderer.prepareAxisX(chartOptions, additionOptions, pivotData.getColKeys());
         chartOptions.plotOptions = {
@@ -4966,12 +4955,28 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             }
         });
 
+        // add virtual fields to rows if required
+        let rows = widgetOptions.rows;
+        if (!lodash.get(widgetOptions, 'rows.length') && widgetOptions.options.breakdown_options) {
+            rows = [
+                {
+                    id: -1,
+                    name: highchartsRenderer.VIRTUAL_FIELDS.WATERFALL_VARIANCE,
+                    type: 'Text',
+                },
+            ];
+        }
+
         // fill rows fields
-        lodash.forEach(widgetOptions.rows, function (valObj) {
-            fieldOb = lodash.find(fields, {id: valObj.id});
-            if (fieldOb) {
-                legendFields.push(fieldOb);
-                lodash.remove(fields, {id: fieldOb.id});
+        lodash.forEach(rows, function (valObj) {
+            if (lodash.includes(highchartsRenderer.VIRTUAL_FIELDS, valObj.name)) {
+                legendFields.push(valObj);
+            } else {
+                fieldOb = lodash.find(fields, {id: valObj.id});
+                if (fieldOb) {
+                    legendFields.push(fieldOb);
+                    lodash.remove(fields, {id: fieldOb.id});
+                }
             }
         });
 
@@ -7939,7 +7944,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
     };
 
     highchartsRenderer.createDateFromString = function (dateString, format) {
-        if ((format && !highchartsRenderer.isDateFormat(dateString, format)) || !highchartsRenderer.isDate(dateString)) {
+        if (!(format && highchartsRenderer.isDateFormat(dateString, format) || highchartsRenderer.isDate(dateString))) {
             return null;
         }
         const utcDate = format 
@@ -8093,6 +8098,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
                 filter.is_excluded = false;
             } else {
                 filter = highchartsRenderer.createDrillDownFilterObject(widget, widget.cols[0], colKey[0]);
+                filters.push(filter);
             }
             filter.values = [];
             for (let i = 0; i < colKey.length; i++) {
@@ -8695,7 +8701,7 @@ let getHighchartsRenderer = function ($, document, Highcharts, default_colors, h
             rows = [];
         } else {
             rows = cols;
-            cols = [];
+            cols = [point.colKeys[1]];
         }
         return { rows, cols };
     }

package/src/novix_renderer.js

@@ -28,8 +28,6 @@ let initNovixRenderer = function($, window, document, Handsontable){
     const delim = " , ";
     const subtotal = "subtotalDatarailsPlaceholder";
     const replaceValue = "SubTotals";
-    const useNewUx = document.ReportHippo && document.ReportHippo && document.ReportHippo.user &&
-      document.ReportHippo.user.organization.settings && document.ReportHippo.user.organization.settings.use_new_ux;
 
     $.pivotUtilities.novix_renderers = {
 
@@ -889,9 +887,14 @@ let initNovixRenderer = function($, window, document, Handsontable){
 
             // inject the widgetId to the class name so we can separate the tables by it
             // look for the search side on line 653 "opts.$el.find(".widget-id-" + opts.widgetId);"
-            return `<div class='novixPivot widget-id-${opts.widgetId} ${
-              useNewUx && opts.chartOptions.table_options.use_new_table_design ? 'handsontable-new' : ''
-            }' style='overflow:auto'></div>`;
+            var tableClasses = ['novixPivot', `widget-id-${opts.widgetId}`];
+            if (opts.chartOptions.table_options.use_new_table_design) {
+                tableClasses.push('handsontable-new');
+            }
+            if (!pvtData.aggregator().uniq) {
+                tableClasses.push('numbers-to-right');
+            }
+            return `<div class='${tableClasses.join(' ')}' style='overflow:auto'></div>`;
         }
 
     };

package/src/pivot.css

@@ -29,9 +29,6 @@ table.pvtTable tbody tr th > i {
     font-size: 10px;
 }
 
-table.pvtTable .pvtColLabel {text-align: center;}
-table.pvtTable .pvtTotalLabel {text-align: right;}
-
 table.pvtTable tbody tr td {
     color: #3D3D3D;
     padding: 5px;
@@ -263,11 +260,6 @@ table.pvtTable.newPvtTable tbody tr td.rowTotal {
   background-color: #dfe6ec !important;
   border-color: #ffffff !important;
 }
-table.pvtTable.newPvtTable .pvtColLabel,
-table.pvtTable.newPvtTable .pvtTotalLabel,
-table.pvtTable.newPvtTable .pvtTotalLabel.rowTotal {
-  text-align: left;
-}
 
 table.pvtTable.newPvtTable tbody tr th .fa {
   padding: 2px;
@@ -408,3 +400,27 @@ table.pvtTable.newPvtTable tbody tr td:hover:after {
   top: 4px;
   font-size: 12px;
 }
+
+
+/* Table cells alignment */
+table.pvtTable .pvtColLabel {text-align: center;}
+table.pvtTable .pvtTotalLabel {text-align: right;}
+
+table.pvtTable.newPvtTable .pvtColLabel,
+table.pvtTable.newPvtTable .pvtTotalLabel,
+table.pvtTable.newPvtTable .pvtTotalLabel.rowTotal {
+    text-align: left;
+}
+
+table.pvtTable thead tr th.pvtColLabel,
+table.pvtTable thead tr th.pvtTotalLabel  {
+    text-align: center !important;
+}
+
+table.pvtTable.numbers-to-right tbody tr td.pvtVal,
+table.pvtTable.numbers-to-right tbody tr td.rowTotal.rowTotal,
+table.pvtTable.numbers-to-right tbody tr td.pvtGrandTotal  {
+    text-align: right !important;
+    padding-right: 9px;
+    line-height: 15px;
+}