@datagrok/sequence-translator 0.0.8 → 1.0.0

package/jest.config.js

@@ -0,0 +1,33 @@
+module.exports = {
+  "roots": [
+    "<rootDir>/src"
+  ],
+  "testMatch": [
+    "**/__jest__/**/*.test.+(ts|tsx)"
+  ],
+  moduleFileExtensions: [
+    'ts',
+    'js',
+  ],
+  "transform": {
+    "^.+\\.(ts|tsx)$": "ts-jest"
+  },
+  transformIgnorePatterns: ['^.+\\.js$'],
+  globals: {
+    'ts-jest': {
+      'tsconfig': {
+          "target": "es6",
+          "module": "es2020",
+      }
+    }
+  },
+  reporters: [
+    "default",
+    [
+      "./node_modules/jest-html-reporter",
+      {
+        "includeConsoleLog": true
+      }
+    ]
+  ]
+}

package/package.json

@@ -1,14 +1,19 @@
 {
   "name": "@datagrok/sequence-translator",
-  "friendlyName": "SequenceTranslator",
-  "version": "0.0.8",
-  "description": "",
+  "friendlyName": "Sequence Translator",
+  "version": "1.0.0",
+  "description": "SequenceTranslator is a [package](https://datagrok.ai/help/develop/develop#packages) for the [Datagrok](https://datagrok.ai) platform, used to translate [oligonucleotide](https://en.wikipedia.org/wiki/Oligonucleotide) sequences between [different representations](https://github.com/datagrok-ai/public/tree/master/packages/SequenceTranslator#sequence-representations).",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/datagrok-ai/public.git",
+    "directory": "packages/SequenceTranslator"
+  },
   "dependencies": {
     "@datagrok-libraries/utils": "^0.1.0",
     "@types/react": "latest",
-    "datagrok-api": ">0.94.10",
+    "datagrok-api": "^1.1.7",
     "datagrok-tools": "^4.1.2",
-    "npm": "^7.11.2",
+    "npm": "^8.11.0",
     "save-svg-as-png": "^1.4.17",
     "ts-loader": "latest",
     "typescript": "latest",
@@ -23,8 +28,14 @@
     "debug-sequencetranslator-public": "grok publish public --rebuild",
     "release-sequencetranslator-public": "grok publish public --rebuild --release",
     "debug-sequencetranslator-local": "grok publish local --rebuild",
-    "release-sequencetranslator-local": "grok publish local --rebuild --release"
+    "release-sequencetranslator-local": "grok publish local --rebuild --release",
+    "test": "set HOST=dev && jest",
+    "test-dev": "set HOST=dev && jest",
+    "test-local": "set HOST=localhost && jest"
   },
+  "sources": [
+    "css/style.css"
+  ],
   "devDependencies": {
     "@typescript-eslint/eslint-plugin": "^4.29.1",
     "@typescript-eslint/parser": "^4.29.1",
@@ -32,6 +43,12 @@
     "eslint": "^7.32.0",
     "eslint-config-google": "^0.14.0",
     "webpack": "^5.31.0",
-    "webpack-cli": "^4.6.0"
-  }
+    "webpack-cli": "^4.6.0",
+    "jest-html-reporter": "^3.5.0",
+    "jest": "^27.0.0",
+    "@types/jest": "^27.0.0",
+    "ts-jest": "^27.0.0",
+    "puppeteer": "^13.7.0"
+  },
+  "category": "Bioinformatics"
 }

package/setup.cmd

@@ -8,4 +8,4 @@ call npm link datagrok-api
 cd ../../packages/SequenceTranslator
 call npm install
 call npm link datagrok-api @datagrok-libraries/utils
-webpack
+webpack

package/src/ICDs.ts

@@ -0,0 +1,3 @@
+export const ICDS = `DISPLAY
+NO DATA
+`;

package/src/IDPs.ts

@@ -0,0 +1,3 @@
+export const IDPS = `DISPLAY
+NO DATA
+`;

package/src/__jest__/remote.test.ts

@@ -0,0 +1,49 @@
+/**
+ * @jest-environment jsdom
+ */
+
+import * as utils from './test-node';
+import puppeteer from 'puppeteer';
+
+const P_START_TIMEOUT: number = 100000;
+let browser: puppeteer.Browser;
+let page: puppeteer.Page;
+
+beforeAll(async () => {
+  let out = await utils.getBrowserPage(puppeteer);
+  browser = out.browser;
+  page = out.page;
+}, P_START_TIMEOUT);
+
+afterAll(async () => {
+  await browser.close();
+});
+
+it('TEST', async () => {
+  const target_package:string = process.env.TARGET_PACKAGE ?? 'SequenceTranslator';
+  console.log(`Testing ${target_package} package`);
+
+  //console.log(require('root-require')('package.json').version);
+  let r = await page.evaluate((target_package):Promise<object> => {
+    return new Promise<object>((resolve, reject) => {
+      (<any>window).grok.functions.eval(target_package + ':test()').then((df: any) => {
+        let cStatus = df.columns.byName('success');
+        let cMessage = df.columns.byName('result');
+        let cCat = df.columns.byName('category');
+        let cName = df.columns.byName('name');
+        let failed = false;
+        let report = '';
+        for (let i = 0; i < df.rowCount; i++)
+          if (!cStatus.get(i)) {
+            report += `${cCat.get(i)}.${cName.get(i)}: ${cMessage.get(i)}\n`;
+            failed = true;
+          }
+        resolve({report, failed});
+      }).catch((e: any) => reject(e));
+    });
+  }, target_package);
+  // @ts-ignore
+  console.log(r.report);
+  // @ts-ignore
+  expect(r.failed).toBe(false);
+}, 100000);

package/src/__jest__/test-node.ts

@@ -0,0 +1,96 @@
+import * as path from "path";
+import * as os from "os";
+import * as fs from "fs";
+// @ts-ignore
+import * as yaml from 'js-yaml';
+const fetch = require('node-fetch');
+
+export async function getToken(url: string, key: string) {
+  let response = await fetch(`${url}/users/login/dev/${key}`, {method: 'POST'});
+  let json = await response.json();
+  if (json.isSuccess == true)
+    return json.token;
+  else
+    throw 'Unable to login to server. Check your dev key';
+}
+
+export async function getWebUrl(url: string, token: string) {
+  let response = await fetch(`${url}/admin/plugins/admin/settings`, {headers: {Authorization: token}});
+  let json = await response.json();
+  return json.settings.webRoot;
+}
+
+const grokDir = path.join(os.homedir(), '.grok');
+const confPath = path.join(grokDir, 'config.yaml');
+
+function mapURL(conf: Config): Indexable {
+  let urls: Indexable = {};
+  for (let server in conf.servers) {
+    urls[conf['servers'][server]['url']] = conf['servers'][server];
+  }
+  return urls;
+}
+
+export function getDevKey(hostKey: string): {url: string, key: string} {
+  let config = yaml.load(fs.readFileSync(confPath, 'utf8')) as any;
+  let host = hostKey == '' ? config.default : hostKey;
+  host = host.trim();
+  let urls = mapURL(config);
+  let key = '';
+  let url = '';
+  try {
+    let url = new URL(host).href;
+    if (url.endsWith('/')) url = url.slice(0, -1);
+    if (url in urls) key = config['servers'][urls[url]]['key'];
+  } catch (error) {
+    if (config['servers'][host] == null)
+      throw `Unknown server alias. Please add it to ${confPath}`;
+    url = config['servers'][host]['url'];
+    key = config['servers'][host]['key'];
+  }
+  return {url, key};
+}
+
+export async function getBrowserPage(puppeteer: any): Promise<{browser: any, page: any}> {
+  let url:string = process.env.HOST ?? '';
+  let cfg = getDevKey(url);
+  url = cfg.url;
+
+  let key = cfg.key;
+  let token = await getToken(url, key);
+  url = await getWebUrl(url, token);
+  console.log(`Using web root: ${url}`);
+
+  let browser = await puppeteer.launch({
+    args: ['--disable-dev-shm-usage', '--disable-features=site-per-process'],
+    ignoreHTTPSErrors: true,
+  });
+
+  let page = await browser.newPage();
+  await page.goto(`${url}/oauth/`);
+  await page.setCookie({name: 'auth', value: token});
+  await page.evaluate((token: any) => {
+    window.localStorage.setItem('auth', token);
+  }, token);
+  await page.goto(url);
+  try {
+    await page.waitForSelector('.grok-preloader');
+    await page.waitForFunction(() => document.querySelector('.grok-preloader') == null, {timeout: 100000});
+  } catch (error) {
+    throw error;
+  }
+  return {browser, page};
+}
+
+
+interface Config {
+  servers: {
+    [alias: string]: {
+      url: string,
+      key: string
+    }
+  },
+  default: string,
+}
+
+interface Indexable { [key: string]: any }

package/src/defineAxolabsPattern.ts

@@ -114,7 +114,7 @@ export function defineAxolabsPattern() {
     asPtoLinkages = asPtoLinkages.concat(Array(maximalAsLength - asBases.length).fill(fullyPto));
     asBases = asBases.concat(Array(maximalAsLength - asBases.length).fill(sequenceBase));
     let nucleotideCounter = 0;
-    for (let i = 0; i < asLength.value; i++) {
+    for (let i = 0; i < asLength.value!; i++) {
       asPtoLinkages[i] = ui.boolInput('', asPtoLinkages[i].value, () => {
         updateSvgScheme();
         updateOutputExamples();
@@ -157,7 +157,7 @@ export function defineAxolabsPattern() {
     ssPtoLinkages = ssPtoLinkages.concat(Array(maximalSsLength - ssBases.length).fill(fullyPto));
     ssBases = ssBases.concat(Array(maximalSsLength - ssBases.length).fill(sequenceBase));
     let nucleotideCounter = 0;
-    for (let i = 0; i < ssLength.value; i++) {
+    for (let i = 0; i < ssLength.value!; i++) {
       ssPtoLinkages[i] = ui.boolInput('', ssPtoLinkages[i].value, () => {
         updateSvgScheme();
         updateOutputExamples();
@@ -196,11 +196,11 @@ export function defineAxolabsPattern() {
   }
 
   function updateUiForNewSequenceLength() {
-    if (ssLength.value < maximalValidSequenceLength && asLength.value < maximalValidSequenceLength) {
-      if (ssLength.value > maximalSsLength)
-        maximalSsLength = ssLength.value;
-      if (asLength.value > maximalAsLength)
-        maximalAsLength = asLength.value;
+    if (ssLength.value! < maximalValidSequenceLength && asLength.value! < maximalValidSequenceLength) {
+      if (ssLength.value! > maximalSsLength)
+        maximalSsLength = ssLength.value!;
+      if (asLength.value! > maximalAsLength)
+        maximalAsLength = asLength.value!;
       updateSsModification();
       updateAsModification();
       updateSvgScheme();
@@ -236,17 +236,17 @@ export function defineAxolabsPattern() {
   }
 
   function updateInputExamples() {
-    ssInputExample.value = generateExample(ssLength.value, sequenceBase.value);
+    ssInputExample.value = generateExample(ssLength.value!, sequenceBase.value!);
     if (createAsStrand.value)
-      asInputExample.value = generateExample(asLength.value, sequenceBase.value);
+      asInputExample.value = generateExample(asLength.value!, sequenceBase.value!);
   }
 
   function updateOutputExamples() {
     ssOutputExample.value = translateSequence(
-      ssInputExample.value, ssBases, ssPtoLinkages, ssFiveModification, ssThreeModification, firstSsPto.value);
+      ssInputExample.value, ssBases, ssPtoLinkages, ssFiveModification, ssThreeModification, firstSsPto.value!);
     if (createAsStrand.value) {
       asOutputExample.value = translateSequence(
-        asInputExample.value, asBases, asPtoLinkages, asFiveModification, asThreeModification, firstAsPto.value);
+        asInputExample.value, asBases, asPtoLinkages, asFiveModification, asThreeModification, firstAsPto.value!);
     }
   }
 
@@ -256,11 +256,11 @@ export function defineAxolabsPattern() {
       ui.span([
         drawAxolabsPattern(
           getShortName(saveAs.value),
-          createAsStrand.value,
-          ssBases.slice(0, ssLength.value).map((e) => e.value),
-          asBases.slice(0, asLength.value).map((e) => e.value),
-          [firstSsPto.value].concat(ssPtoLinkages.slice(0, ssLength.value).map((e) => e.value)),
-          [firstAsPto.value].concat(asPtoLinkages.slice(0, asLength.value).map((e) => e.value)),
+          createAsStrand.value!,
+          ssBases.slice(0, ssLength.value!).map((e) => e.value),
+          asBases.slice(0, asLength.value!).map((e) => e.value),
+          [firstSsPto.value!].concat(ssPtoLinkages.slice(0, ssLength.value!).map((e) => e.value)),
+          [firstAsPto.value!].concat(asPtoLinkages.slice(0, asLength.value!).map((e) => e.value)),
           ssThreeModification.value,
           ssFiveModification.value,
           asThreeModification.value,
@@ -329,7 +329,7 @@ export function defineAxolabsPattern() {
   }
 
   function checkWhetherAllValuesInColumnHaveTheSameLength(colName: string): boolean {
-    const col = tables.value.columns.byName(colName);
+    const col = tables.value!.columns.byName(colName);
     let allLengthsAreTheSame = true;
     for (let i = 1; i < col.length; i++) {
       if (col.get(i - 1).length != col.get(i).length) {
@@ -344,10 +344,10 @@ export function defineAxolabsPattern() {
         .add(ui.divText('The sequence length should match the number of Raw sequences in the input file'))
         .add(ui.divText('\'ADD COLUMN\' to see sequences lengths'))
         .addButton('ADD COLUMN', () => {
-          tables.value.columns.addNewInt('Sequences lengths in ' + colName).init((j: number) => col.get(j).length);
-          grok.shell.info('Column with lengths added to \'' + tables.value.name + '\'');
+          tables.value!.columns.addNewInt('Sequences lengths in ' + colName).init((j: number) => col.get(j).length);
+          grok.shell.info('Column with lengths added to \'' + tables.value!.name + '\'');
           dialog.close();
-          grok.shell.v = grok.shell.getTableView(tables.value.name);
+          grok.shell.v = grok.shell.getTableView(tables.value!.name);
         })
         .show();
     }
@@ -368,10 +368,10 @@ export function defineAxolabsPattern() {
       userStorageKey,
       saveAs.stringValue,
       JSON.stringify({
-        'ssBases': ssBases.slice(0, ssLength.value).map((e) => e.value),
-        'asBases': asBases.slice(0, asLength.value).map((e) => e.value),
-        'ssPtoLinkages': [firstSsPto.value].concat(ssPtoLinkages.slice(0, ssLength.value).map((e) => e.value)),
-        'asPtoLinkages': [firstAsPto.value].concat(asPtoLinkages.slice(0, asLength.value).map((e) => e.value)),
+        'ssBases': ssBases.slice(0, ssLength.value!).map((e) => e.value),
+        'asBases': asBases.slice(0, asLength.value!).map((e) => e.value),
+        'ssPtoLinkages': [firstSsPto.value].concat(ssPtoLinkages.slice(0, ssLength.value!).map((e) => e.value)),
+        'asPtoLinkages': [firstAsPto.value].concat(asPtoLinkages.slice(0, asLength.value!).map((e) => e.value)),
         'ssThreeModification': ssThreeModification.value,
         'ssFiveModification': ssFiveModification.value,
         'asThreeModification': asThreeModification.value,
@@ -506,24 +506,24 @@ export function defineAxolabsPattern() {
 
   function validateSsColumn(colName: string) {
     const allLengthsAreTheSame: boolean = checkWhetherAllValuesInColumnHaveTheSameLength(colName);
-    const firstSequence = tables.value.columns.byName(colName).get(0);
+    const firstSequence = tables.value!.columns.byName(colName).get(0);
     if (allLengthsAreTheSame && firstSequence.length != ssLength.value)
-      ssLength.value = tables.value.columns.byName(colName).get(0).length;
+      ssLength.value = tables.value!.columns.byName(colName).get(0).length;
     ssInputExample.value = firstSequence;
   }
 
   function validateAsColumn(colName: string) {
     const allLengthsAreTheSame: boolean = checkWhetherAllValuesInColumnHaveTheSameLength(colName);
-    const firstSequence = tables.value.columns.byName(colName).get(0);
+    const firstSequence = tables.value!.columns.byName(colName).get(0);
     if (allLengthsAreTheSame && firstSequence.length != asLength.value)
-      asLength.value = tables.value.columns.byName(colName).get(0).length;
+      asLength.value = tables.value!.columns.byName(colName).get(0).length;
     asLengthDiv.innerHTML = '';
     asLengthDiv.append(asLength.root);
     asInputExample.value = firstSequence;
   }
 
   function validateIdsColumn(colName: string) {
-    const col = tables.value.columns.byName(colName);
+    const col = tables.value!.columns.byName(colName);
     if (col.type != DG.TYPE.INT)
       grok.shell.error('Column should contain integers only');
     else if (col.categories.length < col.length) {
@@ -531,32 +531,35 @@ export function defineAxolabsPattern() {
       ui.dialog('Non-unique IDs')
         .add(ui.divText('Press \'OK\' to select rows with non-unique values'))
         .onOK(() => {
-          const selection = tables.value.selection;
+          const selection = tables.value!.selection;
           selection.init((i: number) => duplicates.indexOf(col.get(i)) > -1);
-          grok.shell.v = grok.shell.getTableView(tables.value.name);
-          grok.shell.info('Rows are selected in table \'' + tables.value.name + '\'');
+          grok.shell.v = grok.shell.getTableView(tables.value!.name);
+          grok.shell.info('Rows are selected in table \'' + tables.value!.name + '\'');
         })
         .show();
     }
   }
 
   const tables = ui.tableInput('Tables', grok.shell.tables[0], grok.shell.tables, (t: DG.DataFrame) => {
-    inputSsColumn = ui.choiceInput('SS Column', '', t.columns.names(), (colName: string) => validateSsColumn(colName));
+    const inputSsColumn =
+      ui.choiceInput('SS Column', '', t.columns.names(), (colName: string) => validateSsColumn(colName));
     inputSsColumnDiv.innerHTML = '';
     inputSsColumnDiv.append(inputSsColumn.root);
-    inputAsColumn = ui.choiceInput('AS Column', '', t.columns.names(), (colName: string) => validateAsColumn(colName));
+    const inputAsColumn =
+      ui.choiceInput('AS Column', '', t.columns.names(), (colName: string) => validateAsColumn(colName));
     inputAsColumnDiv.innerHTML = '';
     inputAsColumnDiv.append(inputAsColumn.root);
-    inputIdColumn = ui.choiceInput('ID Column', '', t.columns.names(), (colName: string) => validateIdsColumn(colName));
+    const inputIdColumn =
+      ui.choiceInput('ID Column', '', t.columns.names(), (colName: string) => validateIdsColumn(colName));
     inputIdColumnDiv.innerHTML = '';
     inputIdColumnDiv.append(inputIdColumn.root);
   });
 
-  let inputSsColumn = ui.choiceInput('SS Column', '', []);
+  const inputSsColumn = ui.choiceInput('SS Column', '', []);
   inputSsColumnDiv.append(inputSsColumn.root);
-  let inputAsColumn = ui.choiceInput('AS Column', '', []);
+  const inputAsColumn = ui.choiceInput('AS Column', '', []);
   inputAsColumnDiv.append(inputAsColumn.root);
-  let inputIdColumn = ui.choiceInput('ID Column', '', []);
+  const inputIdColumn = ui.choiceInput('ID Column', '', []);
   inputIdColumnDiv.append(inputIdColumn.root);
 
   updatePatternsList();
@@ -573,8 +576,8 @@ export function defineAxolabsPattern() {
     updateOutputExamples();
   });
 
-  const firstSsPto = ui.boolInput('First SS PTO', fullyPto.value, () => updateSvgScheme());
-  const firstAsPto = ui.boolInput('First AS PTO', fullyPto.value, () => updateSvgScheme());
+  const firstSsPto = ui.boolInput('First SS PTO', fullyPto.value!, () => updateSvgScheme());
+  const firstAsPto = ui.boolInput('First AS PTO', fullyPto.value!, () => updateSvgScheme());
   firstAsPtoDiv.append(firstAsPto.root);
 
   const createAsStrand = ui.boolInput('Create AS Strand', true, (v: boolean) => {
@@ -643,34 +646,34 @@ export function defineAxolabsPattern() {
       dialog
         .add(ui.divText('Length of sequences in columns doesn\'t match entered length. Update length value?'))
         .addButton('YES', () => {
-          ssLength.value = tables.value.columns.byName(inputSsColumn.value).getString(0).length;
-          asLength.value = tables.value.columns.byName(inputAsColumn.value).getString(0).length;
+          ssLength.value = tables.value!.columns.byName(inputSsColumn.value!).getString(0).length;
+          asLength.value = tables.value!.columns.byName(inputAsColumn.value!).getString(0).length;
           dialog.close();
         })
         .show();
     } else {
       if (inputIdColumn.value != null)
-        addColumnWithIds(tables.value.name, inputIdColumn.value, getShortName(saveAs.value));
+        addColumnWithIds(tables.value!.name, inputIdColumn.value, getShortName(saveAs.value));
       addColumnWithTranslatedSequences(
-        tables.value.name, inputSsColumn.value, ssBases, ssPtoLinkages,
-        ssFiveModification, ssThreeModification, firstSsPto.value);
+        tables.value!.name, inputSsColumn.value, ssBases, ssPtoLinkages,
+        ssFiveModification, ssThreeModification, firstSsPto.value!);
       if (createAsStrand.value) {
         addColumnWithTranslatedSequences(
-          tables.value.name, inputAsColumn.value, asBases, asPtoLinkages,
-          asFiveModification, asThreeModification, firstAsPto.value);
+          tables.value!.name, inputAsColumn.value!, asBases, asPtoLinkages,
+          asFiveModification, asThreeModification, firstAsPto.value!);
       }
-      grok.shell.v = grok.shell.getTableView(tables.value.name);
+      grok.shell.v = grok.shell.getTableView(tables.value!.name);
       grok.shell.info(((createAsStrand.value) ? 'Columns were' : 'Column was') +
-      ' added to table \'' + tables.value.name + '\'');
+      ' added to table \'' + tables.value!.name + '\'');
     }
   });
 
-  const ssInputExample = ui.textInput('Sense Strand', generateExample(ssLength.value, sequenceBase.value), () => {
+  const ssInputExample = ui.textInput('Sense Strand', generateExample(ssLength.value!, sequenceBase.value!), () => {
     ssOutputExample.value = translateSequence(ssInputExample.value, ssBases, ssPtoLinkages,
-      ssFiveModification, ssThreeModification, firstSsPto.value);
+      ssFiveModification, ssThreeModification, firstSsPto.value!);
   });
   const ssOutputExample = ui.textInput(' ', translateSequence(
-    ssInputExample.value, ssBases, ssPtoLinkages, ssThreeModification, ssFiveModification, firstSsPto.value));
+    ssInputExample.value, ssBases, ssPtoLinkages, ssThreeModification, ssFiveModification, firstSsPto.value!));
   (ssInputExample.input as HTMLElement).style.resize = 'none';
   (ssInputExample.input as HTMLElement).style.minWidth = exampleMinWidth;
   (ssOutputExample.input as HTMLElement).style.resize = 'none';
@@ -686,12 +689,12 @@ export function defineAxolabsPattern() {
     ], 'ui-input-options'),
   );
 
-  const asInputExample = ui.textInput('Antisense Strand', generateExample(asLength.value, sequenceBase.value), () => {
+  const asInputExample = ui.textInput('Antisense Strand', generateExample(asLength.value!, sequenceBase.value!), () => {
     asOutputExample.value = translateSequence(
-      asInputExample.value, asBases, asPtoLinkages, asFiveModification, asThreeModification, firstSsPto.value);
+      asInputExample.value, asBases, asPtoLinkages, asFiveModification, asThreeModification, firstSsPto.value!);
   });
   const asOutputExample = ui.textInput(' ', translateSequence(
-    asInputExample.value, asBases, asPtoLinkages, asFiveModification, asThreeModification, firstSsPto.value));
+    asInputExample.value, asBases, asPtoLinkages, asFiveModification, asThreeModification, firstSsPto.value!));
   (asInputExample.input as HTMLElement).style.resize = 'none';
   (asInputExample.input as HTMLElement).style.minWidth = exampleMinWidth;
   (asOutputExample.input as HTMLElement).style.resize = 'none';

package/src/package-test.ts

@@ -1,8 +1,9 @@
 import * as DG from 'datagrok-api/dg';
-import {runTests} from '@datagrok-libraries/utils/src/test';
+import {runTests, tests} from '@datagrok-libraries/utils/src/test';
 import './tests/smiles-tests';
 
 export const _package = new DG.Package();
+export {tests};
 
 //name: test
 //output: dataframe result