@datagrok/eda 1.1.12 → 1.1.13

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@datagrok/eda",
   "friendlyName": "EDA",
-  "version": "1.1.12",
+  "version": "1.1.13",
   "description": "Exploratory Data Analysis Tools",
   "dependencies": {
     "@datagrok-libraries/ml": "^6.4.5",

package/src/eda-ui.ts

@@ -117,7 +117,7 @@ export function loadingScatterPlot(features: DG.ColumnList, xLoadings: Array<DG.
 export function addPLSvisualization(
   table: DG.DataFrame, samplesNames: DG.Column, features: DG.ColumnList, predict: DG.Column, plsOutput: any,
 ): void {
-  const view = grok.shell.getTableView(table.name);
+  const view = (table.id !== null) ? grok.shell.getTableView(table.name) : grok.shell.addTableView(table);
 
   // 1. Predicted vs Reference scatter plot
   view.addViewer(predictedVersusReferenceScatterPlot(samplesNames, predict, plsOutput[0]));

package/src/package.ts

@@ -67,12 +67,20 @@ export async function dbScan(df: DG.DataFrame, xCol: DG.Column, yCol: DG.Column,
 //input: int components = 2 {caption: Components} [Number of components.]
 //input: bool center = false [Indicating whether the variables should be shifted to be zero centered.]
 //input: bool scale = false [Indicating whether the variables should be scaled to have unit variance.]
-//output: dataframe result {action:join(table)}
-export async function PCA(table: DG.DataFrame, features: DG.ColumnList, components: number,
-  center: boolean, scale: boolean): Promise<DG.DataFrame> {
+export async function PCA(table: DG.DataFrame, features: DG.ColumnList, components: number, center: boolean, scale: boolean): Promise<void> {
   const pcaTable = await computePCA(table, features, components, center, scale);
   addPrefixToEachColumnName('PCA', pcaTable.columns);
-  return pcaTable;
+
+  if (table.id === null) // table is loaded from a local file
+    grok.shell.addTableView(pcaTable);
+  else {
+    const cols = table.columns;
+
+    for (const col of pcaTable.columns) {
+      col.name = cols.getUnusedName(col.name);
+      cols.add(col);
+    }
+  }
 }