@datagouv/components-next 1.0.2-dev.222 → 1.0.2-dev.223

package/dist/{vue3-xml-viewer.common-Dux7EzjM.js → vue3-xml-viewer.common-DCzadi-B.js}

@@ -1,4 +1,4 @@
-import { g as Ke } from "./main-DAxkqaSe.js";
+import { g as Ke } from "./main-BzR7HPLe.js";
 import We from "vue";
 function Fe(I, K) {
   for (var V = 0; V < K.length; V++) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@datagouv/components-next",
-  "version": "1.0.2-dev.222",
+  "version": "1.0.2-dev.223",
   "private": false,
   "type": "module",
   "engines": {

package/src/components/ResourceAccordion/EditButton.vue

@@ -4,8 +4,7 @@
     icon-only
     :icon="RiPencilLine"
     color="warning"
-    :disabled="!!disabledReason"
-    :title="disabledReason ?? t('Éditer le fichier')"
+    :title="t('Éditer le fichier')"
     data-testid="edit-button"
   />
 </template>
@@ -20,12 +19,10 @@ type Props = {
   datasetId: string
   isCommunityResource?: boolean
   resourceId: string
-  disabledReason?: string | null
 }
 
 const props = withDefaults(defineProps<Props>(), {
   isCommunityResource: false,
-  disabledReason: null,
 })
 
 const { t } = useTranslation()

package/src/components/ResourceAccordion/ResourceAccordion.vue

@@ -173,7 +173,6 @@
             :dataset-id="dataset.id"
             :resource-id="resource.id"
             :is-community-resource="isCommunityResource"
-            :disabled-reason="editDisabledReason"
             size="xs"
           />
         </p>
@@ -328,7 +327,7 @@ import { trackEvent } from '../../functions/matomo'
 import CopyButton from '../CopyButton.vue'
 import { useComponentsConfig } from '../../config'
 import { getOwnerName } from '../../functions/owned'
-import { getResourceFormatIcon, getResourceTitleId, detectOgcService, getResourceFilesize, isGeopfSynced, isImagePreviewFormat, resolveResourceExternalUrl } from '../../functions/resources'
+import { getResourceFormatIcon, getResourceTitleId, detectOgcService, getResourceFilesize, isImagePreviewFormat, resolveResourceExternalUrl } from '../../functions/resources'
 import BrandedButton from '../BrandedButton.vue'
 import { useTranslation } from '../../composables/useTranslation'
 import { useHasTabularData } from '../../composables/useHasTabularData'
@@ -385,10 +384,6 @@ const hasPmtiles = computed(() => {
   return props.resource.extras['analysis:parsing:pmtiles_url'] || props.resource.format === 'pmtiles'
 })
 
-const editDisabledReason = computed(() => {
-  return isGeopfSynced(props.resource) ? t('Vous ne pouvez pas modifier cette ressource car elle est synchronisée avec cartes.gouv.fr') : null
-})
-
 const hasDatafairPreview = computed(() => {
   // Checks if there are the corresponding extras for a datafair preview.
   // Limited only to datasets published by certified organizations since it will load an iframe.

package/src/components/TabularExplorer/TabularCellPopover.vue

@@ -80,7 +80,7 @@ import {
 } from '@remixicon/vue'
 import { toast } from 'vue-sonner'
 import { useTranslation } from '../../composables/useTranslation'
-import { buildTypeConfig, toIsoDay } from '../../functions/tabular'
+import { buildCellValueFilter, buildTypeConfig } from '../../functions/tabular'
 import ClientOnly from '../ClientOnly.vue'
 import type { ColumnType, ColumnFilters } from './types'
 
@@ -128,36 +128,10 @@ function close() {
 
 function filterByValue() {
   if (!cell.value) return
-  const val = String(cell.value.value ?? '')
   const col = cell.value.column
-  const existing = filters.value[col] ?? {}
-  // A date goes through the same `date` filter the column panel writes, so the
-  // calendar opens on the day that was clicked instead of on an empty month.
-  if (cell.value.columnType === 'date') {
-    const day = toIsoDay(cell.value.value)
-    if (day) {
-      filters.value = { ...filters.value, [col]: { ...existing, date: { operator: 'is', start: day } } }
-    }
-    // An empty cell has no day to select: filtering on the missing values is
-    // what "this value" means there, and the panel shows it as such.
-    else if (cell.value.value == null || cell.value.value === '') {
-      filters.value = { ...filters.value, [col]: { ...existing, null: 'only' } }
-    }
-  }
-  else if (cell.value.columnType === 'categorical' || cell.value.columnType === 'text' || cell.value.columnType === 'year') {
-    const current = existing.in ?? []
-    if (!current.includes(val)) {
-      filters.value = { ...filters.value, [col]: { ...existing, in: [...current, val] } }
-    }
-  }
-  else if (cell.value.columnType === 'number') {
-    const num = Number(cell.value.value)
-    if (Number.isFinite(num)) {
-      filters.value = { ...filters.value, [col]: { ...existing, min: num, max: num } }
-    }
-  }
-  else if (cell.value.columnType === 'boolean') {
-    filters.value = { ...filters.value, [col]: { ...existing, exact: val } }
+  filters.value = {
+    ...filters.value,
+    [col]: buildCellValueFilter(cell.value.columnType, cell.value.value, filters.value[col] ?? {}),
   }
   close()
 }

package/src/functions/charts.ts

@@ -1,9 +1,9 @@
-import type { Chart, ChartForm, ChartForApi, Filter, ColumnDefinition } from '../types/visualizations'
+import type { Chart, ChartForm, ChartForApi, GenericFilter, ColumnDefinition } from '../types/visualizations'
 import type { ColumnType, TabularProfile } from '../components/TabularExplorer/types'
 import { resolveColumnType } from './tabular'
 
 export function toChartForm(chart: Chart) {
-  const seriesFilter = chart.series[0]?.filters as Filter | null
+  const seriesFilter: GenericFilter | null = chart.series[0]?.filters ?? null
 
   return {
     title: chart.title,

package/src/functions/resources.ts

@@ -179,10 +179,6 @@ export function getResourceExternalUrl(dataset: Dataset | DatasetV2 | Omit<Datas
   return `${dataset.page}${isCommunityResource(resource) ? '/community-resources' : ''}?resource_id=${resource.id}`
 }
 
-export function isGeopfSynced(resource: Resource | CommunityResource): boolean {
-  return resource.geopf?.push_status != null || typeof resource.geopf?.offering_id === 'string'
-}
-
 export function resolveResourceExternalUrl<R extends Resource | CommunityResource>(
   dataset: Dataset | DatasetV2 | Omit<Dataset, 'resources' | 'community_resources'>,
   resource: R,

package/src/functions/tabular.ts

@@ -93,6 +93,39 @@ export function buildDateFilterParams(column: string, filter: DateFilter): Recor
   return params
 }
 
+/**
+ * The filter "filter by this value" sets on a column for the cell that was
+ * clicked, merged into the filters already set on that column.
+ *
+ * An empty cell holds no value to match on: whatever the column type, filtering
+ * on the missing values is what "this value" means there — and it is the filter
+ * the column panel offers for them.
+ */
+export function buildCellValueFilter(columnType: ColumnType, value: unknown, existing: ColumnFilters): ColumnFilters {
+  if (value == null || value === '') return { ...existing, null: 'only' }
+  switch (columnType) {
+    // A date goes through the same `date` filter the column panel writes, so the
+    // calendar opens on the day that was clicked instead of on an empty month.
+    case 'date': {
+      const day = toIsoDay(value)
+      return day ? { ...existing, date: { operator: 'is', start: day } } : existing
+    }
+    case 'number': {
+      const num = Number(value)
+      return Number.isFinite(num) ? { ...existing, min: num, max: num } : existing
+    }
+    case 'boolean':
+      return { ...existing, exact: String(value) }
+    case 'categorical':
+    case 'text':
+    case 'year': {
+      const val = String(value)
+      const selected = existing.in ?? []
+      return selected.includes(val) ? existing : { ...existing, in: [...selected, val] }
+    }
+  }
+}
+
 export type TypeDisplay = {
   icon: Component
   label: string
@@ -224,15 +257,16 @@ const FALSY_VALUES = ['false', '0', 'non', 'no']
 
 // `encodeURIComponent` leaves `.`, `(` and `)` as-is, but they are the operator
 // separator and the delimiters of the API's `or(...)` grammar: a search value
-// containing one makes the parser reject the whole query with a 400. Wrapping
-// the value in double quotes (as the API README suggests) does not work here —
-// the API keeps them as part of the searched string and returns no result. It
-// does percent-decode the value after parsing, so encoding them is enough.
-function encodeConditionValue(value: string): string {
+// containing one makes the parser reject the whole query with a 400.
+// The API percent-decodes the query string once before running the grammar
+// parser, then percent-decodes the parsed value: grammar-significant characters
+// must therefore be sent double-encoded (`%252E`) so the first decode leaves
+// them escaped (`%2E`) for the parser to unquote after parsing.
+export function encodeConditionValue(value: string): string {
   return encodeURIComponent(value)
-    .replace(/\./g, '%2E')
-    .replace(/\(/g, '%28')
-    .replace(/\)/g, '%29')
+    .replace(/\./g, '%252E')
+    .replace(/\(/g, '%2528')
+    .replace(/\)/g, '%2529')
 }
 
 // A decimal literal, not `Number()`: the API compares against a number column,

package/src/functions/tabularApi.ts

@@ -1,6 +1,7 @@
 import { ofetch } from 'ofetch'
 import { useComponentsConfig, type PluginConfig } from '../config'
-import type { GenericFilter } from '../types/visualizations'
+import { encodeConditionValue } from './tabular'
+import type { AndFilters, Filter, GenericFilter, OrFilters } from '../types/visualizations'
 import type { SortConfig, TabularProfileResponse } from '../components/TabularExplorer/types'
 
 export type { SortConfig }
@@ -56,41 +57,67 @@ export async function fetchTabularData(config: PluginConfig, options: FetchTabul
   return await ofetch<TabularDataResponse>(url)
 }
 
-function buildFilterQuery(filters: GenericFilter): string {
+/**
+ * Serialize a filter tree into tabular-api query params.
+ * - `Filter` → `column__condition=value` (ANDed with the other params)
+ * - root `AndFilters` → one param per child; `OrFilters` children become `or=(...)` params
+ * - root `OrFilters` → a single `or=(...)` param, with `AndFilters` children nested as `and(...)`
+ * (nested-condition grammar: `.` instead of `=`, no value for isnull/isnotnull)
+ */
+export function buildFilterQuery(filters: GenericFilter): string {
   const params: Array<string> = []
-  if ('filters' in filters) {
-    for (const filter of filters.filters) {
-      if ('filters' in filter) {
-        params.push(buildFilterQuery(filter))
+  if (filters._cls === 'Filter') {
+    const param = serializeParam(filters)
+    if (param) params.push(param)
+  }
+  else if (filters._cls === 'AndFilters') {
+    for (const child of filters.filters) {
+      if (child._cls === 'Filter') {
+        const param = serializeParam(child)
+        if (param) params.push(param)
       }
       else {
-        if (filter.condition === 'is_null') {
-          params.push(`${encodeURIComponent(filter.column)}__isnull`)
-        }
-        else if (filter.condition === 'is_not_null') {
-          params.push(`${encodeURIComponent(filter.column)}__isnotnull`)
-        }
-        else if (filter.value !== null && filter.value !== undefined && filter.value !== '') {
-          params.push(`${encodeURIComponent(filter.column)}__${encodeURIComponent(filter.condition)}=${encodeURIComponent(filter.value)}`)
-        }
+        // child is an OrFilters group: serializeGroup returns `or(...)`, the param is `or=(...)`
+        const nested = serializeGroup(child)
+        if (nested) params.push(`or=${nested.slice(2)}`)
       }
     }
   }
   else {
-    const filter = filters
-    if (filter.condition === 'is_null') {
-      params.push(`${encodeURIComponent(filter.column)}__isnull`)
-    }
-    else if (filter.condition === 'is_not_null') {
-      params.push(`${encodeURIComponent(filter.column)}__isnotnull`)
-    }
-    else if (filter.value !== null && filter.value !== undefined && filter.value !== '') {
-      params.push(`${encodeURIComponent(filter.column)}__${encodeURIComponent(filter.condition)}=${encodeURIComponent(filter.value)}`)
-    }
+    const nested = serializeGroup(filters)
+    if (nested) params.push(`or=${nested.slice(2)}`)
   }
   return params.join('&')
 }
 
+/** `column__condition=value` param for a top-level (ANDed) filter, null when empty */
+function serializeParam(filter: Filter): string | null {
+  const column = encodeURIComponent(filter.column)
+  if (filter.condition === 'is_null') return `${column}__isnull`
+  if (filter.condition === 'is_not_null') return `${column}__isnotnull`
+  if (filter.value === null || filter.value === undefined || filter.value === '') return null
+  return `${column}__${encodeURIComponent(filter.condition)}=${encodeURIComponent(filter.value)}`
+}
+
+/** `column__condition.value` condition for the `or(...)` / `and(...)` grammar, null when empty */
+function serializeCondition(filter: Filter): string | null {
+  const column = encodeURIComponent(filter.column)
+  if (filter.condition === 'is_null') return `${column}__isnull`
+  if (filter.condition === 'is_not_null') return `${column}__isnotnull`
+  if (filter.value === null || filter.value === undefined || filter.value === '') return null
+  return `${column}__${encodeURIComponent(filter.condition)}.${encodeConditionValue(filter.value)}`
+}
+
+/** `or(a,b,...)` / `and(a,b,...)` for the nested-condition grammar, null when empty */
+function serializeGroup(group: AndFilters | OrFilters): string | null {
+  const operator = group._cls === 'OrFilters' ? 'or' : 'and'
+  const conditions = group.filters
+    .map(child => ('filters' in child ? serializeGroup(child) : serializeCondition(child)))
+    .filter((condition): condition is string => condition !== null)
+  if (conditions.length === 0) return null
+  return `${operator}(${conditions.join(',')})`
+}
+
 /**
  * Call Tabular-api to get table content
  */

package/src/main.ts

@@ -23,7 +23,7 @@ import type { Site } from './types/site'
 import type { Weight, WellType } from './types/ui'
 import type { User, UserReference } from './types/users'
 import type { Report, ReportSubject, ReportReason } from './types/reports'
-import type { Chart, ChartForm, ChartForApi, FilterCondition, Filter, AndFilters, GenericFilter, XAxisType, XAxisSortBy, SortDirection, XAxis, XAxisForm, UnitPosition, YAxis, DataSeriesType, DataSeries, DataSeriesForm, CombinedSort, ColumnDefinition, ColumnsDefinition } from './types/visualizations'
+import type { Chart, ChartForm, ChartForApi, FilterCondition, Filter, AndFilters, OrFilters, GenericFilter, XAxisType, XAxisSortBy, SortDirection, XAxis, XAxisForm, UnitPosition, YAxis, DataSeriesType, DataSeries, DataSeriesForm, CombinedSort, ColumnDefinition, ColumnsDefinition } from './types/visualizations'
 import type { ColumnFilters, ColumnType, TabularRow } from './components/TabularExplorer/types'
 import type { GlobalSearchConfig, SearchType, SearchTypeConfig, SortOption, HiddenFilter, BuiltInFilterKey, DatasetSearchConfig, DatasetSearchFilters, DataserviceSearchConfig, DataserviceSearchFilters, ReuseSearchConfig, ReuseSearchFilters, OrganizationSearchConfig, OrganizationSearchFilters, TopicSearchConfig, TopicSearchFilters } from './types/search'
 import { getDefaultDatasetConfig, getDefaultDataserviceConfig, getDefaultReuseConfig, getDefaultOrganizationConfig, getDefaultTopicConfig, getDefaultGlobalSearchConfig, defaultDatasetSortOptions, defaultDataserviceSortOptions, defaultReuseSortOptions, defaultOrganizationSortOptions } from './types/search'
@@ -272,6 +272,7 @@ export type {
   FilterCondition,
   Filter,
   AndFilters,
+  OrFilters,
   GenericFilter,
   XAxisType,
   XAxisSortBy,

package/src/types/resources.ts

@@ -12,11 +12,6 @@ export type FileResourceFileType = 'file'
 
 export type ResourceFileType = RemoteResourceFileType | FileResourceFileType
 
-export type GeopfResourceMetadata = {
-  push_status?: 'pending' | 'done' | 'error' | 'timeout' | null
-  offering_id?: string | null
-}
-
 export type Resource = {
   id: string
   title: string
@@ -27,7 +22,6 @@ export type Resource = {
   extras: Record<string, unknown>
   metrics: { views: number }
   harvest: Harvest
-  geopf: GeopfResourceMetadata | null
   filesize: number | null
   filetype: ResourceFileType
   format: string

package/src/types/visualizations.ts

@@ -12,10 +12,15 @@ export type Filter = {
 
 export type AndFilters = {
   _cls: 'AndFilters'
+  filters: Array<Filter | OrFilters>
+}
+
+export type OrFilters = {
+  _cls: 'OrFilters'
   filters: Array<Filter | AndFilters>
 }
 
-export type GenericFilter = Filter | AndFilters
+export type GenericFilter = Filter | AndFilters | OrFilters
 
 export type XAxisType = 'discrete' | 'continuous'