@dataformer/env-service 1.1.1 → 2.0.0

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @dataformer/env-service
 
+## 2.0.0
+
+### Major Changes
+
+- Simplify GCP project ID resolution by removing SECRET_MANAGER_PROJECT_IDBREAKING: Replace SECRET_MANAGER_PROJECT_ID with GCP_PROJECT_ID for unified project approach. Eliminates cross-project complexity and chicken-and-egg problem with project ID resolution.Migration: Update GitHub repository secrets and CI/CD workflows to use GCP_PROJECT_ID
+
+### Patch Changes
+
+- Updated dependencies
+  - @dataformer/secret-manager-client@2.0.0
+
 ## 1.1.0
 
 ### Minor Changes

package/dist/index.d.ts

@@ -3,7 +3,7 @@ declare function obfuscateCred(cred: string | null): string;
 declare function getEnvVar(baseSecretKey: string): Promise<string | null>;
 declare function getCustomSearchApiKey(): Promise<string>;
 declare function getSearchEngineId(): Promise<string>;
-declare function getFirestoreProjectId(): Promise<string>;
+declare function getGcpProjectId(): Promise<string>;
 declare function setEnvVar(baseSecretKey: string, value: string): Promise<boolean>;
 declare const setLogToConsole: () => Promise<void>;
 declare const setPostgresUser: () => Promise<void>;
@@ -36,13 +36,13 @@ declare const getPostgresAuthType: () => Promise<string | null>;
 declare const getBigtableInstanceName: () => Promise<string | null>;
 declare const getBigtableTableName: () => Promise<string | null>;
 declare const getBigtableProjectId: () => Promise<string | null>;
+declare const getFirestoreProjectId: () => Promise<string | null>;
 declare const getJiraApiToken: () => Promise<string | null>;
 declare const getJiraApiBaseUrl: () => Promise<string | null>;
 declare const getJiraUserEmail: () => Promise<string | null>;
 declare const getGeminiApiKey: () => Promise<string | null>;
 declare const getNpmToken: () => Promise<string | null>;
 declare const getProjectRoot: () => string;
-declare const getGcpProjectId: () => Promise<string | null>;
 declare const getGcpUserEmail: () => Promise<string | null>;
 declare const printEnv: () => Promise<void>;
 declare const run: () => Promise<void>;

package/dist/index.js

@@ -61,12 +61,26 @@ async function getSearchEngineId() {
   }
   return searchEngineId;
 }
-async function getFirestoreProjectId() {
-  const projectId = await getEnvVar("FIRESTORE_PROJECT_ID");
-  if (!projectId) {
-    throw new Error("FIRESTORE_PROJECT_ID not found in environment variables.");
+async function getGcpProjectId() {
+  const envProjectId = process.env.GCP_PROJECT_ID;
+  if (envProjectId) {
+    return envProjectId;
+  }
+  try {
+    const { execSync } = await import("child_process");
+    const projectId = execSync("gcloud config get-value project", {
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "ignore"]
+    }).trim();
+    if (!projectId || projectId === "(unset)") {
+      throw new Error("No GCP project configured. Run `gcloud config set project YOUR_PROJECT_ID`");
+    }
+    return projectId;
+  } catch (error) {
+    throw new Error(
+      "GCP_PROJECT_ID not found. Either:\n1. Set GCP_PROJECT_ID environment variable (for deployed environments), or\n2. Configure gcloud: `gcloud config set project YOUR_PROJECT_ID` (for local development)"
+    );
   }
-  return projectId;
 }
 async function setEnvVar(baseSecretKey, value) {
   const sm = await getSecretManager();
@@ -202,6 +216,7 @@ var getBigtableInstanceName = async () => await getEnvVar("BIGTABLE_INSTANCE_NAM
 var getBigtableTableName = async () => await getEnvVar("BIGTABLE_TABLE_NAME");
 var getBigtableProjectId = async () => await getEnvVar("BIGTABLE_PROJECT_ID");
 var _getFirestoreProjectId = async () => await getEnvVar("FIRESTORE_PROJECT_ID");
+var getFirestoreProjectId = _getFirestoreProjectId;
 var getJiraApiToken = async () => await getEnvVar("JIRA_API_TOKEN");
 var getJiraApiBaseUrl = async () => await getEnvVar("JIRA_API_BASE_URL");
 var getJiraUserEmail = async () => await getEnvVar("JIRA_USER_EMAIL");
@@ -211,14 +226,6 @@ var getProjectRoot = () => {
   const currentDir = path.dirname(new URL(import.meta.url).pathname);
   return path.resolve(currentDir, "../..");
 };
-var _getResolvedGcpProjectId = async () => {
-  const sm = await getSecretManager();
-  if (!sm) {
-    console.warn("[EnvService.ts] SecretManager not available for _getResolvedGcpProjectId");
-    return null;
-  }
-  return sm.getResolvedProjectId();
-};
 var _getResolvedGcpUserEmail = async () => {
   const sm = await getSecretManager();
   if (!sm) {
@@ -227,7 +234,6 @@ var _getResolvedGcpUserEmail = async () => {
   }
   return sm.getResolvedUserEmail();
 };
-var getGcpProjectId = _getResolvedGcpProjectId;
 var getGcpUserEmail = _getResolvedGcpUserEmail;
 var printEnv = async () => {
   const logToConsole = await getLogToConsole();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dataformer/env-service",
-  "version": "1.1.1",
+  "version": "2.0.0",
   "description": "Environment service for Dataformer",
   "type": "module",
   "main": "dist/index.js",
@@ -11,14 +11,9 @@
       "types": "./dist/index.d.ts"
     }
   },
-  "scripts": {
-    "build": "tsup src/index.ts --format esm --dts --clean",
-    "dev": "tsup src/index.ts --format esm --dts --watch",
-    "prepublish": "pnpm run build"
-  },
   "dependencies": {
     "@google-cloud/secret-manager": "^5.4.0",
-    "@dataformer/secret-manager-client": "^1.1.0"
+    "@dataformer/secret-manager-client": "^2.0.0"
   },
   "devDependencies": {
     "tsup": "^8.0.0",
@@ -26,5 +21,10 @@
   },
   "peerDependencies": {
     "typescript": "^5.0.0"
+  },
+  "scripts": {
+    "build": "tsup src/index.ts --format esm --dts --clean",
+    "dev": "tsup src/index.ts --format esm --dts --watch",
+    "prepublish": "pnpm run build"
   }
-}
+}

package/src/index.ts

@@ -25,10 +25,9 @@
 //      for your GCP project.
 //
 // PROJECT ID DETECTION:
-// The SecretManagerClient automatically detects the GCP project ID from:
-// 1. SECRET_MANAGER_PROJECT_ID environment variable (for CI/CD deployments)
-// 2. Your local gcloud configuration (for development: `gcloud config get-value project`)
-// 3. Explicit override via createSecretManagerClient({ projectId: "your-project" })
+// The GCP project ID is resolved from:
+// 1. GCP_PROJECT_ID environment variable (for deployed environments - set as GitHub repository secret)
+// 2. Local gcloud configuration (for development: `gcloud config get-value project`)
 //
 // SECRET NAMING CONVENTION:
 // Secrets are named using the format: {projectId}_{userEmail}_{secretId}
@@ -108,12 +107,33 @@ export async function getSearchEngineId(): Promise<string> {
   return searchEngineId;
 }
 
-export async function getFirestoreProjectId(): Promise<string> {
-  const projectId = await getEnvVar('FIRESTORE_PROJECT_ID');
-  if (!projectId) {
-    throw new Error('FIRESTORE_PROJECT_ID not found in environment variables.');
+export async function getGcpProjectId(): Promise<string> {
+  // First try environment variable (for deployed environments)
+  const envProjectId = process.env.GCP_PROJECT_ID;
+  if (envProjectId) {
+    return envProjectId;
+  }
+
+  // Fall back to gcloud config for local development
+  try {
+    const { execSync } = await import('child_process');
+    const projectId = execSync('gcloud config get-value project', { 
+      encoding: 'utf8',
+      stdio: ['ignore', 'pipe', 'ignore']
+    }).trim();
+    
+    if (!projectId || projectId === '(unset)') {
+      throw new Error('No GCP project configured. Run `gcloud config set project YOUR_PROJECT_ID`');
+    }
+    
+    return projectId;
+  } catch (error) {
+    throw new Error(
+      'GCP_PROJECT_ID not found. Either:\n' +
+      '1. Set GCP_PROJECT_ID environment variable (for deployed environments), or\n' +
+      '2. Configure gcloud: `gcloud config set project YOUR_PROJECT_ID` (for local development)'
+    );
   }
-  return projectId;
 }
 
 async function setEnvVar(baseSecretKey: string, value: string): Promise<boolean> {
@@ -274,6 +294,9 @@ const getBigtableInstanceName = async (): Promise<string | null> => await getEnv
 const getBigtableTableName = async (): Promise<string | null> => await getEnvVar('BIGTABLE_TABLE_NAME');
 const getBigtableProjectId = async (): Promise<string | null> => await getEnvVar('BIGTABLE_PROJECT_ID');
 const _getFirestoreProjectId = async (): Promise<string | null> => await getEnvVar('FIRESTORE_PROJECT_ID');
+
+// Export the firestore project ID getter
+export const getFirestoreProjectId = _getFirestoreProjectId;
 const getJiraApiToken = async (): Promise<string | null> => await getEnvVar('JIRA_API_TOKEN');
 const getJiraApiBaseUrl = async (): Promise<string | null> => await getEnvVar('JIRA_API_BASE_URL');
 const getJiraUserEmail = async (): Promise<string | null> => await getEnvVar('JIRA_USER_EMAIL');
@@ -305,7 +328,6 @@ const _getResolvedGcpUserEmail = async (): Promise<string | null> => {
   return sm.getResolvedUserEmail();
 };
 
-const getGcpProjectId = _getResolvedGcpProjectId;
 const getGcpUserEmail = _getResolvedGcpUserEmail;
 
 const printEnv = async (): Promise<void> => {
@@ -440,7 +462,6 @@ export {
 
   // Synchronous Getters / Utility
   getProjectRoot,
-  getGcpProjectId,
   getGcpUserEmail,
 
   // Generic accessors