@datadog/mobile-react-native-session-replay 3.1.1 → 3.2.0

package/DatadogSDKReactNativeSessionReplay.podspec

@@ -23,7 +23,7 @@ Pod::Spec.new do |s|
   s.dependency "React-Core"
 
   # /!\ Remember to keep the version in sync with DatadogSDKReactNative.podspec
-  s.dependency 'DatadogSessionReplay', '3.5.0'
+  s.dependency 'DatadogSessionReplay', '3.8.2'
   s.dependency 'DatadogSDKReactNative'
 
   s.test_spec 'Tests' do |test_spec|

package/android/build.gradle

@@ -216,8 +216,8 @@ dependencies {
     api "com.facebook.react:react-android:$reactNativeVersion"
   }
   implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlin_version"
-  implementation "com.datadoghq:dd-sdk-android-session-replay:3.5.0"
-  implementation "com.datadoghq:dd-sdk-android-internal:3.5.0"
+  implementation "com.datadoghq:dd-sdk-android-session-replay:3.8.0"
+  implementation "com.datadoghq:dd-sdk-android-internal:3.8.0"
   implementation project(path: ':datadog_mobile-react-native')
 
   testImplementation "org.junit.platform:junit-platform-launcher:1.6.2"

package/ios/Sources/RCTTextExtractor.mm

@@ -31,7 +31,7 @@
     RCTTextView* textView = (RCTTextView*)view;
     NSNumber* tag = textView.reactTag;
 
-    __block RCTTextShadowView* shadowView = nil;
+    __block RCTTextPropertiesWrapper* textProperties = nil;
     NSTimeInterval timeout = 0.2;
     dispatch_semaphore_t semaphore = dispatch_semaphore_create(0);
 
@@ -41,8 +41,33 @@
     // That would create a circular dependency and deadlock the app.
     // To avoid this, we dispatch the work asynchronously to the UIManager queue and wait with a timeout.
     // This ensures we block only if absolutely necessary, and can fail gracefully if the queue is busy.
+    //
+    // All shadow view property reads (reactSubviews, textAttributes, layoutMetrics) must also happen
+    // on the UIManager queue. The UIManager queue can mutate or deallocate shadow views and their
+    // subviews at any time, so reading them on the main thread after the semaphore is signaled creates
+    // a race condition that causes SIGSEGV crashes in objc_msgSend.
     dispatch_async(uiManager.methodQueue, ^{
-        shadowView = (RCTTextShadowView*)[uiManager shadowViewForReactTag:tag];
+        RCTTextShadowView* shadowView = (RCTTextShadowView*)[uiManager shadowViewForReactTag:tag];
+
+        if (shadowView != nil && [shadowView isKindOfClass:[RCTTextShadowView class]]) {
+            RCTTextPropertiesWrapper* wrapper = [[RCTTextPropertiesWrapper alloc] init];
+
+            NSString* text = [self tryToExtractTextFromSubViews:shadowView.reactSubviews];
+            if (text != nil) {
+                wrapper.text = text;
+            }
+
+            if (shadowView.textAttributes.foregroundColor != nil) {
+                wrapper.foregroundColor = shadowView.textAttributes.foregroundColor;
+            }
+
+            wrapper.alignment = shadowView.textAttributes.alignment;
+            wrapper.fontSize = shadowView.textAttributes.fontSize;
+            wrapper.contentRect = shadowView.layoutMetrics.contentFrame;
+
+            textProperties = wrapper;
+        }
+
         dispatch_semaphore_signal(semaphore);
     });
 
@@ -53,27 +78,6 @@
         return nil;
     }
 
-    if (shadowView == nil || ![shadowView isKindOfClass:[RCTTextShadowView class]]) {
-        return nil;
-    }
-
-    RCTTextPropertiesWrapper* textProperties = [[RCTTextPropertiesWrapper alloc] init];
-
-    // Extract text from subviews
-    NSString* text = [self tryToExtractTextFromSubViews:shadowView.reactSubviews];
-    if (text != nil) {
-        textProperties.text = text;
-    }
-
-    // Extract text attributes
-    if (shadowView.textAttributes.foregroundColor != nil) {
-        textProperties.foregroundColor = shadowView.textAttributes.foregroundColor;
-    }
-
-    textProperties.alignment = shadowView.textAttributes.alignment;
-    textProperties.fontSize = shadowView.textAttributes.fontSize;
-    textProperties.contentRect = shadowView.layoutMetrics.contentFrame;
-
     return textProperties;
 #else
     return nil;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@datadog/mobile-react-native-session-replay",
-    "version": "3.1.1",
+    "version": "3.2.0",
     "description": "A client-side React Native module to enable session replay with Datadog",
     "keywords": [
         "datadog",
@@ -96,5 +96,5 @@
     "dependencies": {
         "chokidar": "^4.0.3"
     },
-    "gitHead": "5d7701cabda497319391937073b2456dc83a0e62"
+    "gitHead": "f536944e1d1f58d7e75b28bbed9dfb99288e1816"
 }