@dashx/react-native 1.4.1 → 1.5.1

package/.github/workflows/ci.yml

@@ -1,67 +0,0 @@
-name: CI
-
-on:
-  push:
-    branches: [main, develop]
-  pull_request:
-    branches: [main, develop]
-
-jobs:
-  lint-and-test:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: 18
-          cache: yarn
-
-      - name: Install dependencies
-        run: yarn install --frozen-lockfile
-
-      - name: Lint
-        run: yarn lint
-
-      - name: Test
-        run: yarn test
-
-  # Android JVM unit tests for the bridge (see android/src/test). Runs
-  # standalone via the minimal `android/settings.gradle` + buildscript block
-  # added for this purpose — no consumer app checkout required. Scoped to
-  # PRs against `develop` and pushes to `main` per the team's release
-  # workflow (feature branches → develop, develop → main on release).
-  android-test:
-    runs-on: ubuntu-latest
-    if: >-
-      (github.event_name == 'push' && github.ref == 'refs/heads/main') ||
-      (github.event_name == 'pull_request' && github.base_ref == 'develop')
-    steps:
-      - uses: actions/checkout@v4
-
-      - name: Setup JDK 17
-        uses: actions/setup-java@v4
-        with:
-          distribution: temurin
-          java-version: 17
-
-      - name: Cache Gradle
-        uses: actions/cache@v4
-        with:
-          path: |
-            ~/.gradle/caches
-            ~/.gradle/wrapper
-          key: ${{ runner.os }}-gradle-${{ hashFiles('android/build.gradle', 'android/gradle/wrapper/gradle-wrapper.properties') }}
-          restore-keys: ${{ runner.os }}-gradle-
-
-      - name: Run Android unit tests
-        working-directory: android
-        run: ./gradlew :testDebugUnitTest --no-daemon
-
-      - name: Upload test report on failure
-        if: failure()
-        uses: actions/upload-artifact@v4
-        with:
-          name: android-test-report
-          path: android/build/reports/tests/testDebugUnitTest

package/.gitignore

@@ -1,49 +0,0 @@
-
-# OSX
-#
-.DS_Store
-
-# node.js
-#
-node_modules/
-npm-debug.log
-yarn-error.log
-
-# Xcode
-#
-build/
-*.pbxuser
-!default.pbxuser
-*.mode1v3
-!default.mode1v3
-*.mode2v3
-!default.mode2v3
-*.perspectivev3
-!default.perspectivev3
-xcuserdata
-*.xccheckout
-*.moved-aside
-DerivedData
-*.hmap
-*.ipa
-*.xcuserstate
-project.xcworkspace
-
-# Android/IntelliJ
-#
-build/
-.idea
-.gradle
-# Kotlin 2.x incremental-compile cache (errors/, sessions/). Per-dev,
-# regenerated on every compile.
-.kotlin/
-local.properties
-*.iml
-
-# BUCK
-buck-out/
-\.buckd/
-*.keystore
-
-# Cursor
-.cursor

package/.nvmrc

@@ -1 +0,0 @@
-v24

package/CHANGELOG.md

@@ -1,125 +0,0 @@
-# Changelog
-
-All notable changes to `@dashx/react-native` are documented in this file. Format loosely follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), versions follow [SemVer](https://semver.org/).
-
-## [1.4.1] — 2026-05-06
-
-### Required upgrade steps
-
-1. **Bump the dashx-ios pod tag to 1.5.1 in your `ios/Podfile`** — `pod install` will refuse the upgrade otherwise (the podspec floor is now `>= 1.5.1`):
-
-   ```ruby
-   pod 'DashX/SDK', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.5.1'
-   ```
-
-   The floor is required because earlier dashx-ios versions either fall back to silent-push on the backend (pre-1.3.0, throttled by iOS) or omit `.timeSensitive` from the authorization request (pre-1.5.1, causing `interruption-level: time-sensitive` payloads to silently downgrade and stay filterable by Focus / Reduce Interruptions / Scheduled Summary on iOS 18 / 26).
-
-2. **Wire `fallbackToSettings: true` somewhere in your permission UI** to recover existing iOS users — fresh installs are auto-fixed by the upgrade, but users who already granted notification permission under the old SDK keep an `.authorized` state without the time-sensitive entitlement, and Apple's `requestAuthorization` is a one-shot grant that can't be silently upgraded. They have to flip the **Time Sensitive Notifications** toggle in iOS Settings themselves.
-
-   ```js
-   // From a "Notifications acting up?" affordance, or as a one-time
-   // post-upgrade prompt:
-   await DashX.requestNotificationPermission({ fallbackToSettings: true });
-   ```
-
-   When the user is already determined (granted or denied on iOS / permanently denied on Android), this opens the system notification settings page instead of firing a futile `requestAuthorization`. Without this step, your existing iOS users will keep experiencing the original "intermittent / second attempt works" symptom even after upgrading to 1.4.1.
-
-### Migration
-
-- **Consumers who subclass `DashXReactNativeModuleImpl`** and override `requestNotificationPermission(promise:)` need to update the override signature to `requestNotificationPermission(fallbackToSettings: Boolean, promise: Promise)`. Otherwise Kotlin's override resolution silently drops to the impl's version and your custom logic stops running. Same applies to anyone subclassing the new-arch / old-arch `DashXReactNativeModule` wrappers. Most consumers don't subclass these — flagged here for the few that do.
-
-### Added
-
-- **`DashX.requestNotificationPermission({ fallbackToSettings })`.** Optional flag, default `false`. When `true`, the SDK detects platform-specific dead-ends and opens the system notification-settings page instead of firing a futile prompt:
-  - **iOS** — already granted or denied (iOS no-ops `requestAuthorization` in that state).
-  - **Android** — `POST_NOTIFICATIONS` permanently denied (Android 13+, two-strikes rule). `requestPermissions()` auto-resolves DENIED without UI in that state.
-
-  Existing call sites (`DashX.requestNotificationPermission()` with no arguments) compile and behave unchanged.
-
-### Fixed
-
-- **Foreground push duplicate-display race in `DashXNotificationHandler.handleRemoteNotification`.** Now short-circuits when the payload already carries `aps.alert`, letting iOS render the notification natively via NSE / `willPresent` instead of racing a duplicate `UNUserNotificationCenter.add(...)` against it. Without the short-circuit the local re-add could clobber the NSE-attached image or briefly flicker on screen.
-- **Suspension race in the image-attached reconstruction path.** The `fetchCompletionHandler` now fires only after the async image download and the local `add()` both complete, with a 25-second budget under iOS's background-push limit. Previously the handler fired immediately while the download was still in flight, letting iOS suspend the process before the notification actually displayed.
-
-## [1.4.0] — 2026-04-27
-
-### Changed
-
-- **`DashX.unsubscribe()` now returns `Promise<{ success: boolean }>`** (was `void`). Matches `@dashx/browser`'s shape exactly — apps using a Metro `.web.ts` resolver can now share a single typed callsite across web and native.
-
-  **Migration**
-
-  Most existing call sites continue to work unchanged:
-
-  ```ts
-  DashX.unsubscribe()                          // ✓ fire-and-forget still works
-  await DashX.unsubscribe()                    // ✓ still works (return value just unused)
-  const { success } = await DashX.unsubscribe()  // new capability
-  ```
-
-  Two situations to watch for after upgrading:
-
-  - **Unhandled-rejection warnings.** Previously the native module surfaced errors only in its own logs; the JS API was silent. Now JS-side promise rejections fire on SDK-state problems (Firebase Messaging dependency missing, `configure()` not yet called) and transport failures (Firebase `deleteToken` failure, GraphQL / network errors). If you never caught errors before because there was nothing to catch, a fire-and-forget `DashX.unsubscribe()` may now surface "Possible Unhandled Promise Rejection" warnings in your console. Wrap with `.catch(...)` or `try / await` if those warnings are noisy.
-  - **TypeScript `: void` annotations.** `const x: void = DashX.unsubscribe()` no longer compiles. Vanishingly rare in practice but worth a grep.
-
-  **What the resolved value means**
-
-  - **`success: true`** — backend found and unsubscribed a matching contact.
-  - **`success: false`** — non-error outcome meaning "no matching contact found"; typically the anonymous UID rotated since subscribe, the FCM token is stale, the contact is already unsubscribed, or `unsubscribe()` was called on a device that never subscribed in this session. The device ends up unsubscribed in either case; the boolean is useful for diagnostics and analytics.
-  - **Promise rejection** — distinct from `success: false` so callers can branch on SDK-misuse vs legitimate no-match.
-
-- **Native pin bumps to pick up the underlying schema change:**
-  - `android/build.gradle` → `com.dashx:dashx-android` `1.2.7` → `1.2.8`. The bridge now passes `onSuccess` / `onError(DashXError)` callbacks to the native `DashX.unsubscribe(...)` and resolves/rejects the JS promise accordingly.
-  - iOS pod consumers should bump `pod 'DashX/SDK'` to `:tag => '1.5.0'` in their Podfile. The bridge now calls `DashX.unsubscribe { result in ... }` and resolves/rejects the JS promise from the `Result<Bool, Error>` completion.
-
-## [1.3.2] — 2026-04-22
-
-### Added
-- **`DashX.onPushNotificationReceived(callback)`** — new name for registering a foreground push listener. Same signature, same subscription shape; matches the `@dashx/browser` API so cross-platform apps using a Metro `.web.ts` wrapper can share the callsite.
-
-### Deprecated
-- **`DashX.onMessageReceived(callback)`** is now a deprecated alias of `onPushNotificationReceived` and logs a one-time `console.warn` on first call. The name leaked up from Android's Firebase `FirebaseMessagingService.onMessageReceived` override and was ambiguous in the DashX domain ("message" overloaded with `trackMessage` and in-app notifications). Scheduled for removal in the next major version.
-
-## [1.3.1] — 2026-04-21
-
-### Added
-- **`DashX.onNotificationClicked` now fires on Android.** Previously only wired on iOS — the Android bridge didn't register a `DashXNotificationListener` with the SDK, so JS listeners never received tap events. The bridge now registers a listener in `DashXReactNativeModuleImpl.initialize()` and emits a `notificationClicked` event matching the iOS shape: `{ notification, action, actionIdentifier }`. `actionIdentifier` is the tapped button's identifier (body tap → empty string, matching iOS's always-a-string contract).
-- Android JVM unit tests for the kotlinx-serialization conversion helpers (`Utils.kt`) — 16 tests covering all primitive types, nested objects/arrays, null handling, round-trips, and regression cases for the two pre-migration crash paths. Runs as a dedicated `android-test` CI job on PRs to `develop` and pushes to `main`.
-
-### Changed
-- **Android JSON handling consolidated on kotlinx-serialization.** Removed the Gson dependency and the `org.json`-shaped helpers (`MapUtil.java`, `ArrayUtil.java`), rewrote `Utils.kt` to use kotlinx `JsonObject` / `JsonArray` end-to-end. Matches how dashx-android itself serializes (its Apollo scalar mapping is `kotlinx.serialization.json.JsonObject`), eliminates the string round-trips the previous cross-library code was doing, and removes a class of bugs where three JSON libraries coexisted. Internal helper signatures changed (`convertMapToJson` now returns `JsonObject?`, `convertJsonToMap` now takes `JsonObject?`); consumer JS API is unchanged.
-- `android/build.gradle` dep on `com.dashx:dashx-android` bumped `1.2.6` → `1.2.7` to receive the new 3-arg `onNotificationClicked(payload, action, actionIdentifier)` listener overload.
-
-### Fixed
-- `uploadAsset` / `fetchAsset` on Android previously failed to compile against `@dashx/react-native` due to a type mismatch in the TurboModule-migration callsite (`org.json.JSONObject` passed to a Gson `JsonObject`-typed helper, introduced in 1.2.0's TurboModule PR and never caught because no Android consumer had built the bridge since). Fixed by the Gson → kotlinx migration described above.
-
-## [1.3.0] — 2026-04-20
-
-### Breaking
-- **`DashX` pod → `DashX/SDK`.** The podspec now depends on the `DashX/SDK` subspec of [dashx-ios 1.4.0+](https://github.com/dashxhq/dashx-ios) with no version constraint. Consumers must update their Podfile:
-  ```ruby
-  # before
-  pod 'DashX', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.1.9'
-
-  # after
-  pod 'DashX/SDK', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.4.0'
-  ```
-- **`FirebaseMessaging` is now a hard dependency.** Previously the bridge guarded Firebase usage with `#if canImport(FirebaseMessaging)`, but `canImport` doesn't see consumer-Podfile pods at this pod's compile time, so the guard silently elided every FCM code path — push registration stopped working on fresh installs. Consumers must enable modular headers in their Podfile:
-  ```ruby
-  use_modular_headers!
-  # or, per-pod:
-  pod 'FirebaseMessaging', :modular_headers => true
-  ```
-
-### Added
-- `DashX.onNotificationClicked(callback)` — fires when the user taps a DashX notification or one of its action buttons. Callback receives `{ notification, action, actionIdentifier }` where `action` is a resolved `NavigationAction` (`deepLink` / `screen` / `richLanding` / `clickAction`) or `null`.
-- `DashXNotificationResponseResult.navigationAction` — new Swift-only field on the helper result type returned by `DashXNotificationHandler.handleNotificationResponse(_:)`.
-- `NotificationClickedEvent` exported from `index.d.ts`.
-
-### Fixed
-- **iOS dev builds silently failing to receive pushes.** `Messaging.messaging().setAPNSToken(_, type: .unknown)` sometimes mis-tagged the APNs environment on dev-signed binaries, producing an FCM token whose pushes 410'd at Apple. The bridge now forces `.sandbox` in `DEBUG` configurations and `.prod` otherwise.
-- **`DashX.setIdentity(uid, token)` now passes `null` / `""` / `undefined` through to the native SDK unchanged** (apart from normalizing `undefined → null`, since the RN bridge can't carry `undefined`). Previously the JS wrapper threw on `null` / `""` / `undefined` for `uid`, contradicting the nullable signatures on iOS (`NSString?`) and Android (`String?`). TypeScript signature updated: `setIdentity(uid: string | null, token?: string | null): void`.
-
-## [1.2.0] — 2026-04-16
-
-Previous release — see git log.

package/CONTRIBUTING.md

@@ -1,190 +0,0 @@
-# Contributing to @dashx/react-native
-
-## Prerequisites
-
-- Node.js >= 16
-- Yarn
-- Xcode (for iOS)
-- Android Studio with JDK 17 (for Android)
-- CocoaPods (`gem install cocoapods`)
-
-## Getting Started
-
-1. Clone the repository:
-
-```sh
-git clone https://github.com/dashxhq/dashx-react-native.git
-cd dashx-react-native
-```
-
-2. Install dependencies:
-
-```sh
-yarn install
-```
-
-3. Run tests:
-
-```sh
-yarn test
-```
-
-4. Run lint:
-
-```sh
-yarn lint
-```
-
-## Building the SDK Locally
-
-### Android
-
-The Android bridge lives in `android/` and is a Gradle library module that is built as part of a React Native app — it cannot be built standalone because it depends on the React Native Gradle plugin and Android SDK provided by the host app.
-
-To build and test locally, use a React Native demo app (e.g. `dashx-demo-react-native`):
-
-1. In the demo app's `package.json`, point to your local SDK checkout:
-
-```json
-"dependencies": {
-  "@dashx/react-native": "file:../dashx-react-native"
-}
-```
-
-2. Install and build:
-
-```sh
-cd dashx-demo-react-native
-yarn install
-cd android
-./gradlew assembleDebug
-```
-
-3. **To test with a local `dashx-android` SDK build**, publish it to local Maven and add `mavenLocal()` to the demo app's `android/build.gradle` repositories:
-
-```sh
-# In dashx-android:
-./gradlew publishToMavenLocal
-
-# In dashx-react-native/android/build.gradle, add:
-repositories {
-    mavenLocal()
-    // ...
-}
-```
-
-### iOS
-
-The iOS bridge lives in `ios/` and is distributed as a CocoaPod (`DashXReactNative.podspec`). Like Android, it is built as part of a React Native app's Xcode workspace.
-
-To build and test locally, use a React Native demo app (e.g. `dashx-demo-react-native`):
-
-1. In the demo app's `package.json`, point to your local SDK checkout:
-
-```json
-"dependencies": {
-  "@dashx/react-native": "file:../dashx-react-native"
-}
-```
-
-2. Install dependencies and pods:
-
-```sh
-cd dashx-demo-react-native
-yarn install
-cd ios
-pod install
-```
-
-3. Build from Xcode by opening the `.xcworkspace`, or from the command line:
-
-```sh
-xcodebuild -workspace ios/DashXDemoReactNative.xcworkspace \
-  -scheme DashXDemoReactNative \
-  -destination 'generic/platform=iOS Simulator' \
-  build
-```
-
-4. **To test with a local `dashx-ios` SDK build**, add a path override in the demo app's `Podfile`:
-
-```ruby
-pod 'DashX', :path => '../../dashx-ios'
-```
-
-Then re-run `pod install`.
-
-## Project Structure
-
-```
-dashx-react-native/
-  index.js              # JS bridge — public API surface
-  index.d.ts            # TypeScript type definitions
-  android/
-    src/main/java/com/dashx/rn/sdk/
-      DashXReactNativeModule.kt   # Android native module
-      DashXReactNativePackage.kt  # Package registration
-      DashXReactNativeFirebaseMessagingService.kt  # FCM service
-      util/                       # Bridge conversion utilities
-    build.gradle                  # Android build config
-  ios/
-    DashXReactNative.swift        # iOS native module — SOURCE OF TRUTH for bridge methods
-    DashXReactNative.mm           # Obj-C++ bridge exports — AUTO-GENERATED, see below
-    DashXEventEmitter.swift       # Event emitter for push notifications
-    DashXRCTAppDelegate.swift     # AppDelegate with Firebase/push handling
-  scripts/
-    generate-bridge-shim.js       # Regenerates DashXReactNative.mm from the Swift @objc decls
-  DashXReactNative.podspec        # CocoaPods spec
-  __tests__/                      # Jest tests
-```
-
-## iOS bridge: editing methods
-
-`ios/DashXReactNative.mm` is **auto-generated** from `ios/DashXReactNative.swift`.
-Don't hand-edit it — your changes will be overwritten on the next regen, and CI
-will fail anyway because the committed `.mm` won't match what the script
-produces.
-
-Workflow when adding or changing a bridged method:
-
-1. Edit `ios/DashXReactNative.swift`. Each bridged method needs an `@objc`
-   decoration. Multi-arg methods use the explicit form
-   `@objc(methodName:label1:label2:)`; zero-arg methods use bare `@objc`.
-2. Run the regen:
-   ```sh
-   yarn sync-bridge-shim
-   ```
-3. Commit both the Swift change AND the regenerated `ios/DashXReactNative.mm`
-   in the same PR.
-
-CI verification: `yarn lint` chains `yarn check-bridge-shim`, which re-runs
-the generator and fails on a non-empty `git diff` against the committed
-`.mm`. So a forgotten `sync-bridge-shim` step is caught at PR time, not in
-production.
-
-Why the `.mm` exists at all: React Native's iOS bridge requires every Swift
-method to be declared in BOTH the Swift `@objc` form (for runtime dispatch)
-AND in `RCT_EXTERN_METHOD(...)` form in an Obj-C++ shim (for old-arch
-consumers' bridge module registration + new-arch compile-time selector
-verification). The script makes the Swift declarations the single source of
-truth and emits the matching shim mechanically.
-
-If the script ever fails with `unknown Swift parameter type "..."`, add a
-mapping for that type in `scripts/generate-bridge-shim.js`'s
-`SWIFT_TO_OBJC` table (one line, then re-run).
-
-## Running Tests
-
-```sh
-yarn test
-```
-
-Tests mock the React Native native modules and verify the JS bridge layer: input validation, native method delegation, promise handling, and event listener registration.
-
-## Publishing
-
-Use `yarn publish` to bump the version and release to npm:
-
-```sh
-yarn publish
-git push origin main
-```

package/__tests__/fallback.test.js

@@ -1,72 +0,0 @@
-const mockNativeModule = {
-  configure: jest.fn(),
-  identify: jest.fn(),
-  setIdentity: jest.fn(),
-  reset: jest.fn(),
-  track: jest.fn(),
-  screen: jest.fn(),
-  fetchRecord: jest.fn(),
-  searchRecords: jest.fn(),
-  fetchStoredPreferences: jest.fn(),
-  saveStoredPreferences: jest.fn(),
-  subscribe: jest.fn(),
-  unsubscribe: jest.fn(),
-  setLogLevel: jest.fn(),
-  uploadAsset: jest.fn(),
-  fetchAsset: jest.fn(),
-  enableLifecycleTracking: jest.fn(),
-  enableAdTracking: jest.fn(),
-  processURL: jest.fn(),
-  trackNotificationNavigation: jest.fn(),
-  requestNotificationPermission: jest.fn(),
-  getNotificationPermissionStatus: jest.fn(),
-  addListener: jest.fn(),
-  removeListeners: jest.fn(),
-};
-
-jest.mock('react-native', () => ({
-  NativeModules: {
-    DashXReactNative: mockNativeModule,
-  },
-  NativeEventEmitter: jest.fn().mockImplementation(() => ({
-    addListener: jest.fn(() => ({ remove: jest.fn() })),
-  })),
-  Platform: {
-    OS: 'ios',
-    select: jest.fn((obj) => obj.default || ''),
-  },
-  TurboModuleRegistry: {
-    get: jest.fn(() => null),
-    getEnforcing: jest.fn(() => {
-      throw new Error('not available');
-    }),
-  },
-}));
-
-// TurboModule returns null -> should fall back to NativeModules
-jest.mock('../src/NativeDashXReactNative', () => ({
-  __esModule: true,
-  default: null,
-}));
-
-const DashX = require('../index').default;
-
-describe('NativeModules fallback', () => {
-  beforeEach(() => {
-    jest.clearAllMocks();
-  });
-
-  it('falls back to NativeModules.DashXReactNative when TurboModule is null', () => {
-    DashX.configure({ publicKey: 'pk_test' });
-    expect(mockNativeModule.configure).toHaveBeenCalledWith({
-      publicKey: 'pk_test',
-    });
-  });
-
-  it('calls track on the fallback module', () => {
-    DashX.track('event_name', { key: 'value' });
-    expect(mockNativeModule.track).toHaveBeenCalledWith('event_name', {
-      key: 'value',
-    });
-  });
-});