@dashx/react-native 1.1.5 → 1.3.0

package/.claude/settings.local.json

@@ -8,7 +8,24 @@
       "Bash(swift build:*)",
       "Bash(xcodebuild -scheme DashX -destination 'generic/platform=iOS' build)",
       "Bash(./gradlew :dashx:compileDebugKotlin)",
-      "Bash(./gradlew :dashx:compileDebugKotlin --info)"
+      "Bash(./gradlew :dashx:compileDebugKotlin --info)",
+      "Bash(gh pr:*)",
+      "WebFetch(domain:github.com)",
+      "WebFetch(domain:patch-diff.githubusercontent.com)",
+      "WebFetch(domain:raw.githubusercontent.com)",
+      "Bash(ls -la /Users/gulshan/Work/dashx-react-native/ios/DashXRCTAppDelegate*)",
+      "Bash(npx jest *)",
+      "Bash(ls *)",
+      "Bash(grep *)",
+      "Read(//private/tmp/**)",
+      "Bash(javap -p com/dashx/android/DashX.class)",
+      "Bash(javap -p 'com/dashx/android/DashX$Companion.class')",
+      "Bash(jar xf *)",
+      "Bash(javap 'com/dashx/android/DashX$Companion.class')",
+      "Bash(javap 'com/dashx/android/data/Asset.class')",
+      "Bash(javap 'com/dashx/android/data/AssetData.class')",
+      "Read(//Users/gulshan/Work/dashx-ios/**)",
+      "WebSearch"
     ]
   }
 }

package/.gitignore

@@ -42,5 +42,5 @@ buck-out/
 \.buckd/
 *.keystore
 
-# Cursor plans
+# Cursor
 .cursor

package/CHANGELOG.md

@@ -0,0 +1,34 @@
+# Changelog
+
+All notable changes to `@dashx/react-native` are documented in this file. Format loosely follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), versions follow [SemVer](https://semver.org/).
+
+## [1.3.0] — 2026-04-20
+
+### Breaking
+- **`DashX` pod → `DashX/SDK`.** The podspec now depends on the `DashX/SDK` subspec of [dashx-ios 1.3.1+](https://github.com/dashxhq/dashx-ios) with no version constraint. Consumers must update their Podfile:
+  ```ruby
+  # before
+  pod 'DashX', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.1.9'
+
+  # after
+  pod 'DashX/SDK', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.3.1'
+  ```
+- **`FirebaseMessaging` is now a hard dependency.** Previously the bridge guarded Firebase usage with `#if canImport(FirebaseMessaging)`, but `canImport` doesn't see consumer-Podfile pods at this pod's compile time, so the guard silently elided every FCM code path — push registration stopped working on fresh installs. Consumers must enable modular headers in their Podfile:
+  ```ruby
+  use_modular_headers!
+  # or, per-pod:
+  pod 'FirebaseMessaging', :modular_headers => true
+  ```
+
+### Added
+- `DashX.onNotificationClicked(callback)` — fires when the user taps a DashX notification or one of its action buttons. Callback receives `{ notification, action, actionIdentifier }` where `action` is a resolved `NavigationAction` (`deepLink` / `screen` / `richLanding` / `clickAction`) or `null`.
+- `DashXNotificationResponseResult.navigationAction` — new Swift-only field on the helper result type returned by `DashXNotificationHandler.handleNotificationResponse(_:)`.
+- `NotificationClickedEvent` exported from `index.d.ts`.
+
+### Fixed
+- **iOS dev builds silently failing to receive pushes.** `Messaging.messaging().setAPNSToken(_, type: .unknown)` sometimes mis-tagged the APNs environment on dev-signed binaries, producing an FCM token whose pushes 410'd at Apple. The bridge now forces `.sandbox` in `DEBUG` configurations and `.prod` otherwise.
+- **`DashX.setIdentity(uid, token)` now passes `null` / `""` / `undefined` through to the native SDK unchanged** (apart from normalizing `undefined → null`, since the RN bridge can't carry `undefined`). Previously the JS wrapper threw on `null` / `""` / `undefined` for `uid`, contradicting the nullable signatures on iOS (`NSString?`) and Android (`String?`). TypeScript signature updated: `setIdentity(uid: string | null, token?: string | null): void`.
+
+## [1.2.0] — 2026-04-16
+
+Previous release — see git log.

package/DashXReactNative.podspec

@@ -1,7 +1,6 @@
 require "json"
 
 package = JSON.parse(File.read(File.join(__dir__, "package.json")))
-folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'
 
 Pod::Spec.new do |s|
   s.name         = "DashXReactNative"
@@ -17,33 +16,20 @@ Pod::Spec.new do |s|
   s.source_files = "ios/**/*.{h,m,mm,swift}"
   s.requires_arc = true
 
-  # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
-  # See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
-  if respond_to?(:install_modules_dependencies, true)
-    install_modules_dependencies(s)
-  else
-    s.dependency "React-Core"
+  # React Native >= 0.71 provides install_modules_dependencies.
+  # Since our minimum supported RN version is 0.74, we can call it directly.
+  install_modules_dependencies(s)
 
-    # Don't install the dependencies when we run `pod install` in the old architecture.
-    if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
-      s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
-      s.pod_target_xcconfig    = {
-          "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
-          "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
-          "CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
-      }
-      s.dependency "React-Codegen"
-      s.dependency "RCT-Folly"
-      s.dependency "RCTRequired"
-      s.dependency "RCTTypeSafety"
-      s.dependency "ReactCommon/turbomodule/core"
-    end
-  end
-
-  s.dependency "React-RCTAppDelegate"
   # DashX iOS SDK — consumers must provide the source in their Podfile:
-  #   pod 'DashX', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.1.9'
+  #   pod 'DashX/SDK', :git => 'https://github.com/dashxhq/dashx-ios.git', :tag => '1.3.1'
   # For local development:
   #   pod 'DashX', :path => '../dashx-ios'
-  s.dependency "DashX", "~> 1.1.9"
+  s.dependency "DashX/SDK"
+
+  # Hard dependency so that `canImport(FirebaseMessaging)`
+  # evaluates at this pod's compile time, where consumer-Podfile pods aren't
+  # visible — so an "optional" guard silently elides every Firebase code path.
+  # Consumers should set `use_modular_headers!` (or `:modular_headers => true`
+  # on FirebaseMessaging) in their Podfile so this Swift import resolves.
+  s.dependency "FirebaseMessaging"
 end

package/README.md

@@ -26,7 +26,9 @@ _DashX SDK for React Native_
 
 ## Install
 
-Requires **React Native 0.71+**, **iOS 13.0+**, **Android SDK 26+**, and **Node.js 16+**.
+Requires **React Native 0.74+**, **iOS 13.0+**, **Android SDK 26+**, and **Node.js 16+**.
+
+Supports both the **Old Architecture** (bridge) and **New Architecture** (TurboModule) from a single install.
 
 > **Note:** This SDK uses native modules and is **not compatible with Expo Go**. Use a [development build](https://docs.expo.dev/develop/development-builds/introduction/) if you are using Expo.
 

package/__tests__/fallback.test.js

@@ -0,0 +1,72 @@
+const mockNativeModule = {
+  configure: jest.fn(),
+  identify: jest.fn(),
+  setIdentity: jest.fn(),
+  reset: jest.fn(),
+  track: jest.fn(),
+  screen: jest.fn(),
+  fetchRecord: jest.fn(),
+  searchRecords: jest.fn(),
+  fetchStoredPreferences: jest.fn(),
+  saveStoredPreferences: jest.fn(),
+  subscribe: jest.fn(),
+  unsubscribe: jest.fn(),
+  setLogLevel: jest.fn(),
+  uploadAsset: jest.fn(),
+  fetchAsset: jest.fn(),
+  enableLifecycleTracking: jest.fn(),
+  enableAdTracking: jest.fn(),
+  processURL: jest.fn(),
+  trackNotificationNavigation: jest.fn(),
+  requestNotificationPermission: jest.fn(),
+  getNotificationPermissionStatus: jest.fn(),
+  addListener: jest.fn(),
+  removeListeners: jest.fn(),
+};
+
+jest.mock('react-native', () => ({
+  NativeModules: {
+    DashXReactNative: mockNativeModule,
+  },
+  NativeEventEmitter: jest.fn().mockImplementation(() => ({
+    addListener: jest.fn(() => ({ remove: jest.fn() })),
+  })),
+  Platform: {
+    OS: 'ios',
+    select: jest.fn((obj) => obj.default || ''),
+  },
+  TurboModuleRegistry: {
+    get: jest.fn(() => null),
+    getEnforcing: jest.fn(() => {
+      throw new Error('not available');
+    }),
+  },
+}));
+
+// TurboModule returns null -> should fall back to NativeModules
+jest.mock('../src/NativeDashXReactNative', () => ({
+  __esModule: true,
+  default: null,
+}));
+
+const DashX = require('../index').default;
+
+describe('NativeModules fallback', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+  });
+
+  it('falls back to NativeModules.DashXReactNative when TurboModule is null', () => {
+    DashX.configure({ publicKey: 'pk_test' });
+    expect(mockNativeModule.configure).toHaveBeenCalledWith({
+      publicKey: 'pk_test',
+    });
+  });
+
+  it('calls track on the fallback module', () => {
+    DashX.track('event_name', { key: 'value' });
+    expect(mockNativeModule.track).toHaveBeenCalledWith('event_name', {
+      key: 'value',
+    });
+  });
+});

package/__tests__/index.test.js

@@ -37,6 +37,15 @@ jest.mock('react-native', () => ({
     OS: 'ios',
     select: jest.fn((obj) => obj.default || ''),
   },
+  TurboModuleRegistry: {
+    get: jest.fn(() => mockNativeModule),
+    getEnforcing: jest.fn(() => mockNativeModule),
+  },
+}));
+
+jest.mock('../src/NativeDashXReactNative', () => ({
+  __esModule: true,
+  default: mockNativeModule,
 }));
 
 const DashX = require('../index').default;
@@ -97,13 +106,45 @@ describe('setIdentity', () => {
     );
   });
 
-  it('throws if uid is missing', () => {
-    expect(() => DashX.setIdentity(null, 'token')).toThrow('uid is required');
+  it('passes null uid through to native', () => {
+    DashX.setIdentity(null, 'token');
+    expect(mockNativeModule.setIdentity).toHaveBeenCalledWith(null, 'token');
+  });
+
+  it('normalizes undefined uid to null', () => {
+    DashX.setIdentity(undefined, 'token');
+    expect(mockNativeModule.setIdentity).toHaveBeenCalledWith(null, 'token');
+  });
+
+  it('passes empty-string uid through to native without coercing to null', () => {
+    DashX.setIdentity('', 'token');
+    expect(mockNativeModule.setIdentity).toHaveBeenCalledWith('', 'token');
+  });
+
+  it('throws if uid is not a string or null', () => {
+    expect(() => DashX.setIdentity(42, 'token')).toThrow(
+      'uid must be a string or null'
+    );
+  });
+
+  it('passes null token through to native', () => {
+    DashX.setIdentity('uid', null);
+    expect(mockNativeModule.setIdentity).toHaveBeenCalledWith('uid', null);
+  });
+
+  it('passes empty-string token through to native without coercing to null', () => {
+    DashX.setIdentity('uid', '');
+    expect(mockNativeModule.setIdentity).toHaveBeenCalledWith('uid', '');
+  });
+
+  it('passes undefined token as null to native', () => {
+    DashX.setIdentity('uid');
+    expect(mockNativeModule.setIdentity).toHaveBeenCalledWith('uid', null);
   });
 
-  it('throws if token is missing', () => {
-    expect(() => DashX.setIdentity('uid', null)).toThrow(
-      'token is required'
+  it('throws if token is not a string or null', () => {
+    expect(() => DashX.setIdentity('uid', 42)).toThrow(
+      'token must be a string or null'
     );
   });
 });

package/android/build.gradle

@@ -3,6 +3,14 @@ import groovy.json.JsonSlurper
 apply plugin: 'com.android.library'
 apply plugin: 'kotlin-android'
 
+def isNewArchitectureEnabled() {
+    return project.hasProperty("newArchEnabled") && project.newArchEnabled == "true"
+}
+
+if (isNewArchitectureEnabled()) {
+    apply plugin: 'com.facebook.react'
+}
+
 def getVersionFromNpm() {
     def inputFile = new File("../package.json")
     def packageJson = new JsonSlurper().parseText(inputFile.text)
@@ -30,6 +38,16 @@ android {
         abortOnError false
     }
 
+    sourceSets {
+        main {
+            if (isNewArchitectureEnabled()) {
+                java.srcDirs += ['src/newarch/java']
+            } else {
+                java.srcDirs += ['src/oldarch/java']
+            }
+        }
+    }
+
     packaging {
         pickFirst 'lib/arm64-v8a/libc++_shared.so'
         pickFirst 'lib/arm64-v8a/libfbjni.so'
@@ -42,6 +60,14 @@ android {
    }
 }
 
+if (isNewArchitectureEnabled()) {
+    react {
+        jsRootDir = file("../src/")
+        libraryName = "RNDashXReactNativeSpec"
+        codegenJavaPackageName = "com.dashx.rn.sdk"
+    }
+}
+
 repositories {
     mavenCentral()
     google()
@@ -55,5 +81,5 @@ dependencies {
     // Ensure Firebase Messaging types are available for FCM service subclass
     implementation 'com.google.firebase:firebase-messaging-ktx:23.1.2'
 
-    implementation "com.dashx:dashx-android:1.2.4"
+    implementation "com.dashx:dashx-android:1.2.5"
 }

package/android/src/main/AndroidManifest.xml

@@ -1,5 +1,8 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools">
+
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS" />
+
     <application>
         <!-- Replace dashx-android's FCM service with our subclass that also emits to JS. -->
         <service