@dashx/react-native 0.1.21 → 0.1.22

package/android/build/reports/lint-results.html

@@ -173,10 +173,10 @@ document.getElementById(id).style.display = 'none';
 <div class="mdl-layout mdl-js-layout mdl-layout--fixed-header">
   <header class="mdl-layout__header">
     <div class="mdl-layout__header-row">
-      <span class="mdl-layout-title">Lint Report: 1 error and 1 warning</span>
+      <span class="mdl-layout-title">Lint Report: 1 error and 2 warnings</span>
       <div class="mdl-layout-spacer"></div>
       <nav class="mdl-navigation mdl-layout--large-screen-only">
-Check performed at Thu May 12 12:18:17 IST 2022      </nav>
+Check performed at Fri May 13 09:57:23 IST 2022      </nav>
     </div>
   </header>
   <div class="mdl-layout__drawer">
@@ -185,6 +185,7 @@ Check performed at Thu May 12 12:18:17 IST 2022      </nav>
       <a class="mdl-navigation__link" href="#overview"><i class="material-icons">dashboard</i>Overview</a>
       <a class="mdl-navigation__link" href="#InlinedApi"><i class="material-icons warning-icon">warning</i>Using inlined constants on older versions (1)</a>
       <a class="mdl-navigation__link" href="#NewApi"><i class="material-icons error-icon">error</i>Calling new methods on older versions (1)</a>
+      <a class="mdl-navigation__link" href="#GradleDependency"><i class="material-icons warning-icon">warning</i>Obsolete Gradle Dependency (1)</a>
     </nav>
   </div>
   <main class="mdl-layout__content">
@@ -205,6 +206,9 @@ Check performed at Thu May 12 12:18:17 IST 2022      </nav>
 <tr>
 <td class="countColumn">1</td><td class="issueColumn"><i class="material-icons error-icon">error</i>
 <a href="#NewApi">NewApi</a>: Calling new methods on older versions</td></tr>
+<tr>
+<td class="countColumn">1</td><td class="issueColumn"><i class="material-icons warning-icon">warning</i>
+<a href="#GradleDependency">GradleDependency</a>: Obsolete Gradle Dependency</td></tr>
 <tr><td></td><td class="categoryColumn"><a href="#MissingIssues">Disabled Checks (32)</a>
 </td></tr></table>
 <br/>              </div>
@@ -223,13 +227,13 @@ Dismiss</button>            </div>
               <div class="mdl-card__supporting-text">
 <div class="issue">
 <div class="warningslist">
-<span class="location"><a href="../../src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt">../../src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt</a>:107</span>: <span class="message">Field requires API level 23 (current min is 16): <code>android.app.PendingIntent#FLAG_IMMUTABLE</code></span><br /><pre class="errorlines">
-<span class="lineno"> 104 </span>
-<span class="lineno"> 105 </span>  private <span class="keyword">fun</span> getNewPendingIntent(): PendingIntent {
-<span class="lineno"> 106 </span>      <span class="keyword">val</span> context = getApplicationContext()
-<span class="caretline"><span class="lineno"> 107 </span>      <span class="keyword">val</span> pendingIntentFlags = PendingIntent.FLAG_UPDATE_CURRENT or <span class="warning">PendingIntent.FLAG_IMMUTABLE</span>&nbsp;&nbsp;</span>
-<span class="lineno"> 108 </span>
-<span class="lineno"> 109 </span>      <span class="keyword">val</span> intent = getNewBaseIntent()
+<span class="location"><a href="../../src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt">../../src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt</a>:106</span>: <span class="message">Field requires API level 23 (current min is 16): <code>android.app.PendingIntent#FLAG_IMMUTABLE</code></span><br /><pre class="errorlines">
+<span class="lineno"> 103 </span>
+<span class="lineno"> 104 </span>  private <span class="keyword">fun</span> getNewPendingIntent(): PendingIntent {
+<span class="lineno"> 105 </span>      <span class="keyword">val</span> context = getApplicationContext()
+<span class="caretline"><span class="lineno"> 106 </span>      <span class="keyword">val</span> pendingIntentFlags = PendingIntent.FLAG_UPDATE_CURRENT or <span class="warning">PendingIntent.FLAG_IMMUTABLE</span>&nbsp;&nbsp;</span>
+<span class="lineno"> 107 </span>
+<span class="lineno"> 108 </span>      <span class="keyword">val</span> intent = getNewBaseIntent()
 </pre>
 
 </div>
@@ -315,6 +319,52 @@ To suppress this error, use the issue id "NewApi" as explained in the <a href="#
               <div class="mdl-card__actions mdl-card--border">
 <button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationNewApiLink" onclick="reveal('explanationNewApi');">
 Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="NewApiCardLink" onclick="hideid('NewApiCard');">
+Dismiss</button>            </div>
+            </div>
+          </section><a name="GradleDependency"></a>
+<section class="section--center mdl-grid mdl-grid--no-spacing mdl-shadow--2dp" id="GradleDependencyCard" style="display: block;">
+            <div class="mdl-card mdl-cell mdl-cell--12-col">
+  <div class="mdl-card__title">
+    <h2 class="mdl-card__title-text">Obsolete Gradle Dependency</h2>
+  </div>
+              <div class="mdl-card__supporting-text">
+<div class="issue">
+<div class="warningslist">
+<span class="location"><a href="../../build.gradle">../../build.gradle</a>:95</span>: <span class="message">A newer version of com.google.code.gson:gson than 2.8.6 is available: 2.8.9</span><br /><pre class="errorlines">
+<span class="lineno">  92 </span>  implementation <span class="string">'com.facebook.react:react-native:+'</span>   <span class="comment">// From node_modules</span>
+<span class="lineno">  93 </span>  implementation <span class="string">"org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"</span>
+<span class="lineno">  94 </span>
+<span class="caretline"><span class="lineno">  95 </span>  <span class="warning">implementation <span class="string">'com.google.code.gson:gson:2.8.6'</span></span>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</span>
+<span class="lineno">  96 </span>
+<span class="lineno">  97 </span>  <span class="comment">// Import the Firebase BoM (see: https://firebase.google.com/docs/android/learn-more#bom)</span>
+<span class="lineno">  98 </span>  implementation platform(<span class="string">'com.google.firebase:firebase-bom:28.3.0'</span>)
+</pre>
+
+</div>
+<div class="metadata"><div class="explanation" id="explanationGradleDependency" style="display: none;">
+This detector looks for usages of libraries where the version you are using is not the current stable release. Using older versions is fine, and there are cases where you deliberately want to stick with an older version. However, you may simply not be aware that a more recent version is available, and that is what this lint check helps find.<br/>Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.<br>
+To suppress this error, use the issue id "GradleDependency" as explained in the <a href="#SuppressInfo">Suppressing Warnings and Errors</a> section.<br/>
+<br/></div>
+</div>
+</div>
+<div class="chips">
+<span class="mdl-chip">
+    <span class="mdl-chip__text">GradleDependency</span>
+</span>
+<span class="mdl-chip">
+    <span class="mdl-chip__text">Correctness</span>
+</span>
+<span class="mdl-chip">
+    <span class="mdl-chip__text">Warning</span>
+</span>
+<span class="mdl-chip">
+    <span class="mdl-chip__text">Priority 4/10</span>
+</span>
+</div>
+              </div>
+              <div class="mdl-card__actions mdl-card--border">
+<button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="explanationGradleDependencyLink" onclick="reveal('explanationGradleDependency');">
+Explain</button><button class="mdl-button mdl-js-button mdl-js-ripple-effect" id="GradleDependencyCardLink" onclick="hideid('GradleDependencyCard');">
 Dismiss</button>            </div>
             </div>
           </section>

package/android/build/reports/lint-results.xml

@@ -12,8 +12,8 @@
         errorLine1="        val pendingIntentFlags = PendingIntent.FLAG_UPDATE_CURRENT or PendingIntent.FLAG_IMMUTABLE"
         errorLine2="                                                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
         <location
-            file="/Users/amandeepghai/PROJECTS/dashx/dashx-js/packages/react-native/android/src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt"
-            line="107"
+            file="/home/dgulshan/Projects/dashx-js/packages/react-native/android/src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt"
+            line="106"
             column="71"/>
     </issue>
 
@@ -28,9 +28,25 @@
         errorLine1="                content.forEach {"
         errorLine2="                        ~~~~~~~">
         <location
-            file="/Users/amandeepghai/PROJECTS/dashx/dashx-js/packages/react-native/android/src/main/java/com/dashx/rn/sdk/DashXModule.kt"
+            file="/home/dgulshan/Projects/dashx-js/packages/react-native/android/src/main/java/com/dashx/rn/sdk/DashXModule.kt"
             line="138"
             column="25"/>
     </issue>
 
+    <issue
+        id="GradleDependency"
+        severity="Warning"
+        message="A newer version of com.google.code.gson:gson than 2.8.6 is available: 2.8.9"
+        category="Correctness"
+        priority="4"
+        summary="Obsolete Gradle Dependency"
+        explanation="This detector looks for usages of libraries where the version you are using is not the current stable release. Using older versions is fine, and there are cases where you deliberately want to stick with an older version. However, you may simply not be aware that a more recent version is available, and that is what this lint check helps find."
+        errorLine1="  implementation &apos;com.google.code.gson:gson:2.8.6&apos;"
+        errorLine2="  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="/home/dgulshan/Projects/dashx-js/packages/react-native/android/build.gradle"
+            line="95"
+            column="3"/>
+    </issue>
+
 </issues>

package/android/build.gradle

@@ -21,9 +21,6 @@ def safeExtGet(prop, fallback) {
     rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
 }
 
-apply plugin: 'com.android.library'
-apply plugin: 'maven'
-
 buildscript {
   ext.kotlin_version = '1.5.20'
   ext.apollo_version = '2.5.3'
@@ -52,8 +49,8 @@ buildscript {
 }
 
 apply plugin: 'com.android.library'
-apply plugin: 'kotlin-android'
 apply plugin: 'maven'
+apply plugin: 'kotlin-android'
 apply plugin: 'com.apollographql.apollo'
 
 android {
@@ -90,7 +87,7 @@ repositories {
 }
 
 dependencies {
-  implementation 'com.github.dashxhq:dashx-android:main-SNAPSHOT'
+  implementation 'com.github.dashxhq.dashx-android:app:537657701e'
     //noinspection GradleDynamicVersion
   implementation 'com.facebook.react:react-native:+'   // From node_modules
   implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"

package/android/src/main/java/com/dashx/rn/sdk/DashXMessagingService.kt

@@ -69,7 +69,6 @@ class DashXMessagingService : FirebaseMessagingService() {
     }
 
     private fun createNotificationChannel() {
-
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
             val channel = NotificationChannel(
                 CHANNEL_ID,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@dashx/react-native",
   "title": "DashX React Native",
-  "version": "0.1.21",
+  "version": "0.1.22",
   "description": "DashX SDK for React Native",
   "main": "index.js",
   "files": [