@dashforge/tw 0.8.0-beta → 0.9.0-beta

package/src/components/Table/cells/cells.test.tsx

@@ -0,0 +1,247 @@
+// @vitest-environment jsdom
+/**
+ * Unit tests for the Table cell renderer library — `RenderText`,
+ * `RenderTwoLine`, `RenderChip`, `RenderButton`, `RowActionsMenu`.
+ *
+ * Sprint 6 P4 — these shipped in Sprint 4.1 with only integration
+ * coverage (via Table/DataGrid tests). This file exercises them
+ * directly, including the RBAC + edge-case branches.
+ */
+import * as React from 'react';
+import { describe, it, expect, afterEach, beforeAll, vi } from 'vitest';
+import { render, screen, fireEvent, cleanup } from '@testing-library/react';
+import { RenderText } from './RenderText.js';
+import { RenderTwoLine } from './RenderTwoLine.js';
+import { RenderChip } from './RenderChip.js';
+import { RenderButton } from './RenderButton.js';
+import { RowActionsMenu } from './RowActionsMenu.js';
+
+void React;
+afterEach(() => cleanup());
+
+beforeAll(() => {
+  if (typeof globalThis.ResizeObserver === 'undefined') {
+    (globalThis as unknown as { ResizeObserver: unknown }).ResizeObserver =
+      class {
+        observe() {}
+        unobserve() {}
+        disconnect() {}
+      };
+  }
+});
+
+describe('RenderText', () => {
+  it('renders the value in a span', () => {
+    render(<RenderText value="hello" />);
+    expect(screen.getByText('hello').tagName).toBe('SPAN');
+  });
+
+  it('applies the truncate class when truncate is set', () => {
+    render(<RenderText value="long text" truncate />);
+    expect(screen.getByText('long text').className).toContain('truncate');
+  });
+
+  it('applies the muted neutral color when muted is set', () => {
+    render(<RenderText value="dim" muted />);
+    expect(screen.getByText('dim').className).toContain('text-neutral-500');
+  });
+
+  it('merges a custom className', () => {
+    render(<RenderText value="x" className="custom-cls" />);
+    expect(screen.getByText('x').className).toContain('custom-cls');
+  });
+
+  it('renders nothing extra when no flags are set', () => {
+    render(<RenderText value="plain" />);
+    const el = screen.getByText('plain');
+    expect(el.className).not.toContain('truncate');
+    expect(el.className).not.toContain('text-neutral-500');
+  });
+});
+
+describe('RenderTwoLine', () => {
+  it('renders both primary and secondary text', () => {
+    render(<RenderTwoLine primary="Jane Doe" secondary="jane@example.com" />);
+    expect(screen.getByText('Jane Doe')).not.toBeNull();
+    expect(screen.getByText('jane@example.com')).not.toBeNull();
+  });
+
+  it('primary is font-medium, secondary is muted + smaller', () => {
+    render(<RenderTwoLine primary="P" secondary="S" />);
+    expect(screen.getByText('P').className).toContain('font-medium');
+    expect(screen.getByText('S').className).toContain('text-neutral-500');
+  });
+
+  it('merges a custom className on the wrapper', () => {
+    const { container } = render(
+      <RenderTwoLine primary="P" secondary="S" className="twoline-cls" />,
+    );
+    expect(container.firstElementChild?.className).toContain('twoline-cls');
+  });
+});
+
+describe('RenderChip', () => {
+  it('renders children', () => {
+    render(<RenderChip>active</RenderChip>);
+    expect(screen.getByText('active')).not.toBeNull();
+  });
+
+  it('defaults to soft + neutral + sm', () => {
+    render(<RenderChip>x</RenderChip>);
+    // soft neutral → bg-neutral-100
+    expect(screen.getByText('x').className).toContain('bg-neutral-100');
+  });
+
+  it.each(['primary', 'success', 'warning', 'danger', 'info', 'secondary'] as const)(
+    'renders soft variant for the %s intent',
+    (color) => {
+      render(<RenderChip color={color}>{color}</RenderChip>);
+      expect(screen.getByText(color).className).toContain(`bg-${color}-100`);
+    },
+  );
+
+  it('renders the solid variant', () => {
+    render(
+      <RenderChip variant="solid" color="primary">
+        solid
+      </RenderChip>,
+    );
+    expect(screen.getByText('solid').className).toContain('bg-primary-500');
+  });
+
+  it('renders the outline variant', () => {
+    render(
+      <RenderChip variant="outline" color="danger">
+        outline
+      </RenderChip>,
+    );
+    expect(screen.getByText('outline').className).toContain('border-danger-500');
+  });
+
+  it('renders the md size', () => {
+    render(
+      <RenderChip size="md">md</RenderChip>,
+    );
+    expect(screen.getByText('md').className).toContain('h-6');
+  });
+
+  it('merges a custom className', () => {
+    render(<RenderChip className="chip-cls">x</RenderChip>);
+    expect(screen.getByText('x').className).toContain('chip-cls');
+  });
+});
+
+describe('RenderButton', () => {
+  it('renders the label inside a button', () => {
+    render(<RenderButton label="Edit" />);
+    expect(screen.getByRole('button', { name: 'Edit' })).not.toBeNull();
+  });
+
+  it('fires onClick when clicked', () => {
+    const onClick = vi.fn();
+    render(<RenderButton label="Go" onClick={onClick} />);
+    fireEvent.click(screen.getByRole('button', { name: 'Go' }));
+    expect(onClick).toHaveBeenCalledTimes(1);
+  });
+
+  it('honors the disabled prop', () => {
+    const onClick = vi.fn();
+    render(<RenderButton label="Nope" onClick={onClick} disabled />);
+    const btn = screen.getByRole('button', { name: 'Nope' }) as HTMLButtonElement;
+    expect(btn.disabled).toBe(true);
+    fireEvent.click(btn);
+    expect(onClick).not.toHaveBeenCalled();
+  });
+});
+
+describe('RowActionsMenu', () => {
+  interface Row {
+    id: string;
+  }
+  const row: Row = { id: 'r1' };
+
+  it('renders the default 3-dot trigger', () => {
+    render(
+      <RowActionsMenu
+        row={row}
+        actions={[{ label: 'Edit', onClick: () => {} }]}
+      />,
+    );
+    expect(screen.getByRole('button', { name: 'Row actions' })).not.toBeNull();
+  });
+
+  it('returns null when there are no visible actions', () => {
+    const { container } = render(
+      <RowActionsMenu row={row} actions={[]} />,
+    );
+    expect(container.innerHTML).toBe('');
+  });
+
+  it('opens the menu and renders the action items', () => {
+    render(
+      <RowActionsMenu
+        row={row}
+        actions={[
+          { label: 'Edit', onClick: () => {} },
+          { label: 'Delete', onClick: () => {}, color: 'danger' },
+        ]}
+      />,
+    );
+    fireEvent.click(screen.getByRole('button', { name: 'Row actions' }));
+    expect(screen.getByRole('menuitem', { name: 'Edit' })).not.toBeNull();
+    expect(screen.getByRole('menuitem', { name: 'Delete' })).not.toBeNull();
+  });
+
+  it('invokes the action onClick with the row', () => {
+    const onClick = vi.fn();
+    render(
+      <RowActionsMenu row={row} actions={[{ label: 'Edit', onClick }]} />,
+    );
+    fireEvent.click(screen.getByRole('button', { name: 'Row actions' }));
+    fireEvent.click(screen.getByRole('menuitem', { name: 'Edit' }));
+    expect(onClick).toHaveBeenCalledWith(row);
+  });
+
+  it('filters out actions whose RBAC says hide', () => {
+    render(
+      <RowActionsMenu
+        row={row}
+        actions={[
+          { label: 'Edit', onClick: () => {} },
+          {
+            label: 'SecretDelete',
+            onClick: () => {},
+            access: { onUnauthorized: 'hide' },
+          },
+        ]}
+      />,
+    );
+    fireEvent.click(screen.getByRole('button', { name: 'Row actions' }));
+    expect(screen.queryByRole('menuitem', { name: 'Edit' })).not.toBeNull();
+    expect(screen.queryByRole('menuitem', { name: 'SecretDelete' })).toBeNull();
+  });
+
+  it('renders a disabled action item when action.disabled is set', () => {
+    render(
+      <RowActionsMenu
+        row={row}
+        actions={[{ label: 'Edit', onClick: () => {}, disabled: true }]}
+      />,
+    );
+    fireEvent.click(screen.getByRole('button', { name: 'Row actions' }));
+    const item = screen.getByRole('menuitem', { name: 'Edit' }) as HTMLButtonElement;
+    expect(item.disabled).toBe(true);
+  });
+
+  it('uses a custom trigger when provided', () => {
+    render(
+      <RowActionsMenu
+        row={row}
+        actions={[{ label: 'Edit', onClick: () => {} }]}
+        trigger={<button type="button">custom-trigger</button>}
+      />,
+    );
+    expect(screen.getByRole('button', { name: 'custom-trigger' })).not.toBeNull();
+    expect(screen.queryByRole('button', { name: 'Row actions' })).toBeNull();
+  });
+});

package/src/components/Table/table.types.ts

@@ -258,7 +258,14 @@ export type TableRowSelectionMode = 'none' | 'single' | 'multiple';
  */
 export interface TableLabels {
   searchPlaceholder?: string;
+  /** Shown when the dataset itself is empty (0 input rows). */
   noData?: string;
+  /**
+   * Shown when the dataset has rows but an active search / filter
+   * excluded them all. Distinct from `noData` so the user can tell
+   * "nothing here" from "nothing matches your query".
+   */
+  noResults?: string;
   loading?: string;
   ariaSortNone?: string;
   ariaSortAscending?: string;
@@ -288,13 +295,11 @@ export interface TableLabels {
   densityCompact?: string;
   densityComfortable?: string;
   densitySpacious?: string;
-  /** Column visibility dialog. */
+  /** Column visibility menu (Popover-based, auto-commit). */
   columnsButton?: string;
   columnsTitle?: string;
-  columnsDescription?: string;
-  columnsShowAll?: string;
-  columnsHideAll?: string;
-  columnsDone?: string;
+  /** Aria-label for the tri-state show/hide-all master checkbox. */
+  columnsToggleAll?: string;
 }
 
 // ───── Slot props ─────
@@ -355,7 +360,25 @@ export interface TableProps<T extends object>
   // ───── Data ─────
   rows: T[];
   cols: TableColumn<T>[];
-  /** Stable row id resolver. Default: positional index. */
+  /**
+   * Stable row-id resolver — the React key + the identity used by
+   * selection and row-expansion state.
+   *
+   * **Strongly recommended whenever sort / search / selection /
+   * expandable rows are used.** The default falls back to the
+   * positional index (`String(index)`); once rows reorder (sort) or
+   * change presence (search / filter), index `2` points at a
+   * *different* row, so selection and expansion state silently jump
+   * to the wrong rows. Pass a value derived from the data itself:
+   *
+   * ```tsx
+   * <Table getRowId={(row) => row.id} … />
+   * ```
+   *
+   * Dashforge emits a `console.warn` in development when `getRowId`
+   * is omitted and one of those features is active. (`<DataGrid>`
+   * makes this prop required for the same reason.)
+   */
   getRowId?: (row: T, index: number) => string;
 
   // ───── Sort ─────

package/src/components/Typography/Typography.test.tsx

@@ -84,6 +84,21 @@ describe('<Typography>', () => {
       const { container } = render(<Typography color="inherit">x</Typography>);
       expect(container.firstElementChild?.className).toContain('text-inherit');
     });
+
+    it('defaults to color="neutral" (text-neutral-900, NOT text-inherit)', () => {
+      // Sprint 6 P5 fix — a bare <Typography> must emit the
+      // auto-inverting neutral token, not inherit the consumer's
+      // arbitrary root colour (which broke dark-mode consistency).
+      const { container } = render(<Typography>x</Typography>);
+      const cls = container.firstElementChild?.className ?? '';
+      expect(cls).toContain('text-neutral-900');
+      expect(cls).not.toContain('text-inherit');
+    });
+
+    it('color="muted" emits text-neutral-600', () => {
+      const { container } = render(<Typography color="muted">x</Typography>);
+      expect(container.firstElementChild?.className).toContain('text-neutral-600');
+    });
   });
 
   // ─── Override semantics ─────────────────────────────────────────────

package/src/components/Typography/typography.variants.ts

@@ -55,6 +55,15 @@ export const typographyVariants = tv({
      * paints white text).
      */
     color: {
+      // `inherit` is the explicit escape hatch — use it on a
+      // `<Typography>` inside a coloured surface (e.g.
+      // `<Box variant="solid" color="primary">` paints white text)
+      // so the text picks up the surface colour. It is NO LONGER the
+      // default: a bare `<Typography>` would otherwise inherit the
+      // consuming app's arbitrary root colour (often OS-`prefers-
+      // color-scheme` driven), which diverges from the Dashforge
+      // `data-dash-tw-theme` mode and breaks colour consistency in
+      // dark mode. The default is now `neutral` — see `defaultVariants`.
       inherit:   'text-inherit',
       primary:   'text-primary-700 dark:text-primary-400',
       secondary: 'text-secondary-700 dark:text-secondary-400',
@@ -109,7 +118,11 @@ export const typographyVariants = tv({
 
   defaultVariants: {
     variant: 'body1',
-    color:   'inherit',
+    // `neutral` (not `inherit`): a bare `<Typography>` emits
+    // `text-neutral-900`, which auto-inverts via the dashforgePreset()
+    // CSS-var swap and follows the Dashforge mode. Pass
+    // `color="inherit"` explicitly inside a coloured surface.
+    color:   'neutral',
     align:   'left',
   },
 });

package/test-output/vitest/coverage/base.css

@@ -0,0 +1,224 @@
+body, html {
+  margin:0; padding: 0;
+  height: 100%;
+}
+body {
+    font-family: Helvetica Neue, Helvetica, Arial;
+    font-size: 14px;
+    color:#333;
+}
+.small { font-size: 12px; }
+*, *:after, *:before {
+  -webkit-box-sizing:border-box;
+     -moz-box-sizing:border-box;
+          box-sizing:border-box;
+  }
+h1 { font-size: 20px; margin: 0;}
+h2 { font-size: 14px; }
+pre {
+    font: 12px/1.4 Consolas, "Liberation Mono", Menlo, Courier, monospace;
+    margin: 0;
+    padding: 0;
+    -moz-tab-size: 2;
+    -o-tab-size:  2;
+    tab-size: 2;
+}
+a { color:#0074D9; text-decoration:none; }
+a:hover { text-decoration:underline; }
+.strong { font-weight: bold; }
+.space-top1 { padding: 10px 0 0 0; }
+.pad2y { padding: 20px 0; }
+.pad1y { padding: 10px 0; }
+.pad2x { padding: 0 20px; }
+.pad2 { padding: 20px; }
+.pad1 { padding: 10px; }
+.space-left2 { padding-left:55px; }
+.space-right2 { padding-right:20px; }
+.center { text-align:center; }
+.clearfix { display:block; }
+.clearfix:after {
+  content:'';
+  display:block;
+  height:0;
+  clear:both;
+  visibility:hidden;
+  }
+.fl { float: left; }
+@media only screen and (max-width:640px) {
+  .col3 { width:100%; max-width:100%; }
+  .hide-mobile { display:none!important; }
+}
+
+.quiet {
+  color: #7f7f7f;
+  color: rgba(0,0,0,0.5);
+}
+.quiet a { opacity: 0.7; }
+
+.fraction {
+  font-family: Consolas, 'Liberation Mono', Menlo, Courier, monospace;
+  font-size: 10px;
+  color: #555;
+  background: #E8E8E8;
+  padding: 4px 5px;
+  border-radius: 3px;
+  vertical-align: middle;
+}
+
+div.path a:link, div.path a:visited { color: #333; }
+table.coverage {
+  border-collapse: collapse;
+  margin: 10px 0 0 0;
+  padding: 0;
+}
+
+table.coverage td {
+  margin: 0;
+  padding: 0;
+  vertical-align: top;
+}
+table.coverage td.line-count {
+    text-align: right;
+    padding: 0 5px 0 20px;
+}
+table.coverage td.line-coverage {
+    text-align: right;
+    padding-right: 10px;
+    min-width:20px;
+}
+
+table.coverage td span.cline-any {
+    display: inline-block;
+    padding: 0 5px;
+    width: 100%;
+}
+.missing-if-branch {
+    display: inline-block;
+    margin-right: 5px;
+    border-radius: 3px;
+    position: relative;
+    padding: 0 4px;
+    background: #333;
+    color: yellow;
+}
+
+.skip-if-branch {
+    display: none;
+    margin-right: 10px;
+    position: relative;
+    padding: 0 4px;
+    background: #ccc;
+    color: white;
+}
+.missing-if-branch .typ, .skip-if-branch .typ {
+    color: inherit !important;
+}
+.coverage-summary {
+  border-collapse: collapse;
+  width: 100%;
+}
+.coverage-summary tr { border-bottom: 1px solid #bbb; }
+.keyline-all { border: 1px solid #ddd; }
+.coverage-summary td, .coverage-summary th { padding: 10px; }
+.coverage-summary tbody { border: 1px solid #bbb; }
+.coverage-summary td { border-right: 1px solid #bbb; }
+.coverage-summary td:last-child { border-right: none; }
+.coverage-summary th {
+  text-align: left;
+  font-weight: normal;
+  white-space: nowrap;
+}
+.coverage-summary th.file { border-right: none !important; }
+.coverage-summary th.pct { }
+.coverage-summary th.pic,
+.coverage-summary th.abs,
+.coverage-summary td.pct,
+.coverage-summary td.abs { text-align: right; }
+.coverage-summary td.file { white-space: nowrap;  }
+.coverage-summary td.pic { min-width: 120px !important;  }
+.coverage-summary tfoot td { }
+
+.coverage-summary .sorter {
+    height: 10px;
+    width: 7px;
+    display: inline-block;
+    margin-left: 0.5em;
+    background: url(sort-arrow-sprite.png) no-repeat scroll 0 0 transparent;
+}
+.coverage-summary .sorted .sorter {
+    background-position: 0 -20px;
+}
+.coverage-summary .sorted-desc .sorter {
+    background-position: 0 -10px;
+}
+.status-line {  height: 10px; }
+/* yellow */
+.cbranch-no { background: yellow !important; color: #111; }
+/* dark red */
+.red.solid, .status-line.low, .low .cover-fill { background:#C21F39 }
+.low .chart { border:1px solid #C21F39 }
+.highlighted,
+.highlighted .cstat-no, .highlighted .fstat-no, .highlighted .cbranch-no{
+  background: #C21F39 !important;
+}
+/* medium red */
+.cstat-no, .fstat-no, .cbranch-no, .cbranch-no { background:#F6C6CE }
+/* light red */
+.low, .cline-no { background:#FCE1E5 }
+/* light green */
+.high, .cline-yes { background:rgb(230,245,208) }
+/* medium green */
+.cstat-yes { background:rgb(161,215,106) }
+/* dark green */
+.status-line.high, .high .cover-fill { background:rgb(77,146,33) }
+.high .chart { border:1px solid rgb(77,146,33) }
+/* dark yellow (gold) */
+.status-line.medium, .medium .cover-fill { background: #f9cd0b; }
+.medium .chart { border:1px solid #f9cd0b; }
+/* light yellow */
+.medium { background: #fff4c2; }
+
+.cstat-skip { background: #ddd; color: #111; }
+.fstat-skip { background: #ddd; color: #111 !important; }
+.cbranch-skip { background: #ddd !important; color: #111; }
+
+span.cline-neutral { background: #eaeaea; }
+
+.coverage-summary td.empty {
+    opacity: .5;
+    padding-top: 4px;
+    padding-bottom: 4px;
+    line-height: 1;
+    color: #888;
+}
+
+.cover-fill, .cover-empty {
+  display:inline-block;
+  height: 12px;
+}
+.chart {
+  line-height: 0;
+}
+.cover-empty {
+    background: white;
+}
+.cover-full {
+    border-right: none !important;
+}
+pre.prettyprint {
+    border: none !important;
+    padding: 0 !important;
+    margin: 0 !important;
+}
+.com { color: #999 !important; }
+.ignore-none { color: #999; font-weight: normal; }
+
+.wrapper {
+  min-height: 100%;
+  height: auto !important;
+  height: 100%;
+  margin: 0 auto -48px;
+}
+.footer, .push {
+  height: 48px;
+}

package/test-output/vitest/coverage/block-navigation.js

@@ -0,0 +1,87 @@
+/* eslint-disable */
+var jumpToCode = (function init() {
+    // Classes of code we would like to highlight in the file view
+    var missingCoverageClasses = ['.cbranch-no', '.cstat-no', '.fstat-no'];
+
+    // Elements to highlight in the file listing view
+    var fileListingElements = ['td.pct.low'];
+
+    // We don't want to select elements that are direct descendants of another match
+    var notSelector = ':not(' + missingCoverageClasses.join('):not(') + ') > '; // becomes `:not(a):not(b) > `
+
+    // Selector that finds elements on the page to which we can jump
+    var selector =
+        fileListingElements.join(', ') +
+        ', ' +
+        notSelector +
+        missingCoverageClasses.join(', ' + notSelector); // becomes `:not(a):not(b) > a, :not(a):not(b) > b`
+
+    // The NodeList of matching elements
+    var missingCoverageElements = document.querySelectorAll(selector);
+
+    var currentIndex;
+
+    function toggleClass(index) {
+        missingCoverageElements
+            .item(currentIndex)
+            .classList.remove('highlighted');
+        missingCoverageElements.item(index).classList.add('highlighted');
+    }
+
+    function makeCurrent(index) {
+        toggleClass(index);
+        currentIndex = index;
+        missingCoverageElements.item(index).scrollIntoView({
+            behavior: 'smooth',
+            block: 'center',
+            inline: 'center'
+        });
+    }
+
+    function goToPrevious() {
+        var nextIndex = 0;
+        if (typeof currentIndex !== 'number' || currentIndex === 0) {
+            nextIndex = missingCoverageElements.length - 1;
+        } else if (missingCoverageElements.length > 1) {
+            nextIndex = currentIndex - 1;
+        }
+
+        makeCurrent(nextIndex);
+    }
+
+    function goToNext() {
+        var nextIndex = 0;
+
+        if (
+            typeof currentIndex === 'number' &&
+            currentIndex < missingCoverageElements.length - 1
+        ) {
+            nextIndex = currentIndex + 1;
+        }
+
+        makeCurrent(nextIndex);
+    }
+
+    return function jump(event) {
+        if (
+            document.getElementById('fileSearch') === document.activeElement &&
+            document.activeElement != null
+        ) {
+            // if we're currently focused on the search input, we don't want to navigate
+            return;
+        }
+
+        switch (event.which) {
+            case 78: // n
+            case 74: // j
+                goToNext();
+                break;
+            case 66: // b
+            case 75: // k
+            case 80: // p
+                goToPrevious();
+                break;
+        }
+    };
+})();
+window.addEventListener('keydown', jumpToCode);