@dashevo/wasm-dpp 0.25.0-dev.8 → 0.25.0-pr.1545.2

package/src/identity/state_transition/identity_public_key_transitions.rs

@@ -1,17 +1,21 @@
 //todo: move this file to transition
-use dpp::dashcore::anyhow;
-use dpp::document::document_transition::document_base_transition::JsonValue;
-use dpp::identity::state_transition::identity_public_key_transitions::IdentityPublicKeyInCreationWithWitness;
-use dpp::platform_value::BinaryData;
-use dpp::Convertible;
+use dpp::platform_value::{BinaryData, ReplacementType, Value};
+use dpp::serialization::ValueConvertible;
+use dpp::state_transition::public_key_in_creation::accessors::{
+    IdentityPublicKeyInCreationV0Getters, IdentityPublicKeyInCreationV0Setters,
+};
+use dpp::state_transition::public_key_in_creation::v0::BINARY_DATA_FIELDS;
+use dpp::state_transition::public_key_in_creation::IdentityPublicKeyInCreation;
+use js_sys::Reflect::delete_property;
 pub use serde::{Deserialize, Serialize};
-use std::convert::{TryFrom, TryInto};
+use serde_json::Value as JsonValue;
+use std::convert::TryInto;
 use wasm_bindgen::prelude::*;
 
 use crate::errors::from_dpp_err;
 use crate::utils::WithJsError;
 use crate::{buffer::Buffer, utils, with_js_error};
-
+use dpp::version::PlatformVersion;
 #[derive(Deserialize, Default)]
 #[serde(rename_all = "camelCase")]
 struct ToObjectOptions {
@@ -20,98 +24,104 @@ struct ToObjectOptions {
 
 #[wasm_bindgen(js_name=IdentityPublicKeyWithWitness)]
 #[derive(Serialize, Deserialize, Debug, Clone)]
-pub struct IdentityPublicKeyWithWitnessWasm(IdentityPublicKeyInCreationWithWitness);
+pub struct IdentityPublicKeyWithWitnessWasm(IdentityPublicKeyInCreation);
 
 #[wasm_bindgen(js_class = IdentityPublicKeyWithWitness)]
 impl IdentityPublicKeyWithWitnessWasm {
     #[wasm_bindgen(constructor)]
-    pub fn new(raw_public_key: JsValue) -> Result<IdentityPublicKeyWithWitnessWasm, JsValue> {
-        let data_string = utils::stringify(&raw_public_key)?;
-        let value: JsonValue = serde_json::from_str(&data_string).map_err(|e| e.to_string())?;
-
-        let pk = IdentityPublicKeyInCreationWithWitness::from_json_object(value).with_js_error()?;
+    pub fn new(platform_version: u32) -> Result<IdentityPublicKeyWithWitnessWasm, JsValue> {
+        let platform_version =
+            &PlatformVersion::get(platform_version).map_err(|e| JsValue::from(e.to_string()))?;
 
-        Ok(IdentityPublicKeyWithWitnessWasm(pk))
+        IdentityPublicKeyInCreation::default_versioned(&platform_version)
+            .map(Into::into)
+            .map_err(from_dpp_err)
     }
 
     #[wasm_bindgen(js_name=getId)]
     pub fn get_id(&self) -> u32 {
-        self.0.id
+        self.0.id()
     }
 
     #[wasm_bindgen(js_name=setId)]
     pub fn set_id(&mut self, id: u32) {
-        self.0.id = id;
+        self.0.set_id(id);
     }
 
     #[wasm_bindgen(js_name=getType)]
     pub fn get_type(&self) -> u8 {
-        self.0.key_type as u8
+        self.0.key_type() as u8
     }
 
     #[wasm_bindgen(js_name=setType)]
     pub fn set_type(&mut self, key_type: u8) -> Result<(), JsValue> {
-        self.0.key_type = key_type
-            .try_into()
-            .map_err(|e: anyhow::Error| e.to_string())?;
+        self.0.set_type(
+            key_type
+                .try_into()
+                .map_err(|e: anyhow::Error| e.to_string())?,
+        );
         Ok(())
     }
 
     #[wasm_bindgen(js_name=setData)]
     pub fn set_data(&mut self, data: Vec<u8>) -> Result<(), JsValue> {
-        self.0.data = BinaryData::new(data);
+        self.0.set_data(BinaryData::new(data));
         Ok(())
     }
 
     #[wasm_bindgen(js_name=getData)]
     pub fn get_data(&self) -> Buffer {
-        Buffer::from_bytes_owned(self.0.data.to_vec())
+        Buffer::from_bytes_owned(self.0.data().to_vec())
     }
 
     #[wasm_bindgen(js_name=setPurpose)]
     pub fn set_purpose(&mut self, purpose: u8) -> Result<(), JsValue> {
-        self.0.purpose = purpose
-            .try_into()
-            .map_err(|e: anyhow::Error| e.to_string())?;
+        self.0.set_purpose(
+            purpose
+                .try_into()
+                .map_err(|e: anyhow::Error| e.to_string())?,
+        );
         Ok(())
     }
 
     #[wasm_bindgen(js_name=getPurpose)]
     pub fn get_purpose(&self) -> u8 {
-        self.0.purpose as u8
+        self.0.purpose() as u8
     }
 
     #[wasm_bindgen(js_name=setSecurityLevel)]
     pub fn set_security_level(&mut self, security_level: u8) -> Result<(), JsValue> {
-        self.0.security_level = security_level
-            .try_into()
-            .map_err(|e: anyhow::Error| e.to_string())?;
+        self.0.set_security_level(
+            security_level
+                .try_into()
+                .map_err(|e: anyhow::Error| e.to_string())?,
+        );
         Ok(())
     }
 
     #[wasm_bindgen(js_name=getSecurityLevel)]
     pub fn get_security_level(&self) -> u8 {
-        self.0.security_level as u8
+        self.0.security_level() as u8
     }
 
     #[wasm_bindgen(js_name=setReadOnly)]
     pub fn set_read_only(&mut self, read_only: bool) {
-        self.0.read_only = read_only;
+        self.0.set_read_only(read_only);
     }
 
     #[wasm_bindgen(js_name=isReadOnly)]
     pub fn is_read_only(&self) -> bool {
-        self.0.read_only
+        self.0.read_only()
     }
 
     #[wasm_bindgen(js_name=setSignature)]
     pub fn set_signature(&mut self, signature: Vec<u8>) {
-        self.0.signature = BinaryData::new(signature)
+        self.0.set_signature(BinaryData::new(signature))
     }
 
     #[wasm_bindgen(js_name=getSignature)]
     pub fn get_signature(&self) -> Vec<u8> {
-        self.0.signature.to_vec()
+        self.0.signature().to_vec()
     }
 
     #[wasm_bindgen(js_name=hash)]
@@ -119,35 +129,33 @@ impl IdentityPublicKeyWithWitnessWasm {
         self.0.hash_as_vec().with_js_error()
     }
 
-    #[wasm_bindgen(js_name=isMaster)]
-    pub fn is_master(&self) -> bool {
-        self.0.is_master()
-    }
-
     #[wasm_bindgen(js_name=toJSON)]
     pub fn to_json(&self) -> Result<JsValue, JsValue> {
-        let val = self.0.to_json().map_err(from_dpp_err)?;
-        let json = val.to_string();
+        let mut value = self.0.to_object().map_err(from_dpp_err)?;
+
+        value
+            .replace_at_paths(
+                dpp::identity::identity_public_key::BINARY_DATA_FIELDS,
+                ReplacementType::TextBase64,
+            )
+            .map_err(|e| e.to_string())?;
+
+        let json = value
+            .try_into_validating_json()
+            .map_err(|e| e.to_string())?
+            .to_string();
+
         js_sys::JSON::parse(&json)
     }
 
     #[wasm_bindgen(js_name=toObject)]
-    pub fn to_object(&self, options: JsValue) -> Result<JsValue, JsValue> {
-        let opts: ToObjectOptions = if options.is_object() {
-            with_js_error!(serde_wasm_bindgen::from_value(options))?
-        } else {
-            Default::default()
-        };
-
-        let val = self
-            .0
-            .to_raw_json_object(opts.skip_signature.unwrap_or(false))
-            .map_err(|e| from_dpp_err(e.into()))?;
+    pub fn to_object(&self, skip_signature: bool) -> Result<JsValue, JsValue> {
+        let value = self.0.to_object().map_err(from_dpp_err)?;
 
-        let data_buffer = Buffer::from_bytes(self.0.data.as_slice());
+        let data_buffer = Buffer::from_bytes(self.0.data().as_slice());
 
-        let json = val.to_string();
-        let js_object = js_sys::JSON::parse(&json)?;
+        let serializer = serde_wasm_bindgen::Serializer::json_compatible();
+        let js_object = with_js_error!(value.serialize(&serializer))?;
 
         js_sys::Reflect::set(
             &js_object,
@@ -161,12 +169,17 @@ impl IdentityPublicKeyWithWitnessWasm {
             &JsValue::from(data_buffer),
         )?;
 
-        if !opts.skip_signature.unwrap_or(false) && !self.0.signature.is_empty() {
+        if !skip_signature {
+            let signature_buffer = Buffer::from_bytes(self.0.signature().as_slice());
             js_sys::Reflect::set(
                 &js_object,
                 &JsValue::from_str("signature"),
-                &JsValue::from(Buffer::from_bytes_owned(self.0.signature.to_vec())),
+                &JsValue::from(signature_buffer),
             )?;
+        } else {
+            let js_object = js_sys::Object::from(js_object);
+            delete_property(&js_object, &JsValue::from_str("signature"))?;
+            return Ok(js_object.into());
         }
 
         Ok(js_object)
@@ -174,38 +187,39 @@ impl IdentityPublicKeyWithWitnessWasm {
 }
 
 impl IdentityPublicKeyWithWitnessWasm {
-    pub fn into_inner(self) -> IdentityPublicKeyInCreationWithWitness {
+    pub fn into_inner(self) -> IdentityPublicKeyInCreation {
         self.0
     }
 
-    pub fn inner(&self) -> &IdentityPublicKeyInCreationWithWitness {
+    pub fn inner(&self) -> &IdentityPublicKeyInCreation {
         &self.0
     }
 
-    pub fn inner_mut(&mut self) -> &mut IdentityPublicKeyInCreationWithWitness {
+    pub fn inner_mut(&mut self) -> &mut IdentityPublicKeyInCreation {
         &mut self.0
     }
 }
 
-impl From<IdentityPublicKeyInCreationWithWitness> for IdentityPublicKeyWithWitnessWasm {
-    fn from(v: IdentityPublicKeyInCreationWithWitness) -> Self {
+impl From<IdentityPublicKeyInCreation> for IdentityPublicKeyWithWitnessWasm {
+    fn from(v: IdentityPublicKeyInCreation) -> Self {
         IdentityPublicKeyWithWitnessWasm(v)
     }
 }
 
-impl TryFrom<JsValue> for IdentityPublicKeyWithWitnessWasm {
-    type Error = JsValue;
-
-    fn try_from(value: JsValue) -> Result<Self, Self::Error> {
-        let str = String::from(js_sys::JSON::stringify(&value)?);
-        let val = serde_json::from_str(&str).map_err(|e| from_dpp_err(e.into()))?;
-        Ok(Self(
-            IdentityPublicKeyInCreationWithWitness::from_raw_json_object(val).with_js_error()?,
-        ))
-    }
-}
-
-impl From<IdentityPublicKeyWithWitnessWasm> for IdentityPublicKeyInCreationWithWitness {
+// TODO(versioning): restore
+// impl TryFrom<JsValue> for IdentityPublicKeyWithWitnessWasm {
+//     type Error = JsValue;
+//
+//     fn try_from(value: JsValue) -> Result<Self, Self::Error> {
+//         let str = String::from(js_sys::JSON::stringify(&value)?);
+//         let val = serde_json::from_str(&str).map_err(|e| from_dpp_err(e.into()))?;
+//         Ok(Self(
+//             IdentityPublicKeyInCreation::from_raw_json_object(val).with_js_error()?,
+//         ))
+//     }
+// }
+
+impl From<IdentityPublicKeyWithWitnessWasm> for IdentityPublicKeyInCreation {
     fn from(pk: IdentityPublicKeyWithWitnessWasm) -> Self {
         pk.0
     }

package/src/identity/state_transition/identity_topup_transition/identity_topup_transition.rs

@@ -1,34 +1,37 @@
-use crate::utils::{ToSerdeJSONExt, WithJsError};
+use crate::utils::WithJsError;
 
-use std::convert::TryInto;
 use std::default::Default;
 
+use crate::bls_adapter::{BlsAdapter, JsBlsAdapter};
+use crate::errors::from_dpp_err;
+use dpp::identity::state_transition::AssetLockProved;
+use dpp::identity::KeyType;
+use dpp::platform_value::BinaryData;
+use dpp::serialization::ValueConvertible;
+use dpp::state_transition::identity_topup_transition::fields::IDENTIFIER_FIELDS;
+use dpp::version::PlatformVersion;
+use serde_json::Value as JsonValue;
 use wasm_bindgen::prelude::*;
 
 use crate::identifier::IdentifierWrapper;
 
 use crate::{
     buffer::Buffer,
-    create_asset_lock_proof_from_wasm_instance,
-    errors::RustConversionError,
     identity::state_transition::asset_lock_proof::{
         ChainAssetLockProofWasm, InstantAssetLockProofWasm,
     },
-    with_js_error,
+    utils, with_js_error,
 };
 
-use crate::bls_adapter::{BlsAdapter, JsBlsAdapter};
-
-use crate::errors::from_dpp_err;
-use dpp::identity::KeyType;
+use crate::identity::state_transition::create_asset_lock_proof_from_wasm_instance;
 use dpp::platform_value::string_encoding::Encoding;
-use dpp::platform_value::{string_encoding, BinaryData};
-use dpp::state_transition::StateTransitionConvert;
+use dpp::platform_value::{string_encoding, ReplacementType, Value};
+use dpp::serialization::PlatformSerializable;
+use dpp::state_transition::identity_topup_transition::accessors::IdentityTopUpTransitionAccessorsV0;
+use dpp::state_transition::identity_topup_transition::IdentityTopUpTransition;
+use dpp::state_transition::StateTransition;
 use dpp::{
-    identifier::Identifier,
-    identity::state_transition::{
-        asset_lock_proof::AssetLockProof, identity_topup_transition::IdentityTopUpTransition,
-    },
+    identifier::Identifier, identity::state_transition::asset_lock_proof::AssetLockProof,
     state_transition::StateTransitionLike,
 };
 
@@ -51,23 +54,20 @@ impl From<IdentityTopUpTransitionWasm> for IdentityTopUpTransition {
 #[wasm_bindgen(js_class = IdentityTopUpTransition)]
 impl IdentityTopUpTransitionWasm {
     #[wasm_bindgen(constructor)]
-    pub fn new(raw_parameters: JsValue) -> Result<IdentityTopUpTransitionWasm, JsValue> {
-        let raw_state_transition = raw_parameters.with_serde_to_platform_value()?;
-
-        let identity_topup_transition =
-            IdentityTopUpTransition::from_raw_object(raw_state_transition)
-                .map_err(|e| RustConversionError::Error(e.to_string()).to_js_value())?;
+    pub fn new(platform_version: u32) -> Result<IdentityTopUpTransitionWasm, JsValue> {
+        let platform_version =
+            &PlatformVersion::get(platform_version).map_err(|e| JsValue::from(e.to_string()))?;
 
-        Ok(identity_topup_transition.into())
+        IdentityTopUpTransition::default_versioned(&platform_version)
+            .map(Into::into)
+            .map_err(from_dpp_err)
     }
 
     #[wasm_bindgen(js_name=setAssetLockProof)]
     pub fn set_asset_lock_proof(&mut self, asset_lock_proof: JsValue) -> Result<(), JsValue> {
         let asset_lock_proof = create_asset_lock_proof_from_wasm_instance(&asset_lock_proof)?;
 
-        self.0
-            .set_asset_lock_proof(asset_lock_proof)
-            .map_err(|e| RustConversionError::Error(e.to_string()).to_js_value())?;
+        self.0.set_asset_lock_proof(asset_lock_proof);
 
         Ok(())
     }
@@ -79,7 +79,7 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=getAssetLockProof)]
     pub fn get_asset_lock_proof(&self) -> JsValue {
-        let asset_lock_proof = self.0.get_asset_lock_proof().to_owned();
+        let asset_lock_proof = self.0.asset_lock_proof().to_owned();
 
         match asset_lock_proof {
             AssetLockProof::Chain(chain_asset_lock_proof) => {
@@ -93,7 +93,7 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=getType)]
     pub fn get_type(&self) -> u8 {
-        self.0.get_type() as u8
+        self.0.state_transition_type() as u8
     }
 
     #[wasm_bindgen(getter, js_name=identityId)]
@@ -103,23 +103,28 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=getIdentityId)]
     pub fn get_identity_id(&self) -> IdentifierWrapper {
-        (*self.0.get_identity_id()).into()
+        (*self.0.identity_id()).into()
+    }
+
+    #[wasm_bindgen(js_name=setIdentityId)]
+    pub fn set_identity_id(&mut self, identity_id: &IdentifierWrapper) {
+        self.0.set_identity_id(identity_id.to_owned().into());
     }
 
     #[wasm_bindgen(js_name=getOwnerId)]
     pub fn get_owner_id(&self) -> IdentifierWrapper {
-        (*self.0.get_owner_id()).into()
+        self.0.owner_id().to_owned().into()
     }
 
     #[wasm_bindgen(js_name=toObject)]
     pub fn to_object(&self, options: JsValue) -> Result<JsValue, JsValue> {
         let opts: super::to_object::ToObjectOptions = if options.is_object() {
-            with_js_error!(serde_wasm_bindgen::from_value(options))?
+            with_js_error!(serde_wasm_bindgen::from_value(options.clone()))?
         } else {
             Default::default()
         };
 
-        let object = super::to_object::to_object_struct(&self.0, opts);
+        let object = super::to_object::to_object_struct(&self.0, &opts);
         let js_object = js_sys::Object::new();
 
         js_sys::Reflect::set(
@@ -128,11 +133,11 @@ impl IdentityTopUpTransitionWasm {
             &object.transition_type.into(),
         )?;
 
-        js_sys::Reflect::set(
-            &js_object,
-            &"protocolVersion".to_owned().into(),
-            &object.protocol_version.into(),
-        )?;
+        let version = match self.0 {
+            IdentityTopUpTransition::V0(_) => "0",
+        };
+
+        js_sys::Reflect::set(&js_object, &"$version".to_owned().into(), &version.into())?;
 
         if let Some(signature) = object.signature {
             let signature_value: JsValue = if signature.is_empty() {
@@ -169,24 +174,17 @@ impl IdentityTopUpTransitionWasm {
     }
 
     #[wasm_bindgen(js_name=toBuffer)]
-    pub fn to_buffer(&self, options: JsValue) -> Result<JsValue, JsValue> {
-        let opts: super::to_object::ToObjectOptions = if options.is_object() {
-            with_js_error!(serde_wasm_bindgen::from_value(options))?
-        } else {
-            Default::default()
-        };
-
-        let buffer = self
-            .0
-            .to_cbor_buffer(opts.skip_signature.unwrap_or(false))
-            .map_err(from_dpp_err)?;
-
-        Ok(Buffer::from_bytes(&buffer).into())
+    pub fn to_buffer(&self) -> Result<Buffer, JsValue> {
+        let bytes = PlatformSerializable::serialize_to_bytes(&StateTransition::IdentityTopUp(
+            self.0.clone(),
+        ))
+        .with_js_error()?;
+        Ok(Buffer::from_bytes(&bytes))
     }
 
     #[wasm_bindgen(js_name=toJSON)]
     pub fn to_json(&self) -> Result<JsValue, JsValue> {
-        let object = super::to_object::to_object_struct(&self.0, Default::default());
+        let object = super::to_object::to_object_struct(&self.0, &Default::default());
         let js_object = js_sys::Object::new();
 
         js_sys::Reflect::set(
@@ -195,12 +193,6 @@ impl IdentityTopUpTransitionWasm {
             &object.transition_type.into(),
         )?;
 
-        js_sys::Reflect::set(
-            &js_object,
-            &"protocolVersion".to_owned().into(),
-            &object.protocol_version.into(),
-        )?;
-
         if let Some(signature) = object.signature {
             let signature_value: JsValue = if signature.is_empty() {
                 JsValue::undefined()
@@ -211,6 +203,12 @@ impl IdentityTopUpTransitionWasm {
             js_sys::Reflect::set(&js_object, &"signature".to_owned().into(), &signature_value)?;
         }
 
+        let version = match self.0 {
+            IdentityTopUpTransition::V0(_) => "0",
+        };
+
+        js_sys::Reflect::set(&js_object, &"$version".to_owned().into(), &version.into())?;
+
         let asset_lock_proof_json = match object.asset_lock_proof {
             AssetLockProof::Instant(instant_asset_lock_proof) => {
                 InstantAssetLockProofWasm::from(instant_asset_lock_proof).to_json()?
@@ -238,8 +236,8 @@ impl IdentityTopUpTransitionWasm {
     }
 
     #[wasm_bindgen(js_name=getModifiedDataIds)]
-    pub fn get_modified_data_ids(&self) -> Vec<JsValue> {
-        let ids = self.0.get_modified_data_ids();
+    pub fn modified_data_ids(&self) -> Vec<JsValue> {
+        let ids = self.0.modified_data_ids();
 
         ids.into_iter()
             .map(|id| <IdentifierWrapper as std::convert::From<Identifier>>::from(id).into())
@@ -285,18 +283,26 @@ impl IdentityTopUpTransitionWasm {
             BlsAdapter(JsValue::undefined().into())
         };
 
-        self.0
+        // TODO: not the best approach because it involves cloning the transition
+        // Probably it worth to return `sign_by_private_key` per state transition
+        let mut wrapper = StateTransition::IdentityTopUp(self.0.clone());
+        wrapper
             .sign_by_private_key(private_key.as_slice(), key_type, &bls_adapter)
-            .with_js_error()
+            .with_js_error()?;
+
+        self.0.set_signature(wrapper.signature().to_owned());
+
+        Ok(())
     }
 
     #[wasm_bindgen(js_name=getSignature)]
     pub fn get_signature(&self) -> Buffer {
-        Buffer::from_bytes(self.0.get_signature().as_slice())
+        Buffer::from_bytes(self.0.signature().as_slice())
     }
 
     #[wasm_bindgen(js_name=setSignature)]
     pub fn set_signature(&mut self, signature: Option<Vec<u8>>) {
-        self.0.signature = BinaryData::new(signature.unwrap_or(vec![]))
+        self.0
+            .set_signature(BinaryData::new(signature.unwrap_or(vec![])))
     }
 }

package/src/identity/state_transition/identity_topup_transition/identity_topup_transition_basic_validator.rs

@@ -4,8 +4,6 @@ use dpp::identity::state_transition::asset_lock_proof::{
 };
 use dpp::identity::state_transition::identity_topup_transition::validation::basic::IdentityTopUpTransitionBasicValidator;
 
-use dpp::state_transition::state_transition_execution_context::StateTransitionExecutionContext;
-
 use dpp::version::{ProtocolVersionValidator, COMPATIBILITY_MAP, LATEST_VERSION};
 use dpp::ProtocolError;
 

package/src/identity/state_transition/identity_topup_transition/mod.rs

@@ -1,8 +1,8 @@
 pub use identity_topup_transition::*;
 
-pub mod apply_identity_topup_transition;
+// pub mod apply_identity_topup_transition;
 pub mod identity_topup_transition;
-pub mod identity_topup_transition_basic_validator;
-pub mod identity_topup_transition_state_validator;
+// pub mod identity_topup_transition_basic_validator;
+// pub mod identity_topup_transition_state_validator;
 
 mod to_object;

package/src/identity/state_transition/identity_topup_transition/to_object.rs

@@ -1,9 +1,8 @@
 use dpp::identity::state_transition::asset_lock_proof::AssetLockProof;
-use dpp::{
-    identifier::Identifier,
-    identity::state_transition::identity_topup_transition::IdentityTopUpTransition,
-    state_transition::StateTransitionLike,
-};
+use dpp::identity::state_transition::AssetLockProved;
+use dpp::state_transition::identity_topup_transition::accessors::IdentityTopUpTransitionAccessorsV0;
+use dpp::state_transition::identity_topup_transition::IdentityTopUpTransition;
+use dpp::{identifier::Identifier, state_transition::StateTransitionLike};
 use serde::Deserialize;
 use std::default::Default;
 
@@ -16,7 +15,6 @@ pub struct ToObjectOptions {
 #[derive(Default)]
 pub struct ToObject {
     pub transition_type: u8,
-    pub protocol_version: u32,
     pub identity_id: Identifier,
     pub asset_lock_proof: AssetLockProof,
     pub signature: Option<Vec<u8>>,
@@ -24,18 +22,17 @@ pub struct ToObject {
 
 pub fn to_object_struct(
     transition: &IdentityTopUpTransition,
-    options: ToObjectOptions,
+    options: &ToObjectOptions,
 ) -> ToObject {
     let mut to_object = ToObject {
-        transition_type: transition.get_type() as u8,
-        protocol_version: transition.get_protocol_version(),
-        identity_id: *transition.get_identity_id(),
-        asset_lock_proof: transition.get_asset_lock_proof().to_owned(),
+        transition_type: transition.state_transition_type() as u8,
+        identity_id: *transition.identity_id(),
+        asset_lock_proof: transition.asset_lock_proof().to_owned(),
         signature: None,
     };
 
     if !options.skip_signature.unwrap_or(false) {
-        to_object.signature = Some(transition.get_signature().to_vec());
+        to_object.signature = Some(transition.signature().to_vec());
     }
 
     to_object

package/src/identity/state_transition/identity_update_transition/identity_update_public_keys_validator.rs

@@ -2,7 +2,7 @@ use crate::errors::from_dpp_err;
 use crate::identity::state_transition::identity_public_key_transitions::IdentityPublicKeyWithWitnessWasm;
 use crate::utils::WithJsError;
 use crate::validation::ValidationResultWasm;
-use dpp::identity::state_transition::identity_public_key_transitions::IdentityPublicKeyInCreationWithWitness;
+use dpp::identity::state_transition::identity_public_key_transitions::IdentityPublicKeyInCreation;
 use dpp::identity::state_transition::identity_update_transition::validate_public_keys::IdentityUpdatePublicKeysValidator;
 use dpp::identity::validation::TPublicKeysValidator;
 use dpp::platform_value::Value;
@@ -31,7 +31,7 @@ impl IdentityUpdatePublicKeysValidatorWasm {
         let public_keys = raw_public_keys
             .into_iter()
             .map(|raw_key| {
-                let parsed_key: IdentityPublicKeyInCreationWithWitness =
+                let parsed_key: IdentityPublicKeyInCreation =
                     IdentityPublicKeyWithWitnessWasm::new(raw_key)?.into();
 
                 parsed_key.to_raw_object(false).with_js_error()