@dashevo/wasm-dpp 0.25.0-dev.16 → 0.25.0-dev.17

package/src/identity/state_transition/identity_topup_transition/identity_topup_transition.rs

@@ -1,34 +1,36 @@
-use crate::utils::{ToSerdeJSONExt, WithJsError};
+use crate::utils::WithJsError;
 
-use std::convert::TryInto;
 use std::default::Default;
 
+use crate::bls_adapter::{BlsAdapter, JsBlsAdapter};
+use crate::errors::from_dpp_err;
+use dpp::identity::KeyType;
+use dpp::platform_value::BinaryData;
+use dpp::serialization::ValueConvertible;
+use dpp::state_transition::identity_topup_transition::fields::IDENTIFIER_FIELDS;
+use dpp::version::PlatformVersion;
+use serde_json::Value as JsonValue;
 use wasm_bindgen::prelude::*;
 
 use crate::identifier::IdentifierWrapper;
 
 use crate::{
     buffer::Buffer,
-    create_asset_lock_proof_from_wasm_instance,
-    errors::RustConversionError,
     identity::state_transition::asset_lock_proof::{
         ChainAssetLockProofWasm, InstantAssetLockProofWasm,
     },
-    with_js_error,
+    utils, with_js_error,
 };
 
-use crate::bls_adapter::{BlsAdapter, JsBlsAdapter};
-
-use dpp::identity::KeyType;
+use crate::identity::state_transition::create_asset_lock_proof_from_wasm_instance;
 use dpp::platform_value::string_encoding::Encoding;
-use dpp::platform_value::{string_encoding, BinaryData};
-use dpp::serialization_traits::PlatformSerializable;
+use dpp::platform_value::{string_encoding, ReplacementType, Value};
+use dpp::serialization::PlatformSerializable;
+use dpp::state_transition::identity_topup_transition::accessors::IdentityTopUpTransitionAccessorsV0;
+use dpp::state_transition::identity_topup_transition::IdentityTopUpTransition;
 use dpp::state_transition::StateTransition;
 use dpp::{
-    identifier::Identifier,
-    identity::state_transition::{
-        asset_lock_proof::AssetLockProof, identity_topup_transition::IdentityTopUpTransition,
-    },
+    identifier::Identifier, identity::state_transition::asset_lock_proof::AssetLockProof,
     state_transition::StateTransitionLike,
 };
 
@@ -51,23 +53,20 @@ impl From<IdentityTopUpTransitionWasm> for IdentityTopUpTransition {
 #[wasm_bindgen(js_class = IdentityTopUpTransition)]
 impl IdentityTopUpTransitionWasm {
     #[wasm_bindgen(constructor)]
-    pub fn new(raw_parameters: JsValue) -> Result<IdentityTopUpTransitionWasm, JsValue> {
-        let raw_state_transition = raw_parameters.with_serde_to_platform_value()?;
-
-        let identity_topup_transition =
-            IdentityTopUpTransition::from_raw_object(raw_state_transition)
-                .map_err(|e| RustConversionError::Error(e.to_string()).to_js_value())?;
+    pub fn new(platform_version: u32) -> Result<IdentityTopUpTransitionWasm, JsValue> {
+        let platform_version =
+            &PlatformVersion::get(platform_version).map_err(|e| JsValue::from(e.to_string()))?;
 
-        Ok(identity_topup_transition.into())
+        IdentityTopUpTransition::default_versioned(&platform_version)
+            .map(Into::into)
+            .map_err(from_dpp_err)
     }
 
     #[wasm_bindgen(js_name=setAssetLockProof)]
     pub fn set_asset_lock_proof(&mut self, asset_lock_proof: JsValue) -> Result<(), JsValue> {
         let asset_lock_proof = create_asset_lock_proof_from_wasm_instance(&asset_lock_proof)?;
 
-        self.0
-            .set_asset_lock_proof(asset_lock_proof)
-            .map_err(|e| RustConversionError::Error(e.to_string()).to_js_value())?;
+        self.0.set_asset_lock_proof(asset_lock_proof);
 
         Ok(())
     }
@@ -79,7 +78,7 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=getAssetLockProof)]
     pub fn get_asset_lock_proof(&self) -> JsValue {
-        let asset_lock_proof = self.0.get_asset_lock_proof().to_owned();
+        let asset_lock_proof = self.0.asset_lock_proof().to_owned();
 
         match asset_lock_proof {
             AssetLockProof::Chain(chain_asset_lock_proof) => {
@@ -93,7 +92,7 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=getType)]
     pub fn get_type(&self) -> u8 {
-        self.0.get_type() as u8
+        self.0.state_transition_type() as u8
     }
 
     #[wasm_bindgen(getter, js_name=identityId)]
@@ -103,23 +102,28 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=getIdentityId)]
     pub fn get_identity_id(&self) -> IdentifierWrapper {
-        (*self.0.get_identity_id()).into()
+        (*self.0.identity_id()).into()
+    }
+
+    #[wasm_bindgen(js_name=setIdentityId)]
+    pub fn set_identity_id(&mut self, identity_id: &IdentifierWrapper) {
+        self.0.set_identity_id(identity_id.to_owned().into());
     }
 
     #[wasm_bindgen(js_name=getOwnerId)]
     pub fn get_owner_id(&self) -> IdentifierWrapper {
-        (*self.0.get_owner_id()).into()
+        self.0.owner_id().to_owned().into()
     }
 
     #[wasm_bindgen(js_name=toObject)]
     pub fn to_object(&self, options: JsValue) -> Result<JsValue, JsValue> {
         let opts: super::to_object::ToObjectOptions = if options.is_object() {
-            with_js_error!(serde_wasm_bindgen::from_value(options))?
+            with_js_error!(serde_wasm_bindgen::from_value(options.clone()))?
         } else {
             Default::default()
         };
 
-        let object = super::to_object::to_object_struct(&self.0, opts);
+        let object = super::to_object::to_object_struct(&self.0, &opts);
         let js_object = js_sys::Object::new();
 
         js_sys::Reflect::set(
@@ -128,11 +132,11 @@ impl IdentityTopUpTransitionWasm {
             &object.transition_type.into(),
         )?;
 
-        js_sys::Reflect::set(
-            &js_object,
-            &"protocolVersion".to_owned().into(),
-            &object.protocol_version.into(),
-        )?;
+        let version = match self.0 {
+            IdentityTopUpTransition::V0(_) => "0",
+        };
+
+        js_sys::Reflect::set(&js_object, &"$version".to_owned().into(), &version.into())?;
 
         if let Some(signature) = object.signature {
             let signature_value: JsValue = if signature.is_empty() {
@@ -170,15 +174,16 @@ impl IdentityTopUpTransitionWasm {
 
     #[wasm_bindgen(js_name=toBuffer)]
     pub fn to_buffer(&self) -> Result<Buffer, JsValue> {
-        let bytes =
-            PlatformSerializable::serialize(&StateTransition::IdentityTopUp(self.0.clone()))
-                .with_js_error()?;
+        let bytes = PlatformSerializable::serialize_to_bytes(&StateTransition::IdentityTopUp(
+            self.0.clone(),
+        ))
+        .with_js_error()?;
         Ok(Buffer::from_bytes(&bytes))
     }
 
     #[wasm_bindgen(js_name=toJSON)]
     pub fn to_json(&self) -> Result<JsValue, JsValue> {
-        let object = super::to_object::to_object_struct(&self.0, Default::default());
+        let object = super::to_object::to_object_struct(&self.0, &Default::default());
         let js_object = js_sys::Object::new();
 
         js_sys::Reflect::set(
@@ -187,12 +192,6 @@ impl IdentityTopUpTransitionWasm {
             &object.transition_type.into(),
         )?;
 
-        js_sys::Reflect::set(
-            &js_object,
-            &"protocolVersion".to_owned().into(),
-            &object.protocol_version.into(),
-        )?;
-
         if let Some(signature) = object.signature {
             let signature_value: JsValue = if signature.is_empty() {
                 JsValue::undefined()
@@ -203,6 +202,12 @@ impl IdentityTopUpTransitionWasm {
             js_sys::Reflect::set(&js_object, &"signature".to_owned().into(), &signature_value)?;
         }
 
+        let version = match self.0 {
+            IdentityTopUpTransition::V0(_) => "0",
+        };
+
+        js_sys::Reflect::set(&js_object, &"$version".to_owned().into(), &version.into())?;
+
         let asset_lock_proof_json = match object.asset_lock_proof {
             AssetLockProof::Instant(instant_asset_lock_proof) => {
                 InstantAssetLockProofWasm::from(instant_asset_lock_proof).to_json()?
@@ -230,8 +235,8 @@ impl IdentityTopUpTransitionWasm {
     }
 
     #[wasm_bindgen(js_name=getModifiedDataIds)]
-    pub fn get_modified_data_ids(&self) -> Vec<JsValue> {
-        let ids = self.0.get_modified_data_ids();
+    pub fn modified_data_ids(&self) -> Vec<JsValue> {
+        let ids = self.0.modified_data_ids();
 
         ids.into_iter()
             .map(|id| <IdentifierWrapper as std::convert::From<Identifier>>::from(id).into())
@@ -277,18 +282,26 @@ impl IdentityTopUpTransitionWasm {
             BlsAdapter(JsValue::undefined().into())
         };
 
-        self.0
+        // TODO: not the best approach because it involves cloning the transition
+        // Probably it worth to return `sign_by_private_key` per state transition
+        let mut wrapper = StateTransition::IdentityTopUp(self.0.clone());
+        wrapper
             .sign_by_private_key(private_key.as_slice(), key_type, &bls_adapter)
-            .with_js_error()
+            .with_js_error()?;
+
+        self.0.set_signature(wrapper.signature().to_owned());
+
+        Ok(())
     }
 
     #[wasm_bindgen(js_name=getSignature)]
     pub fn get_signature(&self) -> Buffer {
-        Buffer::from_bytes(self.0.get_signature().as_slice())
+        Buffer::from_bytes(self.0.signature().as_slice())
     }
 
     #[wasm_bindgen(js_name=setSignature)]
     pub fn set_signature(&mut self, signature: Option<Vec<u8>>) {
-        self.0.signature = BinaryData::new(signature.unwrap_or(vec![]))
+        self.0
+            .set_signature(BinaryData::new(signature.unwrap_or(vec![])))
     }
 }

package/src/identity/state_transition/identity_topup_transition/identity_topup_transition_basic_validator.rs

@@ -4,8 +4,6 @@ use dpp::identity::state_transition::asset_lock_proof::{
 };
 use dpp::identity::state_transition::identity_topup_transition::validation::basic::IdentityTopUpTransitionBasicValidator;
 
-use dpp::state_transition::state_transition_execution_context::StateTransitionExecutionContext;
-
 use dpp::version::{ProtocolVersionValidator, COMPATIBILITY_MAP, LATEST_VERSION};
 use dpp::ProtocolError;
 

package/src/identity/state_transition/identity_topup_transition/mod.rs

@@ -1,8 +1,8 @@
 pub use identity_topup_transition::*;
 
-pub mod apply_identity_topup_transition;
+// pub mod apply_identity_topup_transition;
 pub mod identity_topup_transition;
-pub mod identity_topup_transition_basic_validator;
-pub mod identity_topup_transition_state_validator;
+// pub mod identity_topup_transition_basic_validator;
+// pub mod identity_topup_transition_state_validator;
 
 mod to_object;

package/src/identity/state_transition/identity_topup_transition/to_object.rs

@@ -1,9 +1,7 @@
 use dpp::identity::state_transition::asset_lock_proof::AssetLockProof;
-use dpp::{
-    identifier::Identifier,
-    identity::state_transition::identity_topup_transition::IdentityTopUpTransition,
-    state_transition::StateTransitionLike,
-};
+use dpp::state_transition::identity_topup_transition::accessors::IdentityTopUpTransitionAccessorsV0;
+use dpp::state_transition::identity_topup_transition::IdentityTopUpTransition;
+use dpp::{identifier::Identifier, state_transition::StateTransitionLike};
 use serde::Deserialize;
 use std::default::Default;
 
@@ -16,7 +14,6 @@ pub struct ToObjectOptions {
 #[derive(Default)]
 pub struct ToObject {
     pub transition_type: u8,
-    pub protocol_version: u32,
     pub identity_id: Identifier,
     pub asset_lock_proof: AssetLockProof,
     pub signature: Option<Vec<u8>>,
@@ -24,18 +21,17 @@ pub struct ToObject {
 
 pub fn to_object_struct(
     transition: &IdentityTopUpTransition,
-    options: ToObjectOptions,
+    options: &ToObjectOptions,
 ) -> ToObject {
     let mut to_object = ToObject {
-        transition_type: transition.get_type() as u8,
-        protocol_version: transition.get_protocol_version(),
-        identity_id: *transition.get_identity_id(),
-        asset_lock_proof: transition.get_asset_lock_proof().to_owned(),
+        transition_type: transition.state_transition_type() as u8,
+        identity_id: *transition.identity_id(),
+        asset_lock_proof: transition.asset_lock_proof().to_owned(),
         signature: None,
     };
 
     if !options.skip_signature.unwrap_or(false) {
-        to_object.signature = Some(transition.get_signature().to_vec());
+        to_object.signature = Some(transition.signature().to_vec());
     }
 
     to_object

package/src/identity/state_transition/identity_update_transition/identity_update_transition.rs

@@ -1,36 +1,40 @@
 use std::convert::TryInto;
 use std::default::Default;
 
-use dpp::consensus::signature::SignatureError;
 use serde::{Deserialize, Serialize};
+use serde_json::Value as JsonValue;
 use wasm_bindgen::__rt::Ref;
 use wasm_bindgen::prelude::*;
 
 use crate::identifier::IdentifierWrapper;
 
 use crate::{
-    buffer::Buffer, errors::RustConversionError,
+    buffer::Buffer,
     identity::state_transition::identity_public_key_transitions::IdentityPublicKeyWithWitnessWasm,
-    identity::IdentityPublicKeyWasm, with_js_error,
+    identity::IdentityPublicKeyWasm, utils, with_js_error,
 };
 
 use crate::bls_adapter::{BlsAdapter, JsBlsAdapter};
 
 use crate::utils::{generic_of_js_val, WithJsError};
 
-use dpp::consensus::ConsensusError;
-use dpp::identity::state_transition::identity_public_key_transitions::IdentityPublicKeyInCreation;
+use crate::errors::from_dpp_err;
+use dpp::errors::consensus::signature::SignatureError;
+use dpp::errors::consensus::ConsensusError;
+use dpp::errors::ProtocolError;
 use dpp::identity::{KeyID, KeyType, TimestampMillis};
 use dpp::platform_value::string_encoding::Encoding;
-use dpp::platform_value::{string_encoding, BinaryData, Value};
+use dpp::platform_value::{string_encoding, BinaryData, ReplacementType, Value};
 use dpp::prelude::Revision;
-use dpp::serialization_traits::PlatformSerializable;
-use dpp::state_transition::{StateTransition, StateTransitionIdentitySigned};
-use dpp::{
-    identifier::Identifier,
-    identity::state_transition::identity_update_transition::identity_update_transition::IdentityUpdateTransition,
-    platform_value, state_transition::StateTransitionLike, ProtocolError,
-};
+use dpp::serialization::PlatformSerializable;
+use dpp::serialization::ValueConvertible;
+use dpp::state_transition::identity_update_transition::accessors::IdentityUpdateTransitionAccessorsV0;
+use dpp::state_transition::identity_update_transition::IdentityUpdateTransition;
+use dpp::state_transition::public_key_in_creation::IdentityPublicKeyInCreation;
+use dpp::state_transition::StateTransition;
+use dpp::state_transition::StateTransitionIdentitySigned;
+use dpp::version::PlatformVersion;
+use dpp::{identifier::Identifier, state_transition::StateTransitionLike};
 
 #[wasm_bindgen(js_name=IdentityUpdateTransition)]
 #[derive(Clone)]
@@ -61,29 +65,23 @@ impl From<IdentityUpdateTransitionWasm> for IdentityUpdateTransition {
     }
 }
 
-pub fn js_value_to_identity_update_transition_object(object: JsValue) -> Result<Value, JsValue> {
-    let parameters: IdentityUpdateTransitionParams =
-        with_js_error!(serde_wasm_bindgen::from_value(object))?;
-
-    platform_value::to_value(parameters).map_err(|e| e.to_string().into())
-}
+// pub fn js_value_to_identity_update_transition_object(object: JsValue) -> Result<Value, JsValue> {
+//     let parameters: IdentityUpdateTransitionParams =
+//         with_js_error!(serde_wasm_bindgen::from_value(object))?;
+//
+//     platform_value::to_value(parameters).map_err(|e| e.to_string().into())
+// }
 
 #[wasm_bindgen(js_class = IdentityUpdateTransition)]
 impl IdentityUpdateTransitionWasm {
     #[wasm_bindgen(constructor)]
-    pub fn new(raw_parameters: JsValue) -> Result<IdentityUpdateTransitionWasm, JsValue> {
-        let mut identity_update_transition_object =
-            js_value_to_identity_update_transition_object(raw_parameters)?;
-
-        IdentityUpdateTransition::clean_value(&mut identity_update_transition_object)
-            .map_err(ProtocolError::ValueError)
-            .with_js_error()?;
+    pub fn new(platform_version: u32) -> Result<IdentityUpdateTransitionWasm, JsValue> {
+        let platform_version =
+            &PlatformVersion::get(platform_version).map_err(|e| JsValue::from(e.to_string()))?;
 
-        let identity_update_transition =
-            IdentityUpdateTransition::new(identity_update_transition_object)
-                .map_err(|e| RustConversionError::Error(e.to_string()).to_js_value())?;
-
-        Ok(identity_update_transition.into())
+        IdentityUpdateTransition::default_versioned(&platform_version)
+            .map(Into::into)
+            .map_err(from_dpp_err)
     }
 
     #[wasm_bindgen(js_name=setPublicKeysToAdd)]
@@ -114,7 +112,7 @@ impl IdentityUpdateTransitionWasm {
     #[wasm_bindgen(js_name=getPublicKeysToAdd)]
     pub fn get_public_keys_add(&self) -> Vec<JsValue> {
         self.0
-            .get_public_keys_to_add()
+            .public_keys_to_add()
             .iter()
             .map(|key| IdentityPublicKeyWithWitnessWasm::from(key.to_owned()).into())
             .collect()
@@ -128,7 +126,7 @@ impl IdentityUpdateTransitionWasm {
     #[wasm_bindgen(js_name=getPublicKeyIdsToDisable)]
     pub fn get_public_key_ids_to_disable(&self) -> Vec<JsValue> {
         self.0
-            .get_public_key_ids_to_disable()
+            .public_key_ids_to_disable()
             .iter()
             .map(|key| JsValue::from_f64(key.to_owned() as f64))
             .collect()
@@ -150,7 +148,7 @@ impl IdentityUpdateTransitionWasm {
     #[wasm_bindgen(js_name=getPublicKeysDisabledAt)]
     pub fn get_public_keys_disabled_at(&self) -> Option<js_sys::Date> {
         self.0
-            .get_public_keys_disabled_at()
+            .public_keys_disabled_at()
             .map(|timestamp| js_sys::Date::new(&JsValue::from_f64(timestamp as f64)))
     }
 
@@ -166,7 +164,7 @@ impl IdentityUpdateTransitionWasm {
 
     #[wasm_bindgen(js_name=getType)]
     pub fn get_type(&self) -> u8 {
-        self.0.get_type() as u8
+        self.0.state_transition_type() as u8
     }
 
     #[wasm_bindgen(getter, js_name=identityId)]
@@ -176,7 +174,7 @@ impl IdentityUpdateTransitionWasm {
 
     #[wasm_bindgen(js_name=getIdentityId)]
     pub fn get_identity_id(&self) -> IdentifierWrapper {
-        (*self.0.get_identity_id()).into()
+        self.0.identity_id().to_owned().into()
     }
 
     #[wasm_bindgen(js_name=setIdentityId)]
@@ -186,7 +184,7 @@ impl IdentityUpdateTransitionWasm {
 
     #[wasm_bindgen(js_name=getOwnerId)]
     pub fn get_owner_id(&self) -> IdentifierWrapper {
-        (*self.0.get_owner_id()).into()
+        StateTransitionLike::owner_id(&self.0).to_owned().into()
     }
 
     #[wasm_bindgen(js_name=toObject)]
@@ -197,7 +195,7 @@ impl IdentityUpdateTransitionWasm {
             Default::default()
         };
 
-        let object = super::to_object::to_object_struct(&self.0, opts);
+        let object = super::to_object::to_object_struct(&self.0, &opts);
         let js_object = js_sys::Object::new();
 
         js_sys::Reflect::set(
@@ -206,11 +204,11 @@ impl IdentityUpdateTransitionWasm {
             &object.transition_type.into(),
         )?;
 
-        js_sys::Reflect::set(
-            &js_object,
-            &"protocolVersion".to_owned().into(),
-            &object.protocol_version.into(),
-        )?;
+        let version = match self.0 {
+            IdentityUpdateTransition::V0(_) => "0",
+        };
+
+        js_sys::Reflect::set(&js_object, &"$version".to_owned().into(), &version.into())?;
 
         js_sys::Reflect::set(
             &js_object,
@@ -227,33 +225,28 @@ impl IdentityUpdateTransitionWasm {
 
             js_sys::Reflect::set(&js_object, &"signature".to_owned().into(), &signature_value)?;
 
-            if let Some(signature_public_key_id) = object.signature_public_key_id {
-                js_sys::Reflect::set(
-                    &js_object,
-                    &"signaturePublicKeyId".to_owned().into(),
-                    &JsValue::from(signature_public_key_id),
-                )?;
-            } else {
-                js_sys::Reflect::set(
-                    &js_object,
-                    &"signaturePublicKeyId".to_owned().into(),
-                    &JsValue::undefined(),
-                )?;
-            }
+            js_sys::Reflect::set(
+                &js_object,
+                &"signaturePublicKeyId".to_owned().into(),
+                &JsValue::from(object.signature_public_key_id),
+            )?;
         }
 
         if let Some(timestamp) = object.public_keys_disabled_at {
             js_sys::Reflect::set(
                 &js_object,
                 &"publicKeysDisabledAt".to_owned().into(),
-                &(timestamp as u32).into(),
+                &js_sys::Date::new(&JsValue::from_f64(timestamp as f64)).into(),
             )?;
         }
 
         if let Some(public_keys_to_add) = object.public_keys_to_add {
             let keys_objects = public_keys_to_add
                 .into_iter()
-                .map(|key| IdentityPublicKeyWithWitnessWasm::from(key).to_object(options.clone()))
+                .map(|key| {
+                    IdentityPublicKeyWithWitnessWasm::from(key)
+                        .to_object(opts.skip_signature.unwrap_or(false))
+                })
                 .collect::<Result<js_sys::Array, _>>()?;
 
             js_sys::Reflect::set(
@@ -287,15 +280,16 @@ impl IdentityUpdateTransitionWasm {
 
     #[wasm_bindgen(js_name=toBuffer)]
     pub fn to_buffer(&self) -> Result<Buffer, JsValue> {
-        let bytes =
-            PlatformSerializable::serialize(&StateTransition::IdentityUpdate(self.0.clone()))
-                .with_js_error()?;
+        let bytes = PlatformSerializable::serialize_to_bytes(&StateTransition::IdentityUpdate(
+            self.0.clone(),
+        ))
+        .with_js_error()?;
         Ok(Buffer::from_bytes(&bytes))
     }
 
     #[wasm_bindgen(js_name=toJSON)]
     pub fn to_json(&self) -> Result<JsValue, JsValue> {
-        let object = super::to_object::to_object_struct(&self.0, Default::default());
+        let object = super::to_object::to_object_struct(&self.0, &Default::default());
         let js_object = js_sys::Object::new();
 
         js_sys::Reflect::set(
@@ -304,11 +298,11 @@ impl IdentityUpdateTransitionWasm {
             &object.transition_type.into(),
         )?;
 
-        js_sys::Reflect::set(
-            &js_object,
-            &"protocolVersion".to_owned().into(),
-            &object.protocol_version.into(),
-        )?;
+        let version = match self.0 {
+            IdentityUpdateTransition::V0(_) => "0",
+        };
+
+        js_sys::Reflect::set(&js_object, &"$version".to_owned().into(), &version.into())?;
 
         js_sys::Reflect::set(
             &js_object,
@@ -325,26 +319,18 @@ impl IdentityUpdateTransitionWasm {
 
             js_sys::Reflect::set(&js_object, &"signature".to_owned().into(), &signature_value)?;
 
-            if let Some(signature_public_key_id) = object.signature_public_key_id {
-                js_sys::Reflect::set(
-                    &js_object,
-                    &"signaturePublicKeyId".to_owned().into(),
-                    &signature_public_key_id.into(),
-                )?;
-            } else {
-                js_sys::Reflect::set(
-                    &js_object,
-                    &"signaturePublicKeyId".to_owned().into(),
-                    &JsValue::undefined(),
-                )?;
-            }
+            js_sys::Reflect::set(
+                &js_object,
+                &"signaturePublicKeyId".to_owned().into(),
+                &object.signature_public_key_id.into(),
+            )?;
         }
 
         if let Some(timestamp) = object.public_keys_disabled_at {
             js_sys::Reflect::set(
                 &js_object,
                 &"publicKeysDisabledAt".to_owned().into(),
-                &(timestamp as u32).into(),
+                &JsValue::from_f64(timestamp as f64),
             )?;
         }
 
@@ -386,8 +372,8 @@ impl IdentityUpdateTransitionWasm {
     }
 
     #[wasm_bindgen(js_name=getModifiedDataIds)]
-    pub fn get_modified_data_ids(&self) -> Vec<JsValue> {
-        let ids = self.0.get_modified_data_ids();
+    pub fn modified_data_ids(&self) -> Vec<JsValue> {
+        let ids = self.0.modified_data_ids();
 
         ids.into_iter()
             .map(|id| <IdentifierWrapper as std::convert::From<Identifier>>::from(id).into())
@@ -433,9 +419,16 @@ impl IdentityUpdateTransitionWasm {
             BlsAdapter(JsValue::undefined().into())
         };
 
-        self.0
+        // TODO: not the best approach because it involves cloning the transition
+        // Probably it worth to return `sign_by_private_key` per state transition
+        let mut wrapper = StateTransition::IdentityUpdate(self.0.clone());
+        wrapper
             .sign_by_private_key(private_key.as_slice(), key_type, &bls_adapter)
-            .with_js_error()
+            .with_js_error()?;
+
+        self.0.set_signature(wrapper.signature().to_owned());
+
+        Ok(())
     }
 
     #[wasm_bindgen(js_name=setSignaturePublicKeyId)]
@@ -445,17 +438,18 @@ impl IdentityUpdateTransitionWasm {
 
     #[wasm_bindgen(js_name=getSignature)]
     pub fn get_signature(&self) -> Buffer {
-        Buffer::from_bytes_owned(self.0.get_signature().to_vec())
+        Buffer::from_bytes_owned(self.0.signature().to_vec())
     }
 
     #[wasm_bindgen(js_name=setSignature)]
     pub fn set_signature(&mut self, signature: Option<Vec<u8>>) {
-        self.0.signature = BinaryData::new(signature.unwrap_or(vec![]))
+        self.0
+            .set_signature(BinaryData::new(signature.unwrap_or(vec![])))
     }
 
     #[wasm_bindgen(js_name=getRevision)]
     pub fn get_revision(&self) -> u32 {
-        self.0.get_revision() as u32
+        self.0.revision() as u32
     }
 
     #[wasm_bindgen(js_name=setRevision)]
@@ -471,13 +465,23 @@ impl IdentityUpdateTransitionWasm {
         bls: JsBlsAdapter,
     ) -> Result<(), JsValue> {
         let bls_adapter = BlsAdapter(bls);
-        self.0
+        // TODO: come up with a better way to set signature to the binding.
+        let mut state_transition = StateTransition::IdentityUpdate(self.0.clone());
+        state_transition
             .sign(
                 &identity_public_key.to_owned().into(),
                 &private_key,
                 &bls_adapter,
             )
-            .with_js_error()
+            .with_js_error()?;
+
+        let signature = state_transition.signature().to_owned();
+        let signature_public_key_id = state_transition.signature_public_key_id().unwrap_or(0);
+
+        self.0.set_signature(signature);
+        self.0.set_signature_public_key_id(signature_public_key_id);
+
+        Ok(())
     }
 
     #[wasm_bindgen(js_name=verifySignature)]
@@ -488,8 +492,7 @@ impl IdentityUpdateTransitionWasm {
     ) -> Result<bool, JsValue> {
         let bls_adapter = BlsAdapter(bls);
 
-        let verification_result = self
-            .0
+        let verification_result = StateTransition::IdentityUpdate(self.0.clone())
             .verify_signature(&identity_public_key.to_owned().into(), &bls_adapter);
 
         match verification_result {