@dashevo/wasm-dpp 0.25.0-dev.1 → 0.25.0-dev.11

package/test/unit/document/DocumentFactory.spec.js

@@ -2,50 +2,38 @@ const bs58 = require('bs58');
 
 const DocumentCreateTransition = require('@dashevo/dpp/lib/document/stateTransition/DocumentsBatchTransition/documentTransition/DocumentCreateTransition');
 const ValidationResult = require('@dashevo/dpp/lib/validation/ValidationResult');
-const createDPPMock = require('@dashevo/dpp/lib/test/mocks/createDPPMock');
-const DocumentFactoryJS = require('@dashevo/dpp/lib/document/DocumentFactory');
 
-const getDataContractFixtureJs = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
-const getDocumentsFixtureJs = require('@dashevo/dpp/lib/test/fixtures/getDocumentsFixture');
+const getDataContractFixture = require('../../../lib/test/fixtures/getDataContractFixture');
+const getDocumentsFixture = require('../../../lib/test/fixtures/getDocumentsFixture');
 const createStateRepositoryMock = require('../../../lib/test/mocks/createStateRepositoryMock');
 const generateRandomIdentifierAsync = require('../../../lib/test/utils/generateRandomIdentifierAsync');
 
 let {
-  Identifier, DocumentFactory, DataContract, ExtendedDocument, DocumentValidator,
+  Identifier, DocumentFactory, ExtendedDocument, DocumentValidator,
   ProtocolVersionValidator, InvalidDocumentTypeInDataContractError, InvalidDocumentError,
   JsonSchemaError, NoDocumentsSuppliedError, MismatchOwnerIdsError, InvalidInitialRevisionError,
-  InvalidActionNameError, PlatformValueError,
+  InvalidActionNameError,
 } = require('../../..');
 
-const { default: loadWasmDpp } = require('../../..');
+const { default: loadWasmDpp, SerializedObjectParsingError } = require('../../..');
 
 describe('DocumentFactory', () => {
-  let decodeProtocolEntityMock;
-  let validateDocumentMock;
-  let fetchAndValidateDataContractMock;
   let stateRepositoryMock;
   let ownerIdJs;
   let ownerId;
   let dataContract;
   let dataContractJs;
   let document;
-  let documentJs;
-  let documentsJs;
   let documents;
   let rawDocument;
-  let rawDocumentJs;
-  let factoryJs;
   let factory;
-  let fakeTime;
-  let fakeTimeDate;
-  let dppMock;
   let dataContractId;
   let documentValidator;
 
   beforeEach(async () => {
     ({
       Identifier, ProtocolVersionValidator, DocumentValidator, DocumentFactory,
-      DataContract, ExtendedDocument,
+      ExtendedDocument,
       // Errors:
       InvalidDocumentTypeInDataContractError,
       InvalidDocumentError,
@@ -54,62 +42,29 @@ describe('DocumentFactory', () => {
       MismatchOwnerIdsError,
       InvalidInitialRevisionError,
       InvalidActionNameError,
-      PlatformValueError,
     } = await loadWasmDpp());
   });
 
-  beforeEach(function beforeEach() {
+  beforeEach(async function beforeEach() {
     const protocolValidator = new ProtocolVersionValidator();
     documentValidator = new DocumentValidator(protocolValidator);
 
-    ([{ ownerId: ownerIdJs }] = getDocumentsFixtureJs());
-    ownerId = Identifier.from(ownerIdJs);
+    dataContract = await getDataContractFixture();
+    dataContractId = dataContract.getId();
 
-    dataContractJs = getDataContractFixtureJs();
-    dataContract = DataContract.fromBuffer(dataContractJs.toBuffer());
-    const dc = DataContract.fromBuffer(dataContractJs.toBuffer());
-    dataContractId = dataContractJs.getId().toBuffer();
+    documents = await getDocumentsFixture(dataContract);
+    ownerId = documents[0].getOwnerId();
 
-    documentsJs = getDocumentsFixtureJs(dataContractJs);
-    documents = documentsJs.map((d) => {
-      const doc = new ExtendedDocument(d.toObject(), dataContract);
-      doc.setEntropy(d.entropy);
-      return doc;
-    });
-
-    ([, , , documentJs] = documentsJs);
-    rawDocumentJs = documentJs.toObject();
     ([, , , document] = documents);
     rawDocument = document.toObject();
 
-    decodeProtocolEntityMock = this.sinonSandbox.stub();
-    validateDocumentMock = this.sinonSandbox.stub();
-
-    validateDocumentMock.returns(new ValidationResult());
-
     const fetchContractResult = new ValidationResult();
     fetchContractResult.setData(dataContractJs);
 
     stateRepositoryMock = createStateRepositoryMock(this.sinonSandbox);
-    stateRepositoryMock.fetchDataContract.resolves(dc);
-
-    fetchAndValidateDataContractMock = this.sinonSandbox.stub().returns(fetchContractResult);
-    dppMock = createDPPMock();
+    stateRepositoryMock.fetchDataContract.resolves(dataContract);
 
     factory = new DocumentFactory(1, documentValidator, stateRepositoryMock);
-    factoryJs = new DocumentFactoryJS(
-      dppMock,
-      validateDocumentMock,
-      fetchAndValidateDataContractMock,
-      decodeProtocolEntityMock,
-    );
-
-    fakeTimeDate = new Date();
-    fakeTime = this.sinonSandbox.useFakeTimers(fakeTimeDate);
-  });
-
-  afterEach(() => {
-    fakeTime.reset();
   });
 
   describe('create', () => {
@@ -118,7 +73,7 @@ describe('DocumentFactory', () => {
       // should be valid for this test and it passes the DataContract validation.
       // The previous version of test passed due to the fact that
       // the mocked DataContract validator always returned true.
-      const [niceDocument] = documentsJs;
+      const [niceDocument] = documents;
 
       const newRawDocument = niceDocument.toObject();
       const contractId = bs58.decode('FQco85WbwNgb5ix8QQAH6wurMcgEC5ENSCv5ixG9cj12');
@@ -227,12 +182,11 @@ describe('DocumentFactory', () => {
     });
 
     it('should throw InvalidDocumentError if Data Contract is not valid', async () => {
-      const dc = DataContract.fromBuffer(dataContractJs.toBuffer());
-      dc.setDocuments({ '$%34': { '^&*': 'Keck' } });
-      stateRepositoryMock.fetchDataContract.resolves(dc);
+      dataContract.setDocuments({ '$%34': { '^&*': 'Keck' } });
+      stateRepositoryMock.fetchDataContract.resolves(dataContract);
 
       try {
-        await factory.createFromObject(rawDocumentJs);
+        await factory.createFromObject(rawDocument);
 
         expect.fail('InvalidDocumentTypeInDataContractError should be thrown');
       } catch (e) {
@@ -241,7 +195,7 @@ describe('DocumentFactory', () => {
         expect(stateRepositoryMock.fetchDataContract.callCount).to.be.equal(1);
         const callArguments = stateRepositoryMock.fetchDataContract.getCall(0).args[0];
 
-        expect(callArguments.toBuffer()).to.be.deep.equal(dc.getId().toBuffer());
+        expect(callArguments.toBuffer()).to.be.deep.equal(dataContract.getId().toBuffer());
       }
     });
   });
@@ -249,28 +203,22 @@ describe('DocumentFactory', () => {
   describe('createFromBuffer', () => {
     let serializedDocument;
 
-    beforeEach(function beforeEach() {
-      this.sinonSandbox.stub(factoryJs, 'createFromObject');
+    beforeEach(() => {
       // eslint-disable-next-line prefer-destructuring
-      documentJs = documentsJs[8]; // document with binary fields
-
-      serializedDocument = documentJs.toBuffer();
-      rawDocumentJs = documentJs.toObject();
-    });
-
-    afterEach(() => {
-      factoryJs.createFromObject.restore();
+      document = documents[8]; // document with binary fields
+      serializedDocument = document.toBuffer();
+      rawDocument = document.toObject();
     });
 
     it('should return new Document from serialized one', async () => {
       const result = await factory.createFromBuffer(serializedDocument);
-      expect(result.toObject()).to.deep.equal(documentJs.toObject());
+      expect(result.toObject()).to.deep.equal(document.toObject());
       expect(stateRepositoryMock.fetchDataContract).to.have.been.calledOnce();
     });
 
     it('should throw InvalidDocumentError if the decoding fails with consensus error', async () => {
-      documentJs.data = 'Not a valid data';
-      serializedDocument = documentJs.toBuffer();
+      stateRepositoryMock.fetchDataContract.resolves(null);
+      serializedDocument = document.toBuffer();
 
       try {
         await factory.createFromBuffer(serializedDocument);
@@ -281,18 +229,19 @@ describe('DocumentFactory', () => {
       }
     });
 
-    it('should throw an error if decoding fails with any other error - Rust', async () => {
+    it('should throw an error if decoding fails with any other error', async () => {
       const serializeDocument = Buffer.alloc(160, 1);
       try {
         await factory.createFromBuffer(serializeDocument);
 
         expect.fail('should throw an error');
       } catch (e) {
-        expect(e).to.be.instanceOf(PlatformValueError);
-        expect(e.getMessage()).to.equal('structure error: value is not a map');
+        expect(e).to.be.instanceOf(SerializedObjectParsingError);
       }
     });
-  }); describe('createStateTransition', () => {
+  });
+
+  describe('createStateTransition', () => {
     it('should throw and error if documents have unknown action', async () => {
       try {
         factory.createStateTransition({
@@ -348,23 +297,22 @@ describe('DocumentFactory', () => {
     });
 
     it('should create DocumentsBatchTransition with passed documents', async () => {
-      const [newDocumentJs] = getDocumentsFixtureJs(dataContractJs);
-      const newDocument = new ExtendedDocument(newDocumentJs.toObject(), dataContract);
+      const [newDocument] = await getDocumentsFixture(dataContract);
+      newDocument.setData({ lastName: 'Keck' });
 
       const stateTransition = factory.createStateTransition({
         create: documents,
         replace: [newDocument],
       });
 
-      const stateTransitionJs = factoryJs.createStateTransition({
-        create: documentsJs,
-        replace: [newDocumentJs],
-      });
-
-      const transitions = stateTransition.getTransitions().map((t) => t.toObject());
-      const expectedTransitions = stateTransitionJs.getTransitions().map((t) => t.toObject());
+      const replaceDocuments = stateTransition.getTransitions()
+        .filter((t) => t.getAction() === 1);
+      const createDocuments = stateTransition.getTransitions()
+        .filter((t) => t.getAction() === 0);
 
-      expect(transitions).to.deep.includes.members(expectedTransitions);
+      expect(replaceDocuments[0].getId()).to.deep.equal(newDocument.getId());
+      expect(replaceDocuments[0].getRevision()).to.deep.equal(2);
+      expect(createDocuments).to.have.lengthOf(documents.length);
     });
   });
 });

package/test/unit/document/stateTransition/DocumetsBatchTransition/DocumentsBatchTransition.spec.js

@@ -105,10 +105,9 @@ describe('DocumentsBatchTransition', () => {
 
   describe('#toBuffer', () => {
     it('should return the same bytes as JS version', () => {
-      const bufferJs = stateTransitionJs.toBuffer();
       const buffer = stateTransition.toBuffer();
-
-      expect(bufferJs).to.deep.equal(buffer);
+      expect(buffer).to.be.instanceOf(Buffer);
+      expect(buffer).to.have.length(23960);
     });
   });
 

package/test/unit/identity/Identity.spec.js

@@ -1,7 +1,6 @@
 const varint = require('varint');
 const JSIdentityPublicKey = require('@dashevo/dpp/lib/identity/IdentityPublicKey');
 const protocolVersion = require('@dashevo/dpp/lib/version/protocolVersion');
-const JSIdentity = require('@dashevo/dpp/lib/identity/Identity');
 
 const { hash: hashFunction } = require('@dashevo/dpp/lib/util/hash');
 const { expect } = require('chai');
@@ -135,14 +134,10 @@ describe('Identity', () => {
   });
 
   describe('#toBuffer', () => {
-    it('should return the same buffer as JS Identity', () => {
-      // Due to browser polyfill, we got two different versions of buffers, and makes
-      // the compatibility test to fail in karma, so hence this hack here.
-      rawIdentity.id = Buffer.from(rawIdentity.id.toBuffer());
-      const oldIdentity = new JSIdentity(rawIdentity);
+    it('should return buffer', () => {
       const result = identity.toBuffer();
-
-      expect(result).to.deep.eq(oldIdentity.toBuffer());
+      expect(result).to.be.instanceOf(Buffer);
+      expect(result).to.have.length(87);
     });
   });
 

package/test/unit/identity/IdentityFactory.spec.js

@@ -2,7 +2,7 @@ const IdentityPublicKey = require('@dashevo/dpp/lib/identity/IdentityPublicKey')
 const getInstantAssetLockProofFixture = require('@dashevo/dpp/lib/test/fixtures/getInstantAssetLockProofFixture');
 const getIdentityFixture = require('@dashevo/dpp/lib/test/fixtures/getIdentityFixture');
 const getChainAssetLockProofFixture = require('../../../lib/test/fixtures/getChainAssetLockProofFixture');
-const { default: loadWasmDpp } = require('../../../dist');
+const { default: loadWasmDpp, SerializedObjectParsingError } = require('../../../dist');
 const getBlsAdapterMock = require('../../../lib/test/mocks/getBlsAdapterMock');
 
 describe('IdentityFactory', () => {
@@ -21,7 +21,6 @@ describe('IdentityFactory', () => {
   let IdentityUpdateTransition;
   let IdentityPublicKeyWithWitness;
   let InvalidIdentityError;
-  let PlatformValueError;
   let UnsupportedProtocolVersionError;
   let ChainAssetLockProof;
 
@@ -30,7 +29,7 @@ describe('IdentityFactory', () => {
       Identity, IdentityFactory, IdentityValidator,
       InstantAssetLockProof, ChainAssetLockProof, IdentityUpdateTransition,
       IdentityCreateTransition, IdentityTopUpTransition, IdentityPublicKeyWithWitness,
-      InvalidIdentityError, UnsupportedProtocolVersionError, PlatformValueError,
+      InvalidIdentityError, UnsupportedProtocolVersionError,
     } = await loadWasmDpp());
   });
 
@@ -149,7 +148,7 @@ describe('IdentityFactory', () => {
 
         expect.fail('should throw an error');
       } catch (e) {
-        expect(e).to.be.instanceOf(PlatformValueError);
+        expect(e).to.be.instanceOf(SerializedObjectParsingError);
       }
     });
   });

package/test/unit/stateTransition/validation/validateStateTransitionBasicFactory.spec.js

@@ -87,11 +87,11 @@ describe('validateStateTransitionBasicFactory', () => {
     expect(error).to.instanceof(JsonSchemaError);
   });
 
-  it('should return invalid result if ST size is more than 16 kb', async () => {
+  it('should return invalid result if ST size is more than 25 kb', async () => {
     const largeDocument = rawStateTransition.dataContract.documents.niceDocument;
 
     // generate big state transition
-    for (let i = 0; i < 6; i++) {
+    for (let i = 0; i < 7; i++) {
       largeDocument.properties[`name${i}`] = { type: 'string' };
     }
     for (let i = 0; i < 90; i++) {

package/test/unit/stateTransition/validation/validateStateTransitionFeeFactory.spec.js

@@ -42,10 +42,9 @@ describe('validateStateTransitionFeeFactory', () => {
 
     const validator = new StateTransitionFeeValidator(stateRepositoryMock);
 
-    validateStateTransitionFee = (st) => validator.validate(st);
-
     executionContext = new StateTransitionExecutionContext();
     executionContext.disableDryRun();
+    validateStateTransitionFee = (st) => validator.validate(st, executionContext);
 
     dataContract = await getDataContractFixture();
   });
@@ -61,7 +60,6 @@ describe('validateStateTransitionFeeFactory', () => {
 
     it('should return invalid result if balance is not enough', async () => {
       executionContext.addOperation(new PreCalculatedOperation(0, 42, []));
-      dataContractCreateTransition.setExecutionContext(executionContext);
       stateRepositoryMock.fetchIdentityBalance.resolves(1);
 
       const result = await validateStateTransitionFee(dataContractCreateTransition);
@@ -83,7 +81,6 @@ describe('validateStateTransitionFeeFactory', () => {
       stateRepositoryMock.fetchIdentityBalance.resolves(42);
 
       executionContext.addOperation(new PreCalculatedOperation(0, 42, []));
-      dataContractCreateTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(dataContractCreateTransition);
 
@@ -112,7 +109,6 @@ describe('validateStateTransitionFeeFactory', () => {
       stateRepositoryMock.fetchIdentityBalance.resolves(1);
 
       executionContext.addOperation(new PreCalculatedOperation(0, 42, []));
-      documentsBatchTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(documentsBatchTransition);
 
@@ -133,7 +129,6 @@ describe('validateStateTransitionFeeFactory', () => {
       stateRepositoryMock.fetchIdentityBalance.resolves(42);
 
       executionContext.addOperation(new PreCalculatedOperation(0, 42, []));
-      documentsBatchTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(documentsBatchTransition);
 
@@ -151,11 +146,10 @@ describe('validateStateTransitionFeeFactory', () => {
       executionContext.enableDryRun();
 
       executionContext.addOperation(new PreCalculatedOperation(0, 42, []));
-      documentsBatchTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(documentsBatchTransition);
 
-      documentsBatchTransition.getExecutionContext().disableDryRun();
+      executionContext.disableDryRun();
 
       expect(result.isValid()).to.be.true();
 
@@ -182,7 +176,6 @@ describe('validateStateTransitionFeeFactory', () => {
 
     it('should return invalid result if asset lock output amount is not enough', async () => {
       executionContext.addOperation(new PreCalculatedOperation(0, outputAmount + 1, []));
-      identityCreateTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(identityCreateTransition);
 
@@ -198,7 +191,6 @@ describe('validateStateTransitionFeeFactory', () => {
 
     it('should return valid result', async () => {
       executionContext.addOperation(new PreCalculatedOperation(0, outputAmount, []));
-      identityCreateTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(identityCreateTransition);
 
@@ -210,11 +202,10 @@ describe('validateStateTransitionFeeFactory', () => {
     it('should not increase balance on dry run', async () => {
       executionContext.enableDryRun();
       executionContext.addOperation(new PreCalculatedOperation(0, outputAmount + 1, []));
-      identityCreateTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(identityCreateTransition);
 
-      identityCreateTransition.getExecutionContext().disableDryRun();
+      executionContext.disableDryRun();
 
       expect(result.isValid()).to.be.true();
     });
@@ -240,7 +231,6 @@ describe('validateStateTransitionFeeFactory', () => {
       stateRepositoryMock.fetchIdentityBalanceWithDebt.resolves(1);
 
       executionContext.addOperation(new PreCalculatedOperation(0, outputAmount + 2, []));
-      identityTopUpTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(identityTopUpTransition);
 
@@ -261,7 +251,6 @@ describe('validateStateTransitionFeeFactory', () => {
       stateRepositoryMock.fetchIdentityBalanceWithDebt.resolves(41);
 
       executionContext.addOperation(new PreCalculatedOperation(0, outputAmount - 1, []));
-      identityTopUpTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(identityTopUpTransition);
 
@@ -278,11 +267,10 @@ describe('validateStateTransitionFeeFactory', () => {
 
       executionContext.enableDryRun();
       executionContext.addOperation(new PreCalculatedOperation(0, outputAmount + 42, []));
-      identityTopUpTransition.setExecutionContext(executionContext);
 
       const result = await validateStateTransitionFee(identityTopUpTransition);
 
-      identityTopUpTransition.getExecutionContext().disableDryRun();
+      executionContext.disableDryRun();
 
       expect(result.isValid()).to.be.true();
 

package/test/unit/stateTransition/validation/validateStateTransitionIdentitySignatureFactory.spec.js

@@ -70,12 +70,13 @@ describe('validateStateTransitionIdentitySignatureFactory', () => {
     identity.addPublicKey(identityPublicKey);
 
     stateTransition.sign(identity.getPublicKeyById(2), privateKey, getBlsMock());
-    stateTransition.setExecutionContext(executionContext);
 
     stateRepositoryMock = createStateRepositoryMock(this.sinonSandbox);
     stateRepositoryMock.fetchIdentity.resolves(identity);
 
-    validateStateTransitionIdentitySignature = (st) => validate(stateRepositoryMock, st, blsMock);
+    validateStateTransitionIdentitySignature = (st) => validate(
+      stateRepositoryMock, st, executionContext, blsMock,
+    );
   });
 
   it('should pass properly signed state transition', async () => {
@@ -227,10 +228,13 @@ describe('validateStateTransitionIdentitySignatureFactory', () => {
 
       expect(error).to.be.instanceOf(InvalidSignaturePublicKeySecurityLevelError);
       expect(error.getPublicKeySecurityLevel()).to.equal(IdentityPublicKey.SECURITY_LEVELS.MASTER);
-      expect(error.getKeySecurityLevelRequirement()).to.equal(2);
+      expect(error.getKeySecurityLevelRequirement()).to.deep.equal([2]);
     });
 
-    it('should return PublicKeySecurityLevelNotMetConsensusError if PublicKeySecurityLevelNotMetError was thrown', async () => {
+    // TODO: the error is not used anymore,
+    //  remove the test and remaining `match` variants in rs-dpp
+    //  that still expecting to receive this error?
+    it.skip('should return PublicKeySecurityLevelNotMetConsensusError if PublicKeySecurityLevelNotMetError was thrown', async () => {
       const publicKeys = identity.getPublicKeys();
       publicKeys[2].setSecurityLevel(IdentityPublicKey.SECURITY_LEVELS.MEDIUM);
       identity.setPublicKeys(publicKeys);