@dashevo/wasm-dpp 0.24.0-dev.33 → 0.25.0-dev.10

package/test/unit/dataContract/stateTransition/DataContractCreateTransition/applyDataContractCreateTransitionFactory.spec.js

@@ -8,10 +8,8 @@ describe('applyDataContractCreateTransitionFactory', () => {
   let stateTransition;
   let dataContract;
   let factory;
-  let executionContext;
   let DataContractCreateTransition;
   let ApplyDataContractCreateTransition;
-  let StateTransitionExecutionContext;
 
   let dataContractStored;
 
@@ -19,7 +17,6 @@ describe('applyDataContractCreateTransitionFactory', () => {
     ({
       DataContractCreateTransition,
       ApplyDataContractCreateTransition,
-      StateTransitionExecutionContext,
     } = await loadWasmDpp());
   });
 
@@ -32,10 +29,6 @@ describe('applyDataContractCreateTransitionFactory', () => {
       entropy: Buffer.alloc(32),
     });
 
-    executionContext = new StateTransitionExecutionContext();
-
-    stateTransition.setExecutionContext(executionContext);
-
     const stateRepositoryLike = {
       createDataContract: async () => {
         dataContractStored = true;

package/test/unit/dataContract/stateTransition/DataContractCreateTransition/validation/state/validateDataContractCreateTransitionStateFactory.spec.js

@@ -1,5 +1,5 @@
-const getDataContractFixture = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
 const protocolVersion = require('@dashevo/dpp/lib/version/protocolVersion');
+const getDataContractFixture = require('../../../../../../../lib/test/fixtures/getDataContractFixture');
 
 const { default: loadWasmDpp } = require('../../../../../../../dist');
 
@@ -27,8 +27,8 @@ describe('validateDataContractCreateTransitionStateFactory', () => {
     } = await loadWasmDpp());
   });
 
-  beforeEach(() => {
-    dataContract = getDataContractFixture();
+  beforeEach(async () => {
+    dataContract = await getDataContractFixture();
     stateTransition = new DataContractCreateTransition({
       protocolVersion: protocolVersion.latestVersion,
       dataContract: dataContract.toObject(),
@@ -37,8 +37,6 @@ describe('validateDataContractCreateTransitionStateFactory', () => {
 
     executionContext = new StateTransitionExecutionContext();
 
-    stateTransition.setExecutionContext(executionContext);
-
     dataContractFetched = false;
 
     const stateRepositoryLike = {
@@ -47,22 +45,26 @@ describe('validateDataContractCreateTransitionStateFactory', () => {
       },
     };
 
-    factory = (t) => validateDataContractCreateTransitionState(stateRepositoryLike, t);
+    factory = (t) => validateDataContractCreateTransitionState(
+      stateRepositoryLike, t, executionContext,
+    );
   });
 
   it('should return invalid result if Data Contract is already exist', async () => {
     // This time our state repository should return a data contract on fetch
     const validator = new DataContractValidator();
     const dataContractFactory = new DataContractFactory(1, validator);
-    const wasmDataContract = await dataContractFactory.createFromBuffer(dataContract.toBuffer());
+    const reCreatedDataContract = await dataContractFactory
+      .createFromBuffer(dataContract.toBuffer());
 
     const stateRepositoryLikeWithContract = {
-      fetchDataContract: async () => wasmDataContract,
+      fetchDataContract: async () => reCreatedDataContract,
     };
 
     const result = await validateDataContractCreateTransitionState(
       stateRepositoryLikeWithContract,
       stateTransition,
+      executionContext,
     );
     const [error] = result.getErrors();
 

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/DataContractUpdateTransition.spec.js

@@ -1,4 +1,3 @@
-const varint = require('varint');
 const getDataContractFixture = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
 const stateTransitionTypes = require('@dashevo/dpp/lib/stateTransition/stateTransitionTypes');
 const protocolVersion = require('@dashevo/dpp/lib/version/protocolVersion');
@@ -62,11 +61,10 @@ describe('DataContractUpdateTransition', () => {
   });
 
   describe('#toBuffer', () => {
-    it('should return serialized State Transition that starts with protocol version', () => {
-      const protocolVersionBytes = Buffer.from(varint.encode(stateTransition.getProtocolVersion()));
-
+    it('should return serialized State Transition', () => {
       const result = stateTransition.toBuffer();
-      expect(result.compare(protocolVersionBytes, 0, 1, 0, 1)).equals(0);
+      expect(result).to.be.instanceOf(Buffer);
+      expect(result).to.have.lengthOf(2239);
     });
   });
 

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/applyDataContractUpdateTransitionFactory.spec.js

@@ -31,8 +31,6 @@ describe('applyDataContractUpdateTransitionFactory', () => {
 
     executionContext = new StateTransitionExecutionContext();
 
-    stateTransition.setExecutionContext(executionContext);
-
     const stateRepositoryLike = {
       updateDataContract: async () => {
         dataContractStored = true;
@@ -45,7 +43,7 @@ describe('applyDataContractUpdateTransitionFactory', () => {
   });
 
   it('should store a data contract from state transition in the repository', async () => {
-    await factory.applyDataContractUpdateTransition(stateTransition);
+    await factory.applyDataContractUpdateTransition(stateTransition, executionContext);
     expect(dataContractStored).to.be.true();
   });
 });

package/test/unit/dataContract/stateTransition/DataContractUpdateTransition/validation/state/validateDataContractUpdateTransitionStateFactory.spec.js

@@ -1,5 +1,5 @@
-const getDataContractFixture = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
 const protocolVersion = require('@dashevo/dpp/lib/version/protocolVersion');
+const getDataContractFixture = require('../../../../../../../lib/test/fixtures/getDataContractFixture');
 
 const { default: loadWasmDpp } = require('../../../../../../../dist');
 
@@ -31,7 +31,7 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
   });
 
   beforeEach(async () => {
-    dataContract = getDataContractFixture();
+    dataContract = await getDataContractFixture();
 
     const updatedRawDataContract = dataContract.toObject();
 
@@ -44,19 +44,19 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
 
     executionContext = new StateTransitionExecutionContext();
 
-    stateTransition.setExecutionContext(executionContext);
-
     const validator = new DataContractValidator();
     const dataContractFactory = new DataContractFactory(protocolVersion.latestVersion, validator);
-    const wasmDataContract = await dataContractFactory.createFromBuffer(dataContract.toBuffer());
+    const reCreatedDataContract = await dataContractFactory
+      .createFromBuffer(dataContract.toBuffer());
 
     const stateRepositoryLike = {
-      fetchDataContract: async () => wasmDataContract,
+      fetchDataContract: async () => reCreatedDataContract,
     };
 
     validateTransitionWithExistingContract = (t) => validateDataContractUpdateTransitionState(
       stateRepositoryLike,
       t,
+      executionContext,
     );
   });
 
@@ -68,6 +68,7 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
     const validateTransitionWithNoContract = (t) => validateDataContractUpdateTransitionState(
       stateRepositoryLikeNoDataContract,
       t,
+      executionContext,
     );
 
     const result = await validateTransitionWithNoContract(stateTransition);
@@ -114,6 +115,7 @@ describe('validateDataContractUpdateTransitionStateFactory', () => {
     const validateTransitionWithNoContract = (t) => validateDataContractUpdateTransitionState(
       stateRepositoryLikeNoDataContract,
       t,
+      executionContext,
     );
 
     executionContext.enableDryRun();

package/test/unit/decodeProtocolEntityFactory.spec.js

@@ -4,7 +4,10 @@ const { encode } = require('@dashevo/dpp/lib/util/serializer');
 let { decodeProtocolEntity, ProtocolVersionParsingError, SerializedObjectParsingError } = require('../..');
 const { default: loadWasmDpp } = require('../..');
 
-describe('decodeProtocolEntityFactory', () => {
+// TODO: decodeProtocolEntity was broken after serialization refactoring
+//   it was mostly used in js-drive and does not seem to be needed anymore
+//   can we remove it completely?
+describe.skip('decodeProtocolEntityFactory', () => {
   let parsedProtocolVersion;
   let entityBuffer;
   let protocolVersionBuffer;

package/test/unit/document/Document.spec.js

@@ -411,15 +411,15 @@ describe('Document', () => {
   });
 
   describe('#toBuffer', () => {
-    it('returned bytes should be the same as JS version', () => {
-      const jsBuffer = documentJs.toBuffer();
+    it('should return serialized Document', () => {
       const buffer = document.toBuffer();
-
-      expect(jsBuffer.length).to.equal(buffer.length);
-      expect(jsBuffer).to.deep.equal(buffer);
+      expect(buffer).to.be.instanceOf(Buffer);
+      expect(buffer.length).to.equal(509);
     });
 
-    it('should return the same bytes as JS version when dynamic identifier is in Document', () => {
+    // TODO: remove or replace?
+    //  can not be compared to JS buffers anymore because uses bin code
+    it.skip('should return the same bytes as JS version when dynamic identifier is in Document', () => {
       const jsId = generateRandomIdentifier();
       const id = new Identifier(jsId.toBuffer());
       const path = 'dataObject.binaryObject.identifier';
@@ -438,7 +438,9 @@ describe('Document', () => {
       expect(jsBuffer).to.deep.equal(buffer);
     });
 
-    it('should return the same bytes as JS version when dynamic binaryData is in Document', () => {
+    // TODO: remove or replace?
+    //  can not be compared to JS buffers anymore because uses bin code
+    it.skip('should return the same bytes as JS version when dynamic binaryData is in Document', () => {
       const data = Buffer.alloc(32);
       const path = 'dataObject.binaryObject.binaryData';
 

package/test/unit/document/DocumentFactory.spec.js

@@ -2,50 +2,38 @@ const bs58 = require('bs58');
 
 const DocumentCreateTransition = require('@dashevo/dpp/lib/document/stateTransition/DocumentsBatchTransition/documentTransition/DocumentCreateTransition');
 const ValidationResult = require('@dashevo/dpp/lib/validation/ValidationResult');
-const createDPPMock = require('@dashevo/dpp/lib/test/mocks/createDPPMock');
-const DocumentFactoryJS = require('@dashevo/dpp/lib/document/DocumentFactory');
 
-const getDataContractFixtureJs = require('@dashevo/dpp/lib/test/fixtures/getDataContractFixture');
-const getDocumentsFixtureJs = require('@dashevo/dpp/lib/test/fixtures/getDocumentsFixture');
+const getDataContractFixture = require('../../../lib/test/fixtures/getDataContractFixture');
+const getDocumentsFixture = require('../../../lib/test/fixtures/getDocumentsFixture');
 const createStateRepositoryMock = require('../../../lib/test/mocks/createStateRepositoryMock');
 const generateRandomIdentifierAsync = require('../../../lib/test/utils/generateRandomIdentifierAsync');
 
 let {
-  Identifier, DocumentFactory, DataContract, ExtendedDocument, DocumentValidator,
+  Identifier, DocumentFactory, ExtendedDocument, DocumentValidator,
   ProtocolVersionValidator, InvalidDocumentTypeInDataContractError, InvalidDocumentError,
   JsonSchemaError, NoDocumentsSuppliedError, MismatchOwnerIdsError, InvalidInitialRevisionError,
-  InvalidActionNameError, PlatformValueError,
+  InvalidActionNameError,
 } = require('../../..');
 
-const { default: loadWasmDpp } = require('../../..');
+const { default: loadWasmDpp, SerializedObjectParsingError } = require('../../..');
 
 describe('DocumentFactory', () => {
-  let decodeProtocolEntityMock;
-  let validateDocumentMock;
-  let fetchAndValidateDataContractMock;
   let stateRepositoryMock;
   let ownerIdJs;
   let ownerId;
   let dataContract;
   let dataContractJs;
   let document;
-  let documentJs;
-  let documentsJs;
   let documents;
   let rawDocument;
-  let rawDocumentJs;
-  let factoryJs;
   let factory;
-  let fakeTime;
-  let fakeTimeDate;
-  let dppMock;
   let dataContractId;
   let documentValidator;
 
   beforeEach(async () => {
     ({
       Identifier, ProtocolVersionValidator, DocumentValidator, DocumentFactory,
-      DataContract, ExtendedDocument,
+      ExtendedDocument,
       // Errors:
       InvalidDocumentTypeInDataContractError,
       InvalidDocumentError,
@@ -54,62 +42,29 @@ describe('DocumentFactory', () => {
       MismatchOwnerIdsError,
       InvalidInitialRevisionError,
       InvalidActionNameError,
-      PlatformValueError,
     } = await loadWasmDpp());
   });
 
-  beforeEach(function beforeEach() {
+  beforeEach(async function beforeEach() {
     const protocolValidator = new ProtocolVersionValidator();
     documentValidator = new DocumentValidator(protocolValidator);
 
-    ([{ ownerId: ownerIdJs }] = getDocumentsFixtureJs());
-    ownerId = Identifier.from(ownerIdJs);
+    dataContract = await getDataContractFixture();
+    dataContractId = dataContract.getId();
 
-    dataContractJs = getDataContractFixtureJs();
-    dataContract = DataContract.fromBuffer(dataContractJs.toBuffer());
-    const dc = DataContract.fromBuffer(dataContractJs.toBuffer());
-    dataContractId = dataContractJs.getId().toBuffer();
+    documents = await getDocumentsFixture(dataContract);
+    ownerId = documents[0].getOwnerId();
 
-    documentsJs = getDocumentsFixtureJs(dataContractJs);
-    documents = documentsJs.map((d) => {
-      const doc = new ExtendedDocument(d.toObject(), dataContract);
-      doc.setEntropy(d.entropy);
-      return doc;
-    });
-
-    ([, , , documentJs] = documentsJs);
-    rawDocumentJs = documentJs.toObject();
     ([, , , document] = documents);
     rawDocument = document.toObject();
 
-    decodeProtocolEntityMock = this.sinonSandbox.stub();
-    validateDocumentMock = this.sinonSandbox.stub();
-
-    validateDocumentMock.returns(new ValidationResult());
-
     const fetchContractResult = new ValidationResult();
     fetchContractResult.setData(dataContractJs);
 
     stateRepositoryMock = createStateRepositoryMock(this.sinonSandbox);
-    stateRepositoryMock.fetchDataContract.resolves(dc);
-
-    fetchAndValidateDataContractMock = this.sinonSandbox.stub().returns(fetchContractResult);
-    dppMock = createDPPMock();
+    stateRepositoryMock.fetchDataContract.resolves(dataContract);
 
     factory = new DocumentFactory(1, documentValidator, stateRepositoryMock);
-    factoryJs = new DocumentFactoryJS(
-      dppMock,
-      validateDocumentMock,
-      fetchAndValidateDataContractMock,
-      decodeProtocolEntityMock,
-    );
-
-    fakeTimeDate = new Date();
-    fakeTime = this.sinonSandbox.useFakeTimers(fakeTimeDate);
-  });
-
-  afterEach(() => {
-    fakeTime.reset();
   });
 
   describe('create', () => {
@@ -118,7 +73,7 @@ describe('DocumentFactory', () => {
       // should be valid for this test and it passes the DataContract validation.
       // The previous version of test passed due to the fact that
       // the mocked DataContract validator always returned true.
-      const [niceDocument] = documentsJs;
+      const [niceDocument] = documents;
 
       const newRawDocument = niceDocument.toObject();
       const contractId = bs58.decode('FQco85WbwNgb5ix8QQAH6wurMcgEC5ENSCv5ixG9cj12');
@@ -227,12 +182,11 @@ describe('DocumentFactory', () => {
     });
 
     it('should throw InvalidDocumentError if Data Contract is not valid', async () => {
-      const dc = DataContract.fromBuffer(dataContractJs.toBuffer());
-      dc.setDocuments({ '$%34': { '^&*': 'Keck' } });
-      stateRepositoryMock.fetchDataContract.resolves(dc);
+      dataContract.setDocuments({ '$%34': { '^&*': 'Keck' } });
+      stateRepositoryMock.fetchDataContract.resolves(dataContract);
 
       try {
-        await factory.createFromObject(rawDocumentJs);
+        await factory.createFromObject(rawDocument);
 
         expect.fail('InvalidDocumentTypeInDataContractError should be thrown');
       } catch (e) {
@@ -241,7 +195,7 @@ describe('DocumentFactory', () => {
         expect(stateRepositoryMock.fetchDataContract.callCount).to.be.equal(1);
         const callArguments = stateRepositoryMock.fetchDataContract.getCall(0).args[0];
 
-        expect(callArguments.toBuffer()).to.be.deep.equal(dc.getId().toBuffer());
+        expect(callArguments.toBuffer()).to.be.deep.equal(dataContract.getId().toBuffer());
       }
     });
   });
@@ -249,28 +203,22 @@ describe('DocumentFactory', () => {
   describe('createFromBuffer', () => {
     let serializedDocument;
 
-    beforeEach(function beforeEach() {
-      this.sinonSandbox.stub(factoryJs, 'createFromObject');
+    beforeEach(() => {
       // eslint-disable-next-line prefer-destructuring
-      documentJs = documentsJs[8]; // document with binary fields
-
-      serializedDocument = documentJs.toBuffer();
-      rawDocumentJs = documentJs.toObject();
-    });
-
-    afterEach(() => {
-      factoryJs.createFromObject.restore();
+      document = documents[8]; // document with binary fields
+      serializedDocument = document.toBuffer();
+      rawDocument = document.toObject();
     });
 
     it('should return new Document from serialized one', async () => {
       const result = await factory.createFromBuffer(serializedDocument);
-      expect(result.toObject()).to.deep.equal(documentJs.toObject());
+      expect(result.toObject()).to.deep.equal(document.toObject());
       expect(stateRepositoryMock.fetchDataContract).to.have.been.calledOnce();
     });
 
     it('should throw InvalidDocumentError if the decoding fails with consensus error', async () => {
-      documentJs.data = 'Not a valid data';
-      serializedDocument = documentJs.toBuffer();
+      stateRepositoryMock.fetchDataContract.resolves(null);
+      serializedDocument = document.toBuffer();
 
       try {
         await factory.createFromBuffer(serializedDocument);
@@ -281,18 +229,19 @@ describe('DocumentFactory', () => {
       }
     });
 
-    it('should throw an error if decoding fails with any other error - Rust', async () => {
+    it('should throw an error if decoding fails with any other error', async () => {
       const serializeDocument = Buffer.alloc(160, 1);
       try {
         await factory.createFromBuffer(serializeDocument);
 
         expect.fail('should throw an error');
       } catch (e) {
-        expect(e).to.be.instanceOf(PlatformValueError);
-        expect(e.getMessage()).to.equal('structure error: value is not a map');
+        expect(e).to.be.instanceOf(SerializedObjectParsingError);
       }
     });
-  }); describe('createStateTransition', () => {
+  });
+
+  describe('createStateTransition', () => {
     it('should throw and error if documents have unknown action', async () => {
       try {
         factory.createStateTransition({
@@ -348,23 +297,22 @@ describe('DocumentFactory', () => {
     });
 
     it('should create DocumentsBatchTransition with passed documents', async () => {
-      const [newDocumentJs] = getDocumentsFixtureJs(dataContractJs);
-      const newDocument = new ExtendedDocument(newDocumentJs.toObject(), dataContract);
+      const [newDocument] = await getDocumentsFixture(dataContract);
+      newDocument.setData({ lastName: 'Keck' });
 
       const stateTransition = factory.createStateTransition({
         create: documents,
         replace: [newDocument],
       });
 
-      const stateTransitionJs = factoryJs.createStateTransition({
-        create: documentsJs,
-        replace: [newDocumentJs],
-      });
-
-      const transitions = stateTransition.getTransitions().map((t) => t.toObject());
-      const expectedTransitions = stateTransitionJs.getTransitions().map((t) => t.toObject());
+      const replaceDocuments = stateTransition.getTransitions()
+        .filter((t) => t.getAction() === 1);
+      const createDocuments = stateTransition.getTransitions()
+        .filter((t) => t.getAction() === 0);
 
-      expect(transitions).to.deep.includes.members(expectedTransitions);
+      expect(replaceDocuments[0].getId()).to.deep.equal(newDocument.getId());
+      expect(replaceDocuments[0].getRevision()).to.deep.equal(2);
+      expect(createDocuments).to.have.lengthOf(documents.length);
     });
   });
 });

package/test/unit/document/stateTransition/DocumetsBatchTransition/DocumentsBatchTransition.spec.js

@@ -105,10 +105,9 @@ describe('DocumentsBatchTransition', () => {
 
   describe('#toBuffer', () => {
     it('should return the same bytes as JS version', () => {
-      const bufferJs = stateTransitionJs.toBuffer();
       const buffer = stateTransition.toBuffer();
-
-      expect(bufferJs).to.deep.equal(buffer);
+      expect(buffer).to.be.instanceOf(Buffer);
+      expect(buffer).to.have.length(23960);
     });
   });
 

package/test/unit/document/stateTransition/DocumetsBatchTransition/applyDocumentsBatchTransitionFactory.spec.js

@@ -104,7 +104,6 @@ describe('applyDocumentsBatchTransitionFactory', () => {
     executionContext = new StateTransitionExecutionContext();
 
     stateTransitionJs.setExecutionContext(executionContextJs);
-    stateTransition.setExecutionContext(executionContext);
 
     stateRepositoryMockJs = createStateRepositoryMock(this.sinonSandbox);
     stateRepositoryMockJs.fetchDataContract.resolves(dataContractJs);
@@ -163,7 +162,7 @@ describe('applyDocumentsBatchTransitionFactory', () => {
   });
 
   it('should call `store`, `replace` and `remove` functions for specific type of transitions - Rust', async () => {
-    await applyDocumentsBatchTransition(stateRepositoryMock, stateTransition);
+    await applyDocumentsBatchTransition(stateRepositoryMock, stateTransition, executionContext);
     expect(stateRepositoryMock.createDocument).to.have.been.calledOnce();
 
     const [fetchContractId, fetchDocumentType] = stateRepositoryMock
@@ -203,7 +202,7 @@ describe('applyDocumentsBatchTransitionFactory', () => {
     const replaceDocumentTransition = documentTransitionsJs[1];
 
     try {
-      await applyDocumentsBatchTransition(stateRepositoryMock, stateTransition);
+      await applyDocumentsBatchTransition(stateRepositoryMock, stateTransition, executionContext);
       expect.fail('Error was not thrown');
     } catch (e) {
       expect(e).to.be.an.instanceOf(DocumentNotProvidedError);
@@ -227,11 +226,11 @@ describe('applyDocumentsBatchTransitionFactory', () => {
       transitions: documentTransitionsJs.map((t) => t.toObject()),
     }, [dataContract]);
 
-    stateTransition.getExecutionContext().enableDryRun();
+    executionContext.enableDryRun();
 
-    await applyDocumentsBatchTransition(stateRepositoryMock, stateTransition);
+    await applyDocumentsBatchTransition(stateRepositoryMock, stateTransition, executionContext);
 
-    stateTransition.getExecutionContext().disableDryRun();
+    executionContext.disableDryRun();
 
     const [documentTransition] = stateTransition.getTransitions();