@dashevo/wasm-dpp 0.24.0-dev.12 → 0.24.0-dev.13

package/test/integration/identity/stateTransition/IdentityTopUpTransition/validation/basic/validateIdentityTopUpTransitionBasicFactory.spec.js

@@ -1,68 +1,60 @@
-const { getRE2Class } = require('@dashevo/wasm-re2');
-
-const createAjv = require('@dashevo/dpp/lib/ajv/createAjv');
-
-const JsonSchemaValidator = require('@dashevo/dpp/lib/validation/JsonSchemaValidator');
-
 const getIdentityTopUpTransitionFixture = require('@dashevo/dpp/lib/test/fixtures/getIdentityTopUpTransitionFixture');
 
-const validateIdentityTopUpTransitionBasicFactory = require(
-  '@dashevo/dpp/lib/identity/stateTransition/IdentityTopUpTransition/validation/basic/validateIdentityTopUpTransitionBasicFactory',
-);
-
+const createStateRepositoryMock = require('@dashevo/dpp/lib/test/mocks/createStateRepositoryMock');
 const {
   expectJsonSchemaError,
   expectValidationError,
-} = require('@dashevo/dpp/lib/test/expect/expectError');
-
-const ValidationResult = require('@dashevo/dpp/lib/validation/ValidationResult');
-
-const ChainAssetLockProof = require('@dashevo/dpp/lib/identity/stateTransition/assetLockProof/chain/ChainAssetLockProof');
-const InstantAssetLockProof = require('@dashevo/dpp/lib/identity/stateTransition/assetLockProof/instant/InstantAssetLockProof');
-const SomeConsensusError = require('@dashevo/dpp/lib/test/mocks/SomeConsensusError');
-const IdentityPublicKey = require('@dashevo/dpp/lib/identity/IdentityPublicKey');
-const StateTransitionExecutionContext = require('@dashevo/dpp/lib/stateTransition/StateTransitionExecutionContext');
+} = require('../../../../../../../lib/test/expect/expectError');
+const { default: loadWasmDpp } = require('../../../../../../../dist');
 
 describe('validateIdentityTopUpTransitionBasicFactory', () => {
   let rawStateTransition;
   let stateTransition;
-  let assetLockPublicKeyHash;
-  let validateIdentityTopUpTransitionBasic;
-  let proofValidationFunctionsByTypeMock;
-  let validateProtocolVersionMock;
-  let executionContext;
-
-  beforeEach(async function beforeEach() {
-    assetLockPublicKeyHash = Buffer.alloc(20, 1);
 
-    const assetLockValidationResult = new ValidationResult();
-    assetLockValidationResult.setData(assetLockPublicKeyHash);
+  let stateRepositoryMock;
+  let executionContext;
 
-    proofValidationFunctionsByTypeMock = {
-      [InstantAssetLockProof.type]: this.sinonSandbox.stub().resolves(assetLockValidationResult),
-      [ChainAssetLockProof.type]: this.sinonSandbox.stub().resolves(assetLockValidationResult),
-    };
+  let validateIdentityTopUpTransitionBasic;
 
-    const RE2 = await getRE2Class();
-    const ajv = createAjv(RE2);
+  let StateTransitionExecutionContext;
+  let IdentityTopUpTransition;
+  let IdentityPublicKey;
+  let UnsupportedProtocolVersionError;
+  let InvalidInstantAssetLockProofSignatureError;
+  let IdentityTopUpTransitionBasicValidator;
+
+  before(async () => {
+    ({
+      IdentityTopUpTransitionBasicValidator,
+      IdentityTopUpTransition,
+      StateTransitionExecutionContext,
+      IdentityPublicKey,
+      UnsupportedProtocolVersionError,
+      InvalidInstantAssetLockProofSignatureError,
+    } = await loadWasmDpp());
+  });
 
-    const jsonSchemaValidator = new JsonSchemaValidator(ajv);
+  beforeEach(async function beforeEach() {
+    stateRepositoryMock = createStateRepositoryMock(this.sinonSandbox);
+    stateRepositoryMock.verifyInstantLock.returns(true);
 
-    validateProtocolVersionMock = this.sinonSandbox.stub().returns(new ValidationResult());
+    executionContext = new StateTransitionExecutionContext();
 
-    validateIdentityTopUpTransitionBasic = validateIdentityTopUpTransitionBasicFactory(
-      jsonSchemaValidator,
-      proofValidationFunctionsByTypeMock,
-      validateProtocolVersionMock,
+    const validator = new IdentityTopUpTransitionBasicValidator(stateRepositoryMock);
+    validateIdentityTopUpTransitionBasic = (st, context) => validator.validate(
+      st,
+      context,
     );
 
-    executionContext = new StateTransitionExecutionContext();
-
-    stateTransition = getIdentityTopUpTransitionFixture();
+    const stateTransitionJS = getIdentityTopUpTransitionFixture();
+    stateTransition = new IdentityTopUpTransition(stateTransitionJS.toObject());
 
     const privateKey = '9b67f852093bc61cea0eeca38599dbfba0de28574d2ed9b99d10d33dc1bde7b2';
 
-    await stateTransition.signByPrivateKey(privateKey, IdentityPublicKey.TYPES.ECDSA_SECP256K1);
+    await stateTransition.signByPrivateKey(
+      Buffer.from(privateKey, 'hex'),
+      IdentityPublicKey.TYPES.ECDSA_SECP256K1,
+    );
 
     rawStateTransition = stateTransition.toObject();
   });
@@ -71,9 +63,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     it('should be present', async () => {
       delete rawStateTransition.protocolVersion;
 
-      const result = await validateIdentityTopUpTransitionBasic(rawStateTransition);
+      const result = await validateIdentityTopUpTransitionBasic(
+        rawStateTransition, executionContext,
+      );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -85,9 +79,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     it('should be an integer', async () => {
       rawStateTransition.protocolVersion = '1';
 
-      const result = await validateIdentityTopUpTransitionBasic(rawStateTransition);
+      const result = await validateIdentityTopUpTransitionBasic(
+        rawStateTransition, executionContext,
+      );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -96,26 +92,13 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     });
 
     it('should be valid', async () => {
-      rawStateTransition.protocolVersion = -1;
-
-      const protocolVersionError = new SomeConsensusError('test');
-      const protocolVersionResult = new ValidationResult([
-        protocolVersionError,
-      ]);
-
-      validateProtocolVersionMock.returns(protocolVersionResult);
+      rawStateTransition.protocolVersion = 1000;
 
-      const result = await validateIdentityTopUpTransitionBasic(rawStateTransition);
-
-      expectValidationError(result, SomeConsensusError);
-
-      const [error] = result.getErrors();
-
-      expect(error).to.equal(protocolVersionError);
-
-      expect(validateProtocolVersionMock).to.be.calledOnceWith(
-        rawStateTransition.protocolVersion,
+      const result = await validateIdentityTopUpTransitionBasic(
+        rawStateTransition, executionContext,
       );
+
+      await expectValidationError(result, UnsupportedProtocolVersionError);
     });
   });
 
@@ -123,9 +106,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     it('should be present', async () => {
       delete rawStateTransition.type;
 
-      const result = await validateIdentityTopUpTransitionBasic(rawStateTransition);
+      const result = await validateIdentityTopUpTransitionBasic(
+        rawStateTransition, executionContext,
+      );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -137,9 +122,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     it('should be equal to 3', async () => {
       rawStateTransition.type = 666;
 
-      const result = await validateIdentityTopUpTransitionBasic(rawStateTransition);
+      const result = await validateIdentityTopUpTransitionBasic(
+        rawStateTransition, executionContext,
+      );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -155,9 +142,10 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
 
       const result = await validateIdentityTopUpTransitionBasic(
         rawStateTransition,
+        executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -169,9 +157,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     it('should be an object', async () => {
       rawStateTransition.assetLockProof = 1;
 
-      const result = await validateIdentityTopUpTransitionBasic(rawStateTransition);
+      const result = await validateIdentityTopUpTransitionBasic(
+        rawStateTransition, executionContext,
+      );
 
-      expectJsonSchemaError(result, 1);
+      await expectJsonSchemaError(result, 1);
 
       const [error] = result.getErrors();
 
@@ -180,29 +170,18 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     });
 
     it('should be valid', async () => {
-      const assetLockError = new SomeConsensusError('test');
-      const assetLockResult = new ValidationResult([
-        assetLockError,
-      ]);
-
-      proofValidationFunctionsByTypeMock[InstantAssetLockProof.type].resolves(assetLockResult);
+      stateRepositoryMock.verifyInstantLock.returns(false);
 
       const result = await validateIdentityTopUpTransitionBasic(
         rawStateTransition,
         executionContext,
       );
 
-      expectValidationError(result);
+      await expectValidationError(result);
 
       const [error] = result.getErrors();
 
-      expect(error).to.equal(assetLockError);
-
-      expect(proofValidationFunctionsByTypeMock[InstantAssetLockProof.type])
-        .to.be.calledOnceWithExactly(
-          rawStateTransition.assetLockProof,
-          executionContext,
-        );
+      expect(error).to.be.instanceOf(InvalidInstantAssetLockProofSignatureError);
     });
   });
 
@@ -215,7 +194,7 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
@@ -232,14 +211,12 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result, 2);
+      await expectJsonSchemaError(result, 32);
 
-      const [error, byteArrayError] = result.getErrors();
+      const [error] = result.getErrors();
 
       expect(error.getInstancePath()).to.equal('/identityId/0');
       expect(error.getKeyword()).to.equal('type');
-
-      expect(byteArrayError.getKeyword()).to.equal('byteArray');
     });
 
     it('should be no less than 32 bytes', async () => {
@@ -250,11 +227,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/identityId');
+      expect(error.getInstancePath()).to.equal('/identityId');
       expect(error.getKeyword()).to.equal('minItems');
     });
 
@@ -266,11 +243,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/identityId');
+      expect(error.getInstancePath()).to.equal('/identityId');
       expect(error.getKeyword()).to.equal('maxItems');
     });
   });
@@ -284,11 +261,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('');
+      expect(error.getInstancePath()).to.equal('');
       expect(error.getKeyword()).to.equal('required');
       expect(error.getParams().missingProperty).to.equal('signature');
     });
@@ -301,14 +278,12 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result, 2);
+      await expectJsonSchemaError(result, 65);
 
-      const [error, byteArrayError] = result.getErrors();
+      const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/signature/0');
+      expect(error.getInstancePath()).to.equal('/signature/0');
       expect(error.getKeyword()).to.equal('type');
-
-      expect(byteArrayError.getKeyword()).to.equal('byteArray');
     });
 
     it('should be not shorter than 65 bytes', async () => {
@@ -319,11 +294,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/signature');
+      expect(error.getInstancePath()).to.equal('/signature');
       expect(error.getKeyword()).to.equal('minItems');
     });
 
@@ -335,11 +310,11 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
         executionContext,
       );
 
-      expectJsonSchemaError(result);
+      await expectJsonSchemaError(result);
 
       const [error] = result.getErrors();
 
-      expect(error.instancePath).to.equal('/signature');
+      expect(error.getInstancePath()).to.equal('/signature');
       expect(error.getKeyword()).to.equal('maxItems');
     });
   });
@@ -351,11 +326,5 @@ describe('validateIdentityTopUpTransitionBasicFactory', () => {
     );
 
     expect(result.isValid()).to.be.true();
-
-    expect(proofValidationFunctionsByTypeMock[InstantAssetLockProof.type])
-      .to.be.calledOnceWithExactly(
-        rawStateTransition.assetLockProof,
-        executionContext,
-      );
   });
 });