@dashevo/grpc-common 0.5.0 → 0.5.1

package/.github/workflows/test_and_release.yml

@@ -20,7 +20,7 @@ jobs:
 
       - uses: actions/setup-node@v2
         with:
-          node-version: '12'
+          node-version: '16'
 
       - name: Enable NPM cache
         uses: actions/cache@v2

package/lib/server/stream/AcknowledgingWritable.js

@@ -11,6 +11,7 @@ class AcknowledgingWritable {
    * @return {Promise<any>}
    */
   write(data) {
+    let handler;
     return new Promise((resolve, reject) => {
       const callback = (error) => {
         if (error) {
@@ -18,8 +19,10 @@ class AcknowledgingWritable {
         }
         return resolve(true);
       };
-      const handler = this.attachHandler(callback);
+      handler = this.attachHandler(callback);
       this.writable.write(data, handler);
+    }).finally(() => {
+      this.detachHandler(handler);
     });
   }
 
@@ -30,7 +33,6 @@ class AcknowledgingWritable {
    */
   createHandler(callback) {
     const handler = (error) => {
-      this.detachHandler(handler);
       callback(error);
     };
     return handler;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@dashevo/grpc-common",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "Common GRPC library",
   "main": "index.js",
   "scripts": {

package/test/unit/server/stream/AcknowledgingWritable.spec.js

@@ -62,8 +62,9 @@ describe('AcknowledgingWritable', () => {
 
       const promise = wrapper.write('123');
 
+      // event error is still not detached
       // eslint-disable-next-line no-underscore-dangle
-      expect(wrapper.writable._eventsCount).to.be.equal(0);
+      expect(wrapper.writable._eventsCount).to.be.equal(1);
 
       const result = await promise;